Skip to contentSkip to conversation

MIPS: BCM63XX: Fix missing prototypes

PATCH Applied Florian Fainelli 2 participants 2 messages Jan 23, 2024 – Jan 26, 2024 MIPS

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 MIPS: BCM63XX: Fix missing prototypes

Most of the symbols for which we do not have a prototype can actually be made static and for the few that cannot, there is already a declaration in a header for it.

---
 arch/mips/bcm63xx/boards/board_bcm963xx.c | 2 +-
 arch/mips/bcm63xx/dev-rng.c               | 2 +-
 arch/mips/bcm63xx/dev-uart.c              | 1 +
 arch/mips/bcm63xx/dev-wdt.c               | 2 +-
 arch/mips/bcm63xx/irq.c                   | 2 +-
 arch/mips/bcm63xx/setup.c                 | 2 +-
 arch/mips/bcm63xx/timer.c                 | 2 +-
 7 files changed, 7 insertions(+), 6 deletions(-)
arch/mips/bcm63xx/boards/board_bcm963xx.c +1 -1
index 01aff80a5967..99f321b6e417 100644
@@ -702,7 +702,7 @@ static struct ssb_sprom bcm63xx_sprom = {
 	.boardflags_hi		= 0x0000,
 };
 
-int bcm63xx_get_fallback_sprom(struct ssb_bus *bus, struct ssb_sprom *out)
+static int bcm63xx_get_fallback_sprom(struct ssb_bus *bus, struct ssb_sprom *out)
 {
 	if (bus->bustype == SSB_BUSTYPE_PCI) {
 		memcpy(out, &bcm63xx_sprom, sizeof(struct ssb_sprom));
arch/mips/bcm63xx/dev-rng.c +1 -1
index d277b4dc6c68..f94151f7c96f 100644
@@ -26,7 +26,7 @@ static struct platform_device bcm63xx_rng_device = {
 	.resource	= rng_resources,
 };
 
-int __init bcm63xx_rng_register(void)
+static int __init bcm63xx_rng_register(void)
 {
 	if (!BCMCPU_IS_6368())
 		return -ENODEV;
arch/mips/bcm63xx/dev-uart.c +1 -0
index 3bc7f3bfc9ad..5d6bf0445b29 100644
@@ -10,6 +10,7 @@
 #include <linux/kernel.h>
 #include <linux/platform_device.h>
 #include <bcm63xx_cpu.h>
+#include <bcm63xx_dev_uart.h>
 
 static struct resource uart0_resources[] = {
 	{
arch/mips/bcm63xx/dev-wdt.c +1 -1
index 42130914a3c2..302bf7ed5ad5 100644
@@ -34,7 +34,7 @@ static struct platform_device bcm63xx_wdt_device = {
 	},
 };
 
-int __init bcm63xx_wdt_register(void)
+static int __init bcm63xx_wdt_register(void)
 {
 	wdt_resources[0].start = bcm63xx_regset_address(RSET_WDT);
 	wdt_resources[0].end = wdt_resources[0].start;
arch/mips/bcm63xx/irq.c +1 -1
index 2548013442f6..6240a8f88ea3 100644
@@ -72,7 +72,7 @@ static inline int enable_irq_for_cpu(int cpu, struct irq_data *d,
  */
 
 #define BUILD_IPIC_INTERNAL(width)					\
-void __dispatch_internal_##width(int cpu)				\
+static void __dispatch_internal_##width(int cpu)			\
 {									\
 	u32 pending[width / 32];					\
 	unsigned int src, tgt;						\
arch/mips/bcm63xx/setup.c +1 -1
index d811e3e03f81..c13ddb544a23 100644
@@ -159,7 +159,7 @@ void __init plat_mem_setup(void)
 	board_setup();
 }
 
-int __init bcm63xx_register_devices(void)
+static int __init bcm63xx_register_devices(void)
 {
 	/* register gpiochip */
 	bcm63xx_gpio_init();
arch/mips/bcm63xx/timer.c +1 -1
index a86065854c0c..74b83807df30 100644
@@ -178,7 +178,7 @@ int bcm63xx_timer_set(int id, int monotonic, unsigned int countdown_us)
 
 EXPORT_SYMBOL(bcm63xx_timer_set);
 
-int bcm63xx_timer_init(void)
+static int bcm63xx_timer_init(void)
 {
 	int ret, irq;
 	u32 reg;
Signature · 1 line
2.34.1
maintainer Applied
#1 lore raw
Quoted 5 lines · Florian Fainelli

Most of the symbols for which we do not have a prototype can actually be made static and for the few that cannot, there is already a declaration in a header for it.

Quoted 9 lines
---
 arch/mips/bcm63xx/boards/board_bcm963xx.c | 2 +-
 arch/mips/bcm63xx/dev-rng.c               | 2 +-
 arch/mips/bcm63xx/dev-uart.c              | 1 +
 arch/mips/bcm63xx/dev-wdt.c               | 2 +-
 arch/mips/bcm63xx/irq.c                   | 2 +-
 arch/mips/bcm63xx/setup.c                 | 2 +-
 arch/mips/bcm63xx/timer.c                 | 2 +-
 7 files changed, 7 insertions(+), 6 deletions(-)

applied to mips-fixes.

Thomas.

Signature · 2 lines
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]