Skip to contentSkip to conversation

gpu: drm: display: indent fix in comment

PATCH In review Kousik Sanagavarapu 2 participants 5 messages Jan 24, 2024 – Feb 12, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gpu: drm: display: indent fix in comment

The comments explaining the function "drm_dp_mst_atom_check_mgr()" had uneven indentation which made "make htmldocs" complain:

	Documentation/gpu/drm-kms-helpers:296:
	./drivers/gpu/drm/display/drm_dp_mst_topology.c:5496:
	ERROR: Unexpected indentation.

	Documentation/gpu/drm-kms-helpers:296:
	./drivers/gpu/drm/display/drm_dp_mst_topology.c:5500:
	WARNING: Block quote ends without a blank line; unexpected unindent.

Fix this by getting the indent right.

---
 drivers/gpu/drm/display/drm_dp_mst_topology.c | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)
drivers/gpu/drm/display/drm_dp_mst_topology.c +9 -9
index bd6c24d4213c..f26cc85e7dbf 100644
@@ -5490,15 +5490,15 @@ EXPORT_SYMBOL(drm_dp_mst_atomic_enable_dsc);
  * Returns:
  *   - 0 if the new state is valid
  *   - %-ENOSPC, if the new state is invalid, because of BW limitation
- *         @failing_port is set to:
- *         - The non-root port where a BW limit check failed
- *           with all the ports downstream of @failing_port passing
- *           the BW limit check.
- *           The returned port pointer is valid until at least
- *           one payload downstream of it exists.
- *         - %NULL if the BW limit check failed at the root port
- *           with all the ports downstream of the root port passing
- *           the BW limit check.
+ *     @failing_port is set to:
+ *
+ *       - The non-root port where a BW limit check failed with all the ports
+ *         downstream of @failing_port passing the BW limit check.
+ *         The returned port pointer is valid until at least one payload
+ *         downstream of it exists.
+ *       - %NULL if the BW limit check failed at the root port with all the
+ *         ports downstream of the root port passing the BW limit check.
+ *
  *   - %-EINVAL, if the new state is invalid, because the root port has
  *     too many payloads.
  */
Signature · 1 line
2.43.0.370.g8962b674a6.dirty
#1 lore raw
Quoted 11 lines · Kousik Sanagavarapu

The comments explaining the function "drm_dp_mst_atom_check_mgr()" had uneven indentation which made "make htmldocs" complain:

	Documentation/gpu/drm-kms-helpers:296:
	./drivers/gpu/drm/display/drm_dp_mst_topology.c:5496:
	ERROR: Unexpected indentation.

	Documentation/gpu/drm-kms-helpers:296:
	./drivers/gpu/drm/display/drm_dp_mst_topology.c:5500:
	WARNING: Block quote ends without a blank line; unexpected unindent.
Quoted 3 lines

Fix this by getting the indent right.

Ping.

Thanks

#2 lore raw
In reply to Kousik Sanagavarapu
Quoted 11 lines · Kousik Sanagavarapu

The comments explaining the function "drm_dp_mst_atom_check_mgr()" had uneven indentation which made "make htmldocs" complain:

	Documentation/gpu/drm-kms-helpers:296:
	./drivers/gpu/drm/display/drm_dp_mst_topology.c:5496:
	ERROR: Unexpected indentation.

	Documentation/gpu/drm-kms-helpers:296:
	./drivers/gpu/drm/display/drm_dp_mst_topology.c:5500:
	WARNING: Block quote ends without a blank line; unexpected unindent.
Quoted 4 lines

Fix this by getting the indent right.

Ping again.

Thanks

#3 lore raw
Quoted 12 lines · Kousik Sanagavarapu
Quoted 11 lines · Kousik Sanagavarapu

The comments explaining the function "drm_dp_mst_atom_check_mgr()" had uneven indentation which made "make htmldocs" complain:

	Documentation/gpu/drm-kms-helpers:296:
	./drivers/gpu/drm/display/drm_dp_mst_topology.c:5496:
	ERROR: Unexpected indentation.

	Documentation/gpu/drm-kms-helpers:296:
	./drivers/gpu/drm/display/drm_dp_mst_topology.c:5500:
	WARNING: Block quote ends without a blank line; unexpected unindent.
Quoted 8 lines
Quoted 4 lines

Fix this by getting the indent right.

Ping again.

Thanks

Hi,
This seems to be fixed by commit 1a84c213146a.

If you don't agree, please explain.
Thanks.

Signature · 1 line
#Randy
#4 lore raw
Quoted 20 lines · Randy Dunlap
Quoted 17 lines · Kousik Sanagavarapu
Quoted 15 lines · Kousik Sanagavarapu

The comments explaining the function "drm_dp_mst_atom_check_mgr()" had uneven indentation which made "make htmldocs" complain:

	Documentation/gpu/drm-kms-helpers:296:
	./drivers/gpu/drm/display/drm_dp_mst_topology.c:5496:
	ERROR: Unexpected indentation.

	Documentation/gpu/drm-kms-helpers:296:
	./drivers/gpu/drm/display/drm_dp_mst_topology.c:5500:
	WARNING: Block quote ends without a blank line; unexpected unindent.

Fix this by getting the indent right.

Quoted 6 lines
Quoted 3 lines

Ping again.

Thanks

Hi,
This seems to be fixed by commit 1a84c213146a.

Makes sense. Sorry for the noise.

Quoted 5 lines

If you don't agree, please explain.
Thanks.

Signature · 1 line
#Randy