Skip to contentSkip to conversation

dt-bindings: pinctrl: Unify "input-debounce" schema

PATCH In review Rob Herring 4 participants 6 messages Jan 24, 2024 – Jan 31, 2024

Subsystems (6)
Device tree bindings GPIO Pin control Arm/nuvoton npcm architecture +2 more subsystems
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/2 dt-bindings: pinctrl: Unify "input-debounce" schema

nuvoton,npcm845-pinctrl defines the common "input-debounce" property as an array rather than an scalar. Update the common definition to expand it to an uint32-array, and update all the users of the property with array constraints.

Signed-off-by Rob Herring <[email protected]>
---
 Documentation/devicetree/bindings/pinctrl/cirrus,madera.yaml   | 3 ++-
 .../devicetree/bindings/pinctrl/nuvoton,npcm845-pinctrl.yaml   | 1 -
 .../devicetree/bindings/pinctrl/nuvoton,wpcm450-pinctrl.yaml   | 3 ++-
 Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml     | 2 +-
 4 files changed, 5 insertions(+), 4 deletions(-)
Documentation/devicetree/bindings/pinctrl/cirrus,madera.yaml +2 -1
index bb61a30321a1..482acda88e73 100644
@@ -93,7 +93,8 @@ properties:
 
           input-schmitt-disable: true
 
-          input-debounce: true
+          input-debounce:
+            maxItems: 1
 
           output-low: true
Documentation/devicetree/bindings/pinctrl/nuvoton,npcm845-pinctrl.yaml +0 -1
index 3e8472898800..20cf0102aa63 100644
@@ -152,7 +152,6 @@ patternProperties:
         description:
           Debouncing periods in microseconds, one period per interrupt
           bank found in the controller
-        $ref: /schemas/types.yaml#/definitions/uint32-array
         minItems: 1
         maxItems: 4
Documentation/devicetree/bindings/pinctrl/nuvoton,wpcm450-pinctrl.yaml +2 -1
index 7b7f840ffc4c..08442c880f07 100644
@@ -103,7 +103,8 @@ patternProperties:
         items:
           pattern: "^gpio1?[0-9]{1,2}$"
 
-      input-debounce: true
+      input-debounce:
+        maxItems: 1
 
     additionalProperties: false
Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml +1 -1
index be81ed22a036..d0af21a564b4 100644
@@ -97,7 +97,7 @@ properties:
     description: disable schmitt-trigger mode
 
   input-debounce:
-    $ref: /schemas/types.yaml#/definitions/uint32
+    $ref: /schemas/types.yaml#/definitions/uint32-array
     description: Takes the debounce time in usec as argument or 0 to disable
       debouncing
Signature · 1 line
2.43.0
author maintainer
#1 lore raw

PATCH 2/2 dt-bindings: pinctrl: nuvoton,npcm845: Drop redundant type for "slew-rate"

pincfg-node.yaml already defines the type for "slew-rate", so drop the type from the nuvoton,npcm845-pinctrl binding.

Signed-off-by Rob Herring <[email protected]>
---
 .../devicetree/bindings/pinctrl/nuvoton,npcm845-pinctrl.yaml     | 1 -
 1 file changed, 1 deletion(-)
Documentation/devicetree/bindings/pinctrl/nuvoton,npcm845-pinctrl.yaml +0 -1
index 20cf0102aa63..b55d9c316659 100644
@@ -159,7 +159,6 @@ patternProperties:
         description: |
           0: Low rate
           1: High rate
-        $ref: /schemas/types.yaml#/definitions/uint32
         enum: [0, 1]
 
       drive-strength:
Signature · 1 line
2.43.0
maintainer Reviewed-by on v1 1/2
#4 lore raw
In reply to Rob Herring
Quoted 8 lines · Rob Herring

nuvoton,npcm845-pinctrl defines the common "input-debounce" property as an array rather than an scalar. Update the common definition to expand it to an uint32-array, and update all the users of the property with array constraints.

Signed-off-by Rob Herring <[email protected]>
---
 Documentation/devicetree/bindings/pinctrl/cirrus,madera.yaml   | 3 ++-
Reviewed-by Charles Keepax <[email protected]>

Thanks,
Charles

#5 lore raw
In reply to Rob Herring
Quoted 6 lines · Rob Herring

nuvoton,npcm845-pinctrl defines the common "input-debounce" property as an array rather than an scalar. Update the common definition to expand it to an uint32-array, and update all the users of the property with array constraints.

Signed-off-by Rob Herring <[email protected]>

Patches applied, thanks for fixing this!

Yours,
Linus Walleij