exec: Distinguish in_execve from in_exec
Subsystems (5)
PATCH 1/1 exec: Distinguish in_execve from in_exec
Just to help distinguish the fs->in_exec flag from the current->in_execve flag, add comments in check_unsafe_exec() and copy_fs() for more context. Also note that in_execve is only used by TOMOYO now.
Cc Kentaro Takeda <[email protected]>
Cc Tetsuo Handa <[email protected]>
Cc Alexander Viro <[email protected]>
Cc Christian Brauner <[email protected]>
Cc Jan Kara <[email protected]>
Cc Eric Biederman <[email protected]>
Cc Andrew Morton <[email protected]>
Cc Sebastian Andrzej Siewior <[email protected]>
Signed-off-by Kees Cook <[email protected]>
--- fs/exec.c | 1 + include/linux/sched.h | 2 +- kernel/fork.c | 1 + 3 files changed, 3 insertions(+), 1 deletion(-)
fs/exec.c +1 -0
@@ -1633,6 +1633,7 @@ static void check_unsafe_exec(struct linux_binprm *bprm) }rcu_read_unlock (); +/* "users" and "in_exec" locked for copy_fs() */ if (p->fs->users > n_fs) bprm->unsafe |=LSM_UNSAFE_SHARE ;else
include/linux/sched.h +1 -1
@@ -920,7 +920,7 @@ struct task_struct { unsigned sched_rt_mutex:1;#endif -/* Bit to tell LSMs we're in execve(): */ +/* Bit to tell TOMOYO we're in execve(): */ unsigned in_execve:1; unsigned in_iowait:1;#ifndef TIF_RESTORE_SIGMASK
kernel/fork.c +1 -0
@@ -1748,6 +1748,7 @@ static int copy_fs(unsigned long clone_flags, struct task_struct *tsk)if (clone_flags &CLONE_FS ) {/* tsk->fs is already what we want */ spin_lock (&fs->lock); +/* "users" and "in_exec" locked for check_unsafe_exec() */ if (fs->in_exec) {spin_unlock (&fs->lock);return -EAGAIN ;
Signature · 1 line
2.34.1