Skip to contentSkip to conversation

tisdk-*-image: Fix SYSTEMD_DEFAULT_TARGET assignment

PATCH New Ryan Eatmon 1 participant 1 message Jan 25, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tisdk-*-image: Fix SYSTEMD_DEFAULT_TARGET assignment

The use of the variable SYSTEMD_DEFAULT_TARGET is as a filename target. But the extra whitespace in the string caused by the link breaks and indents added spaces between the directory and the filename which resulted in the following error:

run.set_systemd_default_target.23991: line 147: [: too many arguments

---
 meta-arago-distro/recipes-core/images/tisdk-default-image.bb  | 4 +---
 .../recipes-core/images/tisdk-thinlinux-image.bb              | 4 +---
 2 files changed, 2 insertions(+), 6 deletions(-)
meta-arago-distro/recipes-core/images/tisdk-default-image.bb +1 -3
index 33ed0f57..7761ac34 100644
@@ -8,9 +8,7 @@ require arago-image.inc
 ARAGO_DEFAULT_IMAGE_EXTRA_INSTALL ?= ""
 
 # we're assuming some display manager is being installed with opengl
-SYSTEMD_DEFAULT_TARGET = " \
-    ${@bb.utils.contains('DISTRO_FEATURES','opengl','graphical.target','multi-user.target',d)} \
-"
+SYSTEMD_DEFAULT_TARGET = "${@bb.utils.contains('DISTRO_FEATURES','opengl','graphical.target','multi-user.target',d)}"
 
 IMAGE_INSTALL += "\
     packagegroup-arago-base \
meta-arago-distro/recipes-core/images/tisdk-thinlinux-image.bb +1 -3
index f266b14a..13e86902 100644
@@ -9,9 +9,7 @@ require arago-image.inc
 ARAGO_THIN_IMAGE_EXTRA_INSTALL ?= ""
 
 # we're assuming some display manager is being installed with opengl
-SYSTEMD_DEFAULT_TARGET = " \
-    ${@bb.utils.contains('DISTRO_FEATURES','opengl','graphical.target','multi-user.target',d)} \
-"
+SYSTEMD_DEFAULT_TARGET = "${@bb.utils.contains('DISTRO_FEATURES','opengl','graphical.target','multi-user.target',d)}"
 
 IMAGE_INSTALL += "\
     packagegroup-arago-base \
Signature · 1 line
2.17.1