FAILED: patch "[PATCH] serial: sc16is7xx: remove obsolete loop in" failed to apply to 4.19-stable tree
Subsystems (2)
[email protected]
maintainerThe patch below does not apply to the 4.19-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
To reproduce the conflict and resubmit, you may use the following commands:
git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-4.19.y
git checkout FETCH_HEAD
git cherry-pick -x ed647256e8f226241ecff7baaecdb8632ffc7ec1
# <resolve conflicts, build, test, etc.>
git commit -s
git send-email --to '<[email protected]>' --in-reply-to '2024012611-quickness-simmering-9ae2@gregkh' --subject-prefix 'PATCH 4.19.y' HEAD^..
Possible dependencies:
ed647256e8f2 ("serial: sc16is7xx: remove obsolete loop in sc16is7xx_port_irq()") 4409df5866b7 ("serial: sc16is7xx: change EFR lock to operate on each channels") e045e18dbf3e ("Merge 6.7-rc5 into tty-next")
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From ed647256e8f226241ecff7baaecdb8632ffc7ec1 Mon Sep 17 00:00:00 2001
From: Hugo Villeneuve <[email protected]>
Date: Thu, 21 Dec 2023 18:18:11 -0500
Subject: [PATCH] serial: sc16is7xx: remove obsolete loop in
sc16is7xx_port_irq()
Commit 834449872105 ("sc16is7xx: Fix for multi-channel stall") changed sc16is7xx_port_irq() from looping multiple times when there was still interrupts to serve. It simply changed the do {} while(1) loop to a do {} while(0) loop, which makes the loop itself now obsolete.
Clean the code by removing this obsolete do {} while(0) loop.
drivers/tty/serial/sc16is7xx.c +41 -44
@@ -725,58 +725,55 @@ static void sc16is7xx_update_mlines(struct sc16is7xx_one *one)static bool sc16is7xx_port_irq (struct sc16is7xx_port *s,int portno) {bool rc = true; +unsigned int iir, rxlen;struct uart_port *port = &s->p[portno].port;struct sc16is7xx_one *one =to_sc16is7xx_one (port, port);mutex_lock (&one->efr_lock); -do { -unsigned int iir, rxlen; + iir =sc16is7xx_port_read (port,SC16IS7XX_IIR_REG ); +if (iir &SC16IS7XX_IIR_NO_INT_BIT ) { + rc = false; + goto out_port_irq; + } - iir =sc16is7xx_port_read (port,SC16IS7XX_IIR_REG ); -if (iir &SC16IS7XX_IIR_NO_INT_BIT ) { - rc = false; - goto out_port_irq; - } + iir &=SC16IS7XX_IIR_ID_MASK ; - iir &=SC16IS7XX_IIR_ID_MASK ; - -switch (iir) { -case SC16IS7XX_IIR_RDI_SRC : -case SC16IS7XX_IIR_RLSE_SRC : -case SC16IS7XX_IIR_RTOI_SRC : -case SC16IS7XX_IIR_XOFFI_SRC : - rxlen =sc16is7xx_port_read (port,SC16IS7XX_RXLVL_REG ); - -/* -* There is a silicon bug that makes the chip report a -* time-out interrupt but no data in the FIFO. This is -* described in errata section 18.1.4. -* -* When this happens, read one byte from the FIFO to -* clear the interrupt. -*/ -if (iir ==SC16IS7XX_IIR_RTOI_SRC && !rxlen) - rxlen =1 ; - -if (rxlen) -sc16is7xx_handle_rx (port, rxlen, iir); -break ; +switch (iir) { +case SC16IS7XX_IIR_RDI_SRC : +case SC16IS7XX_IIR_RLSE_SRC : +case SC16IS7XX_IIR_RTOI_SRC : +case SC16IS7XX_IIR_XOFFI_SRC : + rxlen =sc16is7xx_port_read (port,SC16IS7XX_RXLVL_REG ); + +/* +* There is a silicon bug that makes the chip report a +* time-out interrupt but no data in the FIFO. This is +* described in errata section 18.1.4. +* +* When this happens, read one byte from the FIFO to +* clear the interrupt. +*/ +if (iir ==SC16IS7XX_IIR_RTOI_SRC && !rxlen) + rxlen =1 ; + +if (rxlen) +sc16is7xx_handle_rx (port, rxlen, iir); +break ;/* CTSRTS interrupt comes only when CTS goes inactive */ -case SC16IS7XX_IIR_CTSRTS_SRC : -case SC16IS7XX_IIR_MSI_SRC : -sc16is7xx_update_mlines (one); -break ; -case SC16IS7XX_IIR_THRI_SRC : -sc16is7xx_handle_tx (port); -break ; -default : -dev_err_ratelimited (port->dev, -"ttySC%i: Unexpected interrupt: %x" , - port->line, iir); -break ; - } - }while (0 ); +case SC16IS7XX_IIR_CTSRTS_SRC : +case SC16IS7XX_IIR_MSI_SRC : +sc16is7xx_update_mlines (one); +break ; +case SC16IS7XX_IIR_THRI_SRC : +sc16is7xx_handle_tx (port); +break ; +default : +dev_err_ratelimited (port->dev, +"ttySC%i: Unexpected interrupt: %x" , + port->line, iir); +break ; + } out_port_irq:mutex_unlock (&one->efr_lock);