Skip to contentSkip to conversation

iommu/vt-d: Remove INTEL_IOMMU_BROKEN_GFX_WA

PATCH Superseded Lu Baolu 4 participants 6 messages Jan 27, 2024 – Jan 29, 2024

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Lu Baolu

author maintainer
#0 lore raw

PATCH 1/1 iommu/vt-d: Remove INTEL_IOMMU_BROKEN_GFX_WA

Commit 62edf5dc4a524 ("intel-iommu: Restore DMAR_BROKEN_GFX_WA option for broken graphics drivers") was introduced 24 years ago as a temporary workaround for graphics drivers that used physical addresses for DMA and avoided DMA APIs. This workaround was disabled by default.

As 24 years have passed, it is expected that graphics driver developers have migrated their drivers to use kernel DMA APIs. Therefore, this workaround is no longer required and could been removed.

---
 drivers/iommu/intel/iommu.c |  4 ----
 drivers/iommu/intel/Kconfig | 11 -----------
 2 files changed, 15 deletions(-)
drivers/iommu/intel/iommu.c +0 -4
index 6fb5f6fceea1..fc52fcd786aa 100644
@@ -2660,10 +2660,6 @@ static int __init init_dmars(void)
 		iommu_set_root_entry(iommu);
 	}
 
-#ifdef CONFIG_INTEL_IOMMU_BROKEN_GFX_WA
-	dmar_map_gfx = 0;
-#endif
-
 	if (!dmar_map_gfx)
 		iommu_identity_mapping |= IDENTMAP_GFX;
 
drivers/iommu/intel/Kconfig +0 -11
index 012cd2541a68..d2d34eb28d94 100644
@@ -64,17 +64,6 @@ config INTEL_IOMMU_DEFAULT_ON
 	  one is found. If this option is not selected, DMAR support can
 	  be enabled by passing intel_iommu=on to the kernel.
 
-config INTEL_IOMMU_BROKEN_GFX_WA
-	bool "Workaround broken graphics drivers (going away soon)"
-	depends on BROKEN && X86
-	help
-	  Current Graphics drivers tend to use physical address
-	  for DMA and avoid using DMA APIs. Setting this config
-	  option permits the IOMMU driver to set a unity map for
-	  all the OS-visible memory. Hence the driver can continue
-	  to use physical addresses for DMA, at least until this
-	  option is removed in the 2.6.32 kernel.
-
 config INTEL_IOMMU_FLOPPY_WA
 	def_bool y
 	depends on X86
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines

From: Lu Baolu <[email protected]>
Sent: Saturday, January 27, 2024 2:45 PM

Commit 62edf5dc4a524 ("intel-iommu: Restore DMAR_BROKEN_GFX_WA option for
broken graphics drivers") was introduced 24 years ago as a temporary workaround for graphics drivers that used physical addresses for DMA and avoided DMA APIs. This workaround was disabled by default.

Quoted 6 lines

As 24 years have passed, it is expected that graphics driver developers have migrated their drivers to use kernel DMA APIs. Therefore, this workaround is no longer required and could been removed.

#2 lore raw
In reply to Lu Baolu
Quoted 8 lines · Lu Baolu

Commit 62edf5dc4a524 ("intel-iommu: Restore DMAR_BROKEN_GFX_WA option for broken graphics drivers") was introduced 24 years ago as a temporary workaround for graphics drivers that used physical addresses for DMA and avoided DMA APIs. This workaround was disabled by default.

As 24 years have passed, it is expected that graphics driver developers have migrated their drivers to use kernel DMA APIs. Therefore, this workaround is no longer required and could been removed.

How about you Cc the intel graphics maintainers and get a confirmation?

#3 lore raw
Quoted 10 lines

From: Christoph Hellwig <[email protected]>
Sent: Monday, January 29, 2024 2:03 PM

Quoted 1 line · Lu Baolu

Commit 62edf5dc4a524 ("intel-iommu: Restore DMAR_BROKEN_GFX_WA

option for

Quoted 4 lines

broken graphics drivers") was introduced 24 years ago as a temporary workaround for graphics drivers that used physical addresses for DMA and avoided DMA APIs. This workaround was disabled by default.

Quoted 6 lines
Quoted 3 lines

As 24 years have passed, it is expected that graphics driver developers have migrated their drivers to use kernel DMA APIs. Therefore, this workaround is no longer required and could been removed.

How about you Cc the intel graphics maintainers and get a confirmation?

in the worst case there is still "igfx_off" option available to achieve the same effect.

there is really no good reason to keep this config option so long while it was intended to be removed in 2.6.32.

but yes the Intel graphics maintainers should be CCed.

author maintainer
#4 lore raw
Quoted 17 lines · Kevin
Quoted 10 lines

From: Christoph Hellwig <[email protected]>
Sent: Monday, January 29, 2024 2:03 PM

Quoted 1 line · Lu Baolu

Commit 62edf5dc4a524 ("intel-iommu: Restore DMAR_BROKEN_GFX_WA

option for

Quoted 4 lines

broken graphics drivers") was introduced 24 years ago as a temporary workaround for graphics drivers that used physical addresses for DMA and avoided DMA APIs. This workaround was disabled by default.

Quoted 6 lines
Quoted 3 lines

As 24 years have passed, it is expected that graphics driver developers have migrated their drivers to use kernel DMA APIs. Therefore, this workaround is no longer required and could been removed.

How about you Cc the intel graphics maintainers and get a confirmation?

Quoted 8 lines

in the worst case there is still "igfx_off" option available to achieve the same effect.

there is really no good reason to keep this config option so long while it was intended to be removed in 2.6.32.

but yes the Intel graphics maintainers should be CCed.

You both are right.

I will add above in the commit message and Cc graphic guys with a new upgraded version.

Best regards,
baolu

reviewer
#5 lore raw
Quoted 24 lines · Baolu Lu
Quoted 23 lines · Kevin
Quoted 10 lines

From: Christoph Hellwig <[email protected]>
Sent: Monday, January 29, 2024 2:03 PM

Quoted 1 line · Lu Baolu

Commit 62edf5dc4a524 ("intel-iommu: Restore DMAR_BROKEN_GFX_WA

option for

Quoted 4 lines

broken graphics drivers") was introduced 24 years ago as a temporary workaround for graphics drivers that used physical addresses for DMA and avoided DMA APIs. This workaround was disabled by default.

Quoted 6 lines
Quoted 3 lines

As 24 years have passed, it is expected that graphics driver developers have migrated their drivers to use kernel DMA APIs. Therefore, this workaround is no longer required and could been removed.

How about you Cc the intel graphics maintainers and get a confirmation?

in the worst case there is still "igfx_off" option available to achieve the same effect.

there is really no good reason to keep this config option so long while it was intended to be removed in 2.6.32.

Quoted 7 lines
Quoted 2 lines

but yes the Intel graphics maintainers should be CCed.

You both are right.

I will add above in the commit message and Cc graphic guys with a new upgraded version.

Right, you're not removing the actual workaround at all, you're only removing the Kconfig option to force it on by default, which clearly nobody is using since it's been dead code since 2009 with 0c02a20ff769 ("intel-iommu: Kill DMAR_BROKEN_GFX_WA option.")

Cheers,
Robin.