configs: visionfive2: Disable ENV_IS_NOWHERE
PATCH 1/1 configs: visionfive2: Disable ENV_IS_NOWHERE
The VisionFive 2 board supports saving the u-boot environment settings are saved to on-board SPI flash. However the defconfig enables both ENV_IS_NOWHERE and ENV_IS_IN_SPI_FLASH, preventing the "saveenv" command to work. Fix that by disabling ENV_IS_NOWHERE.
--- configs/starfive_visionfive2_defconfig | 1 - 1 file changed, 1 deletion(-)
configs/starfive_visionfive2_defconfig +0 -1
@@ -77,7 +77,6 @@ CONFIG_CMD_TFTPPUT=y CONFIG_CMD_BOOTSTAGE=y CONFIG_OF_BOARD=y CONFIG_ENV_OVERWRITE=y -CONFIG_ENV_IS_NOWHERE=y CONFIG_ENV_IS_IN_SPI_FLASH=y CONFIG_ENV_SECT_SIZE_AUTO=y CONFIG_SYS_RELOC_GD_ENV_ADDR=y
Signature · 1 line
2.42.0
LGTM.
Maintainers, please also apply this patch to 2024.04 branch when accepting it.
Best regards,
Shengyu
Quoted 25 lines
The VisionFive 2 board supports saving the u-boot environment settings are saved to on-board SPI flash. However the defconfig enables both
ENV_IS_NOWHEREandENV_IS_IN_SPI_FLASH, preventing the "saveenv" command to work. Fix that by disablingENV_IS_NOWHERE.Fixes 7d79bed00c9e ("configs: starfive: Enable environment in SPI flash support")Reported-by E Shattow <[email protected]>Signed-off-by Aurelien Jarno <[email protected]>--- configs/starfive_visionfive2_defconfig | 1 - 1 file changed, 1 deletion(-)configs/starfive_visionfive2_defconfig +0
-1@@ -77,7 +77,6 @@ CONFIG_CMD_TFTPPUT=y CONFIG_CMD_BOOTSTAGE=y CONFIG_OF_BOARD=y CONFIG_ENV_OVERWRITE=y -CONFIG_ENV_IS_NOWHERE=y CONFIG_ENV_IS_IN_SPI_FLASH=y CONFIG_ENV_SECT_SIZE_AUTO=y CONFIG_SYS_RELOC_GD_ENV_ADDR=y
Quoted 5 lines · Aurelien Jarno
The VisionFive 2 board supports saving the u-boot environment settings are saved to on-board SPI flash. However the defconfig enables both
ENV_IS_NOWHEREandENV_IS_IN_SPI_FLASH, preventing the "saveenv" command to work. Fix that by disablingENV_IS_NOWHERE.
Quoted 7 lines
Fixes 7d79bed00c9e ("configs: starfive: Enable environment in SPI flash support")Reported-by E Shattow <[email protected]>Signed-off-by Aurelien Jarno <[email protected]>--- configs/starfive_visionfive2_defconfig | 1 - 1 file changed, 1 deletion(-)