Skip to contentSkip to conversation

configs: visionfive2: Disable ENV_IS_NOWHERE

PATCH In review Aurelien Jarno 3 participants 3 messages Jan 27, 2024 – Jan 31, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 configs: visionfive2: Disable ENV_IS_NOWHERE

The VisionFive 2 board supports saving the u-boot environment settings are saved to on-board SPI flash. However the defconfig enables both ENV_IS_NOWHERE and ENV_IS_IN_SPI_FLASH, preventing the "saveenv" command to work. Fix that by disabling ENV_IS_NOWHERE.

Fixes 7d79bed00c9e ("configs: starfive: Enable environment in SPI flash support")
---
 configs/starfive_visionfive2_defconfig | 1 -
 1 file changed, 1 deletion(-)
configs/starfive_visionfive2_defconfig +0 -1
index 1b7d57bac7..c68f3c2def 100644
@@ -77,7 +77,6 @@ CONFIG_CMD_TFTPPUT=y
 CONFIG_CMD_BOOTSTAGE=y
 CONFIG_OF_BOARD=y
 CONFIG_ENV_OVERWRITE=y
-CONFIG_ENV_IS_NOWHERE=y
 CONFIG_ENV_IS_IN_SPI_FLASH=y
 CONFIG_ENV_SECT_SIZE_AUTO=y
 CONFIG_SYS_RELOC_GD_ENV_ADDR=y
Signature · 1 line
2.42.0
#1 lore raw

LGTM.

Maintainers, please also apply this patch to 2024.04 branch when accepting it.

Best regards,
Shengyu

Quoted 25 lines

The VisionFive 2 board supports saving the u-boot environment settings are saved to on-board SPI flash. However the defconfig enables both ENV_IS_NOWHERE and ENV_IS_IN_SPI_FLASH, preventing the "saveenv" command to work. Fix that by disabling ENV_IS_NOWHERE.

Fixes 7d79bed00c9e ("configs: starfive: Enable environment in SPI flash support")
---
  configs/starfive_visionfive2_defconfig | 1 -
  1 file changed, 1 deletion(-)
configs/starfive_visionfive2_defconfig +0 -1
index 1b7d57bac7..c68f3c2def 100644
@@ -77,7 +77,6 @@ CONFIG_CMD_TFTPPUT=y
  CONFIG_CMD_BOOTSTAGE=y
  CONFIG_OF_BOARD=y
  CONFIG_ENV_OVERWRITE=y
-CONFIG_ENV_IS_NOWHERE=y
  CONFIG_ENV_IS_IN_SPI_FLASH=y
  CONFIG_ENV_SECT_SIZE_AUTO=y
  CONFIG_SYS_RELOC_GD_ENV_ADDR=y
Reviewed-by on v1 1/1
#2 lore raw
In reply to Aurelien Jarno
Quoted 5 lines · Aurelien Jarno

The VisionFive 2 board supports saving the u-boot environment settings are saved to on-board SPI flash. However the defconfig enables both ENV_IS_NOWHERE and ENV_IS_IN_SPI_FLASH, preventing the "saveenv" command to work. Fix that by disabling ENV_IS_NOWHERE.

Quoted 7 lines
Fixes 7d79bed00c9e ("configs: starfive: Enable environment in SPI flash support")
---
 configs/starfive_visionfive2_defconfig | 1 -
 1 file changed, 1 deletion(-)