virtio-gpu: Correct virgl_renderer_resource_get_info() error check
PATCH 1/1 virtio-gpu: Correct virgl_renderer_resource_get_info() error check
virgl_renderer_resource_get_info() returns errno and not -1 on error. Correct the return-value check.
Signed-off-by Dmitry Osipenko <[email protected]>
--- hw/display/virtio-gpu-virgl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
hw/display/virtio-gpu-virgl.c +1 -1
@@ -181,7 +181,7 @@ static void virgl_cmd_set_scanout(VirtIOGPU *g,memset (&info,0 ,sizeof (info)); ret =virgl_renderer_resource_get_info (ss.resource_id, &info);#endif -if (ret ==-1 ) { +if (ret) {qemu_log_mask (LOG_GUEST_ERROR ,"%s: illegal resource specified %d\n" , __func__, ss.resource_id);
Signature · 1 line
2.43.0
Quoted 5 lines · Dmitry Osipenko
virgl_renderer_resource_get_info()returns errno and not -1 on error. Correct the return-value check.Signed-off-by Dmitry Osipenko <[email protected]>
Reviewed-by Marc-André Lureau <[email protected]>
Can you also correct the code in vhost-user-gpu ?
Quoted 20 lines
--- hw/display/virtio-gpu-virgl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)hw/display/virtio-gpu-virgl.c +1
-2@@ -181,7 +181,7 @@ static void virgl_cmd_set_scanout(VirtIOGPU *g,memset (&info,0 ,sizeof (info)); ret =virgl_renderer_resource_get_info (ss.resource_id, &info);#endif -if (ret ==-1 ) { +if (ret) {qemu_log_mask (LOG_GUEST_ERROR ,"%s: illegal resource specified %d\n" , __func__, ss.resource_id); --2.43.0