backlight: mp3309c: Use pwm_apply_might_sleep()
PATCH 1/1 backlight: mp3309c: Use pwm_apply_might_sleep()
pwm_apply_state() is deprecated since commit c748a6d77c06a ("pwm: Rename pwm_apply_state() to pwm_apply_might_sleep()"). This is the final user in the tree.
--- drivers/video/backlight/mp3309c.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/video/backlight/mp3309c.c +2 -2
@@ -131,7 +131,7 @@ static int mp3309c_bl_update_status(struct backlight_device *bl) chip->pdata->levels[brightness], chip->pdata->levels[chip->pdata->max_brightness]); pwmstate.enabled = true; - ret =pwm_apply_state (chip->pwmd, &pwmstate); + ret =pwm_apply_might_sleep (chip->pwmd, &pwmstate);if (ret)return ret;
@@ -393,7 +393,7 @@ static int mp3309c_probe(struct i2c_client *client) chip->pdata->default_brightness, chip->pdata->max_brightness); pwmstate.enabled = true; - ret =pwm_apply_state (chip->pwmd, &pwmstate); + ret =pwm_apply_might_sleep (chip->pwmd, &pwmstate);if (ret)return dev_err_probe (chip->dev, ret,"error setting pwm device\n" );
Signature · 1 line
2.43.0
Hello Sean,
Quoted 5 lines · Sean Young
pwm_apply_state()is deprecated since commitc748a6d77c06a("pwm: Renamepwm_apply_state()topwm_apply_might_sleep()"). This is the final user in the tree.Signed-off-by Sean Young <[email protected]>
The "problem" here is that the mp3309c driver didn't exist yet in commit c748a6d77c06a, so it relies on the pwm_apply_state compatibility stub.
I would mention that in the commit log.
Otherwise the change looks fine.
thanks for catching and addressing this issue
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
Quoted 5 lines · Sean Young
pwm_apply_state()is deprecated since commitc748a6d77c06a("pwm: Renamepwm_apply_state()topwm_apply_might_sleep()"). This is the final user in the tree.Signed-off-by Sean Young <[email protected]>
Daniel.
Hi Sean,
I've just tested your change on my board that uses the mp3309c. All ok, thanks!
...
Quoted 9 lines
Subject: [PATCH] backlight: mp3309c: Use
pwm_apply_might_sleep()
pwm_apply_state()is deprecated since commitc748a6d77c06a("pwm:
Renamepwm_apply_state()topwm_apply_might_sleep()"). This is the final user in the tree.Signed-off-by Sean Young <[email protected]>---
Re: (subset) [PATCH] backlight: mp3309c: Use pwm_apply_might_sleep()
In reply to Sean YoungQuoted 5 lines · Sean Young
pwm_apply_state()is deprecated since commitc748a6d77c06a("pwm: Renamepwm_apply_state()topwm_apply_might_sleep()"). This is the final user in the tree.
Applied, thanks!
[1/1] backlight: mp3309c: Use pwm_apply_might_sleep()
commit: 7feb4ec8ec900daf29602bcdf7c04178c63205ac
--
Lee Jones [李琼斯]