Skip to contentSkip to conversation

radvd: add '--shell /sbin/nologin' to /etc/passwd

PATCH In review Li Wang 2 participants 3 messages Jan 29, 2024 – Feb 8, 2024

lore
Share & tools
lore

Li Wang

author
#0 lore raw

PATCH 1/1 radvd: add '--shell /sbin/nologin' to /etc/passwd

the default setting USERADD_PARAM of yocto:
-s /bin/sh

follow redhat policy:
radvd/redhat/systemd/radvd.spec
useradd ... -s /sbin/nologin ...

---
 meta-networking/recipes-daemons/radvd/radvd.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-networking/recipes-daemons/radvd/radvd.inc +1 -1
index 219d88f49..5da31b3f0 100644
@@ -59,7 +59,7 @@ do_install:append () {
 
 USERADD_PACKAGES = "${PN}"
 GROUPADD_PARAM:${PN} = "--system nogroup"
-USERADD_PARAM:${PN} = "--system --home ${localstatedir}/run/radvd/ -M -g nogroup radvd"
+USERADD_PARAM:${PN} = "--system --home ${localstatedir}/run/radvd/ -M -g nogroup --shell /sbin/nologin radvd"
 
 pkg_postinst:${PN} () {
     if [ -z "$D" -a -x /etc/init.d/populate-volatile.sh ]; then
Signature · 1 line
2.25.1
#1 lore raw

Hi,

Le 29/01/2024 à 07:23, Li Wang via lists.openembedded.org a écrit :

Quoted 9 lines

the default setting USERADD_PARAM of yocto:
-s /bin/sh

follow redhat policy:
radvd/redhat/systemd/radvd.spec
useradd ... -s /sbin/nologin ...

Can this fix this error from autobuilder by any chance?
stdio: ERROR: radvd-2.19-r0 do_prepare_recipe_sysroot: radvd: useradd command did not succeed.
stdio: ERROR: radvd-2.19-r0 do_prepare_recipe_sysroot: ExecutionError('/home/pokybuild/yocto-worker/reproducible-meta-oe/build/build/build-st-meta-networking/build-st/reproducibleA/tmp/work/core2-64-poky-linux/radvd/2.19/temp/run.useradd_sysroot.818430', 1, None, None)

Thanks!

Quoted 28 lines
---
 meta-networking/recipes-daemons/radvd/radvd.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-networking/recipes-daemons/radvd/radvd.inc +1 -2
index 219d88f49..5da31b3f0 100644
@@ -59,7 +59,7 @@ do_install:append () {
 
 USERADD_PACKAGES = "${PN}"
 GROUPADD_PARAM:${PN} = "--system nogroup"
-USERADD_PARAM:${PN} = "--system --home ${localstatedir}/run/radvd/ -M -g nogroup radvd"
+USERADD_PARAM:${PN} = "--system --home ${localstatedir}/run/radvd/ -M -g nogroup --shell /sbin/nologin radvd"
 
 pkg_postinst:${PN} () {
     if [ -z "$D" -a -x /etc/init.d/populate-volatile.sh ]; then
 
 
 
-=-=-=-=-=-=-=-=-=-=-=-

Links: You receive all messages sent to this group.
View/Reply Online (#108480): https://lists.openembedded.org/g/openembedded-devel/message/108480
Mute This Topic: https://lists.openembedded.org/mt/104026959/4316185
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Signature · 2 lines
Yoann Congal
Smile ECS - Tech Expert
#2 lore raw

Le lun. 29 janv. 2024 à 09:07, Yoann Congal <[email protected]> a écrit :

Quoted 20 lines

Hi,

Quoted 9 lines · Li Wang via lists.openembedded.org

the default setting USERADD_PARAM of yocto:
-s /bin/sh

follow redhat policy:
radvd/redhat/systemd/radvd.spec
useradd ... -s /sbin/nologin ...

Can this fix this error from autobuilder by any chance?
stdio: ERROR: radvd-2.19-r0 do_prepare_recipe_sysroot: radvd: useradd
command did not succeed.
stdio: ERROR: radvd-2.19-r0 do_prepare_recipe_sysroot:
ExecutionError('/home/pokybuild/yocto-worker/reproducible-meta-oe/build/build/build-st-meta-networking/build-st/reproducibleA/tmp/work/core2-64-poky-linux/radvd/2.19/temp/run.useradd_sysroot.818430', 1, None, None)

Quoted 2 lines

Link :
https://autobuilder.yoctoproject.org/typhoon/#/builders/155/builds/9/steps/29/logs/errors

FWIW, this was an unrelated problem for which I've sent a patch:
[meta-networking][PATCH] radvd: Fix build in reproducible test
https://lists.openembedded.org/g/openembedded-devel/message/108662

Regards,

Quoted 41 lines

Thanks!

Review

Quoted 5 lines
---
 meta-networking/recipes-daemons/radvd/radvd.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/meta-networking/recipes-daemons/radvd/radvd.inc

meta-networking/recipes-daemons/radvd/radvd.inc do_install:append () { · line 62

Quoted 8 lines

index 219d88f49..5da31b3f0 100644

meta-networking/recipes-daemons/radvd/radvd.inc +0 -1
@@ -59,7 +59,7 @@ do_install:append () {
 
 USERADD_PACKAGES = "${PN}"
 GROUPADD_PARAM:${PN} = "--system nogroup"
-USERADD_PARAM:${PN} = "--system --home ${localstatedir}/run/radvd/ -M

-g nogroup radvd"

meta-networking/recipes-daemons/radvd/radvd.inc do_install:append () { · line 62

Quoted 1 line
meta-networking/recipes-daemons/radvd/radvd.inc +1 -0
+USERADD_PARAM:${PN} = "--system --home ${localstatedir}/run/radvd/ -M

-g nogroup --shell /sbin/nologin radvd"

Quoted 9 lines
meta-networking/recipes-daemons/radvd/radvd.inc +0 -1
 pkg_postinst:${PN} () {
     if [ -z "$D" -a -x /etc/init.d/populate-volatile.sh ]; then
 
 
 
-=-=-=-=-=-=-=-=-=-=-=-

Links: You receive all messages sent to this group. View/Reply Online (#108480):

https://lists.openembedded.org/g/openembedded-devel/message/108480

Quoted 3 lines

Mute This Topic: https://lists.openembedded.org/mt/104026959/4316185
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [

[email protected]]

Quoted 2 lines

-=-=-=-=-=-=-=-=-=-=-=-

--
Yoann Congal
Smile ECS - Tech Expert

Signature · 2 lines
Yoann Congal
Smile ECS - Tech expert