thunderbolt: Fix setting the CNS bit in ROUTER_CS_5
Subsystems (2)
PATCH 1/1 thunderbolt: Fix setting the CNS bit in ROUTER_CS_5
The bit 23, CM TBT3 Not Supported (CNS), in ROUTER_CS_5 indicates whether a USB4 Connection Manager is TBT3-Compatible and should be:
0b for TBT3-Compatible
1b for Not TBT3-Compatible
Signed-off-by Mohammad Rahimi <[email protected]>
--- drivers/thunderbolt/tb_regs.h | 2 +- drivers/thunderbolt/usb4.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/thunderbolt/tb_regs.h +1 -1
@@ -203,7 +203,7 @@ struct tb_regs_switch_header {#define ROUTER_CS_5_WOP BIT(1)#define ROUTER_CS_5_WOU BIT(2)#define ROUTER_CS_5_WOD BIT(3) -#define ROUTER_CS_5_C3S BIT(23) +#define ROUTER_CS_5_CNS BIT(23)#define ROUTER_CS_5_PTO BIT(24)#define ROUTER_CS_5_UTO BIT(25)#define ROUTER_CS_5_HCO BIT(26)
drivers/thunderbolt/usb4.c +1 -1
@@ -290,7 +290,7 @@ int usb4_switch_setup(struct tb_switch *sw) }/* TBT3 supported by the CM */ - val |=ROUTER_CS_5_C3S ; + val &= ~ROUTER_CS_5_CNS ;return tb_sw_write (sw, &val,TB_CFG_SWITCH ,ROUTER_CS_5 ,1 ); }
Signature · 1 line
2.39.2
Quoted 4 lines · Mohammad Rahimi
The bit 23, CM TBT3 Not Supported (CNS), in
ROUTER_CS_5indicates whether a USB4 Connection Manager is TBT3-Compatible and should be:
0b for TBT3-Compatible
1b for Not TBT3-Compatible
I'm sure at some point of the spec it was called C3S and the meaning was opposite ;-) Nice catch though!
Quoted 1 line
Signed-off-by Mohammad Rahimi <[email protected]>
Tagged for stable and applied to thunderbolt.git/fixes, thanks!