hwmon: Add driver for MPS MPQ8785 Synchronous Step-Down Converter
PATCH v2 1/1 hwmon: Add driver for MPS MPQ8785 Synchronous Step-Down Converter
Add support for mpq8785 device from Monolithic Power Systems, Inc. (MPS) vendor. This is synchronous step-down controller.
---
Change in v1:
Initial patchset.
Change in v2:
1.Add pmbus support status registers.
2.Add mpq8785 in trivial-devices.yaml.
3.Remove format[PSC_VOLTAGE_OUT]
4.Fix MODULE_DESCRIPTION
--- .../devicetree/bindings/trivial-devices.yaml | 2 + Documentation/hwmon/index.rst | 1 + Documentation/hwmon/mpq8785.rst | 94 +++++++++++++++++++ drivers/hwmon/pmbus/Kconfig | 9 ++ drivers/hwmon/pmbus/Makefile | 1 + drivers/hwmon/pmbus/mpq8785.c | 62 ++++++++++++ 6 files changed, 169 insertions(+) create mode 100644 Documentation/hwmon/mpq8785.rst create mode 100644 drivers/hwmon/pmbus/mpq8785.c
Documentation/devicetree/bindings/trivial-devices.yaml +2 -0
@@ -129,6 +129,8 @@ properties: - mps,mp2975 # Monolithic Power Systems Inc. multi-phase hot-swap controller mp5990 - mps,mp5990 + # Monolithic Power Systems Inc. synchronous step-down converter mpq8785 + - mps,mpq8785 # Honeywell Humidicon HIH-6130 humidity/temperature sensor - honeywell,hi6130 # IBM Common Form Factor Power Supply Versions (all versions)
Documentation/hwmon/index.rst +1 -0
@@ -163,6 +163,7 @@ Hardware Monitoring Kernel Drivers mp2975 mp5023 mp5990 + mpq8785 nct6683 nct6775 nct7802
Documentation/hwmon/mpq8785.rst new file +94 -0
94 lines not on this page · raw message
drivers/hwmon/pmbus/Kconfig +9 -0
@@ -377,6 +377,15 @@ config SENSORS_MPQ7932 This driver can also be built as a module. If so, the module will be called mpq7932. +config SENSORS_MPQ8785 + tristate "MPS MPQ8785" + help + If you say yes here you get hardware monitoring functionality support + for power management IC MPS MPQ8785. + + This driver can also be built as a module. If so, the module will + be called mpq8785. + config SENSORS_PIM4328 tristate "Flex PIM4328 and compatibles" help
drivers/hwmon/pmbus/Makefile +1 -0
@@ -39,6 +39,7 @@ obj-$(CONFIG_SENSORS_MP2975) += mp2975.o obj-$(CONFIG_SENSORS_MP5023) += mp5023.o obj-$(CONFIG_SENSORS_MP5990) += mp5990.o obj-$(CONFIG_SENSORS_MPQ7932) += mpq7932.o +obj-$(CONFIG_SENSORS_MPQ8785) += mpq8785.o obj-$(CONFIG_SENSORS_PLI1209BC) += pli1209bc.o obj-$(CONFIG_SENSORS_PM6764TR) += pm6764tr.o obj-$(CONFIG_SENSORS_PXE1610) += pxe1610.o
drivers/hwmon/pmbus/mpq8785.c new file +62 -0
62 lines not on this page · raw message
Signature · 1 line
2.34.1
Guenter Roeck
maintainerQuoted 5 lines · Charles Hsu
Add support for mpq8785 device from Monolithic Power Systems, Inc. (MPS) vendor. This is synchronous step-down controller.
Signed-off-by Charles Hsu <[email protected]>
Quoted 7 lines
---
Change in v1:
Initial patchset.
Change in v2:
1.Add pmbus support status registers.
2.Add mpq8785 intrivial-devices.yaml.
3.Remove format[PSC_VOLTAGE_OUT]
This is insufficient, sorry. Problem is that pmbus_identify_common() compares the more reported by PMBUS_VOUT_MODE with the configured mode. Not setting format[PSC_VOLTAGE_OUT] means that the mode is the default (0), which is linear mode. If the chip is configured for direct or vid mode this again will result in probe failure.
I can see two options:
- Add a chip configuration flag such as PMBUS_DETECT_VOUT_MODE (for lack of a better idea) and use it in pmbus_identify_common() to actually _set_ the mode from the VOUT_MODE command instead of expecting it to be already set. This would require providing the coefficients for output voltage direct mode in mpq8785_info. This would be my preferred solution (but require a separate patch to add the code to pmbus_core.c).
- Select a fixed mode and write code to convert affected register readings to that mode if needed. See mp5990.c for an example.
Quoted 17 lines
4.Fix
MODULE_DESCRIPTION--- .../devicetree/bindings/trivial-devices.yaml | 2 + Documentation/hwmon/index.rst | 1 + Documentation/hwmon/mpq8785.rst | 94 +++++++++++++++++++ drivers/hwmon/pmbus/Kconfig | 9 ++ drivers/hwmon/pmbus/Makefile | 1 + drivers/hwmon/pmbus/mpq8785.c | 62 ++++++++++++ 6 files changed, 169 insertions(+)create mode 100644
Documentation/hwmon/mpq8785.rstcreate mode 100644drivers/hwmon/pmbus/mpq8785.cDocumentation/devicetree/bindings/trivial-devices.yaml +0
-0
Documentation/devicetree/bindings/trivial-devices.yaml properties: · line 136
Quoted 8 lines
Documentation/devicetree/bindings/trivial-devices.yaml +2
-0@@ -129,6 +129,8 @@ properties: - mps,mp2975 # Monolithic Power Systems Inc. multi-phase hot-swap controller mp5990 - mps,mp5990 + # Monolithic Power Systems Inc. synchronous step-down converter mpq8785 + - mps,mpq8785 # Honeywell Humidicon HIH-6130 humidity/temperature sensor - honeywell,hi6130 # IBM Common Form Factor Power Supply Versions (all versions)
Sorry, devicetree changes require a separate patch.
Thanks,
Guenter
Guenter Roeck
maintainerQuoted 4 lines · Charles Hsu
Add support for mpq8785 device from Monolithic Power Systems, Inc. (MPS) vendor. This is synchronous step-down controller.
Signed-off-by Charles Hsu <[email protected]>
I hope you are somehow getting this.
I got:
Address not found
Your message wasn't delivered to [email protected] because the address couldn't be found, or is unable to receive mail.
and:
550 5.1.1 The email account that you tried to reach does not exist.
Please try double-checking the recipient's email address for typos or unnecessary spaces.
For more information, go to https://support.google.com/mail/?p=NoSuchUser eo9-20020a056830720900b006e11433d3c1sor1010792otb.11 - gsmtp
Maybe your address got banned from gmail for sending patches to too many recipients (that happened to me before, so it would not be surprising). Unfortunately, I can only accept patches from valid e-mail addresses, so I hope you can get this resolved.
Thanks,
Guenter
Rob Herring
maintainerQuoted 13 lines · Charles Hsu
Add support for mpq8785 device from Monolithic Power Systems, Inc. (MPS) vendor. This is synchronous step-down controller.
Signed-off-by Charles Hsu <[email protected]>---
Change in v1:
Initial patchset.
Change in v2:
1.Add pmbus support status registers.
2.Add mpq8785 intrivial-devices.yaml.
3.Remove format[PSC_VOLTAGE_OUT]
4.FixMODULE_DESCRIPTION
Quoted 2 lines
--- .../devicetree/bindings/trivial-devices.yaml | 2 +
Bindings are a separate patch. checkpatch.pl will tell you this.
Quoted 8 lines
Documentation/hwmon/index.rst | 1 + Documentation/hwmon/mpq8785.rst | 94 +++++++++++++++++++ drivers/hwmon/pmbus/Kconfig | 9 ++ drivers/hwmon/pmbus/Makefile | 1 + drivers/hwmon/pmbus/mpq8785.c | 62 ++++++++++++ 6 files changed, 169 insertions(+) create mode 100644 Documentation/hwmon/mpq8785.rst create mode 100644 drivers/hwmon/pmbus/mpq8785.c