Skip to contentSkip to conversation

opensbi: skip ldflags QA

PATCH In review [email protected] 2 participants 3 messages Jan 29, 2024 – Jan 30, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 opensbi: skip ldflags QA

From: Thomas Perrot <[email protected]>

Quiet the following GNU_HASH error:
ERROR: opensbi-1.4-r0 do_package_qa: QA Issue: File /share/opensbi/lp64/generic/firmware/fw_dynamic.elf in package opensbi doesn't have GNU_HASH (didn't pass LDFLAGS?) File /share/opensbi/lp64/generic/firmware/fw_payload.elf in package opensbi doesn't have GNU_HASH (didn't pass LDFLAGS?)
File /share/opensbi/lp64/generic/firmware/fw_jump.elf in package opensbi doesn't have GNU_HASH (didn't pass LDFLAGS?) [ldflags]

[YOCTO #15370] -- https://bugzilla.yoctoproject.org/show_bug.cgi?id=15370

---
 meta/recipes-bsp/opensbi/opensbi_1.4.bb | 2 ++
 1 file changed, 2 insertions(+)
meta/recipes-bsp/opensbi/opensbi_1.4.bb +2 -0
index fd18c03cfbc4..e36ada081428 100644
@@ -43,3 +43,5 @@ FILES:${PN} += "/share/opensbi/*/${RISCV_SBI_PLAT}/firmware/fw_dynamic.*"
 
 COMPATIBLE_HOST = "(riscv64|riscv32).*"
 INHIBIT_PACKAGE_STRIP = "1"
+
+INSANE_SKIP:${PN} = "ldflags"
Signature · 1 line
2.43.0
#1 lore raw
Quoted 20 lines · Thomas Perrot via lists.openembedded.org

From: Thomas Perrot <[email protected]>

Quiet the following GNU_HASH error:
ERROR: opensbi-1.4-r0 do_package_qa: QA Issue: File /share/opensbi/lp64/generic/firmware/fw_dynamic.elf in package opensbi doesn't have GNU_HASH (didn't pass LDFLAGS?) File /share/opensbi/lp64/generic/firmware/fw_payload.elf in package opensbi doesn't have GNU_HASH (didn't pass LDFLAGS?)
File /share/opensbi/lp64/generic/firmware/fw_jump.elf in package opensbi doesn't have GNU_HASH (didn't pass LDFLAGS?) [ldflags]

[YOCTO #15370] -- https://bugzilla.yoctoproject.org/show_bug.cgi?id=15370

---
 meta/recipes-bsp/opensbi/opensbi_1.4.bb | 2 ++
 1 file changed, 2 insertions(+)
meta/recipes-bsp/opensbi/opensbi_1.4.bb +0 -0
index fd18c03cfbc4..e36ada081428 100644

meta/recipes-bsp/opensbi/opensbi_1.4.bb FILES:${PN} += "/share/opensbi/*/${RISCV_SBI_PLAT}/firmware/fw_dynamic.*" · line 47

Quoted 5 lines
meta/recipes-bsp/opensbi/opensbi_1.4.bb +2 -0
@@ -43,3 +43,5 @@ FILES:${PN} += "/share/opensbi/*/${RISCV_SBI_PLAT}/firmware/fw_dynamic.*"
 
 COMPATIBLE_HOST = "(riscv64|riscv32).*"
 INHIBIT_PACKAGE_STRIP = "1"
+
+INSANE_SKIP:${PN} = "ldflags"

hmmm I wonder if we should pass the OE ldflags, and test it out before disabling this QA warning
try something like TARGET_CC_ARCH += "${LDFLAGS}"

Quoted 12 lines

--
2.43.0

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#194454): https://lists.openembedded.org/g/openembedded-core/message/194454
Mute This Topic: https://lists.openembedded.org/mt/104028517/1997914
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#2 lore raw

Hello Khem,

Quoted 31 lines · Khem Raj
Quoted 28 lines · Thomas Perrot via lists.openembedded.org

From: Thomas Perrot <[email protected]>

Quiet the following GNU_HASH error:
ERROR: opensbi-1.4-r0 do_package_qa: QA Issue: File /share/opensbi/lp64/generic/firmware/fw_dynamic.elf in package opensbi doesn't have GNU_HASH (didn't pass LDFLAGS?) File /share/opensbi/lp64/generic/firmware/fw_payload.elf in package opensbi doesn't have GNU_HASH (didn't pass LDFLAGS?) File /share/opensbi/lp64/generic/firmware/fw_jump.elf in package opensbi doesn't have GNU_HASH (didn't pass LDFLAGS?) [ldflags]

[YOCTO #15370] --
https://bugzilla.yoctoproject.org/show_bug.cgi?id=15370

---
 meta/recipes-bsp/opensbi/opensbi_1.4.bb | 2 ++

 1 file changed, 2 insertions(+)
meta/recipes-bsp/opensbi/opensbi_1.4.bb +0 -0
index fd18c03cfbc4..e36ada081428 100644
@@ -43,3 +43,5 @@ FILES:${PN} +=

"/share/opensbi/*/${RISCV_SBI_PLAT}/firmware/fw_dynamic.*"

Quoted 9 lines

meta/recipes-bsp/opensbi/opensbi_1.4.bb FILES:${PN} += "/share/opensbi/*/${RISCV_SBI_PLAT}/firmware/fw_dynamic.*" · line 47

Quoted 4 lines

 COMPATIBLE_HOST = "(riscv64|riscv32).*"
 INHIBIT_PACKAGE_STRIP = "1"

meta/recipes-bsp/opensbi/opensbi_1.4.bb +2 -0
+
+INSANE_SKIP:${PN} = "ldflags"

hmmm I wonder if we should pass the OE ldflags, and test it out before
disabling this QA warning
try something like TARGET_CC_ARCH += "${LDFLAGS}"

Thank you that solves the issue, I submitted another patch.

Kind regards,
Thomas Perrot

Quoted 19 lines
Quoted 7 lines

--
2.43.0

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#194469):
https://lists.openembedded.org/g/openembedded-core/message/194469
Mute This Topic: https://lists.openembedded.org/mt/104028517/5443093
Group Owner: [email protected] Unsubscribe:
https://lists.openembedded.org/g/openembedded-core/unsub [
[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Signature · 3 lines
Thomas Perrot, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com