Skip to contentSkip to conversation

f2fs: zone: fix to wait completion of last bio in zone correctly

PATCH Applied Chao Yu 3 participants 3 messages Jan 29, 2024 F2FS file system

lore
Share & tools
lore

Chao Yu

author maintainer
#0 lore raw

PATCH 1/1 f2fs: zone: fix to wait completion of last bio in zone correctly

It needs to check last zone_pending_bio and wait IO completion before traverse next fio in io->io_list, otherwise, bio in next zone may be submitted before all IO completion in current zone.

Fixes e067dc3c6b9c ("f2fs: maintain six open zones for zoned devices")
Cc Daeho Jeong <[email protected]>
---
 fs/f2fs/data.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
fs/f2fs/data.c +1 -2
index f45ecb810ae6..8cdbc5ae44db 100644
@@ -1006,7 +1006,7 @@ void f2fs_submit_page_write(struct f2fs_io_info *fio)
 	f2fs_bug_on(sbi, is_read_io(fio->op));
 
 	f2fs_down_write(&io->io_rwsem);
-
+next:
 #ifdef CONFIG_BLK_DEV_ZONED
 	if (f2fs_sb_has_blkzoned(sbi) && btype < META && io->zone_pending_bio) {
 		wait_for_completion_io(&io->zone_wait);
@@ -1016,7 +1016,6 @@ void f2fs_submit_page_write(struct f2fs_io_info *fio)
 	}
 #endif
 
-next:
 	if (fio->in_list) {
 		spin_lock(&io->io_lock);
 		if (list_empty(&io->io_list)) {
Signature · 1 line
2.40.1
Reviewed-by on v1 1/1
#1 lore raw

Thanks,

Quoted 42 lines · Chao Yu

It needs to check last zone_pending_bio and wait IO completion before traverse next fio in io->io_list, otherwise, bio in next zone may be submitted before all IO completion in current zone.

Fixes e067dc3c6b9c ("f2fs: maintain six open zones for zoned devices")
Cc Daeho Jeong <[email protected]>
---
 fs/f2fs/data.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
fs/f2fs/data.c +1 -3
index f45ecb810ae6..8cdbc5ae44db 100644
@@ -1006,7 +1006,7 @@ void f2fs_submit_page_write(struct f2fs_io_info *fio)
        f2fs_bug_on(sbi, is_read_io(fio->op));
 
        f2fs_down_write(&io->io_rwsem);
-
+next:
 #ifdef CONFIG_BLK_DEV_ZONED
        if (f2fs_sb_has_blkzoned(sbi) && btype < META && io->zone_pending_bio) {
                wait_for_completion_io(&io->zone_wait);
@@ -1016,7 +1016,6 @@ void f2fs_submit_page_write(struct f2fs_io_info *fio)
        }
 #endif
 
-next:
        if (fio->in_list) {
                spin_lock(&io->io_lock);
                if (list_empty(&io->io_list)) {
--

2.40.1

_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

#2 lore raw
In reply to Chao Yu
This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim <[email protected]>:

Hello:

This patch was applied to jaegeuk/f2fs.git (dev)
by Jaegeuk Kim <[email protected]>:

Quoted 9 lines · On Mon, 29 Jan 2024 19:27:40 +0800 you wrote:

It needs to check last zone_pending_bio and wait IO completion before traverse next fio in io->io_list, otherwise, bio in next zone may be submitted before all IO completion in current zone.

Fixes e067dc3c6b9c ("f2fs: maintain six open zones for zoned devices")
Cc Daeho Jeong <[email protected]>

[...]

Here is the summary with links:
- [f2fs-dev] f2fs: zone: fix to wait completion of last bio in zone correctly

    https://git.kernel.org/jaegeuk/f2fs/c/cd3ac0d15df7

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html