Skip to contentSkip to conversation

backlight: ktz8866: Correct the check for of_property_read_u32

PATCH Applied Jianhua Lu 3 participants 3 messages Jan 29, 2024 – Feb 8, 2024

Subsystems (3)
lore
Share & tools
lore

Jianhua Lu

author maintainer
#0 lore raw

PATCH 1/1 backlight: ktz8866: Correct the check for of_property_read_u32

of_property_read_u32 returns 0 when success, so reverse the return value to get the true value.

Fixes f8449c8f7355 ("backlight: ktz8866: Add support for Kinetic KTZ8866 backlight")
---
 drivers/video/backlight/ktz8866.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/video/backlight/ktz8866.c +3 -3
index 9c980f2571ee..014877b5a984 100644
@@ -97,20 +97,20 @@ static void ktz8866_init(struct ktz8866 *ktz)
 {
 	unsigned int val = 0;
 
-	if (of_property_read_u32(ktz->client->dev.of_node, "current-num-sinks", &val))
+	if (!of_property_read_u32(ktz->client->dev.of_node, "current-num-sinks", &val))
 		ktz8866_write(ktz, BL_EN, BIT(val) - 1);
 	else
 		/* Enable all 6 current sinks if the number of current sinks isn't specified. */
 		ktz8866_write(ktz, BL_EN, BIT(6) - 1);
 
-	if (of_property_read_u32(ktz->client->dev.of_node, "kinetic,current-ramp-delay-ms", &val)) {
+	if (!of_property_read_u32(ktz->client->dev.of_node, "kinetic,current-ramp-delay-ms", &val)) {
 		if (val <= 128)
 			ktz8866_write(ktz, BL_CFG2, BIT(7) | (ilog2(val) << 3) | PWM_HYST);
 		else
 			ktz8866_write(ktz, BL_CFG2, BIT(7) | ((5 + val / 64) << 3) | PWM_HYST);
 	}
 
-	if (of_property_read_u32(ktz->client->dev.of_node, "kinetic,led-enable-ramp-delay-ms", &val)) {
+	if (!of_property_read_u32(ktz->client->dev.of_node, "kinetic,led-enable-ramp-delay-ms", &val)) {
 		if (val == 0)
 			ktz8866_write(ktz, BL_DIMMING, 0);
 		else {
Signature · 1 line
2.43.0
maintainer Applied
#2 lore raw

Re: (subset) [PATCH] backlight: ktz8866: Correct the check for of_property_read_u32

In reply to Jianhua Lu
Quoted 4 lines · Jianhua Lu

of_property_read_u32 returns 0 when success, so reverse the return value to get the true value.

Applied, thanks!

[1/1] backlight: ktz8866: Correct the check for of_property_read_u32

      commit: 7c0ff4ae24bf4589b5bb460e4b31817c61fa2bef

--
Lee Jones [李琼斯]