Skip to contentSkip to conversation

ARM: dts: aspeed: asus: Add ASUS X4TF BMC

PATCH In review Kelly Hung 3 participants 13 messages Jan 30, 2024 – Mar 26, 2024

Subsystems (2)
lore
Share & tools
lore

Kelly Hung

author
#0 lore raw

PATCH 1/1 ARM: dts: aspeed: asus: Add ASUS X4TF BMC

This initial device-tree provides the necessary configuration for basic BMC functionality and work on ASUS X4TF production.

---
 Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml +1 -0
index 749ee54a3ff8..80009948e14a 100644
@@ -74,6 +74,7 @@ properties:
               - ampere,mtmitchell-bmc
               - aspeed,ast2600-evb
               - aspeed,ast2600-evb-a1
+              - asus,x4tf
               - facebook,bletchley-bmc
               - facebook,cloudripper-bmc
               - facebook,elbert-bmc
Signature · 1 line
2.25.1
author
#1 lore raw

PATCH 1/1 ARM: dts: aspeed: asus: Add ASUS X4TF BMC

From: kelly1732000 <[email protected]>

This initial device-tree provides the necessary configuration for basic BMC functionality and work on ASUS X4TF production.

---
 .../boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts  | 828 ++++++++++++++++++
 1 file changed, 828 insertions(+)
 create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +828 -0
new file mode 100644
index 000000000000..723bbb33137f
@@ -0,0 +1,828 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+// Copyright 2023 ASUS Corp.
+/dts-v1/;
+
+#include "aspeed-g6.dtsi"
+#include <dt-bindings/gpio/aspeed-gpio.h>
+#include <dt-bindings/i2c/i2c.h>
+
+
+/ {
+	model = "ASUS-X4TF";
+	compatible = "asus,x4tf", "aspeed,ast2600";
+
+	chosen {
+		stdout-path = &uart5;
+		bootargs = "console=ttyS4,115200n8 earlycon";
+	};
+
+	memory@80000000 {
+		device_type = "memory";
+		reg = <0x80000000 0x40000000>;
+	};
+
+	reserved-memory {
+		#address-cells = <1>;
+		#size-cells = <1>;
+		ranges;
+
+		gfx_memory: framebuffer {
+			size = <0x01000000>;
+			alignment = <0x01000000>;
+			compatible = "shared-dma-pool";
+			reusable;
+		};
+
+		video_engine_memory: video {
+			size = <0x04000000>;
+			alignment = <0x01000000>;
+			compatible = "shared-dma-pool";
+			reusable;
+		};
+
+		rvas_memory: rvas {
+			size = <0x04000000>;
+			alignment = <0x01000000>;
+			compatible = "shared-dma-pool";
+			reusable;
+		};
+
+		bmc_dev_memory: bmc_dev_memory {
+			size = <0x00100000>;
+			alignment = <0x00100000>;
+			compatible = "shared-dma-pool";
+			no-map;
+		};
+
+		pci_msi_memory: pci_msi_memory {
+			no-map;
+			reg = <0x9e770000 0x100>;
+			compatible = "shared-dma-pool";
+		};
+		/* 1GB memory */
+		vga_memory: region@bf000000 {
+			no-map;
+			compatible = "shared-dma-pool";
+			reg = <0xbf000000 0x01000000>;  /* 16M */
+		};
+		ssp_memory: ssp_memory {
+			size = <0x02000000>;
+			alignment = <0x01000000>;
+			compatible = "shared-dma-pool";
+			no-map;
+		};
+	};
+
+	vcc_sdhci0: regulator-vcc-sdhci0 {
+		compatible = "regulator-fixed";
+		status = "disabled";
+		regulator-name = "SDHCI0 Vcc";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		gpios = <&gpio0 ASPEED_GPIO(V, 0) GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+	};
+
+	vccq_sdhci0: regulator-vccq-sdhci0 {
+		compatible = "regulator-gpio";
+		status = "disabled";
+		regulator-name = "SDHCI0 VccQ";
+		regulator-min-microvolt = <1800000>;
+		regulator-max-microvolt = <3300000>;
+		gpios = <&gpio0 ASPEED_GPIO(V, 1) GPIO_ACTIVE_HIGH>;
+		gpios-states = <1>;
+		states = <3300000 1>,
+			 <1800000 0>;
+	};
+
+	vcc_sdhci1: regulator-vcc-sdhci1 {
+		compatible = "regulator-fixed";
+		status = "disabled";
+		regulator-name = "SDHCI1 Vcc";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		gpios = <&gpio0 ASPEED_GPIO(V, 2) GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+	};
+
+	vccq_sdhci1: regulator-vccq-sdhci1 {
+		compatible = "regulator-gpio";
+		status = "disabled";
+		regulator-name = "SDHCI1 VccQ";
+		regulator-min-microvolt = <1800000>;
+		regulator-max-microvolt = <3300000>;
+		gpios = <&gpio0 ASPEED_GPIO(V, 3) GPIO_ACTIVE_HIGH>;
+		gpios-states = <1>;
+		states = <3300000 1>,
+			 <1800000 0>;
+	};
+	iio-hwmon {
+		compatible = "iio-hwmon";
+		io-channels = <&adc0 0>, <&adc0 1>, <&adc0 2>, <&adc0 3>,
+				<&adc0 4>, <&adc0 5>, <&adc0 6>, <&adc0 7>,
+				<&adc1 0>, <&adc1 1>, <&adc1 2>, <&adc1 3>,
+				<&adc1 4>, <&adc1 5>, <&adc1 6>, <&adc1 7>;
+	};
+
+	video-engine@1e700000 {
+		compatible = "aspeed,ast2600-video-engine";
+		reg = <0x1e700000 0x20000>;
+		clocks = <&syscon ASPEED_CLK_GATE_VCLK>, <&syscon ASPEED_CLK_GATE_ECLK>;
+		clock-names = "vclk", "eclk";
+		interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
+		memory-region = <&video_engine_memory>;
+		//resets = <&syscon ASPEED_RESET_VIDEO>;
+	};
+
+	leds {
+		compatible = "gpio-leds";
+
+		heartbeat {
+			gpios = <&gpio0 ASPEED_GPIO(P, 7) GPIO_ACTIVE_LOW>;
+			linux,default-trigger = "heartbeat";
+		};
+		uid_led {
+			gpios = <&gpio0 ASPEED_GPIO(P, 1) (GPIO_ACTIVE_LOW | GPIO_OPEN_DRAIN)>;
+			default-state = "off";
+		};
+		status_Y {
+			gpios = <&gpio1 ASPEED_GPIO(B, 1) GPIO_ACTIVE_LOW>;
+			default-state = "off";
+		};
+		sys_boot_status {
+			gpios = <&gpio1 ASPEED_GPIO(B, 0) GPIO_ACTIVE_LOW>;
+			default-state = "off";
+		};
+	};
+	spigpio {
+		status = "okay";
+		compatible = "spi-gpio";
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		sck-gpios = <&gpio0 ASPEED_GPIO(Z, 3) GPIO_ACTIVE_HIGH>;
+		mosi-gpios = <&gpio0 ASPEED_GPIO(Z, 4) GPIO_ACTIVE_HIGH>;
+		miso-gpios = <&gpio0 ASPEED_GPIO(Z, 5) GPIO_ACTIVE_HIGH>;
+		num-chipselects = <1>;
+		cs-gpios = <&gpio0 ASPEED_GPIO(Z, 0) GPIO_ACTIVE_HIGH>;
+	};
+
+};
+
+&adc0 {
+	vref = <2500>;
+	status = "okay";
+
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_adc0_default &pinctrl_adc1_default
+		&pinctrl_adc2_default &pinctrl_adc3_default
+		&pinctrl_adc4_default &pinctrl_adc5_default
+		&pinctrl_adc6_default &pinctrl_adc7_default>;
+};
+
+&adc1 {
+	vref = <2500>;
+	status = "okay";
+
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_adc8_default &pinctrl_adc9_default
+		&pinctrl_adc10_default &pinctrl_adc11_default
+		&pinctrl_adc12_default &pinctrl_adc13_default
+		&pinctrl_adc14_default &pinctrl_adc15_default>;
+};
+
+&peci0 {
+	status = "okay";
+};
+
+&lpc_snoop {
+	snoop-ports = <0x80>;
+	status = "okay";
+};
+
+
+&mdio0 {
+	status = "disabled";
+};
+
+
+&mdio1 {
+	status = "disabled";
+};
+
+&mdio2 {
+	status = "okay";
+
+	ethphy2: ethernet-phy@0 {
+		compatible = "ethernet-phy-ieee802.3-c22";
+		reg = <0>;
+	};
+};
+
+&mdio3 {
+	status = "okay";
+
+	ethphy3: ethernet-phy@0 {
+		compatible = "ethernet-phy-ieee802.3-c22";
+		reg = <0>;
+	};
+};
+
+&mac0 {
+	status = "disabled";
+};
+
+&mac1 {
+	status = "disabled";
+};
+
+//for X4TF
+&mac2 {
+	status = "okay";
+	phy-mode = "rmii";
+	#phy-handle = <&ethphy2>;
+	use-ncsi;
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_rmii3_default>;
+};
+
+
+&mac3 {
+	status = "okay";
+	phy-mode = "rmii";
+	#phy-handle = <&ethphy3>;
+	use-ncsi;
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_rmii4_default>;
+};
+
+
+&syscon {
+	uart-clock-high-speed;
+	status = "okay";
+};
+
+&rtc {
+	status = "disabled";
+};
+
+&fmc {
+	status = "okay";
+	flash@0 {
+		status = "okay";
+		m25p,fast-read;
+		label = "bmc-spi";
+		spi-max-frequency = <50000000>;
+		spi-bus-width = <1>;
+		partitions {
+			compatible = "fixed-partitions";
+			#address-cells = <1>;
+			#size-cells = <1>;
+			bmc@0 {
+				label = "bmc";
+				reg = <0x0 0x4000000>;
+			};
+			u-boot@0 {
+				label = "u-boot";
+				reg = <0x0 0x200000>;
+			};
+			u-boot-env@1f0000 {
+				label = "u-boot-env";
+				reg = <0x1f0000 0x10000>;
+			};
+			kernel@200000 {
+				label = "kernel";
+				reg = <0x200000 0xc00000>;
+			};
+			rofs@a00000 {
+				label = "rofs";
+				reg = <0xa00000 0x2a00000>;
+			};
+			rwfs@2a00000 {
+				label = "rwfs";
+				reg = <0x2a00000 0x43f0000>;
+			};
+		};
+	};
+};
+
+&spi1 {
+	status = "okay";
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_spi1_default>;
+
+	flash@0 {
+		status = "okay";
+		w25q256,fast-read;
+		label = "bios-spi";
+		spi-max-frequency = <50000000>;
+		partitions {
+			compatible = "fixed-partitions";
+			#address-cells = <1>;
+			#size-cells = <1>;
+			biosfullimg@0 {
+				reg = <0x0 0x2000000>; //  32768 *1024 = 0x2000000, 32 MB
+				label = "biosfullimg";
+			};
+		};
+	};
+};
+
+&i2c0 {
+	status = "okay";
+};
+
+&i2c1 {
+	status = "okay";
+};
+
+&i2c2 {
+	status = "okay";
+};
+
+&i2c3 {
+	status = "okay";
+};
+
+&i2c4 {
+	status = "okay";
+	tmp75@48 {
+		compatible = "ti,tmp75";
+		reg = <0x48>;
+	};
+	tmp75@49 {
+		compatible = "ti,tmp75";
+		reg = <0x49>;
+	};
+
+	pca9555_4_20: gpio@20 {
+		compatible = "nxp,pca9555";
+		reg = <0x20>;
+		gpio-controller;
+		#gpio-cells = <2>;
+	};
+
+	pca9555_4_22: gpio@22 {
+		compatible = "nxp,pca9555";
+		reg = <0x22>;
+		gpio-controller;
+		#gpio-cells = <2>;
+	};
+
+	pca9555_4_24: gpio@24 {
+		compatible = "nxp,pca9555";
+		reg = <0x24>;
+		gpio-controller;
+		#gpio-cells = <2>;
+		gpio-line-names =
+		/*A0 - A7 0*/	"", "STRAP_BMC_BATTERY_GPIO1", "", "", "", "", "", "",
+		/*B0 - B7 8*/	"", "", "", "", "", "", "", "";
+	};
+
+	pca9555_4_26: gpio@26 {
+		compatible = "nxp,pca9555";
+		reg = <0x26>;
+		gpio-controller;
+		#gpio-cells = <2>;
+	};
+
+	i2c-switch@70 {
+		compatible = "nxp,pca9546";
+		status = "okay";
+		reg = <0x70>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		channel_1: i2c@0 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <0>;
+		};
+
+		channel_2: i2c@1 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <1>;
+		};
+
+		channel_3: i2c@2 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <2>;
+		};
+
+		channel_4: i2c@3 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <3>;
+		};
+	};
+};
+
+&i2c5 {
+	status = "okay";
+	pca9555_5_24: gpio@24 {
+		compatible = "nxp,pca9555";
+		reg = <0x24>;
+		gpio-controller;
+		#gpio-cells = <2>;
+	};
+
+	i2c-switch@70  {
+		compatible = "nxp,pca9546";
+		status = "okay";
+		reg = <0x70 >;
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		channel_5: i2c@0 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <0>;
+			pca9555_5_5_20: gpio@20 {
+				compatible = "nxp,pca9555";
+				reg = <0x20>;
+				gpio-controller;
+				#gpio-cells = <2>;
+				gpio-line-names =
+				/*A0 0*/	"", "", "", "", "", "", "", "",
+				/*B0 8*/	"", "", "SYS_FAN6", "SYS_FAN5",
+				/*B4 12*/	"SYS_FAN4", "SYS_FAN3", "SYS_FAN2", "SYS_FAN1";
+			};
+			pca9555_5_5_21: gpio@21 {
+				compatible = "nxp,pca9555";
+				reg = <0x21>;
+				gpio-controller;
+				#gpio-cells = <2>;
+			};
+			ina219@0x44 {
+				compatible = "ti,ina219";
+				reg = <0x44>;
+				rshunt = <2>;
+			};
+		};
+
+		channel_6: i2c@1 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <1>;
+		};
+
+		channel_7: i2c@2 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <2>;
+		};
+
+		channel_8: i2c@3 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <3>;
+		};
+	};
+};
+
+&i2c6 {
+	status = "okay";
+	pca9555_6_27: gpio@27 {
+		compatible = "nxp,pca9555";
+		reg = <0x27>;
+		gpio-controller;
+		#gpio-cells = <2>;
+	};
+	pca9555_6_20: gpio@20 {
+		compatible = "nxp,pca9555";
+		reg = <0x20>;
+		gpio-controller;
+		#gpio-cells = <2>;
+		gpio-line-names =
+		/*A0 - A7 0*/	"", "", "", "", "", "", "", "",
+		/*B0 - B7 8*/	"Drive_NVMe1", "Drive_NVMe2", "", "", "", "", "", "";
+	};
+	pca9555_6_21: gpio@21 {
+		compatible = "nxp,pca9555";
+		reg = <0x21>;
+		gpio-controller;
+		#gpio-cells = <2>;
+	};
+};
+
+&i2c7 {
+	status = "okay";
+	i2c-switch@70 {
+		compatible = "nxp,pca9546";
+		status = "okay";
+		reg = <0x70>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+		idle-state = <1>;
+
+		channel_9: i2c@0 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <0>;
+			tmp75@48 {
+				compatible = "ti,tmp75";
+				reg = <0x48>;
+			};
+			tmp75@49 {
+				compatible = "ti,tmp75";
+				reg = <0x49>;
+			};
+			ina219@0x40 {
+				compatible = "ti,ina219";
+				reg = <0x40>;
+				rshunt = <2>;
+			};
+			ina219@0x41 {
+				compatible = "ti,ina219";
+				reg = <0x41>;
+				rshunt = <5>;
+			};
+		};
+
+		channel_10: i2c@1 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <1>;
+		};
+
+		channel_11: i2c@2 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <2>;
+		};
+
+		channel_12: i2c@3 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <3>;
+		};
+	};
+	i2c-switch@71 {
+		compatible = "nxp,pca9546";
+		status = "okay";
+		reg = <0x71>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+		i2c-mux-idle-disconnect;
+
+		channel_13: i2c@0 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <0>;
+		};
+
+		channel_14: i2c@1 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <1>;
+		};
+
+		channel_15: i2c@2 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <2>;
+		};
+
+		channel_16: i2c@3 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <3>;
+		};
+	};
+};
+
+&i2c8 {
+	status = "okay";
+	i2c-switch@70 {
+		compatible = "nxp,pca9546";
+		status = "okay";
+		reg = <0x70>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+		i2c-mux-idle-disconnect;
+
+		channel_17: i2c@0 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <0>;
+		};
+
+		channel_18: i2c@1 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <1>;
+			tmp75@48 {
+				compatible = "ti,tmp75";
+				reg = <0x48>;
+			};
+			ina219@0x41 {
+				compatible = "ti,ina219";
+				reg = <0x41>;
+				rshunt = <5>;
+			};
+		};
+
+		channel_19: i2c@2 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <2>;
+		};
+
+		channel_20: i2c@3 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <3>;
+		};
+	};
+};
+
+&i2c9 {
+	status = "okay";
+};
+
+&i2c10 {
+	status = "okay";
+};
+
+&i2c11 {
+	status = "okay";
+};
+
+&i2c12 {
+	status = "disabled";
+};
+
+&i2c13 {
+	status = "disabled";
+};
+
+&i2c14 {
+	status = "okay";
+	multi-master;
+	eeprom@50 {
+		compatible = "atmel,24c08";
+		reg = <0x50>;
+	};
+	eeprom@51 {
+		compatible = "atmel,24c08";
+		reg = <0x51>;
+	};
+};
+
+&sgpiom0 {
+	status = "okay";
+};
+
+&gfx {
+	pcie-reset-detect;
+	status = "disabled";
+	memory-region = <&gfx_memory>;
+};
+
+&sdc {
+	status = "okay";
+};
+
+&sdhci0 {
+	status = "disabled";
+	bus-width = <4>;
+	max-frequency = <100000000>;
+	sdhci-drive-type = /bits/ 8 <3>;
+	/* SDR104/DDR50/SDR50 bits in CAPA2 is not supported */
+	sdhci-caps-mask = <0x7 0x580000>;
+	sdhci,wp-inverted;
+};
+
+#if !defined(CONFIG_SPX_FEATURE_ENABLE_SSP)
+&sdhci1 {
+	status = "disabled";
+	bus-width = <4>;
+	max-frequency = <100000000>;
+	sdhci-drive-type = /bits/ 8 <3>;
+	sdhci-caps-mask = <0x7 0x580000>;
+	sdhci,wp-inverted;
+};
+#endif
+
+&lpc_snoop {
+	status = "okay";
+	snoop-ports = <0x80>;
+};
+
+&ibt {
+	status = "disabled";
+};
+
+&kcs1 {
+	kcs_addr = <0xca0>;
+	status = "okay";
+};
+
+&kcs2 {
+	kcs_addr = <0xca8>;
+	status = "okay";
+};
+
+&kcs3 {
+	kcs_addr = <0xca2>;
+	status = "okay";
+};
+
+&kcs4 {
+	kcs_addr = <0xca4>;
+	status = "disabled";
+};
+
+&uart1 {
+	status = "disabled";
+};
+
+&uart2 {
+	status = "disabled";
+};
+
+&uart3 {
+	status = "okay";
+};
+
+&uart4 {
+	status = "okay";
+	/* GPIOB6 will be used in ASD function, do not set to be TXD4 */
+	//pinctrl-0 = <&pinctrl_txd4_default &pinctrl_rxd4_default>;
+	pinctrl-0 = <&pinctrl_txd2_default &pinctrl_rxd2_default>;
+};
+
+&uart_routing {
+	status = "okay";
+};
+
+&uart5 {
+	status = "okay";
+};
+
+#if defined(CONFIG_SPX_FEATURE_ENABLE_SSP)
+&uart7 {
+	status = "okay";
+};
+#endif
+
+#if defined(CONFIG_SPX_FEATURE_PLATGUARDPLUS_SUPPORT)
+&uart11 {
+	status = "okay";
+};
+#endif
+#ifdef CONFIG_SPX_FEATURE_USB_PORT_B_HOST_SUPPORT
+&ehci1 {
+	status = "okay";
+};
+
+&uhci {
+	status = "okay";
+};
+#endif
+
+&vhub {
+	status = "okay";
+};
+
+#ifdef CONFIG_SPX_FEATURE_USB_PORT_B_SUPPORT
+&udc {
+	status = "okay";
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_usb2bd_default>;
+};
+#endif
+
+&gpio0 {
+	gpio-line-names =
+	/*A0 0*/	"", "", "", "", "", "", "", "",
+	/*B0 8*/	"", "", "", "", "", "", "PS_PWROK", "",
+	/*C0 16*/	"", "", "", "", "", "", "", "",
+	/*D0 24*/	"", "", "", "", "", "", "", "",
+	/*E0 32*/	"", "", "", "", "", "", "", "",
+	/*F0 40*/	"", "", "", "", "", "", "", "",
+	/*G0 48*/	"", "", "", "", "", "", "", "",
+	/*H0 56*/	"", "", "", "", "", "", "", "",
+	/*I0 64*/	"", "", "", "", "", "", "", "",
+	/*J0 72*/	"", "", "", "", "", "", "", "",
+	/*K0 80*/	"", "", "", "", "", "", "", "",
+	/*L0 88*/	"", "", "", "", "", "", "", "",
+	/*M0 96*/	"", "", "", "", "", "", "", "",
+	/*N0 104*/	"", "", "", "",
+	/*N4 108*/	"POST_COMPLETE", "ESR1_GPIO_AST_SPISEL", "", "",
+	/*O0 112*/	"", "", "", "", "", "", "", "",
+	/*P0 120*/	"ID_BUTTON", "ID_OUT", "POWER_BUTTON", "POWER_OUT",
+	/*P4 124*/	"RESET_BUTTON", "RESET_OUT", "", "HEARTBEAT",
+	/*Q0 128*/	"", "", "", "", "", "", "", "",
+	/*R0 136*/	"", "", "", "", "", "", "", "",
+	/*S0 144*/	"", "", "", "", "", "", "", "",
+	/*T0 152*/	"", "", "", "", "", "", "", "",
+	/*U0 160*/	"", "", "", "", "", "", "", "",
+	/*V0 168*/	"", "", "", "", "", "", "", "",
+	/*W0 176*/	"", "", "", "", "", "", "", "",
+	/*X0 184*/	"", "", "", "", "", "", "", "",
+	/*Y0 192*/	"", "", "", "", "", "", "", "",
+	/*Z0 200*/	"", "", "", "", "", "", "", "";
+};
Signature · 1 line
2.25.1
#2 lore raw
Quoted 10 lines · Kelly Hung

From: kelly1732000 <[email protected]>

This initial device-tree provides the necessary configuration for basic BMC functionality and work on ASUS X4TF production.

---
 .../boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts  | 828 ++++++++++++++++++
 1 file changed, 828 insertions(+)
 create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts

It's impossible to test this file. You miss Makefile.

Quoted 13 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +6 -0
new file mode 100644
index 000000000000..723bbb33137f
@@ -0,0 +1,828 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+// Copyright 2023 ASUS Corp.
+/dts-v1/;
+
+#include "aspeed-g6.dtsi"
+#include <dt-bindings/gpio/aspeed-gpio.h>

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 16

Quoted 10 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +10 -0
+#include <dt-bindings/i2c/i2c.h>
+
+
+/ {
+	model = "ASUS-X4TF";
+	compatible = "asus,x4tf", "aspeed,ast2600";
+
+	chosen {
+		stdout-path = &uart5;
+		bootargs = "console=ttyS4,115200n8 earlycon";

earlycon is a debugging feature, not mainline. Also, move console to stdout-path, so entire bootargs can be dropped.

Quoted 24 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +24 -0
+	};
+
+	memory at 80000000 {
+		device_type = "memory";
+		reg = <0x80000000 0x40000000>;
+	};
+
+	reserved-memory {
+		#address-cells = <1>;
+		#size-cells = <1>;
+		ranges;
+
+		gfx_memory: framebuffer {
+			size = <0x01000000>;
+			alignment = <0x01000000>;
+			compatible = "shared-dma-pool";
+			reusable;
+		};
+
+		video_engine_memory: video {
+			size = <0x04000000>;
+			alignment = <0x01000000>;
+			compatible = "shared-dma-pool";
+			reusable;

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 50

Quoted 10 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +10 -0
+		};
+
+		rvas_memory: rvas {
+			size = <0x04000000>;
+			alignment = <0x01000000>;
+			compatible = "shared-dma-pool";
+			reusable;
+		};
+
+		bmc_dev_memory: bmc_dev_memory {

No underscores in node names. This applies everywhere.

Quoted 18 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +18 -0
+			size = <0x00100000>;
+			alignment = <0x00100000>;
+			compatible = "shared-dma-pool";
+			no-map;
+		};
+
+		pci_msi_memory: pci_msi_memory {
+			no-map;
+			reg = <0x9e770000 0x100>;
+			compatible = "shared-dma-pool";
+		};
+		/* 1GB memory */
+		vga_memory: region at bf000000 {
+			no-map;
+			compatible = "shared-dma-pool";
+			reg = <0xbf000000 0x01000000>;  /* 16M */
+		};
+		ssp_memory: ssp_memory {

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 78

Quoted 10 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +10 -0
+			size = <0x02000000>;
+			alignment = <0x01000000>;
+			compatible = "shared-dma-pool";
+			no-map;
+		};
+	};
+
+	vcc_sdhci0: regulator-vcc-sdhci0 {
+		compatible = "regulator-fixed";
+		status = "disabled";

Why? It makes it entirely pointless.

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 88

Quoted 10 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +10 -0
+		regulator-name = "SDHCI0 Vcc";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		gpios = <&gpio0 ASPEED_GPIO(V, 0) GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+	};
+
+	vccq_sdhci0: regulator-vccq-sdhci0 {
+		compatible = "regulator-gpio";
+		status = "disabled";

Pointless node.

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 100

Quoted 12 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +12 -0
+		regulator-name = "SDHCI0 VccQ";
+		regulator-min-microvolt = <1800000>;
+		regulator-max-microvolt = <3300000>;
+		gpios = <&gpio0 ASPEED_GPIO(V, 1) GPIO_ACTIVE_HIGH>;
+		gpios-states = <1>;
+		states = <3300000 1>,
+			 <1800000 0>;
+	};
+
+	vcc_sdhci1: regulator-vcc-sdhci1 {
+		compatible = "regulator-fixed";
+		status = "disabled";

Pointless node.

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 110

Quoted 10 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +10 -0
+		regulator-name = "SDHCI1 Vcc";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		gpios = <&gpio0 ASPEED_GPIO(V, 2) GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+	};
+
+	vccq_sdhci1: regulator-vccq-sdhci1 {
+		compatible = "regulator-gpio";
+		status = "disabled";

Pointless node.

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 118

Quoted 8 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +8 -0
+		regulator-name = "SDHCI1 VccQ";
+		regulator-min-microvolt = <1800000>;
+		regulator-max-microvolt = <3300000>;
+		gpios = <&gpio0 ASPEED_GPIO(V, 3) GPIO_ACTIVE_HIGH>;
+		gpios-states = <1>;
+		states = <3300000 1>,
+			 <1800000 0>;
+	};

Missing blank line.

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts

Quoted 8 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +8 -0
+	iio-hwmon {
+		compatible = "iio-hwmon";
+		io-channels = <&adc0 0>, <&adc0 1>, <&adc0 2>, <&adc0 3>,
+				<&adc0 4>, <&adc0 5>, <&adc0 6>, <&adc0 7>,
+				<&adc1 0>, <&adc1 1>, <&adc1 2>, <&adc1 3>,
+				<&adc1 4>, <&adc1 5>, <&adc1 6>, <&adc1 7>;
+	};
+> +	video-engine at 1e700000 {

Wrong placement. Also tools would tell you that.

It does not look like you tested the DTS against bindings. Please run make dtbs_check W=1 (see Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 134

Quoted 7 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +7 -0
+		compatible = "aspeed,ast2600-video-engine";
+		reg = <0x1e700000 0x20000>;
+		clocks = <&syscon ASPEED_CLK_GATE_VCLK>, <&syscon ASPEED_CLK_GATE_ECLK>;
+		clock-names = "vclk", "eclk";
+		interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
+		memory-region = <&video_engine_memory>;
+		//resets = <&syscon ASPEED_RESET_VIDEO>;

Dead code.

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 140

Quoted 6 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +6 -0
+	};
+
+	leds {
+		compatible = "gpio-leds";
+
+		heartbeat {

It does not look like you tested the DTS against bindings. Please run make dtbs_check W=1 (see Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 144

Quoted 4 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +4 -0
+			gpios = <&gpio0 ASPEED_GPIO(P, 7) GPIO_ACTIVE_LOW>;
+			linux,default-trigger = "heartbeat";
+		};
+		uid_led {

It does not look like you tested the DTS against bindings. Please run make dtbs_check W=1 (see Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 147

Quoted 3 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +3 -0
+			gpios = <&gpio0 ASPEED_GPIO(P, 1) (GPIO_ACTIVE_LOW | GPIO_OPEN_DRAIN)>;
+			default-state = "off";
+		};

Missing blank line, everywhere.

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 157

Quoted 10 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +10 -0
+		status_Y {
+			gpios = <&gpio1 ASPEED_GPIO(B, 1) GPIO_ACTIVE_LOW>;
+			default-state = "off";
+		};
+		sys_boot_status {
+			gpios = <&gpio1 ASPEED_GPIO(B, 0) GPIO_ACTIVE_LOW>;
+			default-state = "off";
+		};
+	};
+	spigpio {

It does not look like you tested the DTS against bindings. Please run make dtbs_check W=1 (see Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 157

Quoted 1 line
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +1 -0
+		status = "okay";

Why?

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 169

Quoted 11 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +11 -0
+		compatible = "spi-gpio";
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		sck-gpios = <&gpio0 ASPEED_GPIO(Z, 3) GPIO_ACTIVE_HIGH>;
+		mosi-gpios = <&gpio0 ASPEED_GPIO(Z, 4) GPIO_ACTIVE_HIGH>;
+		miso-gpios = <&gpio0 ASPEED_GPIO(Z, 5) GPIO_ACTIVE_HIGH>;
+		num-chipselects = <1>;
+		cs-gpios = <&gpio0 ASPEED_GPIO(Z, 0) GPIO_ACTIVE_HIGH>;
+	};
+

Redundant blank line.

Quoted 24 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +24 -0
+};
+
+&adc0 {
+	vref = <2500>;
+	status = "okay";
+
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_adc0_default &pinctrl_adc1_default
+		&pinctrl_adc2_default &pinctrl_adc3_default
+		&pinctrl_adc4_default &pinctrl_adc5_default
+		&pinctrl_adc6_default &pinctrl_adc7_default>;
+};
+
+&adc1 {
+	vref = <2500>;
+	status = "okay";
+
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_adc8_default &pinctrl_adc9_default
+		&pinctrl_adc10_default &pinctrl_adc11_default
+		&pinctrl_adc12_default &pinctrl_adc13_default
+		&pinctrl_adc14_default &pinctrl_adc15_default>;
+};
+

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 203

Quoted 10 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +10 -0
+&peci0 {
+	status = "okay";
+};
+
+&lpc_snoop {
+	snoop-ports = <0x80>;
+	status = "okay";
+};
+
+

Redundant blank line. Clean this code before sending upstream from such trivialities.

Quoted 36 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +36 -0
+&mdio0 {
+	status = "disabled";
+};
+
+
+&mdio1 {
+	status = "disabled";
+};
+
+&mdio2 {
+	status = "okay";
+
+	ethphy2: ethernet-phy at 0 {
+		compatible = "ethernet-phy-ieee802.3-c22";
+		reg = <0>;
+	};
+};
+
+&mdio3 {
+	status = "okay";
+
+	ethphy3: ethernet-phy at 0 {
+		compatible = "ethernet-phy-ieee802.3-c22";
+		reg = <0>;
+	};
+};
+
+&mac0 {
+	status = "disabled";
+};
+
+&mac1 {
+	status = "disabled";
+};
+
+//for X4TF

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 249

Quoted 10 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +10 -0
+&mac2 {
+	status = "okay";
+	phy-mode = "rmii";
+	#phy-handle = <&ethphy2>;
+	use-ncsi;
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_rmii3_default>;
+};
+
+

Ditto

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 259

Quoted 10 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +10 -0
+&mac3 {
+	status = "okay";
+	phy-mode = "rmii";
+	#phy-handle = <&ethphy3>;
+	use-ncsi;
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_rmii4_default>;
+};
+
+

Ditto

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 261

Quoted 2 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +2 -0
+&syscon {
+	uart-clock-high-speed;

That's a syscon property?

It does not look like you tested the DTS against bindings. Please run make dtbs_check W=1 (see Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 272

Quoted 11 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +11 -0
+	status = "okay";
+};
+
+&rtc {
+	status = "disabled";
+};
+
+&fmc {
+	status = "okay";
+	flash at 0 {
+		status = "okay";

Drop. Everywhere where it is not needed.

Quoted 67 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +67 -0
+		m25p,fast-read;
+		label = "bmc-spi";
+		spi-max-frequency = <50000000>;
+		spi-bus-width = <1>;
+		partitions {
+			compatible = "fixed-partitions";
+			#address-cells = <1>;
+			#size-cells = <1>;
+			bmc at 0 {
+				label = "bmc";
+				reg = <0x0 0x4000000>;
+			};
+			u-boot at 0 {
+				label = "u-boot";
+				reg = <0x0 0x200000>;
+			};
+			u-boot-env at 1f0000 {
+				label = "u-boot-env";
+				reg = <0x1f0000 0x10000>;
+			};
+			kernel at 200000 {
+				label = "kernel";
+				reg = <0x200000 0xc00000>;
+			};
+			rofs at a00000 {
+				label = "rofs";
+				reg = <0xa00000 0x2a00000>;
+			};
+			rwfs at 2a00000 {
+				label = "rwfs";
+				reg = <0x2a00000 0x43f0000>;
+			};
+		};
+	};
+};
+
+&spi1 {
+	status = "okay";
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_spi1_default>;
+
+	flash at 0 {
+		status = "okay";
+		w25q256,fast-read;
+		label = "bios-spi";
+		spi-max-frequency = <50000000>;
+		partitions {
+			compatible = "fixed-partitions";
+			#address-cells = <1>;
+			#size-cells = <1>;
+			biosfullimg at 0 {
+				reg = <0x0 0x2000000>; //  32768 *1024 = 0x2000000, 32 MB
+				label = "biosfullimg";
+			};
+		};
+	};
+};
+
+&i2c0 {
+	status = "okay";
+};
+
+&i2c1 {
+	status = "okay";
+};
+
+&i2c2 {

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts

Quoted 10 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +10 -0
+	status = "okay";
+};
+
+&i2c3 {
+	status = "okay";
+};
+
+&i2c4 {
+	status = "okay";
+	tmp75 at 48 {

Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts

Quoted 4 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +4 -0
+		compatible = "ti,tmp75";
+		reg = <0x48>;
+	};
+	tmp75 at 49 {

Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

I am going to skip the rest. Please fix all the trivialities and test your patches with tools.

Best regards,
Krzysztof

#3 lore raw

Hi, Krzysztof,

Thanks for review, I notice there were a lot of errors. I've corrected them and done a schema and patch check, then resend the patch on 2/22.

Best Regards
Kelly
-----Original Message-----
From: Krzysztof Kozlowski <[email protected]>
Sent: Tuesday, January 30, 2024 6:39 PM
To: Kelly Hung <[email protected]>; [email protected]
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; Kelly Hung(洪嘉莉) <[email protected]>
Subject: Re: [PATCH] ARM: dts: aspeed: asus: Add ASUS X4TF BMC

External email : Ensure your email is secure before opening links and attachments.

Quoted 11 lines · Kelly Hung

From: kelly1732000 <[email protected]>

This initial device-tree provides the necessary configuration for basic BMC functionality and work on ASUS X4TF production.

---
 .../boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts  | 828
++++++++++++++++++
 1 file changed, 828 insertions(+)
 create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts

It's impossible to test this file. You miss Makefile.

Quoted 14 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +6 -0
new file mode 100644
index 000000000000..723bbb33137f
@@ -0,0 +1,828 @@
+// SPDX-License-Identifier: GPL-2.0-or-later // Copyright 2023 ASUS
+Corp.
+/dts-v1/;
+
+#include "aspeed-g6.dtsi"
+#include <dt-bindings/gpio/aspeed-gpio.h> #include

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 16

Quoted 10 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +10 -0
+<dt-bindings/i2c/i2c.h>
+
+
+/ {
+     model = "ASUS-X4TF";
+     compatible = "asus,x4tf", "aspeed,ast2600";
+
+     chosen {
+             stdout-path = &uart5;
+             bootargs = "console=ttyS4,115200n8 earlycon";

earlycon is a debugging feature, not mainline. Also, move console to stdout-path, so entire bootargs can be dropped.

Quoted 24 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +24 -0
+     };
+
+     memory@80000000 {
+             device_type = "memory";
+             reg = <0x80000000 0x40000000>;
+     };
+
+     reserved-memory {
+             #address-cells = <1>;
+             #size-cells = <1>;
+             ranges;
+
+             gfx_memory: framebuffer {
+                     size = <0x01000000>;
+                     alignment = <0x01000000>;
+                     compatible = "shared-dma-pool";
+                     reusable;
+             };
+
+             video_engine_memory: video {
+                     size = <0x04000000>;
+                     alignment = <0x01000000>;
+                     compatible = "shared-dma-pool";
+                     reusable;

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 50

Quoted 10 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +10 -0
+             };
+
+             rvas_memory: rvas {
+                     size = <0x04000000>;
+                     alignment = <0x01000000>;
+                     compatible = "shared-dma-pool";
+                     reusable;
+             };
+
+             bmc_dev_memory: bmc_dev_memory {

No underscores in node names. This applies everywhere.

Quoted 18 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +18 -0
+                     size = <0x00100000>;
+                     alignment = <0x00100000>;
+                     compatible = "shared-dma-pool";
+                     no-map;
+             };
+
+             pci_msi_memory: pci_msi_memory {
+                     no-map;
+                     reg = <0x9e770000 0x100>;
+                     compatible = "shared-dma-pool";
+             };
+             /* 1GB memory */
+             vga_memory: region@bf000000 {
+                     no-map;
+                     compatible = "shared-dma-pool";
+                     reg = <0xbf000000 0x01000000>;  /* 16M */
+             };
+             ssp_memory: ssp_memory {

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 78

Quoted 10 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +10 -0
+                     size = <0x02000000>;
+                     alignment = <0x01000000>;
+                     compatible = "shared-dma-pool";
+                     no-map;
+             };
+     };
+
+     vcc_sdhci0: regulator-vcc-sdhci0 {
+             compatible = "regulator-fixed";
+             status = "disabled";

Why? It makes it entirely pointless.

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 88

Quoted 10 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +10 -0
+             regulator-name = "SDHCI0 Vcc";
+             regulator-min-microvolt = <3300000>;
+             regulator-max-microvolt = <3300000>;
+             gpios = <&gpio0 ASPEED_GPIO(V, 0) GPIO_ACTIVE_HIGH>;
+             enable-active-high;
+     };
+
+     vccq_sdhci0: regulator-vccq-sdhci0 {
+             compatible = "regulator-gpio";
+             status = "disabled";

Pointless node.

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 100

Quoted 12 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +12 -0
+             regulator-name = "SDHCI0 VccQ";
+             regulator-min-microvolt = <1800000>;
+             regulator-max-microvolt = <3300000>;
+             gpios = <&gpio0 ASPEED_GPIO(V, 1) GPIO_ACTIVE_HIGH>;
+             gpios-states = <1>;
+             states = <3300000 1>,
+                      <1800000 0>;
+     };
+
+     vcc_sdhci1: regulator-vcc-sdhci1 {
+             compatible = "regulator-fixed";
+             status = "disabled";

Pointless node.

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 110

Quoted 10 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +10 -0
+             regulator-name = "SDHCI1 Vcc";
+             regulator-min-microvolt = <3300000>;
+             regulator-max-microvolt = <3300000>;
+             gpios = <&gpio0 ASPEED_GPIO(V, 2) GPIO_ACTIVE_HIGH>;
+             enable-active-high;
+     };
+
+     vccq_sdhci1: regulator-vccq-sdhci1 {
+             compatible = "regulator-gpio";
+             status = "disabled";

Pointless node.

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 118

Quoted 8 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +8 -0
+             regulator-name = "SDHCI1 VccQ";
+             regulator-min-microvolt = <1800000>;
+             regulator-max-microvolt = <3300000>;
+             gpios = <&gpio0 ASPEED_GPIO(V, 3) GPIO_ACTIVE_HIGH>;
+             gpios-states = <1>;
+             states = <3300000 1>,
+                      <1800000 0>;
+     };

Missing blank line.

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts

Quoted 8 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +8 -0
+     iio-hwmon {
+             compatible = "iio-hwmon";
+             io-channels = <&adc0 0>, <&adc0 1>, <&adc0 2>, <&adc0 3>,
+                             <&adc0 4>, <&adc0 5>, <&adc0 6>, <&adc0 7>,
+                             <&adc1 0>, <&adc1 1>, <&adc1 2>, <&adc1 3>,
+                             <&adc1 4>, <&adc1 5>, <&adc1 6>, <&adc1 7>;
+     };
+> +  video-engine@1e700000 {

Wrong placement. Also tools would tell you that.

It does not look like you tested the DTS against bindings. Please run make dtbs_check W=1 (see Documentation/devicetree/bindings/writing-schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 134

Quoted 7 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +7 -0
+             compatible = "aspeed,ast2600-video-engine";
+             reg = <0x1e700000 0x20000>;
+             clocks = <&syscon ASPEED_CLK_GATE_VCLK>, <&syscon ASPEED_CLK_GATE_ECLK>;
+             clock-names = "vclk", "eclk";
+             interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
+             memory-region = <&video_engine_memory>;
+             //resets = <&syscon ASPEED_RESET_VIDEO>;

Dead code.

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 140

Quoted 6 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +6 -0
+     };
+
+     leds {
+             compatible = "gpio-leds";
+
+             heartbeat {

It does not look like you tested the DTS against bindings. Please run make dtbs_check W=1 (see Documentation/devicetree/bindings/writing-schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 144

Quoted 4 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +4 -0
+                     gpios = <&gpio0 ASPEED_GPIO(P, 7) GPIO_ACTIVE_LOW>;
+                     linux,default-trigger = "heartbeat";
+             };
+             uid_led {

It does not look like you tested the DTS against bindings. Please run make dtbs_check W=1 (see Documentation/devicetree/bindings/writing-schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 147

Quoted 3 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +3 -0
+                     gpios = <&gpio0 ASPEED_GPIO(P, 1) (GPIO_ACTIVE_LOW | GPIO_OPEN_DRAIN)>;
+                     default-state = "off";
+             };

Missing blank line, everywhere.

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 157

Quoted 10 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +10 -0
+             status_Y {
+                     gpios = <&gpio1 ASPEED_GPIO(B, 1) GPIO_ACTIVE_LOW>;
+                     default-state = "off";
+             };
+             sys_boot_status {
+                     gpios = <&gpio1 ASPEED_GPIO(B, 0) GPIO_ACTIVE_LOW>;
+                     default-state = "off";
+             };
+     };
+     spigpio {

It does not look like you tested the DTS against bindings. Please run make dtbs_check W=1 (see Documentation/devicetree/bindings/writing-schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 157

Quoted 1 line
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +1 -0
+             status = "okay";

Why?

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 169

Quoted 11 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +11 -0
+             compatible = "spi-gpio";
+             #address-cells = <1>;
+             #size-cells = <0>;
+
+             sck-gpios = <&gpio0 ASPEED_GPIO(Z, 3) GPIO_ACTIVE_HIGH>;
+             mosi-gpios = <&gpio0 ASPEED_GPIO(Z, 4) GPIO_ACTIVE_HIGH>;
+             miso-gpios = <&gpio0 ASPEED_GPIO(Z, 5) GPIO_ACTIVE_HIGH>;
+             num-chipselects = <1>;
+             cs-gpios = <&gpio0 ASPEED_GPIO(Z, 0) GPIO_ACTIVE_HIGH>;
+     };
+

Redundant blank line.

Quoted 22 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +22 -0
+};
+
+&adc0 {
+     vref = <2500>;
+     status = "okay";
+
+     pinctrl-names = "default";
+     pinctrl-0 = <&pinctrl_adc0_default &pinctrl_adc1_default
+             &pinctrl_adc2_default &pinctrl_adc3_default
+             &pinctrl_adc4_default &pinctrl_adc5_default
+             &pinctrl_adc6_default &pinctrl_adc7_default>; };
+
+&adc1 {
+     vref = <2500>;
+     status = "okay";
+
+     pinctrl-names = "default";
+     pinctrl-0 = <&pinctrl_adc8_default &pinctrl_adc9_default
+             &pinctrl_adc10_default &pinctrl_adc11_default
+             &pinctrl_adc12_default &pinctrl_adc13_default
+             &pinctrl_adc14_default &pinctrl_adc15_default>; };
+

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 203

Quoted 10 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +10 -0
+&peci0 {
+     status = "okay";
+};
+
+&lpc_snoop {
+     snoop-ports = <0x80>;
+     status = "okay";
+};
+
+

Redundant blank line. Clean this code before sending upstream from such trivialities.

Quoted 35 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +35 -0
+&mdio0 {
+     status = "disabled";
+};
+
+
+&mdio1 {
+     status = "disabled";
+};
+
+&mdio2 {
+     status = "okay";
+
+     ethphy2: ethernet-phy@0 {
+             compatible = "ethernet-phy-ieee802.3-c22";
+             reg = <0>;
+     };
+};
+
+&mdio3 {
+     status = "okay";
+
+     ethphy3: ethernet-phy@0 {
+             compatible = "ethernet-phy-ieee802.3-c22";
+             reg = <0>;
+     };
+};
+
+&mac0 {
+     status = "disabled";
+};
+
+&mac1 {
+     status = "disabled";
+};
+

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 249

Quoted 10 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +10 -0
+//for X4TF
+&mac2 {
+     status = "okay";
+     phy-mode = "rmii";
+     #phy-handle = <&ethphy2>;
+     use-ncsi;
+     pinctrl-names = "default";
+     pinctrl-0 = <&pinctrl_rmii3_default>; };
+
+

Ditto

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 259

Quoted 9 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +9 -0
+&mac3 {
+     status = "okay";
+     phy-mode = "rmii";
+     #phy-handle = <&ethphy3>;
+     use-ncsi;
+     pinctrl-names = "default";
+     pinctrl-0 = <&pinctrl_rmii4_default>; };
+
+

Ditto

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 261

Quoted 2 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +2 -0
+&syscon {
+     uart-clock-high-speed;

That's a syscon property?

It does not look like you tested the DTS against bindings. Please run make dtbs_check W=1 (see Documentation/devicetree/bindings/writing-schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 272

Quoted 11 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +11 -0
+     status = "okay";
+};
+
+&rtc {
+     status = "disabled";
+};
+
+&fmc {
+     status = "okay";
+     flash@0 {
+             status = "okay";

Drop. Everywhere where it is not needed.

Quoted 67 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +67 -0
+             m25p,fast-read;
+             label = "bmc-spi";
+             spi-max-frequency = <50000000>;
+             spi-bus-width = <1>;
+             partitions {
+                     compatible = "fixed-partitions";
+                     #address-cells = <1>;
+                     #size-cells = <1>;
+                     bmc@0 {
+                             label = "bmc";
+                             reg = <0x0 0x4000000>;
+                     };
+                     u-boot@0 {
+                             label = "u-boot";
+                             reg = <0x0 0x200000>;
+                     };
+                     u-boot-env@1f0000 {
+                             label = "u-boot-env";
+                             reg = <0x1f0000 0x10000>;
+                     };
+                     kernel@200000 {
+                             label = "kernel";
+                             reg = <0x200000 0xc00000>;
+                     };
+                     rofs@a00000 {
+                             label = "rofs";
+                             reg = <0xa00000 0x2a00000>;
+                     };
+                     rwfs@2a00000 {
+                             label = "rwfs";
+                             reg = <0x2a00000 0x43f0000>;
+                     };
+             };
+     };
+};
+
+&spi1 {
+     status = "okay";
+     pinctrl-names = "default";
+     pinctrl-0 = <&pinctrl_spi1_default>;
+
+     flash@0 {
+             status = "okay";
+             w25q256,fast-read;
+             label = "bios-spi";
+             spi-max-frequency = <50000000>;
+             partitions {
+                     compatible = "fixed-partitions";
+                     #address-cells = <1>;
+                     #size-cells = <1>;
+                     biosfullimg@0 {
+                             reg = <0x0 0x2000000>; //  32768 *1024 = 0x2000000, 32 MB
+                             label = "biosfullimg";
+                     };
+             };
+     };
+};
+
+&i2c0 {
+     status = "okay";
+};
+
+&i2c1 {
+     status = "okay";
+};
+
+&i2c2 {

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 349

Quoted 10 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +10 -0
+     status = "okay";
+};
+
+&i2c3 {
+     status = "okay";
+};
+
+&i2c4 {
+     status = "okay";
+     tmp75@48 {

Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 353

Quoted 4 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +4 -0
+             compatible = "ti,tmp75";
+             reg = <0x48>;
+     };
+     tmp75@49 {

Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

I am going to skip the rest. Please fix all the trivialities and test your patches with tools.

Best regards,
Krzysztof

<p></p>
===================================================================================================================================
This email and any attachments to it contain confidential information and are intended solely for the use of the individual to whom it is addressed. If you are not the intended recipient or receive it accidentally, please immediately notify the sender by e-mail and delete the message and any attachments from your computer system, and destroy all hard copies. Please be advised that any unauthorized disclosure, copying, distribution or any action taken or omitted in reliance on this, is illegal and prohibited. Any views or opinions expressed are solely those of the author and do not represent those of ASUSTeK.

For pricing information, ASUS is only entitled to set a recommendation resale price. All customers are free to set their own price as they wish.
===================================================================================================================================

#4 lore raw
Quoted 3 lines · Kelly Hung(???)

Hi, Krzysztof,

Thanks for review, I notice there were a lot of errors. I've corrected them and done a schema and patch check, then resend the patch on 2/22.

And what happened with my other messages? Why you were not replying to them? Why only some parts were implemented?

Best regards,
Krzysztof

#5 lore raw

Krzysztof Kozlowski <[email protected]> 於 2024年3月4日 週一 下午7:23寫道:

Quoted 13 lines · Kelly Hung(洪嘉莉)
Quoted 3 lines

Hi, Krzysztof,

Thanks for review, I notice there were a lot of errors. I've corrected

them and done a schema and patch check, then resend the patch on 2/22.

And what happened with my other messages? Why you were not replying to them? Why only some parts were implemented?

Best regards,
Krzysztof

Hi, Krzysztof,
I repllied to all emails using my Gamil account again. Thanks for your comment.

Best Regards
Kelly

#6 lore raw
In reply to Krzysztof Kozlowski

Hi, Krzysztof,
Please see my response below.

Thanks a log.

Best Regards
Kelly
-----Original Message-----
From: Krzysztof Kozlowski <[email protected]>
Sent: Tuesday, January 30, 2024 6:39 PM
To: Kelly Hung <[email protected]>; [email protected]
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; Kelly Hung(洪嘉莉) <[email protected]>
Subject: Re: [PATCH] ARM: dts: aspeed: asus: Add ASUS X4TF BMC

External email : Ensure your email is secure before opening links and attachments.

Quoted 11 lines · Kelly Hung

From: kelly1732000 <[email protected]>

This initial device-tree provides the necessary configuration for basic BMC functionality and work on ASUS X4TF production.

---
 .../boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts  | 828
++++++++++++++++++
 1 file changed, 828 insertions(+)
 create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts

It's impossible to test this file. You miss Makefile.

Kelly: I've add aspeed-bmc-asus-x4tf.dtb in Makefle.

Quoted 14 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +6 -0
new file mode 100644
index 000000000000..723bbb33137f
@@ -0,0 +1,828 @@
+// SPDX-License-Identifier: GPL-2.0-or-later // Copyright 2023 ASUS
+Corp.
+/dts-v1/;
+
+#include "aspeed-g6.dtsi"
+#include <dt-bindings/gpio/aspeed-gpio.h> #include

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 16

Quoted 10 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +10 -0
+<dt-bindings/i2c/i2c.h>
+
+
+/ {
+     model = "ASUS-X4TF";
+     compatible = "asus,x4tf", "aspeed,ast2600";
+
+     chosen {
+             stdout-path = &uart5;
+             bootargs = "console=ttyS4,115200n8 earlycon";

earlycon is a debugging feature, not mainline. Also, move console to stdout-path, so entire bootargs can be dropped.

Kelly: I've moved "bootargs" into "stdout-path" and resend my patch.

Quoted 24 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +24 -0
+     };
+
+     memory@80000000 {
+             device_type = "memory";
+             reg = <0x80000000 0x40000000>;
+     };
+
+     reserved-memory {
+             #address-cells = <1>;
+             #size-cells = <1>;
+             ranges;
+
+             gfx_memory: framebuffer {
+                     size = <0x01000000>;
+                     alignment = <0x01000000>;
+                     compatible = "shared-dma-pool";
+                     reusable;
+             };
+
+             video_engine_memory: video {
+                     size = <0x04000000>;
+                     alignment = <0x01000000>;
+                     compatible = "shared-dma-pool";
+                     reusable;

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 50

Quoted 10 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +10 -0
+             };
+
+             rvas_memory: rvas {
+                     size = <0x04000000>;
+                     alignment = <0x01000000>;
+                     compatible = "shared-dma-pool";
+                     reusable;
+             };
+
+             bmc_dev_memory: bmc_dev_memory {

No underscores in node names. This applies everywhere.

Kelly: Yes, thanks for reminding, I've removed it and resent my patch.

Quoted 18 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +18 -0
+                     size = <0x00100000>;
+                     alignment = <0x00100000>;
+                     compatible = "shared-dma-pool";
+                     no-map;
+             };
+
+             pci_msi_memory: pci_msi_memory {
+                     no-map;
+                     reg = <0x9e770000 0x100>;
+                     compatible = "shared-dma-pool";
+             };
+             /* 1GB memory */
+             vga_memory: region@bf000000 {
+                     no-map;
+                     compatible = "shared-dma-pool";
+                     reg = <0xbf000000 0x01000000>;  /* 16M */
+             };
+             ssp_memory: ssp_memory {

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 78

Quoted 10 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +10 -0
+                     size = <0x02000000>;
+                     alignment = <0x01000000>;
+                     compatible = "shared-dma-pool";
+                     no-map;
+             };
+     };
+
+     vcc_sdhci0: regulator-vcc-sdhci0 {
+             compatible = "regulator-fixed";
+             status = "disabled";

Why? It makes it entirely pointless.
Kelly: I've removed it and loaded into our X4TF platform and it boot into BMC console. I have resent my patch.

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 88

Quoted 10 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +10 -0
+             regulator-name = "SDHCI0 Vcc";
+             regulator-min-microvolt = <3300000>;
+             regulator-max-microvolt = <3300000>;
+             gpios = <&gpio0 ASPEED_GPIO(V, 0) GPIO_ACTIVE_HIGH>;
+             enable-active-high;
+     };
+
+     vccq_sdhci0: regulator-vccq-sdhci0 {
+             compatible = "regulator-gpio";
+             status = "disabled";

Pointless node.
Kelly: I've removed it and loaded into our X4TF platform and it boot into BMC console. I have resent my patch.

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 100

Quoted 12 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +12 -0
+             regulator-name = "SDHCI0 VccQ";
+             regulator-min-microvolt = <1800000>;
+             regulator-max-microvolt = <3300000>;
+             gpios = <&gpio0 ASPEED_GPIO(V, 1) GPIO_ACTIVE_HIGH>;
+             gpios-states = <1>;
+             states = <3300000 1>,
+                      <1800000 0>;
+     };
+
+     vcc_sdhci1: regulator-vcc-sdhci1 {
+             compatible = "regulator-fixed";
+             status = "disabled";

Pointless node.
Kelly: I've removed it and loaded into our X4TF platform and it boot into BMC console. I have resent my patch.

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 110

Quoted 10 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +10 -0
+             regulator-name = "SDHCI1 Vcc";
+             regulator-min-microvolt = <3300000>;
+             regulator-max-microvolt = <3300000>;
+             gpios = <&gpio0 ASPEED_GPIO(V, 2) GPIO_ACTIVE_HIGH>;
+             enable-active-high;
+     };
+
+     vccq_sdhci1: regulator-vccq-sdhci1 {
+             compatible = "regulator-gpio";
+             status = "disabled";

Pointless node.
Kelly: I've removed it and loaded into our X4TF platform and it boot into BMC console. I have resent my patch.

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 118

Quoted 8 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +8 -0
+             regulator-name = "SDHCI1 VccQ";
+             regulator-min-microvolt = <1800000>;
+             regulator-max-microvolt = <3300000>;
+             gpios = <&gpio0 ASPEED_GPIO(V, 3) GPIO_ACTIVE_HIGH>;
+             gpios-states = <1>;
+             states = <3300000 1>,
+                      <1800000 0>;
+     };

Missing blank line.
Kelly: I've review our dts and add blank line or remove redundant blank lines.

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts

Quoted 8 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +8 -0
+     iio-hwmon {
+             compatible = "iio-hwmon";
+             io-channels = <&adc0 0>, <&adc0 1>, <&adc0 2>, <&adc0 3>,
+                             <&adc0 4>, <&adc0 5>, <&adc0 6>, <&adc0 7>,
+                             <&adc1 0>, <&adc1 1>, <&adc1 2>, <&adc1 3>,
+                             <&adc1 4>, <&adc1 5>, <&adc1 6>, <&adc1 7>;
+     };
+> +  video-engine@1e700000 {

Wrong placement. Also tools would tell you that.

It does not look like you tested the DTS against bindings. Please run make dtbs_check W=1 (see Documentation/devicetree/bindings/writing-schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).

Kelly: I've checked our dts, removed unnecessary parts and run the DTS check script.

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 134

Quoted 7 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +7 -0
+             compatible = "aspeed,ast2600-video-engine";
+             reg = <0x1e700000 0x20000>;
+             clocks = <&syscon ASPEED_CLK_GATE_VCLK>, <&syscon ASPEED_CLK_GATE_ECLK>;
+             clock-names = "vclk", "eclk";
+             interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
+             memory-region = <&video_engine_memory>;
+             //resets = <&syscon ASPEED_RESET_VIDEO>;

Dead code.

Kelly: I have removed this part and resent the patch.

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 140

Quoted 6 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +6 -0
+     };
+
+     leds {
+             compatible = "gpio-leds";
+
+             heartbeat {

It does not look like you tested the DTS against bindings. Please run make dtbs_check W=1 (see Documentation/devicetree/bindings/writing-schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).

Kelly: I added led- for all LED configurations. Heartbeat will be led-heartbeat.

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 144

Quoted 4 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +4 -0
+                     gpios = <&gpio0 ASPEED_GPIO(P, 7) GPIO_ACTIVE_LOW>;
+                     linux,default-trigger = "heartbeat";
+             };
+             uid_led {

It does not look like you tested the DTS against bindings. Please run make dtbs_check W=1 (see Documentation/devicetree/bindings/writing-schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).

Kelly: I added led- for all LED configurations.

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 147

Quoted 3 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +3 -0
+                     gpios = <&gpio0 ASPEED_GPIO(P, 1) (GPIO_ACTIVE_LOW | GPIO_OPEN_DRAIN)>;
+                     default-state = "off";
+             };

Missing blank line, everywhere.

Kelly: I've review our dts and add blank line or remove redundant blank lines.

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 157

Quoted 10 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +10 -0
+             status_Y {
+                     gpios = <&gpio1 ASPEED_GPIO(B, 1) GPIO_ACTIVE_LOW>;
+                     default-state = "off";
+             };
+             sys_boot_status {
+                     gpios = <&gpio1 ASPEED_GPIO(B, 0) GPIO_ACTIVE_LOW>;
+                     default-state = "off";
+             };
+     };
+     spigpio {

It does not look like you tested the DTS against bindings. Please run make dtbs_check W=1 (see Documentation/devicetree/bindings/writing-schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 157

Quoted 1 line
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +1 -0
+             status = "okay";

Why?

Kelly: I've removed spigpio and tested on our X4TF platform and it boots to the BMC console. I've resent our new patch.

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 169

Quoted 11 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +11 -0
+             compatible = "spi-gpio";
+             #address-cells = <1>;
+             #size-cells = <0>;
+
+             sck-gpios = <&gpio0 ASPEED_GPIO(Z, 3) GPIO_ACTIVE_HIGH>;
+             mosi-gpios = <&gpio0 ASPEED_GPIO(Z, 4) GPIO_ACTIVE_HIGH>;
+             miso-gpios = <&gpio0 ASPEED_GPIO(Z, 5) GPIO_ACTIVE_HIGH>;
+             num-chipselects = <1>;
+             cs-gpios = <&gpio0 ASPEED_GPIO(Z, 0) GPIO_ACTIVE_HIGH>;
+     };
+

Redundant blank line.

Kelly: I've review our dts and add blank line or remove redundant blank lines.

Quoted 22 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +22 -0
+};
+
+&adc0 {
+     vref = <2500>;
+     status = "okay";
+
+     pinctrl-names = "default";
+     pinctrl-0 = <&pinctrl_adc0_default &pinctrl_adc1_default
+             &pinctrl_adc2_default &pinctrl_adc3_default
+             &pinctrl_adc4_default &pinctrl_adc5_default
+             &pinctrl_adc6_default &pinctrl_adc7_default>; };
+
+&adc1 {
+     vref = <2500>;
+     status = "okay";
+
+     pinctrl-names = "default";
+     pinctrl-0 = <&pinctrl_adc8_default &pinctrl_adc9_default
+             &pinctrl_adc10_default &pinctrl_adc11_default
+             &pinctrl_adc12_default &pinctrl_adc13_default
+             &pinctrl_adc14_default &pinctrl_adc15_default>; };
+

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 203

Quoted 10 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +10 -0
+&peci0 {
+     status = "okay";
+};
+
+&lpc_snoop {
+     snoop-ports = <0x80>;
+     status = "okay";
+};
+
+

Redundant blank line. Clean this code before sending upstream from such trivialities.

Kelly: I've review our dts and add blank line or remove redundant blank lines.

Quoted 35 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +35 -0
+&mdio0 {
+     status = "disabled";
+};
+
+
+&mdio1 {
+     status = "disabled";
+};
+
+&mdio2 {
+     status = "okay";
+
+     ethphy2: ethernet-phy@0 {
+             compatible = "ethernet-phy-ieee802.3-c22";
+             reg = <0>;
+     };
+};
+
+&mdio3 {
+     status = "okay";
+
+     ethphy3: ethernet-phy@0 {
+             compatible = "ethernet-phy-ieee802.3-c22";
+             reg = <0>;
+     };
+};
+
+&mac0 {
+     status = "disabled";
+};
+
+&mac1 {
+     status = "disabled";
+};
+

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 249

Quoted 10 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +10 -0
+//for X4TF
+&mac2 {
+     status = "okay";
+     phy-mode = "rmii";
+     #phy-handle = <&ethphy2>;
+     use-ncsi;
+     pinctrl-names = "default";
+     pinctrl-0 = <&pinctrl_rmii3_default>; };
+
+

Ditto
Kelly: I've review our dts and add blank line or remove redundant blank lines.

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 259

Quoted 9 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +9 -0
+&mac3 {
+     status = "okay";
+     phy-mode = "rmii";
+     #phy-handle = <&ethphy3>;
+     use-ncsi;
+     pinctrl-names = "default";
+     pinctrl-0 = <&pinctrl_rmii4_default>; };
+
+

Ditto
Kelly: I've review our dts and add blank line or remove redundant blank lines.

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 261

Quoted 2 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +2 -0
+&syscon {
+     uart-clock-high-speed;

That's a syscon property?

It does not look like you tested the DTS against bindings. Please run make dtbs_check W=1 (see Documentation/devicetree/bindings/writing-schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).

Kelly: I've removed syscon and tested on our X4TF platform and it boots to the BMC console. I've resent our new patch.

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 272

Quoted 11 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +11 -0
+     status = "okay";
+};
+
+&rtc {
+     status = "disabled";
+};
+
+&fmc {
+     status = "okay";
+     flash@0 {
+             status = "okay";

Drop. Everywhere where it is not needed.

Kelly: I've adjusted fmc config and resent the patch.

Quoted 67 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +67 -0
+             m25p,fast-read;
+             label = "bmc-spi";
+             spi-max-frequency = <50000000>;
+             spi-bus-width = <1>;
+             partitions {
+                     compatible = "fixed-partitions";
+                     #address-cells = <1>;
+                     #size-cells = <1>;
+                     bmc@0 {
+                             label = "bmc";
+                             reg = <0x0 0x4000000>;
+                     };
+                     u-boot@0 {
+                             label = "u-boot";
+                             reg = <0x0 0x200000>;
+                     };
+                     u-boot-env@1f0000 {
+                             label = "u-boot-env";
+                             reg = <0x1f0000 0x10000>;
+                     };
+                     kernel@200000 {
+                             label = "kernel";
+                             reg = <0x200000 0xc00000>;
+                     };
+                     rofs@a00000 {
+                             label = "rofs";
+                             reg = <0xa00000 0x2a00000>;
+                     };
+                     rwfs@2a00000 {
+                             label = "rwfs";
+                             reg = <0x2a00000 0x43f0000>;
+                     };
+             };
+     };
+};
+
+&spi1 {
+     status = "okay";
+     pinctrl-names = "default";
+     pinctrl-0 = <&pinctrl_spi1_default>;
+
+     flash@0 {
+             status = "okay";
+             w25q256,fast-read;
+             label = "bios-spi";
+             spi-max-frequency = <50000000>;
+             partitions {
+                     compatible = "fixed-partitions";
+                     #address-cells = <1>;
+                     #size-cells = <1>;
+                     biosfullimg@0 {
+                             reg = <0x0 0x2000000>; //  32768 *1024 = 0x2000000, 32 MB
+                             label = "biosfullimg";
+                     };
+             };
+     };
+};
+
+&i2c0 {
+     status = "okay";
+};
+
+&i2c1 {
+     status = "okay";
+};
+
+&i2c2 {

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 349

Quoted 10 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +10 -0
+     status = "okay";
+};
+
+&i2c3 {
+     status = "okay";
+};
+
+&i2c4 {
+     status = "okay";
+     tmp75@48 {

Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 353

Quoted 4 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +4 -0
+             compatible = "ti,tmp75";
+             reg = <0x48>;
+     };
+     tmp75@49 {

Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

I am going to skip the rest. Please fix all the trivialities and test your patches with tools.

Kelly: I have renamed tmp75 as temperature-sensor.
I've checked our dts, removed unnecessary parts and run the DTS check script.

Best regards,
Krzysztof

<p></p>
===================================================================================================================================
This email and any attachments to it contain confidential information and are intended solely for the use of the individual to whom it is addressed. If you are not the intended recipient or receive it accidentally, please immediately notify the sender by e-mail and delete the message and any attachments from your computer system, and destroy all hard copies. Please be advised that any unauthorized disclosure, copying, distribution or any action taken or omitted in reliance on this, is illegal and prohibited. Any views or opinions expressed are solely those of the author and do not represent those of ASUSTeK.

For pricing information, ASUS is only entitled to set a recommendation resale price. All customers are free to set their own price as they wish.
===================================================================================================================================

#7 lore raw
In reply to Krzysztof Kozlowski

Hi, Krzysztof,
I use my Gmail account and response inline.
Thank you.

Best Regards
Kelly

Krzysztof Kozlowski <[email protected]> 於 2024年1月30日 週二 下午6:39寫道:

Quoted 45 lines · Kelly Hung
Quoted 10 lines

From: kelly1732000 <[email protected]>

This initial device-tree provides the necessary configuration for basic BMC functionality and work on ASUS X4TF production.

---
 .../boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts  | 828 ++++++++++++++++++
 1 file changed, 828 insertions(+)
 create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts

It's impossible to test this file. You miss Makefile.

I added the Makfile and re-sent the v5 patch on February 29, 2024.

Review

Quoted 2 lines
(quoted diff) +0 -0

b/arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts

Quoted 11 lines

new file mode 100644
index 000000000000..723bbb33137f

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +6 -0
@@ -0,0 +1,828 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+// Copyright 2023 ASUS Corp.
+/dts-v1/;
+
+#include "aspeed-g6.dtsi"
+#include <dt-bindings/gpio/aspeed-gpio.h>

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 16

Quoted 10 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +10 -0
+#include <dt-bindings/i2c/i2c.h>
+
+
+/ {
+     model = "ASUS-X4TF";
+     compatible = "asus,x4tf", "aspeed,ast2600";
+
+     chosen {
+             stdout-path = &uart5;
+             bootargs = "console=ttyS4,115200n8 earlycon";

earlycon is a debugging feature, not mainline. Also, move console to stdout-path, so entire bootargs can be dropped.

Quoted 1 line

I removed the bootargs and modified the stdouut-path and re-sent the v5

patch on Februarty 29, 2024.

Quoted 62 lines
Quoted 24 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +24 -0
+     };
+
+     memory@80000000 {
+             device_type = "memory";
+             reg = <0x80000000 0x40000000>;
+     };
+
+     reserved-memory {
+             #address-cells = <1>;
+             #size-cells = <1>;
+             ranges;
+
+             gfx_memory: framebuffer {
+                     size = <0x01000000>;
+                     alignment = <0x01000000>;
+                     compatible = "shared-dma-pool";
+                     reusable;
+             };
+
+             video_engine_memory: video {
+                     size = <0x04000000>;
+                     alignment = <0x01000000>;
+                     compatible = "shared-dma-pool";
+                     reusable;

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 50

Quoted 10 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +10 -0
+             };
+
+             rvas_memory: rvas {
+                     size = <0x04000000>;
+                     alignment = <0x01000000>;
+                     compatible = "shared-dma-pool";
+                     reusable;
+             };
+
+             bmc_dev_memory: bmc_dev_memory {

No underscores in node names. This applies everywhere.

I removed the bmc_dev_memory and re-sent the v5 patch.

Quoted 22 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +22 -0
+                     size = <0x00100000>;
+                     alignment = <0x00100000>;
+                     compatible = "shared-dma-pool";
+                     no-map;
+             };
+
+             pci_msi_memory: pci_msi_memory {
+                     no-map;
+                     reg = <0x9e770000 0x100>;
+                     compatible = "shared-dma-pool";
+             };
+             /* 1GB memory */
+             vga_memory: region@bf000000 {
+                     no-map;
+                     compatible = "shared-dma-pool";
+                     reg = <0xbf000000 0x01000000>;  /* 16M */
+             };
+             ssp_memory: ssp_memory {
+                     size = <0x02000000>;
+                     alignment = <0x01000000>;
+                     compatible = "shared-dma-pool";
+                     no-map;
Quoted 9 lines

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 78

Quoted 6 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +6 -0
+             };
+     };
+
+     vcc_sdhci0: regulator-vcc-sdhci0 {
+             compatible = "regulator-fixed";
+             status = "disabled";

Why? It makes it entirely pointless.

I removed the vcc_sdhci0 and re-send the v5 pathch.

Quoted 46 lines

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 88

Quoted 11 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +10 -0
+             regulator-name = "SDHCI0 Vcc";
+             regulator-min-microvolt = <3300000>;
+             regulator-max-microvolt = <3300000>;
+             gpios = <&gpio0 ASPEED_GPIO(V, 0) GPIO_ACTIVE_HIGH>;
+             enable-active-high;
+     };
+
+     vccq_sdhci0: regulator-vccq-sdhci0 {
+             compatible = "regulator-gpio";
+             status = "disabled";

Pointless node.

I removed the vccq_sdhci0 and re-send the v5 patch.

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 100

Quoted 12 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +12 -0
+             regulator-name = "SDHCI0 VccQ";
+             regulator-min-microvolt = <1800000>;
+             regulator-max-microvolt = <3300000>;
+             gpios = <&gpio0 ASPEED_GPIO(V, 1) GPIO_ACTIVE_HIGH>;
+             gpios-states = <1>;
+             states = <3300000 1>,
+                      <1800000 0>;
+     };
+
+     vcc_sdhci1: regulator-vcc-sdhci1 {
+             compatible = "regulator-fixed";
+             status = "disabled";

Pointless node.

I removed the vcc_sdhci1 and re-send the v5 patch.

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 110

Quoted 10 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +10 -0
+             regulator-name = "SDHCI1 Vcc";
+             regulator-min-microvolt = <3300000>;
+             regulator-max-microvolt = <3300000>;
+             gpios = <&gpio0 ASPEED_GPIO(V, 2) GPIO_ACTIVE_HIGH>;
+             enable-active-high;
+     };
+
+     vccq_sdhci1: regulator-vccq-sdhci1 {
+             compatible = "regulator-gpio";
+             status = "disabled";
Quoted 2 lines

Pointless node.

I removed the vccq_sdhci1 and re-send the v5 patch.

Quoted 11 lines

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 118

Quoted 8 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +8 -0
+             regulator-name = "SDHCI1 VccQ";
+             regulator-min-microvolt = <1800000>;
+             regulator-max-microvolt = <3300000>;
+             gpios = <&gpio0 ASPEED_GPIO(V, 3) GPIO_ACTIVE_HIGH>;
+             gpios-states = <1>;
+             states = <3300000 1>,
+                      <1800000 0>;
+     };

Missing blank line.

For the blank line issue, I've corrected them all and re-sent the v5 patch.

Quoted 11 lines

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts

Quoted 8 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +8 -0
+     iio-hwmon {
+             compatible = "iio-hwmon";
+             io-channels = <&adc0 0>, <&adc0 1>, <&adc0 2>, <&adc0 3>,
+                             <&adc0 4>, <&adc0 5>, <&adc0 6>, <&adc0 7>,
+                             <&adc1 0>, <&adc1 1>, <&adc1 2>, <&adc1 3>,
+                             <&adc1 4>, <&adc1 5>, <&adc1 6>, <&adc1 7>;
+     };
+> +  video-engine@1e700000 {

Wrong placement. Also tools would tell you that.

I removed the video-engine.

Quoted 30 lines

It does not look like you tested the DTS against bindings. Please run make dtbs_check W=1 (see Documentation/devicetree/bindings/writing-schema.rst or

https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts

Quoted 3 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +3 -0
+             compatible = "aspeed,ast2600-video-engine";
+             reg = <0x1e700000 0x20000>;
+             clocks = <&syscon ASPEED_CLK_GATE_VCLK>, <&syscon

ASPEED_CLK_GATE_ECLK>;

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 134

Quoted 4 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +4 -0
+             clock-names = "vclk", "eclk";
+             interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
+             memory-region = <&video_engine_memory>;
+             //resets = <&syscon ASPEED_RESET_VIDEO>;

Dead code.

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 140

Quoted 6 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +6 -0
+     };
+
+     leds {
+             compatible = "gpio-leds";
+
+             heartbeat {

It does not look like you tested the DTS against bindings. Please run make dtbs_check W=1 (see Documentation/devicetree/bindings/writing-schema.rst or

Quoted 3 lines

https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).

I've used the dts schema to check our dts.

Quoted 13 lines

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 144

Quoted 5 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +4 -0
+                     gpios = <&gpio0 ASPEED_GPIO(P, 7) GPIO_ACTIVE_LOW>;
+                     linux,default-trigger = "heartbeat";
+             };
+             uid_led {

It does not look like you tested the DTS against bindings. Please run make dtbs_check W=1 (see Documentation/devicetree/bindings/writing-schema.rst or

https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).

Quoted 7 lines

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 144

Quoted 1 line
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +1 -0
+                     gpios = <&gpio0 ASPEED_GPIO(P, 1) (GPIO_ACTIVE_LOW

| GPIO_OPEN_DRAIN)>;

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 146

Quoted 2 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +2 -0
+                     default-state = "off";
+             };

Missing blank line, everywhere.

For the blank line issue, I've corrected them all and re-sent the v5 patch.

Quoted 27 lines

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 157

Quoted 11 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +10 -0
+             status_Y {
+                     gpios = <&gpio1 ASPEED_GPIO(B, 1) GPIO_ACTIVE_LOW>;
+                     default-state = "off";
+             };
+             sys_boot_status {
+                     gpios = <&gpio1 ASPEED_GPIO(B, 0) GPIO_ACTIVE_LOW>;
+                     default-state = "off";
+             };
+     };
+     spigpio {

It does not look like you tested the DTS against bindings. Please run make dtbs_check W=1 (see Documentation/devicetree/bindings/writing-schema.rst or

https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).

I've used the dts schema to check our dts.

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 157

Quoted 1 line
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +1 -0
+             status = "okay";

Why?

Quoted 14 lines

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 169

Quoted 11 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +11 -0
+             compatible = "spi-gpio";
+             #address-cells = <1>;
+             #size-cells = <0>;
+
+             sck-gpios = <&gpio0 ASPEED_GPIO(Z, 3) GPIO_ACTIVE_HIGH>;
+             mosi-gpios = <&gpio0 ASPEED_GPIO(Z, 4) GPIO_ACTIVE_HIGH>;
+             miso-gpios = <&gpio0 ASPEED_GPIO(Z, 5) GPIO_ACTIVE_HIGH>;
+             num-chipselects = <1>;
+             cs-gpios = <&gpio0 ASPEED_GPIO(Z, 0) GPIO_ACTIVE_HIGH>;
+     };
+

Redundant blank line.

For the blank line issue, I've corrected them all and re-sent the v5 patch.

Quoted 30 lines
Quoted 30 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +29 -0
+};
+
+&adc0 {
+     vref = <2500>;
+     status = "okay";
+
+     pinctrl-names = "default";
+     pinctrl-0 = <&pinctrl_adc0_default &pinctrl_adc1_default
+             &pinctrl_adc2_default &pinctrl_adc3_default
+             &pinctrl_adc4_default &pinctrl_adc5_default
+             &pinctrl_adc6_default &pinctrl_adc7_default>;
+};
+
+&adc1 {
+     vref = <2500>;
+     status = "okay";
+
+     pinctrl-names = "default";
+     pinctrl-0 = <&pinctrl_adc8_default &pinctrl_adc9_default
+             &pinctrl_adc10_default &pinctrl_adc11_default
+             &pinctrl_adc12_default &pinctrl_adc13_default
+             &pinctrl_adc14_default &pinctrl_adc15_default>;
+};
+
+&peci0 {
+     status = "okay";
+};
+
+&lpc_snoop {
Quoted 9 lines

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 203

Quoted 5 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +5 -0
+     snoop-ports = <0x80>;
+     status = "okay";
+};
+
+

Redundant blank line. Clean this code before sending upstream from such trivialities.

For the blank line issue, I've corrected them all and re-sent the v5 patch.

Quoted 50 lines
Quoted 37 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +36 -0
+&mdio0 {
+     status = "disabled";
+};
+
+
+&mdio1 {
+     status = "disabled";
+};
+
+&mdio2 {
+     status = "okay";
+
+     ethphy2: ethernet-phy@0 {
+             compatible = "ethernet-phy-ieee802.3-c22";
+             reg = <0>;
+     };
+};
+
+&mdio3 {
+     status = "okay";
+
+     ethphy3: ethernet-phy@0 {
+             compatible = "ethernet-phy-ieee802.3-c22";
+             reg = <0>;
+     };
+};
+
+&mac0 {
+     status = "disabled";
+};
+
+&mac1 {
+     status = "disabled";
+};
+
+//for X4TF

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 249

Quoted 10 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +10 -0
+&mac2 {
+     status = "okay";
+     phy-mode = "rmii";
+     #phy-handle = <&ethphy2>;
+     use-ncsi;
+     pinctrl-names = "default";
+     pinctrl-0 = <&pinctrl_rmii3_default>;
+};
+
+

Ditto

Quoted 1 line

For the blank line issue, I've corrected them all and re-sent the v5

patch.

Quoted 4 lines
Quoted 4 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +4 -0
+&mac3 {
+     status = "okay";
+     phy-mode = "rmii";
+     #phy-handle = <&ethphy3>;
Quoted 9 lines

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 259

Quoted 6 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +6 -0
+     use-ncsi;
+     pinctrl-names = "default";
+     pinctrl-0 = <&pinctrl_rmii4_default>;
+};
+
+

Ditto

For the blank line issue, I've corrected them all and re-sent the v5 patch.

Quoted 124 lines

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 261

Quoted 3 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +2 -0
+&syscon {
+     uart-clock-high-speed;

That's a syscon property?

It does not look like you tested the DTS against bindings. Please run make dtbs_check W=1 (see Documentation/devicetree/bindings/writing-schema.rst or

https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 272

Quoted 11 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +11 -0
+     status = "okay";
+};
+
+&rtc {
+     status = "disabled";
+};
+
+&fmc {
+     status = "okay";
+     flash@0 {
+             status = "okay";

Drop. Everywhere where it is not needed.

I have corrected the related flash configuration and re-send the v5 patch.

Quoted 42 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +42 -0
+             m25p,fast-read;
+             label = "bmc-spi";
+             spi-max-frequency = <50000000>;
+             spi-bus-width = <1>;
+             partitions {
+                     compatible = "fixed-partitions";
+                     #address-cells = <1>;
+                     #size-cells = <1>;
+                     bmc@0 {
+                             label = "bmc";
+                             reg = <0x0 0x4000000>;
+                     };
+                     u-boot@0 {
+                             label = "u-boot";
+                             reg = <0x0 0x200000>;
+                     };
+                     u-boot-env@1f0000 {
+                             label = "u-boot-env";
+                             reg = <0x1f0000 0x10000>;
+                     };
+                     kernel@200000 {
+                             label = "kernel";
+                             reg = <0x200000 0xc00000>;
+                     };
+                     rofs@a00000 {
+                             label = "rofs";
+                             reg = <0xa00000 0x2a00000>;
+                     };
+                     rwfs@2a00000 {
+                             label = "rwfs";
+                             reg = <0x2a00000 0x43f0000>;
+                     };
+             };
+     };
+};
+
+&spi1 {
+     status = "okay";
+     pinctrl-names = "default";
+     pinctrl-0 = <&pinctrl_spi1_default>;
+
+     flash@0 {

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts

Quoted 10 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +10 -0
+             status = "okay";
+             w25q256,fast-read;
+             label = "bios-spi";
+             spi-max-frequency = <50000000>;
+             partitions {
+                     compatible = "fixed-partitions";
+                     #address-cells = <1>;
+                     #size-cells = <1>;
+                     biosfullimg@0 {
+                             reg = <0x0 0x2000000>; //  32768 *1024 =

0x2000000, 32 MB

Quoted 15 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +15 -0
+                             label = "biosfullimg";
+                     };
+             };
+     };
+};
+
+&i2c0 {
+     status = "okay";
+};
+
+&i2c1 {
+     status = "okay";
+};
+
+&i2c2 {

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 349

Quoted 10 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +10 -0
+     status = "okay";
+};
+
+&i2c3 {
+     status = "okay";
+};
+
+&i2c4 {
+     status = "okay";
+     tmp75@48 {

Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification:

https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

I've used the dts schema to check our dts.

arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts line 353

Quoted 4 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-asus-x4tf.dts new file +4 -0
+             compatible = "ti,tmp75";
+             reg = <0x48>;
+     };
+     tmp75@49 {
Quoted 6 lines

Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification:

https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

I've used the dts schema to check our dts.

Quoted 7 lines

I am going to skip the rest. Please fix all the trivialities and test your patches with tools.

Best regards,
Krzysztof

#9 lore raw

Hi, Krzysztof,
I'll use the full name in future patches.
Thanks for reminding.

Best Regards
Kelly

-----Original Message-----
From: Krzysztof Kozlowski <[email protected]>
Sent: Tuesday, January 30, 2024 6:40 PM
To: Kelly Hung <[email protected]>; [email protected]
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; Kelly Hung(洪嘉莉) <[email protected]>
Subject: Re: [PATCH] ARM: dts: aspeed: asus: Add ASUS X4TF BMC

External email : Ensure your email is secure before opening links and attachments.

Quoted 6 lines · Kelly Hung

From: kelly1732000 <[email protected]>

This initial device-tree provides the necessary configuration for basic BMC functionality and work on ASUS X4TF production.

Please use full name.

Best regards,
Krzysztof

<p></p>
===================================================================================================================================
This email and any attachments to it contain confidential information and are intended solely for the use of the individual to whom it is addressed. If you are not the intended recipient or receive it accidentally, please immediately notify the sender by e-mail and delete the message and any attachments from your computer system, and destroy all hard copies. Please be advised that any unauthorized disclosure, copying, distribution or any action taken or omitted in reliance on this, is illegal and prohibited. Any views or opinions expressed are solely those of the author and do not represent those of ASUSTeK.

For pricing information, ASUS is only entitled to set a recommendation resale price. All customers are free to set their own price as they wish.
===================================================================================================================================

#10 lore raw
In reply to Kelly Hung
Quoted 4 lines · Kelly Hung

This initial device-tree provides the necessary configuration for basic BMC functionality and work on ASUS X4TF production.

Please use subject prefixes matching the subsystem. You can get them for example with git log --oneline -- DIRECTORY_OR_FILE on the directory your patch is touching.

Best regards,
Krzysztof

#11 lore raw

Hi, Krzysztof,
Thanks for reminding. I've finished and corrected my theme prefix.

Best Regards
Kelly
-----Original Message-----
From: Krzysztof Kozlowski <[email protected]>
Sent: Tuesday, January 30, 2024 6:35 PM
To: Kelly Hung <[email protected]>; [email protected]
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; Kelly Hung(洪嘉莉) <[email protected]>
Subject: Re: [PATCH] ARM: dts: aspeed: asus: Add ASUS X4TF BMC

External email : Ensure your email is secure before opening links and attachments.

Quoted 4 lines · Kelly Hung

This initial device-tree provides the necessary configuration for basic BMC functionality and work on ASUS X4TF production.

Please use subject prefixes matching the subsystem. You can get them for example with git log --oneline -- DIRECTORY_OR_FILE on the directory your patch is touching.

Best regards,
Krzysztof

<p></p>
===================================================================================================================================
This email and any attachments to it contain confidential information and are intended solely for the use of the individual to whom it is addressed. If you are not the intended recipient or receive it accidentally, please immediately notify the sender by e-mail and delete the message and any attachments from your computer system, and destroy all hard copies. Please be advised that any unauthorized disclosure, copying, distribution or any action taken or omitted in reliance on this, is illegal and prohibited. Any views or opinions expressed are solely those of the author and do not represent those of ASUSTeK.

For pricing information, ASUS is only entitled to set a recommendation resale price. All customers are free to set their own price as they wish.
===================================================================================================================================

#12 lore raw
In reply to Krzysztof Kozlowski

Krzysztof Kozlowski <[email protected]> 於 2024年1月30日 週二 下午6:35寫道:

Quoted 11 lines · Kelly Hung
Quoted 4 lines

This initial device-tree provides the necessary configuration for basic BMC functionality and work on ASUS X4TF production.

Please use subject prefixes matching the subsystem. You can get them for example with git log --oneline -- DIRECTORY_OR_FILE on the directory your patch is touching.

Hi, Krzysztof,

I use my Gmail account and respond inline.
Yes, I used git log --oneline -- DIRECTORY_OR_FILE and re-sent the v5 patch on February 29, 2024.
[PATCH v5 1/2] dt-bindings: arm: aspeed: add ASUS X4TF board

Quoted 4 lines

Best regards,
Krzysztof