Skip to contentSkip to conversation

dts: ast2600: add x4tf dts for asus product

PATCH In review Kelly Hung 3 participants 4 messages Jan 30, 2024 – Feb 1, 2024 Arm (32-bit)

lore
Share & tools
lore

Kelly Hung

author
#0 lore raw

PATCH 1/1 dts: ast2600: add x4tf dts for asus product

This initial device-tree provides the necessary configuration for basic BMC functionality and work on ASUS X4TF production.

---
 arch/arm/dts/Makefile         |   3 +-
 arch/arm/dts/ast2600-x4tf.dts | 239 ++++++++++++++++++++++++++++++++++
 2 files changed, 241 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm/dts/ast2600-x4tf.dts
arch/arm/dts/Makefile +2 -1
index 37675a32..6d4a6ed0 100755
@@ -698,7 +698,8 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
 	ast2600-slt.dtb \
 	ast2600-tacoma.dtb \
 	ast2600-intel.dtb \
-	ast2600-tacoma.dtb
+	ast2600-tacoma.dtb \
+	ast2600-x4tf.dtb
 
 dtb-$(CONFIG_ARCH_STI) += stih410-b2260.dtb
 
arch/arm/dts/ast2600-x4tf.dts new file +239 -0

239 lines not on this page · raw message

Signature · 1 line
2.25.1
#1 lore raw
Quoted 7 lines · Kelly Hung

This initial device-tree provides the necessary configuration for basic BMC functionality and work on ASUS X4TF production.

---
 arch/arm/dts/Makefile         |   3 +-
 arch/arm/dts/ast2600-x4tf.dts | 239 ++++++++++++++++++++++++++++++++++

[snip]

Quoted 6 lines
arch/arm/dts/ast2600-x4tf.dts new file +0 -0
new file mode 100644
index 00000000..3c478058

arch/arm/dts/ast2600-x4tf.dts line 9

Quoted 9 lines
arch/arm/dts/ast2600-x4tf.dts new file +9 -0
@@ -0,0 +1,239 @@
+// SPDX-License-Identifier: GPL-2.0+
+// Copyright 2020 IBM Corp.
+/dts-v1/;
+
+#include "ast2600-u-boot.dtsi"
+
+/ {
+	model = "AST2600 ASUS";
+	compatible = "aspeed,ast2600-evb", "aspeed,ast2600";

Compatible should be board unique.

arch/arm/dts/ast2600-x4tf.dts line 11

Quoted 2 lines
arch/arm/dts/ast2600-x4tf.dts new file +2 -0
+&uart5 {
+	u-boot,dm-pre-reloc;

All of these are bootph* now.

And is there effort being made to upstream the dts files for these platforms to Linux?

Signature · 1 line
Tom
#2 lore raw

Hi, Tom,

Review

Quoted 2 lines
(quoted diff) +2 -0
+     model = "AST2600 ASUS";
+     compatible = "aspeed,ast2600-asus", "aspeed,ast2600";

I do a modification, replace "asus2600-evb" with "ast2600-asus".

All of these are bootph* now.

And is there effort being made to upstream the dts files for these platforms to Linux?

Yes, I also git send-email to kernel related persons to add a asus dts in kernel device tree.

Thans for review.

Best Regards
Kelly

-----Original Message-----
From: Tom Rini <[email protected]>
Sent: Tuesday, January 30, 2024 11:09 PM
To: Kelly Hung <[email protected]>
Cc: [email protected]; [email protected]; Kelly Hung(洪嘉莉) <[email protected]>
Subject: Re: [PATCH] dts: ast2600: add x4tf dts for asus product

Quoted 8 lines · Kelly Hung

This initial device-tree provides the necessary configuration for basic BMC functionality and work on ASUS X4TF production.

---
 arch/arm/dts/Makefile         |   3 +-
 arch/arm/dts/ast2600-x4tf.dts | 239

++++++++++++++++++++++++++++++++++

[snip]

Quoted 6 lines
(quoted diff) +0 -0

b/arch/arm/dts/ast2600-x4tf.dts new file mode 100644 index 00000000..3c478058

arch/arm/dts/ast2600-x4tf.dts line 9

Quoted 9 lines
arch/arm/dts/ast2600-x4tf.dts new file +9 -0
@@ -0,0 +1,239 @@
+// SPDX-License-Identifier: GPL-2.0+
+// Copyright 2020 IBM Corp.
+/dts-v1/;
+
+#include "ast2600-u-boot.dtsi"
+
+/ {
+     model = "AST2600 ASUS";
+     compatible = "aspeed,ast2600-evb", "aspeed,ast2600";

Compatible should be board unique.

arch/arm/dts/ast2600-x4tf.dts line 11

Quoted 2 lines
arch/arm/dts/ast2600-x4tf.dts new file +2 -0
+&uart5 {
+     u-boot,dm-pre-reloc;

All of these are bootph* now.

And is there effort being made to upstream the dts files for these platforms to Linux?

--
Tom
===================================================================================================================================
This email and any attachments to it contain confidential information and are intended solely for the use of the individual to whom it is addressed. If you are not the intended recipient or receive it accidentally, please immediately notify the sender by e-mail and delete the message and any attachments from your computer system, and destroy all hard copies. Please be advised that any unauthorized disclosure, copying, distribution or any action taken or omitted in reliance on this, is illegal and prohibited. Any views or opinions expressed are solely those of the author and do not represent those of ASUSTeK.

For pricing information, ASUS is only entitled to set a recommendation resale price. All customers are free to set their own price as they wish.
===================================================================================================================================

#3 lore raw

Hi, Tom,

Q:

Review

Quoted 2 lines
(quoted diff) +2 -0
+     model = "AST2600 ASUS";
+     compatible = "aspeed,ast2600-asus", "aspeed,ast2600";

A: I do a modification, replace "ast2600-evb" with "ast2600-asus".

Q: All of these are bootph* now.

And is there effort being made to upstream the dts files for these platforms to Linux?

A: Yes, I also git send-email to kernel related persons to add a asus dts in kernel device tree.

My typo, I would like to correct it.

Review line 2

Quoted 3 lines
(quoted diff) +2 -0
@@ -0,0 +1,239 @@
+// SPDX-License-Identifier: GPL-2.0+
+// Copyright 2023 ASUS Corp.

Thans for review.

Best Regards
Kelly

-----Original Message-----
From: Tom Rini <[email protected]>
Sent: Tuesday, January 30, 2024 11:09 PM
To: Kelly Hung <[email protected]>
Cc: [email protected]; [email protected]; Kelly Hung(洪嘉莉) <[email protected]>
Subject: Re: [PATCH] dts: ast2600: add x4tf dts for asus product

Quoted 8 lines · Kelly Hung

This initial device-tree provides the necessary configuration for basic BMC functionality and work on ASUS X4TF production.

---
 arch/arm/dts/Makefile         |   3 +-
 arch/arm/dts/ast2600-x4tf.dts | 239

++++++++++++++++++++++++++++++++++

[snip]

Quoted 6 lines
(quoted diff) +0 -0

b/arch/arm/dts/ast2600-x4tf.dts new file mode 100644 index 00000000..3c478058

arch/arm/dts/ast2600-x4tf.dts line 9

Quoted 9 lines
arch/arm/dts/ast2600-x4tf.dts new file +9 -0
@@ -0,0 +1,239 @@
+// SPDX-License-Identifier: GPL-2.0+
+// Copyright 2020 IBM Corp.
+/dts-v1/;
+
+#include "ast2600-u-boot.dtsi"
+
+/ {
+     model = "AST2600 ASUS";
+     compatible = "aspeed,ast2600-evb", "aspeed,ast2600";

Compatible should be board unique.

arch/arm/dts/ast2600-x4tf.dts line 11

Quoted 2 lines
arch/arm/dts/ast2600-x4tf.dts new file +2 -0
+&uart5 {
+     u-boot,dm-pre-reloc;

All of these are bootph* now.

And is there effort being made to upstream the dts files for these platforms to Linux?

--
Tom
===================================================================================================================================
This email and any attachments to it contain confidential information and are intended solely for the use of the individual to whom it is addressed. If you are not the intended recipient or receive it accidentally, please immediately notify the sender by e-mail and delete the message and any attachments from your computer system, and destroy all hard copies. Please be advised that any unauthorized disclosure, copying, distribution or any action taken or omitted in reliance on this, is illegal and prohibited. Any views or opinions expressed are solely those of the author and do not represent those of ASUSTeK.

For pricing information, ASUS is only entitled to set a recommendation resale price. All customers are free to set their own price as they wish.
===================================================================================================================================