Skip to contentSkip to conversation

imx9: clock: Fix board_interface_eth_init for FEC

PATCH Applied Primoz Fiser 3 participants 3 messages Jan 30, 2024 – Feb 8, 2024

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 imx9: clock: Fix board_interface_eth_init for FEC

Commit d5eae216d833 ("net: dwc_eth_qos: Add board_interface_eth_init() for i.MX93") implemented board_interface_eth_init for i.MX9 platforms. However it only accounted for the EQOS interface while any board using FEC as primary Ethernet interface was left out as return value -EINVAL is always returned from the function in such case.

Fix this by returning 0 (success) when FEC interface is primarily used instead of EQOS interface on i.MX93.

Fixes d5eae216d833 ("net: dwc_eth_qos: Add board_interface_eth_init() for i.MX93")
---
 arch/arm/mach-imx/imx9/clock.c | 5 +++++
 1 file changed, 5 insertions(+)
arch/arm/mach-imx/imx9/clock.c +5 -0
index 92c41e9a67bf..75d92af036a1 100644
@@ -882,6 +882,11 @@ int board_interface_eth_init(struct udevice *dev, phy_interface_t interface_type
 	    device_is_compatible(dev, "nxp,imx93-dwmac-eqos"))
 		return imx93_eqos_interface_init(dev, interface_type);
 
+	if (IS_ENABLED(CONFIG_IMX93) &&
+	    IS_ENABLED(CONFIG_FEC_MXC) &&
+	    device_is_compatible(dev, "fsl,imx93-fec"))
+		return 0;
+
 	return -EINVAL;
 }
 
Signature · 1 line
2.25.1
reviewer Applied
#2 lore raw
In reply to Primoz Fiser
Quoted 7 lines · Primoz Fiser

Commit d5eae216d833 ("net: dwc_eth_qos: Add board_interface_eth_init() for i.MX93") implemented board_interface_eth_init for i.MX9 platforms. However it only accounted for the EQOS interface while any board using FEC as primary Ethernet interface was left out as return value -EINVAL is always returned from the function in such case.

Quoted 5 lines

Fix this by returning 0 (success) when FEC interface is primarily used instead of EQOS interface on i.MX93.

Fixes d5eae216d833 ("net: dwc_eth_qos: Add board_interface_eth_init() for i.MX93")

Applied, thanks.