Skip to contentSkip to conversation

perf report: Prevent segfault with --no-parent

PATCH Applied Andi Kleen 2 participants 3 messages Jan 30, 2024 – Feb 2, 2024 perf events

lore
Share & tools
lore

Andi Kleen

author
#0 lore raw

PATCH 1/1 perf report: Prevent segfault with --no-parent

Prevent a perf report segfault with the (non sensical) --no-parent option

---
 tools/perf/util/sort.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/util/sort.c +1 -1
index 30254eb63709..92a1bd695e8a 100644
@@ -3372,7 +3372,7 @@ int sort_dimension__add(struct perf_hpp_list *list, const char *tok,
 				sort_dimension_add_dynamic_header(sd);
 		}
 
-		if (sd->entry == &sort_parent) {
+		if (sd->entry == &sort_parent && parent_pattern) {
 			int ret = regcomp(&parent_regex, parent_pattern, REG_EXTENDED);
 			if (ret) {
 				char err[BUFSIZ];
Signature · 1 line
2.43.0
maintainer Acked-by on v1 1/1
#1 lore raw

Hi Andi,

Quoted 5 lines · Andi Kleen

Prevent a perf report segfault with the (non sensical) --no-parent option

Thanks,
Namhyung

Quoted 21 lines
---
 tools/perf/util/sort.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/util/sort.c +1 -2
index 30254eb63709..92a1bd695e8a 100644
@@ -3372,7 +3372,7 @@ int sort_dimension__add(struct perf_hpp_list *list, const char *tok,
                                sort_dimension_add_dynamic_header(sd);
                }
 
-               if (sd->entry == &sort_parent) {
+               if (sd->entry == &sort_parent && parent_pattern) {
                        int ret = regcomp(&parent_regex, parent_pattern, REG_EXTENDED);
                        if (ret) {
                                char err[BUFSIZ];
--

2.43.0