Skip to contentSkip to conversation

nvme-common: add module description

PATCH Superseded Chaitanya Kulkarni 3 participants 3 messages Jan 31, 2024 NVMe

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nvme-common: add module description

Add MODULE_DESCRIPTION() in order to remove warnings & get clean build:-

WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/common/nvme-auth.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/common/nvme-keyring.o

---
 drivers/nvme/common/auth.c    | 1 +
 drivers/nvme/common/keyring.c | 1 +
 2 files changed, 2 insertions(+)
drivers/nvme/common/auth.c +1 -0
index a23ab5c968b9..b707e6b7d263 100644
@@ -471,4 +471,5 @@ int nvme_auth_generate_key(u8 *secret, struct nvme_dhchap_key **ret_key)
 }
 EXPORT_SYMBOL_GPL(nvme_auth_generate_key);
 
+MODULE_DESCRIPTION("NVMe Authentication framework");
 MODULE_LICENSE("GPL v2");
drivers/nvme/common/keyring.c +1 -0
index a5c0431c101c..394c3948e339 100644
@@ -181,5 +181,6 @@ static void __exit nvme_keyring_exit(void)
 
 MODULE_LICENSE("GPL v2");
 MODULE_AUTHOR("Hannes Reinecke <[email protected]>");
+MODULE_DESCRIPTION("NVMe TLS Keyring implementation");
 module_init(nvme_keyring_init);
 module_exit(nvme_keyring_exit);
Signature · 1 line
2.40.0
maintainer Reviewed-by on v1 1/1
#2 lore raw
In reply to Chaitanya Kulkarni
Quoted 27 lines

Add MODULE_DESCRIPTION() in order to remove warnings & get clean build:-

WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/common/nvme-auth.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvme/common/nvme-keyring.o

---
  drivers/nvme/common/auth.c    | 1 +
  drivers/nvme/common/keyring.c | 1 +
  2 files changed, 2 insertions(+)
drivers/nvme/common/auth.c +1 -0
index a23ab5c968b9..b707e6b7d263 100644
@@ -471,4 +471,5 @@ int nvme_auth_generate_key(u8 *secret, struct nvme_dhchap_key **ret_key)
  }
  EXPORT_SYMBOL_GPL(nvme_auth_generate_key);
 
+MODULE_DESCRIPTION("NVMe Authentication framework");
  MODULE_LICENSE("GPL v2");
drivers/nvme/common/keyring.c +0 -0
index a5c0431c101c..394c3948e339 100644

drivers/nvme/common/keyring.c static void __exit nvme_keyring_exit(void) · line 184

Quoted 4 lines
drivers/nvme/common/keyring.c +1 -0
@@ -181,5 +181,6 @@ static void __exit nvme_keyring_exit(void)
 
  MODULE_LICENSE("GPL v2");
  MODULE_AUTHOR("Hannes Reinecke <[email protected]>");
+MODULE_DESCRIPTION("NVMe TLS Keyring implementation");

iirc, I think Hannes had an intention to make the inband auth implementation to use nvme keyring as well. So I'd omit TLS from the description.

Other than that,