lib/intel_device_info: set has_flatccs on LNL
PATCH 1/3 lib/intel_device_info: set has_flatccs on LNL
Xe2 supports flat CCS based compression, including igpu. Currently HAS_FLATCCS() is incorrectly returning false on LNL.
--- lib/intel_device_info.c | 1 + 1 file changed, 1 insertion(+)
lib/intel_device_info.c +1 -0
@@ -509,6 +509,7 @@ static const struct intel_device_info intel_lunarlake_info = { .graphics_rel = 4, .display_ver = 20, .has_4tile = true, + .has_flatccs = true, .is_lunarlake = true, .codename = "lunarlake", .cmds_info = &xe2_cmds_info,
Signature · 1 line
2.43.0
PATCH 2/3 tests/intel/xe_ccs: require flat CCS on xe2
On Xe2 compression is handled via PAT indexes and flat CCS, even on igpu. Ensure the device has flat CCS support on such hardware, to determine if these tests are valid.
--- tests/intel/xe_ccs.c | 2 ++ 1 file changed, 2 insertions(+)
tests/intel/xe_ccs.c +2 -0
@@ -653,6 +653,8 @@ igt_main_args("bf:pst:W:H:", NULL, help_str, opt_handler, NULL) igt_fixture { xe =drm_open_driver (DRIVER_XE );igt_require (blt_has_block_copy (xe)); +if (AT_LEAST_GEN (xe,20 )) +igt_require (HAS_FLATCCS (xe));xe_device_get (xe);
Signature · 1 line
2.43.0
Re: [PATCH i-g-t 2/3] tests/intel/xe_ccs: require flat CCS on xe2
Quoted 16 lines · Matthew Auld
On Xe2 compression is handled via PAT indexes and flat CCS, even on igpu. Ensure the device has flat CCS support on such hardware, to determine if these tests are valid.
Signed-off-by Matthew Auld <[email protected]>Cc Akshata Jahagirdar <[email protected]>Cc Zbigniew Kempczyński <[email protected]>--- tests/intel/xe_ccs.c | 2 ++ 1 file changed, 2 insertions(+)tests/intel/xe_ccs.c +0
-0
tests/intel/xe_ccs.c igt_main_args("bf:pst:W:H:", NULL, help_str, opt_handler, NULL) · line 657
Quoted 5 lines
tests/intel/xe_ccs.c +2
-0@@ -653,6 +653,8 @@ igt_main_args("bf:pst:W:H:", NULL, help_str, opt_handler, NULL) igt_fixture { xe =drm_open_driver (DRIVER_XE );igt_require (blt_has_block_copy (xe)); +if (AT_LEAST_GEN (xe,20 )) +igt_require (HAS_FLATCCS (xe));
We have block-copy-uncompressed which doesn't require flatccs. I included this in xe_ccs.c to avoid duplicating the test code. Shouldn't above check be in compressed subtests?
--
Zbigniew
Quoted 6 lines
tests/intel/xe_ccs.c +0
-0xe_device_get (xe);Signature · 1 line
2.43.0
Re: [PATCH i-g-t 2/3] tests/intel/xe_ccs: require flat CCS on xe2
Quoted 12 lines · Zbigniew Kempczyński
Quoted 11 lines · Matthew Auld
On Xe2 compression is handled via PAT indexes and flat CCS, even on igpu. Ensure the device has flat CCS support on such hardware, to determine if these tests are valid.
Signed-off-by Matthew Auld <[email protected]>Cc Akshata Jahagirdar <[email protected]>Cc Zbigniew Kempczyński <[email protected]>--- tests/intel/xe_ccs.c | 2 ++ 1 file changed, 2 insertions(+)
Quoted 14 lines
tests/intel/xe_ccs.c igt_main_args("bf:pst:W:H:", NULL, help_str, opt_handler, NULL) · line 657
Quoted 10 lines
tests/intel/xe_ccs.c +2
-0@@ -653,6 +653,8 @@ igt_main_args("bf:pst:W:H:", NULL, help_str, opt_handler, NULL) igt_fixture { xe =drm_open_driver (DRIVER_XE );igt_require (blt_has_block_copy (xe)); +if (AT_LEAST_GEN (xe,20 )) +igt_require (HAS_FLATCCS (xe));We have block-copy-uncompressed which doesn't require flatccs. I included this in
xe_ccs.cto avoid duplicating the test code. Shouldn't above check be in compressed subtests?
Yes, I think that makes sense. I didn't look closely enough here.
Quoted 10 lines
--
ZbigniewQuoted 6 lines
tests/intel/xe_ccs.c +0
-0xe_device_get (xe);Signature · 1 line
2.43.0
PATCH 3/3 tests/intel/xe_pat: assert flat CSS support for xe2
In reply to Matthew AuldXe2+ should support flat CCS compression, and here we are using compressed PAT index modes. Assert the platform indeed has flat CCS here, otherwise something is likely wrong.
--- tests/intel/xe_pat.c | 1 + 1 file changed, 1 insertion(+)
tests/intel/xe_pat.c +1 -0
@@ -1049,6 +1049,7 @@ igt_main_args("V", NULL, help_str, opt_handler, NULL) igt_subtest_with_dynamic("pat-index-xe2") {igt_require (intel_get_device_info (dev_id)->graphics_ver >=20 ); +igt_assert (HAS_FLATCCS (dev_id));subtest_pat_index_modes_with_regions (fd, xe2_pat_index_modes,ARRAY_SIZE (xe2_pat_index_modes)); }
Signature · 1 line
2.43.0
Re: [PATCH i-g-t 3/3] tests/intel/xe_pat: assert flat CSS support for xe2
Quoted 26 lines · Matthew Auld
Xe2+ should support flat CCS compression, and here we are using compressed PAT index modes. Assert the platform indeed has flat CCS here, otherwise something is likely wrong.
Signed-off-by Matthew Auld <[email protected]>Cc Akshata Jahagirdar <[email protected]>Cc Zbigniew Kempczyński <[email protected]>--- tests/intel/xe_pat.c | 1 + 1 file changed, 1 insertion(+)tests/intel/xe_pat.c +1
-0@@ -1049,6 +1049,7 @@ igt_main_args("V", NULL, help_str, opt_handler, NULL) igt_subtest_with_dynamic("pat-index-xe2") {igt_require (intel_get_device_info (dev_id)->graphics_ver >=20 ); +igt_assert (HAS_FLATCCS (dev_id));subtest_pat_index_modes_with_regions (fd, xe2_pat_index_modes,ARRAY_SIZE (xe2_pat_index_modes)); }Signature · 1 line
2.43.0
--
Zbigniew
Patchwork
CI✓ CI.xeBAT: success for series starting with [i-g-t,1/3] lib/intel_device_info: set has_flatccs on LNL
In reply to Matthew Auld== Series Details ==
== Series Details ==
Series: series starting with [i-g-t,1/3] lib/intel_device_info: set has_flatccs on LNL
URL : https://patchwork.freedesktop.org/series/129366/
State : success
== Summary ==
CI Bug Log - changes from XEIGT_7699_BAT -> XEIGTPW_10611_BAT
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (4 -> 3)
------------------------------
Missing (1): bat-pvc-2
Changes
-------
No changes found
Build changes
-------------
* IGT: IGT_7699 -> IGTPW_10611
* Linux: xe-699-c655e0fd28045dbaa581d04bf7cc266eec1c3457 -> xe-705-3d244fce99b65e012c4409d8a22bb9168c41f101
IGTPW_10611: 10611
IGT_7699: 7699
xe-699-c655e0fd28045dbaa581d04bf7cc266eec1c3457: c655e0fd28045dbaa581d04bf7cc266eec1c3457 xe-705-3d244fce99b65e012c4409d8a22bb9168c41f101: 3d244fce99b65e012c4409d8a22bb9168c41f101
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10611/index.html
Quoted 25 lines · Matthew Auld
Xe2 supports flat CCS based compression, including igpu. Currently
HAS_FLATCCS()is incorrectly returning false on LNL.Signed-off-by Matthew Auld <[email protected]>Cc Akshata Jahagirdar <[email protected]>Cc Zbigniew Kempczyński <[email protected]>--- lib/intel_device_info.c | 1 + 1 file changed, 1 insertion(+)lib/intel_device_info.c +1
-0@@ -509,6 +509,7 @@ static const struct intel_device_info intel_lunarlake_info = { .graphics_rel = 4, .display_ver = 20, .has_4tile = true, + .has_flatccs = true, .is_lunarlake = true, .codename = "lunarlake", .cmds_info = &xe2_cmds_info,Signature · 1 line
2.43.0
--
Zbigniew
Patchwork
CI✓ Fi.CI.BAT: success for series starting with [i-g-t,1/3] lib/intel_device_info: set has_flatccs on LNL
In reply to Matthew Auld== Series Details ==
== Series Details ==
Series: series starting with [i-g-t,1/3] lib/intel_device_info: set has_flatccs on LNL
URL : https://patchwork.freedesktop.org/series/129366/
State : success
== Summary ==
CI Bug Log - changes from IGT_7699 -> IGTPW_10611
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10611/index.html
Participating hosts (38 -> 33)
------------------------------
Missing (5): bat-kbl-2 fi-bsw-n3050 fi-tgl-1115g4 fi-snb-2520m bat-mtlp-8
Known issues
------------
Here are the changes found in IGTPW_10611 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@debugfs_test@basic-hwmon:
- bat-jsl-1: NOTRUN -> [SKIP][1] ([i915#9318])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10611/bat-jsl-1/igt@[email protected]
* igt@gem_huc_copy@huc-copy:
- bat-jsl-1: NOTRUN -> [SKIP][2] ([i915#2190])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10611/bat-jsl-1/igt@[email protected]
* igt@gem_lmem_swapping@verify-random:
- bat-jsl-1: NOTRUN -> [SKIP][3] ([i915#4613]) +3 other tests skip
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10611/bat-jsl-1/igt@[email protected]
* igt@i915_hangman@error-state-basic:
- bat-mtlp-6: [PASS][4] -> [ABORT][5] ([i915#9414])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7699/bat-mtlp-6/igt@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10611/bat-mtlp-6/igt@[email protected]
* igt@i915_selftest@live@sanitycheck:
- fi-kbl-7567u: [PASS][6] -> [DMESG-WARN][7] ([i915#9730]) +36 other tests dmesg-warn
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7699/fi-kbl-7567u/igt@i915_selftest@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10611/fi-kbl-7567u/igt@i915_selftest@[email protected]
* igt@kms_addfb_basic@invalid-set-prop:
- fi-kbl-7567u: [PASS][8] -> [DMESG-WARN][9] ([i915#8585]) +41 other tests dmesg-warn
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7699/fi-kbl-7567u/igt@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10611/fi-kbl-7567u/igt@[email protected]
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- bat-jsl-1: NOTRUN -> [SKIP][10] ([i915#4103]) +1 other test skip
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10611/bat-jsl-1/igt@[email protected]
* igt@kms_dsc@dsc-basic:
- bat-jsl-1: NOTRUN -> [SKIP][11] ([i915#3555] / [i915#9886])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10611/bat-jsl-1/igt@[email protected]
* igt@kms_force_connector_basic@force-load-detect:
- bat-jsl-1: NOTRUN -> [SKIP][12] ([fdo#109285])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10611/bat-jsl-1/igt@[email protected]
* igt@kms_pm_rpm@basic-pci-d3-state:
- fi-kbl-7567u: [PASS][13] -> [DMESG-WARN][14] ([i915#180] / [i915#8585]) +45 other tests dmesg-warn
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7699/fi-kbl-7567u/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10611/fi-kbl-7567u/igt@[email protected]
* igt@kms_setmode@basic-clone-single-crtc:
- bat-jsl-1: NOTRUN -> [SKIP][15] ([i915#3555])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10611/bat-jsl-1/igt@[email protected]
#### Possible fixes ####
* igt@gem_tiled_blits@basic:
- fi-pnv-d510: [SKIP][16] ([fdo#109271]) -> [PASS][17] +2 other tests pass
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7699/fi-pnv-d510/igt@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10611/fi-pnv-d510/igt@[email protected]
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#8585]: https://gitlab.freedesktop.org/drm/intel/issues/8585
[i915#9318]: https://gitlab.freedesktop.org/drm/intel/issues/9318
[i915#9414]: https://gitlab.freedesktop.org/drm/intel/issues/9414
[i915#9730]: https://gitlab.freedesktop.org/drm/intel/issues/9730
[i915#9886]: https://gitlab.freedesktop.org/drm/intel/issues/9886
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7699 -> IGTPW_10611
CI-20190529: 20190529
CI_DRM_14193: c655e0fd28045dbaa581d04bf7cc266eec1c3457 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_10611: 10611
IGT_7699: 7699
Testlist changes
----------------
-igt@xe_ccs@block-copy-compressed-inc-dimension
-igt@xe_ccs@block-copy-uncompressed-inc-dimension
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10611/index.html