Skip to contentSkip to conversation

libmultipath: hwtable: fix fast_io_fail for Infinibox

PATCH In review Martin Wilck 2 participants 3 messages Jan 31, 2024 – Feb 14, 2024 Device mapper

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libmultipath: hwtable: fix fast_io_fail for Infinibox

The Infinibox hwtable entry had fast_io_fail and dev_loss both set to 15, which has the effect that fast_io_fail is switched off (dev_loss timeout must be higher than fast_io_fail timeout).

Remove the dev_loss value, which will cause the default of 600 to be used. Experience shows that dev_loss_tmo values below a few minutes are seldom helpful.

Fixes 55da608 ("libmultipath: update INFINIDAT builtin config")
Cc Arnon Yaari <[email protected]>
Cc Xose Vazquez Perez <[email protected]>
Cc Tom Abraham <[email protected]>
Cc Jiri Belka <[email protected]>
---
 libmultipath/hwtable.c | 1 -
 1 file changed, 1 deletion(-)
libmultipath/hwtable.c +0 -1
index 808af54..9ef3e45 100644
@@ -1161,7 +1161,6 @@ static struct hwentry default_hw[] = {
 		.minio_rq      = 1,
 		.flush_on_last_del = FLUSH_ENABLED,
 		.fast_io_fail  = 15,
-		.dev_loss      = 15,
 	},
 	/*
 	 * Kaminario
Signature · 1 line
2.43.0
#1 lore raw

Gentle review reminder.

Quoted 34 lines · Martin Wilck

The Infinibox hwtable entry had fast_io_fail and dev_loss both set to 15,
which has the effect that fast_io_fail is switched off (dev_loss timeout
must be higher than fast_io_fail timeout).

Remove the dev_loss value, which will cause the default of 600 to be used.
Experience shows that dev_loss_tmo values below a few minutes are seldom
helpful.

Fixes 55da608 ("libmultipath: update INFINIDAT builtin config")
Cc Arnon Yaari <[email protected]>
Cc Xose Vazquez Perez <[email protected]>
Cc Tom Abraham <[email protected]>
Cc Jiri Belka <[email protected]>

---
 libmultipath/hwtable.c | 1 -

 1 file changed, 1 deletion(-)
libmultipath/hwtable.c +0 -1
index 808af54..9ef3e45 100644
@@ -1161,7 +1161,6 @@ static struct hwentry default_hw[] = {
  		.minio_rq      = 1,
  		.flush_on_last_del = FLUSH_ENABLED,
  		.fast_io_fail  = 15,
-		.dev_loss      = 15,
  	},
  	/*
  	 * Kaminario
maintainer Reviewed-by
#2 lore raw
Quoted 18 lines · Martin Wilck

Gentle review reminder.

Quoted 15 lines · Martin Wilck

The Infinibox hwtable entry had fast_io_fail and dev_loss both set to 15,
which has the effect that fast_io_fail is switched off (dev_loss timeout
must be higher than fast_io_fail timeout).

Remove the dev_loss value, which will cause the default of 600 to be used.
Experience shows that dev_loss_tmo values below a few minutes are seldom
helpful.

Fixes 55da608 ("libmultipath: update INFINIDAT builtin config")
Cc Arnon Yaari <[email protected]>
Quoted 19 lines
Quoted 19 lines
Cc Xose Vazquez Perez <[email protected]>
Cc Tom Abraham <[email protected]>
Cc Jiri Belka <[email protected]>

---
 libmultipath/hwtable.c | 1 -

 1 file changed, 1 deletion(-)
libmultipath/hwtable.c +0 -1
index 808af54..9ef3e45 100644
@@ -1161,7 +1161,6 @@ static struct hwentry default_hw[] = {
  		.minio_rq      = 1,
  		.flush_on_last_del = FLUSH_ENABLED,
  		.fast_io_fail  = 15,
-		.dev_loss      = 15,
  	},
  	/*
  	 * Kaminario