Skip to contentSkip to conversation

linux-next: build warning after merge of the tip tree

DISCUSSION Stephen Rothwell 3 participants 4 messages Feb 1, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Hi all,

After merging the tip tree, today's linux-next build (x86_64 allmodconfig) produced this warning:

vmlinux.o: warning: objtool: fred_extint+0x1c: call to array_index_mask_nospec.constprop.0() leaves .noinstr.text section

Probably introduced by commit

6786137bf8fd ("x86/fred: FRED entry/exit and dispatch code")

Signature · 2 lines
Cheers,
Stephen Rothwell
#1 lore raw
Quoted 11 lines · Stephen Rothwell

Hi all,

After merging the tip tree, today's linux-next build (x86_64 allmodconfig) produced this warning:

vmlinux.o: warning: objtool: fred_extint+0x1c: call to array_index_mask_nospec.constprop.0() leaves .noinstr.text section

Probably introduced by commit

   6786137bf8fd ("x86/fred: FRED entry/exit and dispatch code")

Thanks for reporting, I will take care of it.
Xin

#2 lore raw
In reply to Stephen Rothwell
Quoted 11 lines · Stephen Rothwell

Hi all,

After merging the tip tree, today's linux-next build (x86_64 allmodconfig) produced this warning:

vmlinux.o: warning: objtool: fred_extint+0x1c: call to array_index_mask_nospec.constprop.0() leaves .noinstr.text section

Probably introduced by commit

   6786137bf8fd ("x86/fred: FRED entry/exit and dispatch code")

The following patch gets rid of the warning.

Boris, should I send a format patch?

Thanks!
Xin

arch/x86/include/asm/barrier.h +1 -1
index 0216f63a366b..fe1e7e3cc844 100644
@@ -33,7 +33,7 @@
  * Returns:
  *     0 - (index < size)
  */
-static inline unsigned long array_index_mask_nospec(unsigned long index,
+static __always_inline unsigned long array_index_mask_nospec(unsigned long index,
 		unsigned long size)
 {
 	unsigned long mask;
maintainer
#3 lore raw
Quoted 3 lines · Xin Li

The following patch gets rid of the warning.

Boris, should I send a format patch?

This is how kernel development is usually done. People send formal patches and maintainers apply them.

:-)

Make sure you explain why you're fixing it.

Thx.

Signature · 4 lines
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette