Skip to contentSkip to conversation

lib/rendercopy_gen9: Fix Xe2 missing pixels on non-modulo-16 surfaces

PATCH Superseded Zbigniew Kempczyński 3 participants 4 messages Feb 1, 2024 Library code

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lib/rendercopy_gen9: Fix Xe2 missing pixels on non-modulo-16 surfaces

Missing setting Kernel0Enable bit results in lack of rasterization of right and bottom part of the surface. Fix this as kms tests depends on that.

---
 lib/rendercopy_gen9.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/rendercopy_gen9.c +1 -1
index bdfd9be087..a63d5320b3 100644
@@ -863,7 +863,7 @@ gen8_emit_ps(struct intel_bb *ibb, uint32_t kernel, bool fast_clear) {
 	intel_bb_out(ibb, 0);
 
 	intel_bb_out(ibb, GEN7_3DSTATE_PS | (12-2));
-	intel_bb_out(ibb, kernel);
+	intel_bb_out(ibb, kernel | 1);
 	intel_bb_out(ibb, 0); /* kernel hi */
 
 	if (fast_clear)
Signature · 1 line
2.34.1
Tested-by on v1 1/1
#1 lore raw
Quoted 4 lines · Zbigniew Kempczyński

Missing setting Kernel0Enable bit results in lack of rasterization of right and bottom part of the surface. Fix this as kms tests depends
on that.

Seems to fix the problem with missing pixels on non-modulo-16 surfaces:

Quoted 21 lines

---
 lib/rendercopy_gen9.c | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
lib/rendercopy_gen9.c +0 -0
index bdfd9be087..a63d5320b3 100644
@@ -863,7 +863,7 @@ gen8_emit_ps(struct intel_bb *ibb, uint32_t
 kernel, bool fast_clear) {
         intel_bb_out(ibb, 0);


        intel_bb_out(ibb, GEN7_3DSTATE_PS | (12-2)); -       intel_bb_out(ibb, kernel);
+       intel_bb_out(ibb, kernel | 1); intel_bb_out(ibb, 0); /* kernel hi */
        if (fast_clear)

#2 lore raw

✗ Fi.CI.BAT: failure for lib/rendercopy_gen9: Fix Xe2 missing pixels on non-modulo-16 surfaces

In reply to Zbigniew Kempczyński
== Series Details ==

== Series Details ==

Series: lib/rendercopy_gen9: Fix Xe2 missing pixels on non-modulo-16 surfaces
URL : https://patchwork.freedesktop.org/series/129417/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_14209 -> IGTPW_10624
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_10624 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes
introduced in IGTPW_10624, please notify your bug team ([email protected]) to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10624/index.html

Participating hosts (39 -> 38)
------------------------------

Additional (1): fi-pnv-d510
Missing (2): fi-snb-2520m fi-bsw-n3050

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_10624:

### IGT changes ###

#### Possible regressions ####

* igt@i915_selftest@live@gt_heartbeat:
- fi-glk-j4005: [PASS][1] -> [ABORT][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14209/fi-glk-j4005/igt@i915_selftest@live@gt_heartbeat.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10624/fi-glk-j4005/igt@i915_selftest@live@gt_heartbeat.html

#### Warnings ####

* igt@core_hotunplug@unbind-rebind:
- fi-apl-guc: [DMESG-WARN][3] ([i915#180] / [i915#8585]) -> [INCOMPLETE][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14209/fi-apl-guc/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10624/fi-apl-guc/igt@[email protected]

#### Suppressed ####

The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.

* igt@prime_vgem@basic-fence-flip:
- {bat-arls-2}: [PASS][5] -> [FAIL][6] +2 other tests fail
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14209/bat-arls-2/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10624/bat-arls-2/igt@[email protected]

* igt@prime_vgem@basic-fence-mmap:
- {bat-arls-2}: [SKIP][7] ([i915#10196]) -> [FAIL][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14209/bat-arls-2/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10624/bat-arls-2/igt@[email protected]

* igt@prime_vgem@basic-fence-read:
- {bat-arls-2}: [SKIP][9] ([i915#10212]) -> [FAIL][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14209/bat-arls-2/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10624/bat-arls-2/igt@[email protected]

Known issues
------------

Here are the changes found in IGTPW_10624 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_lmem_swapping@basic:
- fi-pnv-d510: NOTRUN -> [SKIP][11] ([fdo#109271]) +31 other tests skip
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10624/fi-pnv-d510/igt@[email protected]

#### Possible fixes ####

* igt@i915_selftest@live@hangcheck:
- bat-adlp-9: [ABORT][12] ([i915#10021]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14209/bat-adlp-9/igt@i915_selftest@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10624/bat-adlp-9/igt@i915_selftest@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#10021]: https://gitlab.freedesktop.org/drm/intel/issues/10021
[i915#10196]: https://gitlab.freedesktop.org/drm/intel/issues/10196
[i915#10197]: https://gitlab.freedesktop.org/drm/intel/issues/10197
[i915#10211]: https://gitlab.freedesktop.org/drm/intel/issues/10211
[i915#10212]: https://gitlab.freedesktop.org/drm/intel/issues/10212
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#8585]: https://gitlab.freedesktop.org/drm/intel/issues/8585

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_7700 -> IGTPW_10624

CI-20190529: 20190529
CI_DRM_14209: 3e58a4940c44430f20cad20ead5e1b77ed209cde @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_10624: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10624/index.html
IGT_7700: 7700

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10624/index.html

#3 lore raw

✓ CI.xeBAT: success for lib/rendercopy_gen9: Fix Xe2 missing pixels on non-modulo-16 surfaces

In reply to Zbigniew Kempczyński
== Series Details ==

== Series Details ==

Series: lib/rendercopy_gen9: Fix Xe2 missing pixels on non-modulo-16 surfaces
URL : https://patchwork.freedesktop.org/series/129417/
State : success

== Summary ==

CI Bug Log - changes from XEIGT_7700_BAT -> XEIGTPW_10624_BAT
====================================================

Summary
-------

**SUCCESS**

No regressions found.

Participating hosts (4 -> 4)
------------------------------

No changes in participating hosts

Known issues
------------

Here are the changes found in XEIGTPW_10624_BAT that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@kms_flip@basic-flip-vs-wf_vblank:
- bat-dg2-oem2: [PASS][1] -> [FAIL][2] ([Intel XE#480]) +1 other test fail
[1]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7700/bat-dg2-oem2/igt@kms_flip@basic-flip-vs-wf_vblank.html
[2]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10624/bat-dg2-oem2/igt@kms_flip@basic-flip-vs-wf_vblank.html

[Intel XE#480]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/480

Build changes
-------------

* IGT: IGT_7700 -> IGTPW_10624
* Linux: xe-712-cba66c6a2af4df1b9b420fbad0a9ac1e68f14030 -> xe-715-3e58a4940c44430f20cad20ead5e1b77ed209cde

IGTPW_10624: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10624/index.html
IGT_7700: 7700
xe-712-cba66c6a2af4df1b9b420fbad0a9ac1e68f14030: cba66c6a2af4df1b9b420fbad0a9ac1e68f14030 xe-715-3e58a4940c44430f20cad20ead5e1b77ed209cde: 3e58a4940c44430f20cad20ead5e1b77ed209cde

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10624/index.html