Skip to contentSkip to conversation

wifi: wilc1000: remove setting msg.spi

PATCH In review David Lechner 2 participants 2 messages Feb 1, 2024 – Feb 5, 2024 Microchip WILC1000 wifi driver

lore
Share & tools
lore

David Lechner

author
#0 lore raw

PATCH v2 1/1 wifi: wilc1000: remove setting msg.spi

Calling spi_sync() unconditionally sets the spi field of struct spi_message. Therefore setting msg.spi = spi before calling spi_sync() has no effect and can be removed.

(spi_message_add_tail() does not access this field.)

Signed-off-by David Lechner <[email protected]>

---

v2 changes:
* fixed incomplete commit message

Link to v1: https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

 drivers/net/wireless/microchip/wilc1000/spi.c | 4 ----
 1 file changed, 4 deletions(-)
drivers/net/wireless/microchip/wilc1000/spi.c +0 -4
index 77b4cdff73c3..7eb0f8a421a3 100644
@@ -300,7 +300,6 @@ static int wilc_spi_tx(struct wilc *wilc, u8 *b, u32 len)
 
 		memset(&msg, 0, sizeof(msg));
 		spi_message_init(&msg);
-		msg.spi = spi;
 		spi_message_add_tail(&tr, &msg);
 
 		ret = spi_sync(spi, &msg);

@@ -343,7 +342,6 @@ static int wilc_spi_rx(struct wilc *wilc, u8 *rb, u32 rlen)
 
 		memset(&msg, 0, sizeof(msg));
 		spi_message_init(&msg);
-		msg.spi = spi;
 		spi_message_add_tail(&tr, &msg);
 
 		ret = spi_sync(spi, &msg);

@@ -381,8 +379,6 @@ static int wilc_spi_tx_rx(struct wilc *wilc, u8 *wb, u8 *rb, u32 rlen)
 
 		memset(&msg, 0, sizeof(msg));
 		spi_message_init(&msg);
-		msg.spi = spi;
-
 		spi_message_add_tail(&tr, &msg);
 		ret = spi_sync(spi, &msg);
 		if (ret < 0)
Signature · 1 line
2.43.0
#1 lore raw
Quoted 7 lines · David Lechner

Calling spi_sync() unconditionally sets the spi field of struct spi_message. Therefore setting msg.spi = spi before calling spi_sync() has no effect and can be removed.

(spi_message_add_tail() does not access this field.)

Signed-off-by David Lechner <[email protected]>

Patch applied to wireless-next.git, thanks.

bed41a344426 wifi: wilc1000: remove setting msg.spi

Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches