Skip to contentSkip to conversation

RDMA/rxe: Remove unused 'iova' parameter from rxe_mr_init_user

PATCH Applied Guoqing Jiang 3 participants 3 messages Feb 2, 2024 – Feb 4, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 RDMA/rxe: Remove unused 'iova' parameter from rxe_mr_init_user

This one is not needed since commit 954afc5a8fd8 ("RDMA/rxe:
Use members of generic struct in rxe_mr").

---
v2 changes:
1. add relevant change in rxe_reg_user_mr, thanks for Yanjun's reminder

 drivers/infiniband/sw/rxe/rxe_loc.h   | 2 +-
 drivers/infiniband/sw/rxe/rxe_mr.c    | 2 +-
 drivers/infiniband/sw/rxe/rxe_verbs.c | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
drivers/infiniband/sw/rxe/rxe_loc.h +1 -1
index 4d2a8ef52c85..746110898a0e 100644
@@ -59,7 +59,7 @@ int rxe_mmap(struct ib_ucontext *context, struct vm_area_struct *vma);
 /* rxe_mr.c */
 u8 rxe_get_next_key(u32 last_key);
 void rxe_mr_init_dma(int access, struct rxe_mr *mr);
-int rxe_mr_init_user(struct rxe_dev *rxe, u64 start, u64 length, u64 iova,
+int rxe_mr_init_user(struct rxe_dev *rxe, u64 start, u64 length,
 		     int access, struct rxe_mr *mr);
 int rxe_mr_init_fast(int max_pages, struct rxe_mr *mr);
 int rxe_flush_pmem_iova(struct rxe_mr *mr, u64 iova, unsigned int length);
drivers/infiniband/sw/rxe/rxe_mr.c +1 -1
index bc81fde696ee..da3dee520876 100644
@@ -126,7 +126,7 @@ static int rxe_mr_fill_pages_from_sgt(struct rxe_mr *mr, struct sg_table *sgt)
 	return xas_error(&xas);
 }
 
-int rxe_mr_init_user(struct rxe_dev *rxe, u64 start, u64 length, u64 iova,
+int rxe_mr_init_user(struct rxe_dev *rxe, u64 start, u64 length,
 		     int access, struct rxe_mr *mr)
 {
 	struct ib_umem *umem;
drivers/infiniband/sw/rxe/rxe_verbs.c +1 -1
index f0a03b910702..614581989b38 100644
@@ -1278,7 +1278,7 @@ static struct ib_mr *rxe_reg_user_mr(struct ib_pd *ibpd, u64 start,
 	mr->ibmr.pd = ibpd;
 	mr->ibmr.device = ibpd->device;
 
-	err = rxe_mr_init_user(rxe, start, length, iova, access, mr);
+	err = rxe_mr_init_user(rxe, start, length, access, mr);
 	if (err) {
 		rxe_dbg_mr(mr, "reg_user_mr failed, err = %d\n", err);
 		goto err_cleanup;
Signature · 1 line
2.35.3
Reviewed-by on v2 1/1
#1 lore raw
Quoted 4 lines · Guoqing Jiang

This one is not needed since commit 954afc5a8fd8 ("RDMA/rxe:
Use members of generic struct in rxe_mr").

Thanks,
Zhu Yanjun

Quoted 48 lines

---
v2 changes:
1. add relevant change in rxe_reg_user_mr, thanks for Yanjun's reminder

  drivers/infiniband/sw/rxe/rxe_loc.h   | 2 +-
  drivers/infiniband/sw/rxe/rxe_mr.c    | 2 +-
  drivers/infiniband/sw/rxe/rxe_verbs.c | 2 +-
  3 files changed, 3 insertions(+), 3 deletions(-)
drivers/infiniband/sw/rxe/rxe_loc.h +1 -1
index 4d2a8ef52c85..746110898a0e 100644
@@ -59,7 +59,7 @@ int rxe_mmap(struct ib_ucontext *context, struct vm_area_struct *vma);
  /* rxe_mr.c */
  u8 rxe_get_next_key(u32 last_key);
  void rxe_mr_init_dma(int access, struct rxe_mr *mr);
-int rxe_mr_init_user(struct rxe_dev *rxe, u64 start, u64 length, u64 iova,
+int rxe_mr_init_user(struct rxe_dev *rxe, u64 start, u64 length,
  		     int access, struct rxe_mr *mr);
  int rxe_mr_init_fast(int max_pages, struct rxe_mr *mr);
  int rxe_flush_pmem_iova(struct rxe_mr *mr, u64 iova, unsigned int length);
drivers/infiniband/sw/rxe/rxe_mr.c +1 -1
index bc81fde696ee..da3dee520876 100644
@@ -126,7 +126,7 @@ static int rxe_mr_fill_pages_from_sgt(struct rxe_mr *mr, struct sg_table *sgt)
  	return xas_error(&xas);
  }
 
-int rxe_mr_init_user(struct rxe_dev *rxe, u64 start, u64 length, u64 iova,
+int rxe_mr_init_user(struct rxe_dev *rxe, u64 start, u64 length,
  		     int access, struct rxe_mr *mr)
  {
  	struct ib_umem *umem;
drivers/infiniband/sw/rxe/rxe_verbs.c +1 -1
index f0a03b910702..614581989b38 100644
@@ -1278,7 +1278,7 @@ static struct ib_mr *rxe_reg_user_mr(struct ib_pd *ibpd, u64 start,
  	mr->ibmr.pd = ibpd;
  	mr->ibmr.device = ibpd->device;
 
-	err = rxe_mr_init_user(rxe, start, length, iova, access, mr);
+	err = rxe_mr_init_user(rxe, start, length, access, mr);
  	if (err) {
  		rxe_dbg_mr(mr, "reg_user_mr failed, err = %d\n", err);
  		goto err_cleanup;