Skip to contentSkip to conversation

imx_v6_v7_defconfig: Enable sm3, sm4, polyval, xctr cipher test support

PATCH In review Kshitiz Varshney 4 participants 6 messages Dec 20, 2023 – Feb 5, 2024

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 imx_v6_v7_defconfig: Enable sm3, sm4, polyval, xctr cipher test support

Enable config for sm3, sm4, polyval, xctr cipher test as built in module.

Issue:-
Multiple crypto tests like sm3, sm4 xctr and polyval failing.

skcipher: failed to allocate transform for xctr(aes): -2
alg: self-tests for xctr(aes) using xctr(aes) failed (rc=-2)
alg: self-tests for sm3 using sm3 failed (rc=-2)
tcrypt: failed to load transform for sm3: -2
alg: hash: failed to allocate transform for polyval: -2
alg: self-tests for polyval using polyval failed (rc=-2)

Resolution:-
Enabling CONFIG_CRYPTO_SM3_GENERIC, CONFIG_CRYPTO_SM4_GENERIC, CONFIG_CRYPTO_HCTR2, CONFIG_CRYPTO_ARIA as module enables support of sm3, sm4, aria, polyval & xctr.

---
 arch/arm/configs/imx_v6_v7_defconfig | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/configs/imx_v6_v7_defconfig +4 -0
index 0a90583f9f01..627f57da9d5b 100644
@@ -484,3 +484,7 @@ CONFIG_DEBUG_FS=y
 # CONFIG_SLUB_DEBUG is not set
 # CONFIG_SCHED_DEBUG is not set
 # CONFIG_FTRACE is not set
+CONFIG_CRYPTO_HCTR2=m
+CONFIG_CRYPTO_SM3_GENERIC=m
+CONFIG_CRYPTO_SM4_GENERIC=m
+CONFIG_CRYPTO_ARIA=m
Signature · 1 line
2.25.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 55 lines

-----Original Message-----
From: Kshitiz Varshney <[email protected]>
Sent: Wednesday, December 20, 2023 5:09 PM
To: Herbert Xu <[email protected]>; Shawn Guo <[email protected]>; Sascha Hauer <[email protected]>; Fabio Estevam <[email protected]>; dl-linux-imx <[email protected]>; Pengutronix Kernel Team <[email protected]>; Varun Sethi <[email protected]>; Gaurav Jain <[email protected]>; Pankaj Gupta <[email protected]>; Sahil Malhotra <[email protected]>; Vabhav Sharma <[email protected]>; Meenakshi Aggarwal <[email protected]>; Rahul Kumar Yadav <[email protected]>; Nikhil Singla <[email protected]>
Cc: [email protected]; [email protected]; Kshitiz Varshney <[email protected]>
Subject: [PATCH v1] imx_v6_v7_defconfig: Enable sm3, sm4, polyval, xctr cipher test support

Enable config for sm3, sm4, polyval, xctr cipher test as built in module.

Issue:-
Multiple crypto tests like sm3, sm4 xctr and polyval failing.

skcipher: failed to allocate transform for xctr(aes): -2
alg: self-tests for xctr(aes) using xctr(aes) failed (rc=-2)
alg: self-tests for sm3 using sm3 failed (rc=-2)
tcrypt: failed to load transform for sm3: -2
alg: hash: failed to allocate transform for polyval: -2
alg: self-tests for polyval using polyval failed (rc=-2)

Resolution:-
Enabling CONFIG_CRYPTO_SM3_GENERIC, CONFIG_CRYPTO_SM4_GENERIC, CONFIG_CRYPTO_HCTR2, CONFIG_CRYPTO_ARIA as module enables support
of
sm3, sm4, aria, polyval & xctr.

---
 arch/arm/configs/imx_v6_v7_defconfig | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/configs/imx_v6_v7_defconfig +4 -1
index 0a90583f9f01..627f57da9d5b 100644
@@ -484,3 +484,7 @@ CONFIG_DEBUG_FS=y
 # CONFIG_SLUB_DEBUG is not set
 # CONFIG_SCHED_DEBUG is not set
 # CONFIG_FTRACE is not set
+CONFIG_CRYPTO_HCTR2=m
+CONFIG_CRYPTO_SM3_GENERIC=m
+CONFIG_CRYPTO_SM4_GENERIC=m
+CONFIG_CRYPTO_ARIA=m
--

2.25.1

#2 lore raw
In reply to Kshitiz Varshney

Hi Herbert,

Gentle Reminder.
Please help to merge the patch.

Regards,
Kshitiz

Quoted 56 lines

-----Original Message-----
From: Kshitiz Varshney <[email protected]>
Sent: Wednesday, December 20, 2023 5:09 PM
To: Herbert Xu <[email protected]>; Shawn Guo <[email protected]>; Sascha Hauer <[email protected]>; Fabio Estevam <[email protected]>; dl-linux-imx <[email protected]>; Pengutronix Kernel Team <[email protected]>; Varun Sethi <[email protected]>; Gaurav Jain <[email protected]>; Pankaj Gupta <[email protected]>; Sahil Malhotra <[email protected]>; Vabhav Sharma <[email protected]>; Meenakshi Aggarwal <[email protected]>; Rahul Kumar Yadav <[email protected]>; Nikhil Singla <[email protected]>
Cc: [email protected]; [email protected]; Kshitiz Varshney <[email protected]>
Subject: [PATCH v1] imx_v6_v7_defconfig: Enable sm3, sm4, polyval, xctr cipher test support

Enable config for sm3, sm4, polyval, xctr cipher test as built in module.

Issue:-
Multiple crypto tests like sm3, sm4 xctr and polyval failing.

skcipher: failed to allocate transform for xctr(aes): -2
alg: self-tests for xctr(aes) using xctr(aes) failed (rc=-2)
alg: self-tests for sm3 using sm3 failed (rc=-2)
tcrypt: failed to load transform for sm3: -2
alg: hash: failed to allocate transform for polyval: -2
alg: self-tests for polyval using polyval failed (rc=-2)

Resolution:-
Enabling CONFIG_CRYPTO_SM3_GENERIC,
CONFIG_CRYPTO_SM4_GENERIC,
CONFIG_CRYPTO_HCTR2, CONFIG_CRYPTO_ARIA as module enables
support of
sm3, sm4, aria, polyval & xctr.

---
 arch/arm/configs/imx_v6_v7_defconfig | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/configs/imx_v6_v7_defconfig +4 -1
index 0a90583f9f01..627f57da9d5b 100644
@@ -484,3 +484,7 @@ CONFIG_DEBUG_FS=y
 # CONFIG_SLUB_DEBUG is not set
 # CONFIG_SCHED_DEBUG is not set
 # CONFIG_FTRACE is not set
+CONFIG_CRYPTO_HCTR2=m
+CONFIG_CRYPTO_SM3_GENERIC=m
+CONFIG_CRYPTO_SM4_GENERIC=m
+CONFIG_CRYPTO_ARIA=m
--

2.25.1

reviewer
#3 lore raw
Quoted 5 lines · Kshitiz Varshney

Hi Herbert,

Gentle Reminder.
Please help to merge the patch.

This patch goes to Shawn's tree, not Herbert's.

We are currently in the merge window, so this change will likely be applied after 6.8-rc1 is out.

#4 lore raw
In reply to Kshitiz Varshney
Quoted 12 lines · Kshitiz Varshney

Enable config for sm3, sm4, polyval, xctr cipher test as built in module.

Issue:-
Multiple crypto tests like sm3, sm4 xctr and polyval failing.

skcipher: failed to allocate transform for xctr(aes): -2
alg: self-tests for xctr(aes) using xctr(aes) failed (rc=-2)
alg: self-tests for sm3 using sm3 failed (rc=-2)
tcrypt: failed to load transform for sm3: -2
alg: hash: failed to allocate transform for polyval: -2
alg: self-tests for polyval using polyval failed (rc=-2)

Quoted 6 lines

Resolution:-
Enabling CONFIG_CRYPTO_SM3_GENERIC, CONFIG_CRYPTO_SM4_GENERIC, CONFIG_CRYPTO_HCTR2, CONFIG_CRYPTO_ARIA as module enables support of sm3, sm4, aria, polyval & xctr.

The commit log and Signed-off-by lines shouldn't have leading spaces/indent.

Quoted 9 lines
---
 arch/arm/configs/imx_v6_v7_defconfig | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/configs/imx_v6_v7_defconfig +0 -0
index 0a90583f9f01..627f57da9d5b 100644

arch/arm/configs/imx_v6_v7_defconfig CONFIG_DEBUG_FS=y · line 490

Quoted 7 lines
arch/arm/configs/imx_v6_v7_defconfig +4 -0
@@ -484,3 +484,7 @@ CONFIG_DEBUG_FS=y
 # CONFIG_SLUB_DEBUG is not set
 # CONFIG_SCHED_DEBUG is not set
 # CONFIG_FTRACE is not set
+CONFIG_CRYPTO_HCTR2=m
+CONFIG_CRYPTO_SM3_GENERIC=m
+CONFIG_CRYPTO_SM4_GENERIC=m
+CONFIG_CRYPTO_ARIA=m

Instead of adding lines at the end of file, please use help from 'make savedefconfig' to get them appear at the correct places.

Shawn

#5 lore raw
Quoted 40 lines

-----Original Message-----
From: Shawn Guo <[email protected]>
Sent: Saturday, February 3, 2024 7:52 PM
To: Kshitiz Varshney <[email protected]>
Cc: Herbert Xu <[email protected]>; Shawn Guo <[email protected]>; Sascha Hauer <[email protected]>; Fabio Estevam <[email protected]>; dl-linux-imx <[email protected]>; Pengutronix Kernel Team <[email protected]>; Varun Sethi <[email protected]>; Gaurav Jain <[email protected]>; Pankaj Gupta <[email protected]>; Sahil Malhotra <[email protected]>; Vabhav Sharma <[email protected]>; Meenakshi Aggarwal <[email protected]>; Rahul Kumar Yadav <[email protected]>; Nikhil Singla <[email protected]>; [email protected]; [email protected]
Subject: [EXT] Re: [PATCH v1] imx_v6_v7_defconfig: Enable sm3, sm4, polyval, xctr cipher test support

Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the message using the 'Report this email' button

Quoted 12 lines · Kshitiz Varshney

Enable config for sm3, sm4, polyval, xctr cipher test as built in module.

Issue:-
Multiple crypto tests like sm3, sm4 xctr and polyval failing.

skcipher: failed to allocate transform for xctr(aes): -2
alg: self-tests for xctr(aes) using xctr(aes) failed (rc=-2)
alg: self-tests for sm3 using sm3 failed (rc=-2)
tcrypt: failed to load transform for sm3: -2
alg: hash: failed to allocate transform for polyval: -2
alg: self-tests for polyval using polyval failed (rc=-2)

Quoted 2 lines

Resolution:-
Enabling CONFIG_CRYPTO_SM3_GENERIC,

CONFIG_CRYPTO_SM4_GENERIC,

Quoted 8 lines
Quoted 1 line

CONFIG_CRYPTO_HCTR2, CONFIG_CRYPTO_ARIA as module enables

support of

Quoted 3 lines

sm3, sm4, aria, polyval & xctr.

The commit log and Signed-off-by lines shouldn't have leading spaces/indent.

Checkpatch has not reported any such issues.

Quoted 5 lines
Quoted 5 lines
---
 arch/arm/configs/imx_v6_v7_defconfig | 4 ++++
 1 file changed, 4 insertions(+)
Quoted 16 lines

arch/arm/configs/imx_v6_v7_defconfig CONFIG_DEBUG_FS=y · line 490

Quoted 13 lines
arch/arm/configs/imx_v6_v7_defconfig +4 -0
index 0a90583f9f01..627f57da9d5b 100644
@@ -484,3 +484,7 @@ CONFIG_DEBUG_FS=y
 # CONFIG_SLUB_DEBUG is not set
 # CONFIG_SCHED_DEBUG is not set
 # CONFIG_FTRACE is not set
+CONFIG_CRYPTO_HCTR2=m
+CONFIG_CRYPTO_SM3_GENERIC=m
+CONFIG_CRYPTO_SM4_GENERIC=m
+CONFIG_CRYPTO_ARIA=m

Instead of adding lines at the end of file, please use help from 'make savedefconfig' to get them appear at the correct places.

Changes done in v2.

Quoted 2 lines

Shawn