Skip to contentSkip to conversation

arm: omap1: remove duplicated 'select ARCH_OMAP'

PATCH In review Masahiro Yamada 2 participants 3 messages Feb 4, 2024 – Feb 28, 2024

Subsystems (3)
Arm (32-bit) Arm sub-architectures OMAP1 support
lore
Share & tools
lore

Masahiro Yamada

author
#0 lore raw

PATCH 1/1 arm: omap1: remove duplicated 'select ARCH_OMAP'

Commit 980a637d11fe ("ARM: omap1: fix !ARCH_OMAP1_ANY link failures") added one more 'select ARCH_OMAP'.

Signed-off-by Masahiro Yamada <[email protected]>

---

 arch/arm/mach-omap1/Kconfig | 1 -
 1 file changed, 1 deletion(-)
arch/arm/mach-omap1/Kconfig +0 -1
index cbf703f0d850..a643b71e30a3 100644
@@ -4,7 +4,6 @@ menuconfig ARCH_OMAP1
 	depends on ARCH_MULTI_V4T || ARCH_MULTI_V5
 	depends on CPU_LITTLE_ENDIAN
 	depends on ATAGS
-	select ARCH_OMAP
 	select ARCH_HAS_HOLES_MEMORYMODEL
 	select ARCH_OMAP
 	select CLKSRC_MMIO
Signature · 1 line
2.40.1
author
#1 lore raw

Just a nit.

The commit subject "arm:" should be capitalized to "ARM:" because it is a convention for changes under arch/arm/.

Maybe, the maintainer can cater to it?

Quoted 25 lines · Masahiro Yamada

Commit 980a637d11fe ("ARM: omap1: fix !ARCH_OMAP1_ANY link failures") added one more 'select ARCH_OMAP'.

Signed-off-by Masahiro Yamada <[email protected]>

---

 arch/arm/mach-omap1/Kconfig | 1 -
 1 file changed, 1 deletion(-)
arch/arm/mach-omap1/Kconfig +0 -2
index cbf703f0d850..a643b71e30a3 100644
@@ -4,7 +4,6 @@ menuconfig ARCH_OMAP1
        depends on ARCH_MULTI_V4T || ARCH_MULTI_V5
        depends on CPU_LITTLE_ENDIAN
        depends on ATAGS
-       select ARCH_OMAP
        select ARCH_HAS_HOLES_MEMORYMODEL
        select ARCH_OMAP
        select CLKSRC_MMIO
--

2.40.1

Signature · 2 lines
Best Regards
Masahiro Yamada
reviewer
#2 lore raw
Quoted 6 lines · Masahiro Yamada

Just a nit.

The commit subject "arm:" should be capitalized to "ARM:" because it is a convention for changes under arch/arm/.

Maybe, the maintainer can cater to it?

Thanks yes applying into omap-for-v6.9/omap1 with the prefix changed.

Regards,

Tony