Skip to contentSkip to conversation

intel_th: Remove redundant initialization of pointer outp

PATCH New Colin Ian King 1 participant 1 message Feb 5, 2024

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 intel_th: Remove redundant initialization of pointer outp

The pointer outp is being initialized with a value that is never read. All the reads of outp occur after outp has neen set to an appropriate value rather than using the first value is initialized with. The assignment is redundant and can be removed.

Cleans up clang scan warning:
drivers/hwtracing/intel_th/sth.c:73:15: warning: Value stored to 'outp' during its initialization is never read [deadcode.DeadStores]

---
 drivers/hwtracing/intel_th/sth.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hwtracing/intel_th/sth.c +1 -1
index 9ca8c4e045f8..87c1c751d183 100644
@@ -70,7 +70,7 @@ static ssize_t notrace sth_stm_packet(struct stm_data *stm_data,
 	struct sth_device *sth = container_of(stm_data, struct sth_device, stm);
 	struct intel_th_channel __iomem *out =
 		sth_channel(sth, master, channel);
-	u64 __iomem *outp = &out->Dn;
+	u64 __iomem *outp;
 	unsigned long reg = REG_STH_TRIG;
 
 #ifndef CONFIG_64BIT
Signature · 1 line
2.39.2