Skip to contentSkip to conversation

perf kvm powerpc: Fix build

PATCH Applied Ian Rogers 2 participants 3 messages Feb 6, 2024 – Feb 7, 2024 perf events

lore
Share & tools
lore

Ian Rogers

author reviewer
#0 lore raw

PATCH 1/1 perf kvm powerpc: Fix build

Updates to struct parse_events_error needed to be carried through to PowerPC specific event parsing.

Fixes fd7b8e8fb20f ("perf parse-events: Print all errors")
---
 tools/perf/arch/powerpc/util/kvm-stat.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/arch/powerpc/util/kvm-stat.c +1 -1
index d9a0ac1cdf30..c8357b571ccf 100644
@@ -114,7 +114,7 @@ static int is_tracepoint_available(const char *str, struct evlist *evlist)
 
 	parse_events_error__init(&err);
 	ret = parse_events(evlist, str, &err);
-	if (err.str)
+	if (ret)
 		parse_events_error__print(&err, "tracepoint");
 	parse_events_error__exit(&err);
 	return ret;
Signature · 1 line
2.43.0.594.gd9cf4e227d-goog
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 7 lines · Ian Rogers

Updates to struct parse_events_error needed to be carried through to PowerPC specific event parsing.

Fixes fd7b8e8fb20f ("perf parse-events: Print all errors")

Thanks for the quick fix!
Namhyung

Quoted 20 lines
---
 tools/perf/arch/powerpc/util/kvm-stat.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/arch/powerpc/util/kvm-stat.c +1 -2
index d9a0ac1cdf30..c8357b571ccf 100644
@@ -114,7 +114,7 @@ static int is_tracepoint_available(const char *str, struct evlist *evlist)
 
        parse_events_error__init(&err);
        ret = parse_events(evlist, str, &err);
-       if (err.str)
+       if (ret)
                parse_events_error__print(&err, "tracepoint");
        parse_events_error__exit(&err);
        return ret;
--

2.43.0.594.gd9cf4e227d-goog

maintainer Applied
#2 lore raw
In reply to Ian Rogers
Quoted 4 lines · Ian Rogers

Updates to struct parse_events_error needed to be carried through to PowerPC specific event parsing.

Applied to perf-tools-next, thanks!

Best regards,

Signature · 1 line
Namhyung Kim <[email protected]>