Skip to contentSkip to conversation

ACPI: scan: Defer enumeration of devices with a _DEP pointing to IVSC device

PATCH Applied Wentong Wu 2 participants 3 messages Feb 7, 2024 – Feb 21, 2024 ACPI

lore
Share & tools
lore

Wentong Wu

author
#0 lore raw

PATCH 1/1 ACPI: scan: Defer enumeration of devices with a _DEP pointing to IVSC device

Inside IVSC, switching ownership requires an interface with two different hardware modules, ACE and CSI. The software interface to these modules is based on Intel MEI framework. Usually mei client devices are dynamically created, so the info of consumers depending on mei client devices is not present in the firmware tables.

This causes problems with the probe ordering with respect to drivers for consumers of these MEI client devices. But on these camera sensor devices, the ACPI nodes describing the sensors all have a _DEP dependency on the matching MEI bus ACPI device, so adding IVSC MEI bus ACPI device to acpi_honor_dep_ids allows solving the probe-ordering problem by deferring the enumeration of ACPI-devices which have a _DEP dependency on an IVSC mei bus ACPI device.

Add INTC10CF, the HID of IVSC MEI bus ACPI device on MTL platform, to acpi_honor_dep_ids.

---
 drivers/acpi/scan.c | 1 +
 1 file changed, 1 insertion(+)
drivers/acpi/scan.c +1 -0
index e6ed1ba91e5c..f32a2c738c8b 100644
@@ -798,6 +798,7 @@ static const char * const acpi_honor_dep_ids[] = {
 	"INTC1059", /* IVSC (TGL) driver must be loaded to allow i2c access to camera sensors */
 	"INTC1095", /* IVSC (ADL) driver must be loaded to allow i2c access to camera sensors */
 	"INTC100A", /* IVSC (RPL) driver must be loaded to allow i2c access to camera sensors */
+	"INTC10CF", /* IVSC (MTL) driver must be loaded to allow i2c access to camera sensors */
 	NULL
 };
 
Signature · 1 line
2.43.0
maintainer Applied
#1 lore raw
Quoted 30 lines · Wentong Wu

Inside IVSC, switching ownership requires an interface with two different hardware modules, ACE and CSI. The software interface to these modules is based on Intel MEI framework. Usually mei client devices are dynamically created, so the info of consumers depending on mei client devices is not present in the firmware tables.

This causes problems with the probe ordering with respect to drivers for consumers of these MEI client devices. But on these camera sensor devices, the ACPI nodes describing the sensors all have a _DEP dependency on the matching MEI bus ACPI device, so adding IVSC MEI bus ACPI device to acpi_honor_dep_ids allows solving the probe-ordering problem by deferring the enumeration of ACPI-devices which have a _DEP dependency on an IVSC mei bus ACPI device.

Add INTC10CF, the HID of IVSC MEI bus ACPI device on MTL platform, to acpi_honor_dep_ids.

---
 drivers/acpi/scan.c | 1 +
 1 file changed, 1 insertion(+)
drivers/acpi/scan.c +0 -0
index e6ed1ba91e5c..f32a2c738c8b 100644

drivers/acpi/scan.c static const char * const acpi_honor_dep_ids[] = {

Quoted 8 lines
drivers/acpi/scan.c +1 -1
@@ -798,6 +798,7 @@ static const char * const acpi_honor_dep_ids[] = {
        "INTC1059", /* IVSC (TGL) driver must be loaded to allow i2c access to camera sensors */
        "INTC1095", /* IVSC (ADL) driver must be loaded to allow i2c access to camera sensors */
        "INTC100A", /* IVSC (RPL) driver must be loaded to allow i2c access to camera sensors */
+       "INTC10CF", /* IVSC (MTL) driver must be loaded to allow i2c access to camera sensors */
        NULL
 };
 
--

Applied as 6.9 material, thanks!

#2 lore raw
Quoted 42 lines

From: Rafael J. Wysocki <[email protected]>

Quoted 28 lines · Wentong Wu

Inside IVSC, switching ownership requires an interface with two different hardware modules, ACE and CSI. The software interface to these modules is based on Intel MEI framework. Usually mei client devices are dynamically created, so the info of consumers depending on mei client devices is not present in the firmware tables.

This causes problems with the probe ordering with respect to drivers for consumers of these MEI client devices. But on these camera sensor devices, the ACPI nodes describing the sensors all have a _DEP dependency on the matching MEI bus ACPI device, so adding IVSC MEI bus ACPI device to acpi_honor_dep_ids allows solving the probe-ordering problem by deferring the enumeration of ACPI-devices which have a _DEP dependency on an IVSC mei bus ACPI device.

Add INTC10CF, the HID of IVSC MEI bus ACPI device on MTL platform, to acpi_honor_dep_ids.

---
 drivers/acpi/scan.c | 1 +
 1 file changed, 1 insertion(+)
drivers/acpi/scan.c index renamed from drivers/acpi/scan.c +0 -0

e6ed1ba91e5c..f32a2c738c8b 100644

drivers/acpi/scan.c static const char * const acpi_honor_dep_ids[] = { · line 798

Quoted 1 line
drivers/acpi/scan.c +0 -0
@@ -798,6 +798,7 @@ static const char * const acpi_honor_dep_ids[] = {
        "INTC1059", /* IVSC (TGL) driver must be loaded to allow i2c access to

camera sensors */

drivers/acpi/scan.c static const char * const acpi_honor_dep_ids[] = { · line 799

Quoted 1 line
drivers/acpi/scan.c +0 -0
        "INTC1095", /* IVSC (ADL) driver must be loaded to allow i2c access to

camera sensors */

Quoted 7 lines
drivers/acpi/scan.c +0 -0
        "INTC100A", /* IVSC (RPL) driver must be loaded to allow i2c

access to camera sensors */
+ "INTC10CF", /* IVSC (MTL) driver must be loaded to allow i2c
+ access to camera sensors */
NULL
};

Quoted 3 lines
Quoted 1 line

--

Applied as 6.9 material, thanks!

Thanks, and any chance to 6.8?

BR,
Wentong