dt-bindings: interrupt-controller: Convert Atmel AIC to json-schema
PATCH 1/1 dt-bindings: interrupt-controller: Convert Atmel AIC to json-schema
Convert the Atmel AIC binding document to DT schema format using json-schema.
---
Note: I get the following warnings on latest kernel but not in 6.7. Should I be worried?
usage: yamllint [-h] [-] [-c CONFIG_FILE | -d CONFIG_DATA] [--list-files] [-f {parsable,standard,colored,github,auto}] [-s] [--no-warnings] [-v] [FILE_OR_DIR [FILE_OR_DIR ...]]
yamllint: error: one of the arguments FILE_OR_DIR - is required
.../interrupt-controller/atmel,aic.txt | 43 --------- .../interrupt-controller/atmel,aic.yaml | 88 +++++++++++++++++++ 2 files changed, 88 insertions(+), 43 deletions(-) delete mode 100644 Documentation/devicetree/bindings/interrupt-controller/atmel,aic.txt create mode 100644 Documentation/devicetree/bindings/interrupt-controller/atmel,aic.yaml
Documentation/devicetree/bindings/interrupt-controller/atmel,aic.txt deleted +0 -43
@@ -1,43 +0,0 @@ -* Advanced Interrupt Controller (AIC) - -Required properties: -- compatible: Should be: - - "atmel,<chip>-aic" where <chip> can be "at91rm9200", "sama5d2", - "sama5d3" or "sama5d4" - - "microchip,<chip>-aic" where <chip> can be "sam9x60" - -- interrupt-controller: Identifies the node as an interrupt controller. -- #interrupt-cells: The number of cells to define the interrupts. It should be 3. - The first cell is the IRQ number (aka "Peripheral IDentifier" on datasheet). - The second cell is used to specify flags: - bits[3:0] trigger type and level flags: - 1 = low-to-high edge triggered. - 2 = high-to-low edge triggered. - 4 = active high level-sensitive. - 8 = active low level-sensitive. - Valid combinations are 1, 2, 3, 4, 8. - Default flag for internal sources should be set to 4 (active high). - The third cell is used to specify the irq priority from 0 (lowest) to 7 - (highest). -- reg: Should contain AIC registers location and length -- atmel,external-irqs: u32 array of external irqs. - -Examples: - /* - * AIC - */ - aic: interrupt-controller@fffff000 { - compatible = "atmel,at91rm9200-aic"; - interrupt-controller; - #interrupt-cells = <3>; - reg = <0xfffff000 0x200>; - }; - - /* - * An interrupt generating device that is wired to an AIC. - */ - dma: dma-controller@ffffec00 { - compatible = "atmel,at91sam9g45-dma"; - reg = <0xffffec00 0x200>; - interrupts = <21 4 5>; - };
Documentation/devicetree/bindings/interrupt-controller/atmel,aic.yaml new file +88 -0
88 lines not on this page · raw message
base-commit: 047371968ffc470769f541d6933e262dc7085456
Signature · 1 line
2.25.1
Rob Herring
maintainerQuoted 8 lines · Dharma Balasubiramani
Convert the Atmel AIC binding document to DT schema format using json-schema.
Signed-off-by Dharma Balasubiramani <[email protected]>---
Note: I get the following warnings on latest kernel but not in 6.7. Should I be worried?
Quoted 9 lines
usage: yamllint [-h] [-] [-c
CONFIG_FILE| -dCONFIG_DATA] [--list-files] [-f {parsable,standard,colored,github,auto}] [-s] [--no-warnings] [-v] [FILE_OR_DIR[FILE_OR_DIR...]]
yamllint: error: one of the argumentsFILE_OR_DIR- is required.../interrupt-controller/atmel,aic.txt | 43 --------- .../interrupt-controller/atmel,aic.yaml | 88 +++++++++++++++++++ 2 files changed, 88 insertions(+), 43 deletions(-) delete mode 100644 Documentation/devicetree/bindings/interrupt-controller/atmel,aic.txt create mode 100644 Documentation/devicetree/bindings/interrupt-controller/atmel,aic.yaml
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:Documentation/devicetree/bindings/interrupt-controller/atmel,aic.example.dtb: /example-1/dma-controller@ffffec00: failed to match any schema with compatible: ['atmel,at91sam9g45-dma']
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]
The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Hey Dharma,
Quoted 11 lines · Rob Herring
Quoted 9 lines · Dharma Balasubiramani
Convert the Atmel AIC binding document to DT schema format using json-schema.
Signed-off-by Dharma Balasubiramani <[email protected]>---
Note: I get the following warnings on latest kernel but not in 6.7.
Should I be worried?
usage: yamllint [-h] [-] [-cCONFIG_FILE| -dCONFIG_DATA] [--list-files] [-f {parsable,standard,colored,github,auto}] [-s] [--no-warnings] [-v] [FILE_OR_DIR[FILE_OR_DIR...]]
yamllint: error: one of the argumentsFILE_OR_DIR- is required
Hard to say, how were you envoking the command? There were some issues recently with dt_binding_check, but I thought those had been fixed.
Quoted 2 lines
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/interrupt-controller/atmel,aic.example.dtb: /example-1/dma-controller@ffffec00: failed to match any schema with compatible: ['atmel,at91sam9g45-dma']
But you didn't see this warning?
I think you can resolve it by just dropping the "user" example from the binding entirely. I don't think it adds anything at all.
Cheers,
Conor.
Hi Conor,
Quoted 7 lines · Conor Dooley
Hey Dharma,
Quoted 4 lines · Rob Herring
Quoted 3 lines · Dharma Balasubiramani
Convert the Atmel AIC binding document to DT schema format using json-schema.
Quoted 8 lines
Quoted 6 lines
Quoted 6 lines
Signed-off-by Dharma Balasubiramani<[email protected]>---
Note: I get the following warnings on latest kernel but not in 6.7.
Should I be worried?
usage: yamllint [-h] [-] [-cCONFIG_FILE| -dCONFIG_DATA] [--list-files] [-f {parsable,standard,colored,github,auto}] [-s] [--no-warnings] [-v] [FILE_OR_DIR[FILE_OR_DIR...]]
yamllint: error: one of the argumentsFILE_OR_DIR- is requiredHard to say, how were you envoking the command? There were some issues recently with
dt_binding_check, but I thought those had been fixed.
I use this command to validate
make ARCH=arm CROSS_COMPILE=arm-linux-gnueabi- dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/interrupt-controller/atmel,aic.yaml
and also dtbs_check.
version = yamllint 1.32.0
Quoted 4 lines
Quoted 3 lines
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/interrupt-controller/atmel,aic.example.dtb: /example-1/dma-controller@ffffec00: failed to match any schema with compatible: ['atmel,at91sam9g45-dma']But you didn't see this warning?
No I didn't see this warning when applied on tag:6.7. Don't know why.
Quoted 2 lines
I think you can resolve it by just dropping the "user" example from the binding entirely. I don't think it adds anything at all.
I intentionally checked the generated example dts file and found that both the examples look correct.
example-0 {
#address-cells = <1>;
#size-cells = <1>;
/* AIC */
aic: interrupt-controller@fffff000 {
compatible = "atmel,at91rm9200-aic";
interrupt-controller;
#interrupt-cells = <3>;
reg = <0xfffff000 0x200>;
atmel,external-irqs = <31>;
};
};
example-1 {
#address-cells = <1>;
#size-cells = <1>;
interrupt-parent = <&fake_intc1>;
fake_intc1: fake-interrupt-controller {
interrupt-controller;
#interrupt-cells = < 3 >;
};
/* An interrupt generating device that is wired to an AIC. */
dma: dma-controller@ffffec00 {
compatible = "atmel,at91sam9g45-dma";
#dma-cells = <2>;
reg = <0xffffec00 0x200>;
interrupts = <21 4 5>;
};
};Quoted 3 lines
Cheers,
Conor.
Please correct me if I'm doing something wrong here.
Signature · 2 lines
With Best Regards, Dharma B.
Rob Herring
maintainerQuoted 16 lines · On Fri, Feb 09, 2024 at 06:31:15AM +0000, [email protected] wrote:
Hi Conor,
Quoted 13 lines · Conor Dooley
Hey Dharma,
Quoted 10 lines · Rob Herring
Quoted 9 lines · Dharma Balasubiramani
Convert the Atmel AIC binding document to DT schema format using json-schema.
Signed-off-by Dharma Balasubiramani<[email protected]>---
Note: I get the following warnings on latest kernel but not in 6.7.
Should I be worried?
usage: yamllint [-h] [-] [-cCONFIG_FILE| -dCONFIG_DATA] [--list-files] [-f {parsable,standard,colored,github,auto}] [-s] [--no-warnings] [-v] [FILE_OR_DIR[FILE_OR_DIR...]]
yamllint: error: one of the argumentsFILE_OR_DIR- is required
Quoted 7 lines
Quoted 2 lines
Hard to say, how were you envoking the command? There were some issues recently with
dt_binding_check, but I thought those had been fixed.I use this command to validate
make ARCH=arm CROSS_COMPILE=arm-linux-gnueabi-
dt_binding_checkDT_SCHEMA_FILES=Documentation/devicetree/bindings/interrupt-controller/atmel,aic.yaml
Humm, not sure. Will have to investigate.
Quoted 9 lines
and also
dtbs_check.version = yamllint 1.32.0
Quoted 4 lines
Quoted 3 lines
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/interrupt-controller/atmel,aic.example.dtb: /example-1/dma-controller@ffffec00: failed to match any schema with compatible: ['atmel,at91sam9g45-dma']But you didn't see this warning?
No I didn't see this warning when applied on tag:6.7. Don't know why.
That's because it just got enabled by default.
Quoted 6 lines
Quoted 3 lines
I think you can resolve it by just dropping the "user" example from the binding entirely. I don't think it adds anything at all.
I intentionally checked the generated example dts file and found that both the examples look correct.
Maybe so, but how do we know with no schema? Your choices are drop from the example or add a schema for the DMA controller.
Rob
Hi Rob,
Quoted 43 lines · Rob Herring
EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
Quoted 16 lines · On Fri, Feb 09, 2024 at 06:31:15AM +0000, [email protected] wrote:
Hi Conor,
Quoted 13 lines · Conor Dooley
Hey Dharma,
Quoted 10 lines · Rob Herring
Quoted 9 lines · Dharma Balasubiramani
Convert the Atmel AIC binding document to DT schema format using json-schema.
Signed-off-by Dharma Balasubiramani<[email protected]>---
Note: I get the following warnings on latest kernel but not in 6.7.
Should I be worried?
usage: yamllint [-h] [-] [-cCONFIG_FILE| -dCONFIG_DATA] [--list-files] [-f {parsable,standard,colored,github,auto}] [-s] [--no-warnings] [-v] [FILE_OR_DIR[FILE_OR_DIR...]]
yamllint: error: one of the argumentsFILE_OR_DIR- is requiredQuoted 7 lines
Quoted 2 lines
Hard to say, how were you envoking the command? There were some issues recently with
dt_binding_check, but I thought those had been fixed.I use this command to validate
make ARCH=arm CROSS_COMPILE=arm-linux-gnueabi-
dt_binding_checkDT_SCHEMA_FILES=Documentation/devicetree/bindings/interrupt-controller/atmel,aic.yamlHumm, not sure. Will have to investigate.
Quoted 9 lines
and also
dtbs_check.version = yamllint 1.32.0
Quoted 4 lines
Quoted 3 lines
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/interrupt-controller/atmel,aic.example.dtb: /example-1/dma-controller@ffffec00: failed to match any schema with compatible: ['atmel,at91sam9g45-dma']But you didn't see this warning?
No I didn't see this warning when applied on tag:6.7. Don't know why.
That's because it just got enabled by default.
Quoted 1 line
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
I think you can resolve it by just dropping the "user" example from the binding entirely. I don't think it adds anything at all.
I intentionally checked the generated example dts file and found that both the examples look correct.
Maybe so, but how do we know with no schema? Your choices are drop from the example or add a schema for the DMA controller.
Currently, my colleague is actively working on adding the schema for DMA, anyway I will drop the dma example in the interrupt controller for now.
Thanks.
Quoted 2 lines
Rob
Signature · 2 lines
With Best Regards, Dharma B.
Hey Dharma,
Overall this looks alright, but I have a few comments for you.
Quoted 9 lines · Dharma Balasubiramani
Documentation/devicetree/bindings/interrupt-controller/atmel,aic.yaml new file +3
-0@@ -0,0 +1,88 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +---
Documentation/devicetree/bindings/interrupt-controller/atmel,aic.yaml line 13
Quoted 10 lines
Documentation/devicetree/bindings/interrupt-controller/atmel,aic.yaml new file +10
-0+$id: http://devicetree.org/schemas/interrupt-controller/atmel,aic.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Advanced Interrupt Controller (AIC) + +maintainers: + - Nicolas Ferre <[email protected]> + - Dharma balasubiramani <[email protected]> + +description: |
The chomping operator, |, is not needed here as you have no formatting to preserve.
Documentation/devicetree/bindings/interrupt-controller/atmel,aic.yaml line 18
Quoted 7 lines
Documentation/devicetree/bindings/interrupt-controller/atmel,aic.yaml new file +3
-0+ The Advanced Interrupt Controller (AIC) is an 8-level priority, individually + maskable, vectored interrupt controller providing handling of up to one + hundred and twenty-eight interrupt sources.It is designed to substantially
Documentation/devicetree/bindings/interrupt-controller/atmel,aic.yaml new file +2
-0+ reduce the software and real-time overhead in handling internal and external + interrupts.
This reeks of a marketing statement and should be removed IMO.
Quoted 15 lines
Documentation/devicetree/bindings/interrupt-controller/atmel,aic.yaml new file +15
-0+allOf: + - $ref: /schemas/interrupt-controller.yaml# + +properties: + compatible: + enum: + - atmel,at91rm9200-aic + - atmel,sama5d2-aic + - atmel,sama5d3-aic + - atmel,sama5d4-aic + - microchip,sam9x60-aic + + interrupt-controller: true + + "#interrupt-cells":
Documentation/devicetree/bindings/interrupt-controller/atmel,aic.yaml line 44
Quoted 10 lines
Documentation/devicetree/bindings/interrupt-controller/atmel,aic.yaml new file +10
-0+ const: 3 + description: | + The 1st cell is the IRQ number (Peripheral IDentifier on datasheet). + The 2nd cell specifies flags: + bits[3:0] trigger type and level flags: + 1 = low-to-high edge triggered. + 2 = high-to-low edge triggered. + 4 = active high level-sensitive. + 8 = active low level-sensitive. + Valid combinations: 1, 2, 3, 4, 8.
Shame that these are not aligned with the IRQ_TYPE defines :(
Documentation/devicetree/bindings/interrupt-controller/atmel,aic.yaml line 49
Quoted 6 lines
Documentation/devicetree/bindings/interrupt-controller/atmel,aic.yaml new file +5
-0+ Default for internal sources: 4 (active high). + The 3rd cell specifies irq priority from 0 (lowest) to 7 (highest). + + interrupts: + description: Interrupt source of the parent interrupt controller.
Drop the description, it's obvious.
Documentation/devicetree/bindings/interrupt-controller/atmel,aic.yaml line 52
Quoted 3 lines
Documentation/devicetree/bindings/interrupt-controller/atmel,aic.yaml new file +3
-0+ maxItems: 1 + + reg:
A nit, but I would put reg after compatible.
Quoted 1 line
+ description: Specifies base physical address(s) and size of the AIC registers.
Same here.
Documentation/devicetree/bindings/interrupt-controller/atmel,aic.yaml line 64
Quoted 11 lines
Documentation/devicetree/bindings/interrupt-controller/atmel,aic.yaml new file +11
-0+ maxItems: 1 + + atmel,external-irqs: + $ref: /schemas/types.yaml#/definitions/uint32-array + description: u32 array of external irqs. + +required: + - compatible + - interrupt-controller + - "#interrupt-cells" + - reg
A nit, but I would put reg after compatible
Documentation/devicetree/bindings/interrupt-controller/atmel,aic.yaml line 71
Quoted 7 lines
Documentation/devicetree/bindings/interrupt-controller/atmel,aic.yaml new file +7
-0+ - atmel,external-irqs + +unevaluatedProperties: false + +examples: + - | + /* AIC */
Drop the comment, its obvious.
Quoted 1 line
+ aic: interrupt-controller@fffff000 {
The node name here is not used, drop it.
Quoted 6 lines
Documentation/devicetree/bindings/interrupt-controller/atmel,aic.yaml new file +6
-0+ compatible = "atmel,at91rm9200-aic"; + interrupt-controller; + #interrupt-cells = <3>; + reg = <0xfffff000 0x200>; + atmel,external-irqs = <31>; + };
Documentation/devicetree/bindings/interrupt-controller/atmel,aic.yaml line 87
Quoted 10 lines
Documentation/devicetree/bindings/interrupt-controller/atmel,aic.yaml new file +9
-0+ + - | + /* An interrupt generating device that is wired to an AIC. */ + dma: dma-controller@ffffec00 { + compatible = "atmel,at91sam9g45-dma"; + #dma-cells = <2>; + reg = <0xffffec00 0x200>; + interrupts = <21 4 5>; + };
And delete this whole example :)
Cheers,
Conor.
Quoted 13 lines · Conor Dooley
Documentation/devicetree/bindings/interrupt-controller/atmel,aic.yaml line 44
Quoted 11 lines · Dharma Balasubiramani
Documentation/devicetree/bindings/interrupt-controller/atmel,aic.yaml new file +11
-0+ "#interrupt-cells": + const: 3 + description: | + The 1st cell is the IRQ number (Peripheral IDentifier on datasheet). + The 2nd cell specifies flags: + bits[3:0] trigger type and level flags: + 1 = low-to-high edge triggered. + 2 = high-to-low edge triggered. + 4 = active high level-sensitive. + 8 = active low level-sensitive. + Valid combinations: 1, 2, 3, 4, 8.
Quoted 1 line
Shame that these are not aligned with the
IRQ_TYPEdefines :(
Dharma pointed out to me that these are the same and I just looked at the wrong header file.
Hi Conor,
Quoted 19 lines · Conor Dooley
Hey Dharma,
Overall this looks alright, but I have a few comments for you.
Quoted 13 lines · Dharma Balasubiramani
Documentation/devicetree/bindings/interrupt-controller/atmel,aic.yaml new file +7
-0@@ -0,0 +1,88 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id:http://devicetree.org/schemas/interrupt-controller/atmel,aic.yaml# +$schema:http://devicetree.org/meta-schemas/core.yaml# + +title: Advanced Interrupt Controller (AIC)
Quoted 8 lines
Documentation/devicetree/bindings/interrupt-controller/atmel,aic.yaml line 13
Quoted 6 lines
Documentation/devicetree/bindings/interrupt-controller/atmel,aic.yaml new file +6
-0+ +maintainers: + - Nicolas Ferre<[email protected]> + - Dharma balasubiramani<[email protected]> + +description: |The chomping operator, |, is not needed here as you have no formatting to preserve.
I missed it again, I will fix it.
Quoted 8 lines
Documentation/devicetree/bindings/interrupt-controller/atmel,aic.yaml line 18
Quoted 7 lines
Documentation/devicetree/bindings/interrupt-controller/atmel,aic.yaml new file +3
-0+ The Advanced Interrupt Controller (AIC) is an 8-level priority, individually + maskable, vectored interrupt controller providing handling of up to one + hundred and twenty-eight interrupt sources.It is designed to substantially
Documentation/devicetree/bindings/interrupt-controller/atmel,aic.yaml new file +2
-0+ reduce the software and real-time overhead in handling internal and external + interrupts.This reeks of a marketing statement and should be removed IMO.
Noted. I will remove it.
Quoted 28 lines
Quoted 16 lines
Documentation/devicetree/bindings/interrupt-controller/atmel,aic.yaml new file +15
-0+allOf: + - $ref: /schemas/interrupt-controller.yaml# + +properties: + compatible: + enum: + - atmel,at91rm9200-aic + - atmel,sama5d2-aic + - atmel,sama5d3-aic + - atmel,sama5d4-aic + - microchip,sam9x60-aic + + interrupt-controller: true + + "#interrupt-cells":Documentation/devicetree/bindings/interrupt-controller/atmel,aic.yaml line 44
Quoted 10 lines
Documentation/devicetree/bindings/interrupt-controller/atmel,aic.yaml new file +10
-0+ const: 3 + description: | + The 1st cell is the IRQ number (Peripheral IDentifier on datasheet). + The 2nd cell specifies flags: + bits[3:0] trigger type and level flags: + 1 = low-to-high edge triggered. + 2 = high-to-low edge triggered. + 4 = active high level-sensitive. + 8 = active low level-sensitive. + Valid combinations: 1, 2, 3, 4, 8.Shame that these are not aligned with the
IRQ_TYPEdefines 🙁
Quoted 6 lines
Documentation/devicetree/bindings/interrupt-controller/atmel,aic.yaml line 49
Quoted 5 lines
Documentation/devicetree/bindings/interrupt-controller/atmel,aic.yaml new file +5
-0+ Default for internal sources: 4 (active high). + The 3rd cell specifies irq priority from 0 (lowest) to 7 (highest). + + interrupts: + description: Interrupt source of the parent interrupt controller.Drop the description, it's obvious.
Sure.
Quoted 5 lines
Documentation/devicetree/bindings/interrupt-controller/atmel,aic.yaml line 52
Quoted 4 lines
Documentation/devicetree/bindings/interrupt-controller/atmel,aic.yaml new file +3
-0+ maxItems: 1 + + reg:A nit, but I would put reg after compatible.
Sure.
Quoted 3 lines
Quoted 2 lines
+ description: Specifies base physical address(s) and size of the AIC registers.
Same here.
Sure, I will drop the description.
Quoted 13 lines
Documentation/devicetree/bindings/interrupt-controller/atmel,aic.yaml line 64
Quoted 12 lines
Documentation/devicetree/bindings/interrupt-controller/atmel,aic.yaml new file +11
-0+ maxItems: 1 + + atmel,external-irqs: + $ref: /schemas/types.yaml#/definitions/uint32-array + description: u32 array of external irqs. + +required: + - compatible + - interrupt-controller + - "#interrupt-cells" + - regA nit, but I would put reg after compatible
Sure.
Quoted 9 lines
Documentation/devicetree/bindings/interrupt-controller/atmel,aic.yaml line 71
Quoted 8 lines
Documentation/devicetree/bindings/interrupt-controller/atmel,aic.yaml new file +7
-0+ - atmel,external-irqs + +unevaluatedProperties: false + +examples: + - | + /* AIC */Drop the comment, its obvious.
Sure, I will drop it
Quoted 3 lines
Quoted 2 lines
+ aic: interrupt-controller@fffff000 {
The node name here is not used, drop it.
Sure, I will drop the aic and use just interrupt-controller@fffff000.
Quoted 16 lines
Quoted 6 lines
Documentation/devicetree/bindings/interrupt-controller/atmel,aic.yaml new file +5
-0+ compatible = "atmel,at91rm9200-aic"; + interrupt-controller; + #interrupt-cells = <3>; + reg = <0xfffff000 0x200>; + atmel,external-irqs = <31>;Documentation/devicetree/bindings/interrupt-controller/atmel,aic.yaml line 87
Quoted 10 lines
Documentation/devicetree/bindings/interrupt-controller/atmel,aic.yaml new file +10
-0+ }; + + - | + /* An interrupt generating device that is wired to an AIC. */ + dma: dma-controller@ffffec00 { + compatible = "atmel,at91sam9g45-dma"; + #dma-cells = <2>; + reg = <0xffffec00 0x200>; + interrupts = <21 4 5>; + };
Quoted 1 line
And delete this whole example 🙂
Sure, I will delete this example.
Quoted 4 lines
Cheers,
Conor.
Signature · 2 lines
With Best Regards, Dharma B.