perf tools: Remove misleading comments on map functions
Namhyung Kim
maintainerPATCH 1/1 perf tools: Remove misleading comments on map functions
When it converts sample IP to or from objdump-capable one, there's a comment saying that kernel modules have DSO_SPACE__USER. But commit 02213cec64bb ("perf maps: Mark module DSOs with kernel type") changed it and makes the comment confusing. Let's get rid of it.
--- tools/perf/util/map.c | 8 -------- 1 file changed, 8 deletions(-)
tools/perf/util/map.c +0 -8
@@ -553,10 +553,6 @@ u64 map__rip_2objdump(struct map *map, u64 rip)if (dso->rel)return rip -map__pgoff (map); -/* -* kernel modules also have DSO_TYPE_USER in dso->kernel, -* but all kernel modules are ET_REL, so won't get here. -*/ if (dso->kernel ==DSO_SPACE__USER )return rip + dso->text_offset;
@@ -585,10 +581,6 @@ u64 map__objdump_2mem(struct map *map, u64 ip)if (dso->rel)return map__unmap_ip (map, ip +map__pgoff (map)); -/* -* kernel modules also have DSO_TYPE_USER in dso->kernel, -* but all kernel modules are ET_REL, so won't get here. -*/ if (dso->kernel ==DSO_SPACE__USER )return map__unmap_ip (map, ip - dso->text_offset);
Signature · 1 line
2.43.0.687.g38aa6559b0-goog
Quoted 7 lines · Namhyung Kim
When it converts sample IP to or from objdump-capable one, there's a comment saying that kernel modules have
DSO_SPACE__USER. But commit02213cec64bb("perf maps: Mark module DSOs with kernel type") changed it and makes the comment confusing. Let's get rid of it.Signed-off-by Namhyung Kim <[email protected]>
Thanks,
Ian
Quoted 33 lines
--- tools/perf/util/map.c | 8 -------- 1 file changed, 8 deletions(-)tools/perf/util/map.c +0
-9@@ -553,10 +553,6 @@ u64 map__rip_2objdump(struct map *map, u64 rip)if (dso->rel)return rip -map__pgoff (map); -/* -* kernel modules also have DSO_TYPE_USER in dso->kernel, -* but all kernel modules are ET_REL, so won't get here. -*/ if (dso->kernel ==DSO_SPACE__USER )return rip + dso->text_offset;@@ -585,10 +581,6 @@ u64 map__objdump_2mem(struct map *map, u64 ip)if (dso->rel)return map__unmap_ip (map, ip +map__pgoff (map)); -/* -* kernel modules also have DSO_TYPE_USER in dso->kernel, -* but all kernel modules are ET_REL, so won't get here. -*/ if (dso->kernel ==DSO_SPACE__USER )return map__unmap_ip (map, ip - dso->text_offset); --2.43.0.687.g38aa6559b0-goog
Quoted 4 lines · Namhyung Kim
When it converts sample IP to or from objdump-capable one, there's a comment saying that kernel modules have
DSO_SPACE__USER. But commit02213cec64bb("perf maps: Mark module DSOs with kernel type") changed it and makes the comment confusing. Let's get rid of it.
- Arnaldo
Quoted 33 lines
Signed-off-by Namhyung Kim <[email protected]>--- tools/perf/util/map.c | 8 -------- 1 file changed, 8 deletions(-)tools/perf/util/map.c +0
-8@@ -553,10 +553,6 @@ u64 map__rip_2objdump(struct map *map, u64 rip)if (dso->rel)return rip -map__pgoff (map); -/* -* kernel modules also have DSO_TYPE_USER in dso->kernel, -* but all kernel modules are ET_REL, so won't get here. -*/ if (dso->kernel ==DSO_SPACE__USER )return rip + dso->text_offset;@@ -585,10 +581,6 @@ u64 map__objdump_2mem(struct map *map, u64 ip)if (dso->rel)return map__unmap_ip (map, ip +map__pgoff (map)); -/* -* kernel modules also have DSO_TYPE_USER in dso->kernel, -* but all kernel modules are ET_REL, so won't get here. -*/ if (dso->kernel ==DSO_SPACE__USER )return map__unmap_ip (map, ip - dso->text_offset);Signature · 1 line
2.43.0.687.g38aa6559b0-goog
Namhyung Kim
maintainerQuoted 6 lines · Namhyung Kim
When it converts sample IP to or from objdump-capable one, there's a comment saying that kernel modules have
DSO_SPACE__USER. But commit02213cec64bb("perf maps: Mark module DSOs with kernel type") changed it and makes the comment confusing. Let's get rid of it.
Applied perf-tools-next, thanks!
Best regards,
Signature · 1 line
Namhyung Kim <[email protected]>