Skip to contentSkip to conversation

UNI-T UTi260B support

PATCH Superseded Sebastian Reichel 6 participants 35 messages Feb 10, 2024 – Feb 13, 2024

Subsystems (10)

v1 of 6 Superseded Latest is v6 →

lore
Share & tools
lore
#0 lore raw

cover UNI-T UTi260B support

From: Sebastian Reichel <[email protected]>

Hi,

This adds adds support for the UNI-T UTi260B thermal camera, which is based on i.MX6ULL. Patches 1-11 clean up all warnings reported by CHECK_DTBS for i.MX6ULL (i.e. for an empty board). They are not specific to the UTi260B and in fact that machine has most of the IP handled by these patches marked as disabled. Then patches 12+13 introduce the vendor and board compatible DT bindings. Finally the last patches adds support for the thermal camera itself.

The DT is based on reverse engineered information. More information about the device can be found in this presentation from Embedded Recipes 2023:

* https://embedded-recipes.org/2023/wp-content/uploads/2023/10/Running-FOSS-on-a-Thermal-Camera-Sebastian-Reichel-compressed.pdf
* https://www.youtube.com/watch?v=uvObsCG-Cqo

I also prepared a branch with these patches (and a minimal kernel config) and published it here:

https://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-misc.git/log/?h=uti260b

Greetings,

-- Sebastian

Sebastian Reichel (14):
dt-bindings: pinctrl: fsl,imx6ul-pinctrl: convert to YAML
dt-bindings: bus: imx-weim: convert to YAML
dt-bindings: sound: fsl,imx-asrc: convert to YAML
dt-bindings: input: touchscreen: fsl,imx6ul-tsc convert to YAML
dt-bindings: soc: imx: fsl,imx-anatop: add binding
dt-bindings: soc: imx: fsl,imx-iomuxc-gpr: add imx6
dt-bindings: lcdif: Do not require power-domains for i.MX6ULL
dt-bindings: fsl-imx-sdma: fix HDMI audio index
ARM: dts: imx6ull: fix pinctrl node name
ARM: dts: imx6ul: Remove fsl,anatop from usbotg1
ARM: dts: imx6ul: add missing #thermal-sensor-cells
dt-bindings: vendor-prefixes: add UNI-T
dt-bindings: arm: add UNI-T UTi260b
ARM: dts: imx6ull-uti260b: Add board

 .../devicetree/bindings/arm/fsl.yaml          |   1 +
 .../devicetree/bindings/bus/fsl,imx-weim.yaml | 225 +++++++
 .../devicetree/bindings/bus/imx-weim.txt      | 117 ----
 .../bindings/display/fsl,lcdif.yaml           |   8 +-
 .../devicetree/bindings/dma/fsl,imx-sdma.yaml |   3 +-
 .../input/touchscreen/fsl,imx6ul-tsc.yaml     |  92 +++
 .../bindings/input/touchscreen/imx6ul_tsc.txt |  38 --
 .../bindings/pinctrl/fsl,imx6ul-pinctrl.txt   |  37 --
 .../bindings/pinctrl/fsl,imx6ul-pinctrl.yaml  | 116 ++++
 .../bindings/soc/imx/fsl,imx-anatop.yaml      | 125 ++++
 .../bindings/soc/imx/fsl,imx-iomuxc-gpr.yaml  |  18 +
 .../devicetree/bindings/sound/fsl,asrc.txt    |  80 ---
 .../bindings/sound/fsl,imx-asrc.yaml          | 159 +++++
 .../devicetree/bindings/vendor-prefixes.yaml  |   2 +
 arch/arm/boot/dts/nxp/imx/Makefile            |   1 +
 arch/arm/boot/dts/nxp/imx/imx6ul.dtsi         |   2 +-
 arch/arm/boot/dts/nxp/imx/imx6ull-uti260b.dts | 564 ++++++++++++++++++
 arch/arm/boot/dts/nxp/imx/imx6ull.dtsi        |   2 +-
 18 files changed, 1314 insertions(+), 276 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/bus/fsl,imx-weim.yaml
 delete mode 100644 Documentation/devicetree/bindings/bus/imx-weim.txt
 create mode 100644 Documentation/devicetree/bindings/input/touchscreen/fsl,imx6ul-tsc.yaml
 delete mode 100644 Documentation/devicetree/bindings/input/touchscreen/imx6ul_tsc.txt
 delete mode 100644 Documentation/devicetree/bindings/pinctrl/fsl,imx6ul-pinctrl.txt
 create mode 100644 Documentation/devicetree/bindings/pinctrl/fsl,imx6ul-pinctrl.yaml
 create mode 100644 Documentation/devicetree/bindings/soc/imx/fsl,imx-anatop.yaml
 delete mode 100644 Documentation/devicetree/bindings/sound/fsl,asrc.txt
 create mode 100644 Documentation/devicetree/bindings/sound/fsl,imx-asrc.yaml
 create mode 100644 arch/arm/boot/dts/nxp/imx/imx6ull-uti260b.dts
Signature · 1 line
2.43.0
#1 lore raw

PATCH 1/14 dt-bindings: pinctrl: fsl,imx6ul-pinctrl: convert to YAML

Convert i.MX6UL pinctrl bindings to YAML.

---
 .../bindings/pinctrl/fsl,imx6ul-pinctrl.txt   |  37 ------
 .../bindings/pinctrl/fsl,imx6ul-pinctrl.yaml  | 116 ++++++++++++++++++
 2 files changed, 116 insertions(+), 37 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/pinctrl/fsl,imx6ul-pinctrl.txt
 create mode 100644 Documentation/devicetree/bindings/pinctrl/fsl,imx6ul-pinctrl.yaml
Documentation/devicetree/bindings/pinctrl/fsl,imx6ul-pinctrl.txt deleted +0 -37
deleted file mode 100644
index 7ca4f6118d9a..000000000000
@@ -1,37 +0,0 @@
-* Freescale i.MX6 UltraLite IOMUX Controller
-
-Please refer to fsl,imx-pinctrl.txt in this directory for common binding part
-and usage.
-
-Required properties:
-- compatible: "fsl,imx6ul-iomuxc" for main IOMUX controller or
-  "fsl,imx6ull-iomuxc-snvs" for i.MX 6ULL's SNVS IOMUX controller.
-- fsl,pins: each entry consists of 6 integers and represents the mux and config
-  setting for one pin.  The first 5 integers <mux_reg conf_reg input_reg mux_val
-  input_val> are specified using a PIN_FUNC_ID macro, which can be found in
-  imx6ul-pinfunc.h under device tree source folder.  The last integer CONFIG is
-  the pad setting value like pull-up on this pin.  Please refer to i.MX6 UltraLite
-  Reference Manual for detailed CONFIG settings.
-
-CONFIG bits definition:
-PAD_CTL_HYS                     (1 << 16)
-PAD_CTL_PUS_100K_DOWN           (0 << 14)
-PAD_CTL_PUS_47K_UP              (1 << 14)
-PAD_CTL_PUS_100K_UP             (2 << 14)
-PAD_CTL_PUS_22K_UP              (3 << 14)
-PAD_CTL_PUE                     (1 << 13)
-PAD_CTL_PKE                     (1 << 12)
-PAD_CTL_ODE                     (1 << 11)
-PAD_CTL_SPEED_LOW               (0 << 6)
-PAD_CTL_SPEED_MED               (1 << 6)
-PAD_CTL_SPEED_HIGH              (3 << 6)
-PAD_CTL_DSE_DISABLE             (0 << 3)
-PAD_CTL_DSE_260ohm              (1 << 3)
-PAD_CTL_DSE_130ohm              (2 << 3)
-PAD_CTL_DSE_87ohm               (3 << 3)
-PAD_CTL_DSE_65ohm               (4 << 3)
-PAD_CTL_DSE_52ohm               (5 << 3)
-PAD_CTL_DSE_43ohm               (6 << 3)
-PAD_CTL_DSE_37ohm               (7 << 3)
-PAD_CTL_SRE_FAST                (1 << 0)
-PAD_CTL_SRE_SLOW                (0 << 0)
Documentation/devicetree/bindings/pinctrl/fsl,imx6ul-pinctrl.yaml new file +116 -0

116 lines not on this page · raw message

Signature · 1 line
2.43.0
#2 lore raw

PATCH 2/14 dt-bindings: bus: imx-weim: convert to YAML

In reply to Sebastian Reichel

Convert the i.MX Wireless External Interface Module binding to YAML.

---
 .../devicetree/bindings/bus/fsl,imx-weim.yaml | 225 ++++++++++++++++++
 .../devicetree/bindings/bus/imx-weim.txt      | 117 ---------
 2 files changed, 225 insertions(+), 117 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/bus/fsl,imx-weim.yaml
 delete mode 100644 Documentation/devicetree/bindings/bus/imx-weim.txt
Documentation/devicetree/bindings/bus/fsl,imx-weim.yaml new file +225 -0
new file mode 100644
index 000000000000..3d27bdaef304
@@ -0,0 +1,225 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/bus/fsl,imx-weim.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: i.MX Wireless External Interface Module (WEIM)
+
+maintainers:
+  - Shawn Guo <[email protected]>
+  - Sascha Hauer <[email protected]>
+
+description:
+  The term "wireless" does not imply that the WEIM is literally an interface
+  without wires. It simply means that this module was originally designed for
+  wireless and mobile applications that use low-power technology. The actual
+  devices are instantiated from the child nodes of a WEIM node.
+
+properties:
+  compatible:
+    oneOf:
+      - enum:
+          - fsl,imx1-weim
+          - fsl,imx27-weim
+          - fsl,imx50-weim
+          - fsl,imx51-weim
+          - fsl,imx6q-weim
+      - items:
+          - enum:
+              - fsl,imx31-weim
+              - fsl,imx35-weim
+          - const: fsl,imx27-weim
+      - items:
+          - enum:
+              - fsl,imx6sx-weim
+              - fsl,imx6ul-weim
+          - const: fsl,imx6q-weim
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  '#address-cells':
+    const: 2
+
+  '#size-cells':
+    const: 1
+
+  ranges: true
+
+  fsl,weim-cs-gpr:
+    $ref: /schemas/types.yaml#/definitions/phandle
+    description: |
+      Phandle to the system General Purpose Register controller that contains
+      WEIM CS GPR register, e.g. IOMUXC_GPR1 on i.MX6Q. IOMUXC_GPR1[11:0]
+      should be set up as one of the following 4 possible values depending on
+      the CS space configuration.
+
+      IOMUXC_GPR1[11:0]    CS0    CS1    CS2    CS3
+      ---------------------------------------------
+              05          128M     0M     0M     0M
+              033          64M    64M     0M     0M
+              0113         64M    32M    32M     0M
+              01111        32M    32M    32M    32M
+
+      In case that the property is absent, the reset value or what bootloader
+      sets up in IOMUXC_GPR1[11:0] will be used.
+
+  fsl,burst-clk-enable:
+    type: boolean
+    description:
+      The presence of this property indicates that the weim bus should operate
+      in Burst Clock Mode.
+
+  fsl,continuous-burst-clk:
+    type: boolean
+    description:
+      Make Burst Clock to output continuous clock. Without this option Burst
+      Clock will output clock only when necessary.
+
+patternProperties:
+  "^.*@[0-7],[0-9a-f]+$":
+    description: Devices attached to chip selects are represented as subnodes.
+    type: object
+    additionalProperties: true
+    properties:
+      fsl,weim-cs-timing:
+        $ref: /schemas/types.yaml#/definitions/uint32-array
+        description:
+          Timing values for the child node.
+    required:
+      - fsl,weim-cs-timing
+
+allOf:
+  - if:
+      properties:
+        compatible:
+          not:
+            contains:
+              enum:
+                - fsl,imx50-weim
+                - fsl,imx6q-weim
+    then:
+      properties:
+        fsl,weim-cs-gpr: false
+        fsl,burst-clk-enable: false
+  - if:
+      properties:
+        fsl,burst-clk-enable: false
+    then:
+      properties:
+        fsl,continuous-burst-clk: false
+  - if:
+      properties:
+        compatible:
+          contains:
+            const: fsl,imx1-weim
+    then:
+      patternProperties:
+        "^.*@[0-7],[0-9a-f]+$":
+          properties:
+            fsl,weim-cs-timing:
+              items:
+                items:
+                  - description: CSxU
+                  - description: CSxL
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - fsl,imx27-weim
+              - fsl,imx31-weim
+              - fsl,imx35-weim
+    then:
+      patternProperties:
+        "^.*@[0-7],[0-9a-f]+$":
+          properties:
+            fsl,weim-cs-timing:
+              items:
+                items:
+                  - description: CSCRxU
+                  - description: CSCRxL
+                  - description: CSCRxA
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - fsl,imx50-weim
+              - fsl,imx51-weim
+              - fsl,imx6q-weim
+              - fsl,imx6sx-weim
+              - fsl,imx6ul-weim
+    then:
+      patternProperties:
+        "^.*@[0-7],[0-9a-f]+$":
+          properties:
+            fsl,weim-cs-timing:
+              items:
+                items:
+                  - description: CSxGCR1
+                  - description: CSxGCR2
+                  - description: CSxRCR1
+                  - description: CSxRCR2
+                  - description: CSxWCR1
+                  - description: CSxWCR2
+
+required:
+  - compatible
+  - reg
+  - clocks
+  - '#address-cells'
+  - '#size-cells'
+  - ranges
+
+additionalProperties: false
+
+examples:
+  - |
+    weim@21b8000 {
+        compatible = "fsl,imx6q-weim";
+        reg = <0x021b8000 0x4000>;
+        clocks = <&clks 196>;
+        #address-cells = <2>;
+        #size-cells = <1>;
+        ranges = <0 0 0x08000000 0x08000000>;
+        fsl,weim-cs-gpr = <&gpr>;
+
+        nor@0,0 {
+            compatible = "cfi-flash";
+            reg = <0 0 0x02000000>;
+            #address-cells = <1>;
+            #size-cells = <1>;
+            bank-width = <2>;
+            fsl,weim-cs-timing = <0x00620081 0x00000001 0x1c022000
+            0x0000c000 0x1404a38e 0x00000000>;
+        };
+    };
+  - |
+    weim@21b8000 {
+        compatible = "fsl,imx6q-weim";
+        reg = <0x021b8000 0x4000>;
+        clocks = <&clks 196>;
+        #address-cells = <2>;
+        #size-cells = <1>;
+        ranges = <0 0 0x08000000 0x02000000
+                  1 0 0x0a000000 0x02000000
+                  2 0 0x0c000000 0x02000000
+                  3 0 0x0e000000 0x02000000>;
+        fsl,weim-cs-gpr = <&gpr>;
+
+        acme@0,0 {
+            compatible = "acme,whatever";
+            reg = <0 0 0x100>, <0 0x400000 0x800>,
+                  <1 0x400000 0x800>;
+            fsl,weim-cs-timing = <0x024400b1 0x00001010 0x20081100
+                                  0x00000000 0xa0000240 0x00000000>;
+        };
+    };
Documentation/devicetree/bindings/bus/imx-weim.txt deleted +0 -117

117 lines not on this page · raw message

Signature · 1 line
2.43.0
maintainer
#3 lore raw

Re: [PATCH v1 02/14] dt-bindings: bus: imx-weim: convert to YAML

Quoted 10 lines · Sebastian Reichel

Convert the i.MX Wireless External Interface Module binding to YAML.

---
 .../devicetree/bindings/bus/fsl,imx-weim.yaml | 225 ++++++++++++++++++
 .../devicetree/bindings/bus/imx-weim.txt      | 117 ---------
 2 files changed, 225 insertions(+), 117 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/bus/fsl,imx-weim.yaml
 delete mode 100644 Documentation/devicetree/bindings/bus/imx-weim.txt

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/bus/fsl,imx-weim.example.dtb: nor@0,0: $nodename:0: 'nor@0,0' does not match '^(flash|.*sram|nand)(@.*)?$'
from schema $id: http://devicetree.org/schemas/mtd/mtd-physmap.yaml#
Documentation/devicetree/bindings/bus/fsl,imx-weim.example.dtb: /example-1/weim@21b8000/acme@0,0: failed to match any schema with compatible: ['acme,whatever']

doc reference errors (make refcheckdocs):
Warning: drivers/staging/fieldbus/Documentation/devicetree/bindings/fieldbus/arcx,anybus-controller.txt references a file that doesn't exist: Documentation/devicetree/bindings/bus/imx-weim.txt drivers/staging/fieldbus/Documentation/devicetree/bindings/fieldbus/arcx,anybus-controller.txt: Documentation/devicetree/bindings/bus/imx-weim.txt

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]

The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.

#4 lore raw

Re: [PATCH v1 02/14] dt-bindings: bus: imx-weim: convert to YAML

In reply to Sebastian Reichel
Quoted 16 lines · Sebastian Reichel

Convert the i.MX Wireless External Interface Module binding to YAML.

---
 .../devicetree/bindings/bus/fsl,imx-weim.yaml | 225 ++++++++++++++++++
 .../devicetree/bindings/bus/imx-weim.txt      | 117 ---------
 2 files changed, 225 insertions(+), 117 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/bus/fsl,imx-weim.yaml
 delete mode 100644 Documentation/devicetree/bindings/bus/imx-weim.txt
Documentation/devicetree/bindings/bus/fsl,imx-weim.yaml new file +0 -0
new file mode 100644
index 000000000000..3d27bdaef304

Documentation/devicetree/bindings/bus/fsl,imx-weim.yaml line 7

Quoted 7 lines
Documentation/devicetree/bindings/bus/fsl,imx-weim.yaml new file +7 -0
@@ -0,0 +1,225 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/bus/fsl,imx-weim.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: i.MX Wireless External Interface Module (WEIM)

This patchset does not do what I asked to, but maybe that's just coincidence that you send conversion now.

To recall:

https://lore.kernel.org/all/[email protected]/

Quoted 80 lines
Documentation/devicetree/bindings/bus/fsl,imx-weim.yaml new file +80 -0
+
+maintainers:
+  - Shawn Guo <[email protected]>
+  - Sascha Hauer <[email protected]>
+
+description:
+  The term "wireless" does not imply that the WEIM is literally an interface
+  without wires. It simply means that this module was originally designed for
+  wireless and mobile applications that use low-power technology. The actual
+  devices are instantiated from the child nodes of a WEIM node.
+
+properties:
+  compatible:
+    oneOf:
+      - enum:
+          - fsl,imx1-weim
+          - fsl,imx27-weim
+          - fsl,imx50-weim
+          - fsl,imx51-weim
+          - fsl,imx6q-weim
+      - items:
+          - enum:
+              - fsl,imx31-weim
+              - fsl,imx35-weim
+          - const: fsl,imx27-weim
+      - items:
+          - enum:
+              - fsl,imx6sx-weim
+              - fsl,imx6ul-weim
+          - const: fsl,imx6q-weim
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  '#address-cells':
+    const: 2
+
+  '#size-cells':
+    const: 1
+
+  ranges: true
+
+  fsl,weim-cs-gpr:
+    $ref: /schemas/types.yaml#/definitions/phandle
+    description: |
+      Phandle to the system General Purpose Register controller that contains
+      WEIM CS GPR register, e.g. IOMUXC_GPR1 on i.MX6Q. IOMUXC_GPR1[11:0]
+      should be set up as one of the following 4 possible values depending on
+      the CS space configuration.
+
+      IOMUXC_GPR1[11:0]    CS0    CS1    CS2    CS3
+      ---------------------------------------------
+              05          128M     0M     0M     0M
+              033          64M    64M     0M     0M
+              0113         64M    32M    32M     0M
+              01111        32M    32M    32M    32M
+
+      In case that the property is absent, the reset value or what bootloader
+      sets up in IOMUXC_GPR1[11:0] will be used.
+
+  fsl,burst-clk-enable:
+    type: boolean
+    description:
+      The presence of this property indicates that the weim bus should operate
+      in Burst Clock Mode.
+
+  fsl,continuous-burst-clk:
+    type: boolean
+    description:
+      Make Burst Clock to output continuous clock. Without this option Burst
+      Clock will output clock only when necessary.
+
+patternProperties:
+  "^.*@[0-7],[0-9a-f]+$":

Documentation/devicetree/bindings/bus/fsl,imx-weim.yaml line 97

Quoted 10 lines
Documentation/devicetree/bindings/bus/fsl,imx-weim.yaml new file +10 -0
+    description: Devices attached to chip selects are represented as subnodes.
+    type: object
+    additionalProperties: true
+    properties:
+      fsl,weim-cs-timing:
+        $ref: /schemas/types.yaml#/definitions/uint32-array
+        description:
+          Timing values for the child node.
+    required:
+      - fsl,weim-cs-timing

You need to integrate it into mc-peripheral-props.yaml. Also check how other bus controllers define children schema.

required: block goes here.

Documentation/devicetree/bindings/bus/fsl,imx-weim.yaml line 106

Quoted 9 lines
Documentation/devicetree/bindings/bus/fsl,imx-weim.yaml new file +9 -0
+
+allOf:
+  - if:
+      properties:
+        compatible:
+          not:
+            contains:
+              enum:
+                - fsl,imx50-weim

Best regards,
Krzysztof

maintainer
#5 lore raw

Re: [PATCH v1 02/14] dt-bindings: bus: imx-weim: convert to YAML

In reply to Sebastian Reichel
Quoted 103 lines · Sebastian Reichel

Convert the i.MX Wireless External Interface Module binding to YAML.

---
 .../devicetree/bindings/bus/fsl,imx-weim.yaml | 225 ++++++++++++++++++
 .../devicetree/bindings/bus/imx-weim.txt      | 117 ---------
 2 files changed, 225 insertions(+), 117 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/bus/fsl,imx-weim.yaml
 delete mode 100644 Documentation/devicetree/bindings/bus/imx-weim.txt
Documentation/devicetree/bindings/bus/fsl,imx-weim.yaml new file +87 -0
new file mode 100644
index 000000000000..3d27bdaef304
@@ -0,0 +1,225 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/bus/fsl,imx-weim.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: i.MX Wireless External Interface Module (WEIM)
+
+maintainers:
+  - Shawn Guo <[email protected]>
+  - Sascha Hauer <[email protected]>
+
+description:
+  The term "wireless" does not imply that the WEIM is literally an interface
+  without wires. It simply means that this module was originally designed for
+  wireless and mobile applications that use low-power technology. The actual
+  devices are instantiated from the child nodes of a WEIM node.
+
+properties:
+  compatible:
+    oneOf:
+      - enum:
+          - fsl,imx1-weim
+          - fsl,imx27-weim
+          - fsl,imx50-weim
+          - fsl,imx51-weim
+          - fsl,imx6q-weim
+      - items:
+          - enum:
+              - fsl,imx31-weim
+              - fsl,imx35-weim
+          - const: fsl,imx27-weim
+      - items:
+          - enum:
+              - fsl,imx6sx-weim
+              - fsl,imx6ul-weim
+          - const: fsl,imx6q-weim
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  '#address-cells':
+    const: 2
+
+  '#size-cells':
+    const: 1
+
+  ranges: true
+
+  fsl,weim-cs-gpr:
+    $ref: /schemas/types.yaml#/definitions/phandle
+    description: |
+      Phandle to the system General Purpose Register controller that contains
+      WEIM CS GPR register, e.g. IOMUXC_GPR1 on i.MX6Q. IOMUXC_GPR1[11:0]
+      should be set up as one of the following 4 possible values depending on
+      the CS space configuration.
+
+      IOMUXC_GPR1[11:0]    CS0    CS1    CS2    CS3
+      ---------------------------------------------
+              05          128M     0M     0M     0M
+              033          64M    64M     0M     0M
+              0113         64M    32M    32M     0M
+              01111        32M    32M    32M    32M
+
+      In case that the property is absent, the reset value or what bootloader
+      sets up in IOMUXC_GPR1[11:0] will be used.
+
+  fsl,burst-clk-enable:
+    type: boolean
+    description:
+      The presence of this property indicates that the weim bus should operate
+      in Burst Clock Mode.
+
+  fsl,continuous-burst-clk:
+    type: boolean
+    description:
+      Make Burst Clock to output continuous clock. Without this option Burst
+      Clock will output clock only when necessary.
+
+patternProperties:
+  "^.*@[0-7],[0-9a-f]+$":

Documentation/devicetree/bindings/bus/fsl,imx-weim.yaml line 97

Quoted 10 lines
Documentation/devicetree/bindings/bus/fsl,imx-weim.yaml new file +10 -0
+    description: Devices attached to chip selects are represented as subnodes.
+    type: object
+    additionalProperties: true
+    properties:
+      fsl,weim-cs-timing:
+        $ref: /schemas/types.yaml#/definitions/uint32-array
+        description:
+          Timing values for the child node.
+    required:
+      - fsl,weim-cs-timing

This needs to go in its own schema doc and then added to memory-controllers/mc-peripheral-props.yaml

We should probably also move this binding to memory-controllers/

Quoted 79 lines
Documentation/devicetree/bindings/bus/fsl,imx-weim.yaml new file +79 -0
+
+allOf:
+  - if:
+      properties:
+        compatible:
+          not:
+            contains:
+              enum:
+                - fsl,imx50-weim
+                - fsl,imx6q-weim
+    then:
+      properties:
+        fsl,weim-cs-gpr: false
+        fsl,burst-clk-enable: false
+  - if:
+      properties:
+        fsl,burst-clk-enable: false
+    then:
+      properties:
+        fsl,continuous-burst-clk: false
+  - if:
+      properties:
+        compatible:
+          contains:
+            const: fsl,imx1-weim
+    then:
+      patternProperties:
+        "^.*@[0-7],[0-9a-f]+$":
+          properties:
+            fsl,weim-cs-timing:
+              items:
+                items:
+                  - description: CSxU
+                  - description: CSxL
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - fsl,imx27-weim
+              - fsl,imx31-weim
+              - fsl,imx35-weim
+    then:
+      patternProperties:
+        "^.*@[0-7],[0-9a-f]+$":
+          properties:
+            fsl,weim-cs-timing:
+              items:
+                items:
+                  - description: CSCRxU
+                  - description: CSCRxL
+                  - description: CSCRxA
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - fsl,imx50-weim
+              - fsl,imx51-weim
+              - fsl,imx6q-weim
+              - fsl,imx6sx-weim
+              - fsl,imx6ul-weim
+    then:
+      patternProperties:
+        "^.*@[0-7],[0-9a-f]+$":
+          properties:
+            fsl,weim-cs-timing:
+              items:
+                items:
+                  - description: CSxGCR1
+                  - description: CSxGCR2
+                  - description: CSxRCR1
+                  - description: CSxRCR2
+                  - description: CSxWCR1
+                  - description: CSxWCR2
+
+required:
+  - compatible
+  - reg

Documentation/devicetree/bindings/bus/fsl,imx-weim.yaml line 186

Quoted 10 lines
Documentation/devicetree/bindings/bus/fsl,imx-weim.yaml new file +10 -0
+  - clocks
+  - '#address-cells'
+  - '#size-cells'
+  - ranges
+
+additionalProperties: false
+
+examples:
+  - |
+    weim@21b8000 {

bus or external-bus

Quoted 23 lines
Documentation/devicetree/bindings/bus/fsl,imx-weim.yaml new file +23 -0
+        compatible = "fsl,imx6q-weim";
+        reg = <0x021b8000 0x4000>;
+        clocks = <&clks 196>;
+        #address-cells = <2>;
+        #size-cells = <1>;
+        ranges = <0 0 0x08000000 0x08000000>;
+        fsl,weim-cs-gpr = <&gpr>;
+
+        nor@0,0 {
+            compatible = "cfi-flash";
+            reg = <0 0 0x02000000>;
+            #address-cells = <1>;
+            #size-cells = <1>;
+            bank-width = <2>;
+            fsl,weim-cs-timing = <0x00620081 0x00000001 0x1c022000
+            0x0000c000 0x1404a38e 0x00000000>;
+        };
+    };
+  - |
+    weim@21b8000 {
+        compatible = "fsl,imx6q-weim";
+        reg = <0x021b8000 0x4000>;
+        clocks = <&clks 196>;

Documentation/devicetree/bindings/bus/fsl,imx-weim.yaml line 219

Quoted 10 lines
Documentation/devicetree/bindings/bus/fsl,imx-weim.yaml new file +10 -0
+        #address-cells = <2>;
+        #size-cells = <1>;
+        ranges = <0 0 0x08000000 0x02000000
+                  1 0 0x0a000000 0x02000000
+                  2 0 0x0c000000 0x02000000
+                  3 0 0x0e000000 0x02000000>;
+        fsl,weim-cs-gpr = <&gpr>;
+
+        acme@0,0 {
+            compatible = "acme,whatever";

Real bindings only please.

Quoted 6 lines
Documentation/devicetree/bindings/bus/fsl,imx-weim.yaml new file +6 -0
+            reg = <0 0 0x100>, <0 0x400000 0x800>,
+                  <1 0x400000 0x800>;
+            fsl,weim-cs-timing = <0x024400b1 0x00001010 0x20081100
+                                  0x00000000 0xa0000240 0x00000000>;
+        };
+    };
#6 lore raw

Re: [PATCH v1 02/14] dt-bindings: bus: imx-weim: convert to YAML

Hi Rob,

Quoted 6 lines · Rob Herring

[...]

Documentation/devicetree/bindings/bus/fsl,imx-weim.yaml line 186

Quoted 3 lines
Documentation/devicetree/bindings/bus/fsl,imx-weim.yaml new file +3 -0
+examples:
+  - |
+    weim@21b8000 {

bus or external-bus

I used "memory-controller", which is what the other bindings in memory-controller use.

-- Sebastian

#7 lore raw

PATCH 3/14 dt-bindings: sound: fsl,imx-asrc: convert to YAML

In reply to Sebastian Reichel

Convert the i.MX ASRC DT binding to YAML.

---
 .../devicetree/bindings/sound/fsl,asrc.txt    |  80 ---------
 .../bindings/sound/fsl,imx-asrc.yaml          | 159 ++++++++++++++++++
 2 files changed, 159 insertions(+), 80 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/sound/fsl,asrc.txt
 create mode 100644 Documentation/devicetree/bindings/sound/fsl,imx-asrc.yaml
Documentation/devicetree/bindings/sound/fsl,asrc.txt deleted +0 -80
deleted file mode 100644
index 998b4c8a7f78..000000000000
@@ -1,80 +0,0 @@
-Freescale Asynchronous Sample Rate Converter (ASRC) Controller
-
-The Asynchronous Sample Rate Converter (ASRC) converts the sampling rate of a
-signal associated with an input clock into a signal associated with a different
-output clock. The driver currently works as a Front End of DPCM with other Back
-Ends Audio controller such as ESAI, SSI and SAI. It has three pairs to support
-three substreams within totally 10 channels.
-
-Required properties:
-
-  - compatible		: Compatible list, should contain one of the following
-			  compatibles:
-			  "fsl,imx35-asrc",
-			  "fsl,imx53-asrc",
-			  "fsl,imx8qm-asrc",
-			  "fsl,imx8qxp-asrc",
-
-  - reg			: Offset and length of the register set for the device.
-
-  - interrupts		: Contains the spdif interrupt.
-
-  - dmas		: Generic dma devicetree binding as described in
-			  Documentation/devicetree/bindings/dma/dma.txt.
-
-  - dma-names		: Contains "rxa", "rxb", "rxc", "txa", "txb" and "txc".
-
-  - clocks		: Contains an entry for each entry in clock-names.
-
-  - clock-names		: Contains the following entries
-	"mem"		  Peripheral access clock to access registers.
-	"ipg"		  Peripheral clock to driver module.
-	"asrck_<0-f>"	  Clock sources for input and output clock.
-	"spba"		  The spba clock is required when ASRC is placed as a
-			  bus slave of the Shared Peripheral Bus and when two
-			  or more bus masters (CPU, DMA or DSP) try to access
-			  it. This property is optional depending on the SoC
-			  design.
-
-   - fsl,asrc-rate	: Defines a mutual sample rate used by DPCM Back Ends.
-
-   - fsl,asrc-width	: Defines a mutual sample width used by DPCM Back Ends.
-
-   - fsl,asrc-clk-map   : Defines clock map used in driver. which is required
-			  by imx8qm/imx8qxp platform
-			  <0> - select the map for asrc0 in imx8qm/imx8qxp
-			  <1> - select the map for asrc1 in imx8qm/imx8qxp
-
-Optional properties:
-
-   - big-endian		: If this property is absent, the little endian mode
-			  will be in use as default. Otherwise, the big endian
-			  mode will be in use for all the device registers.
-
-   - fsl,asrc-format	: Defines a mutual sample format used by DPCM Back
-			  Ends, which can replace the fsl,asrc-width.
-			  The value is 2 (S16_LE), or 6 (S24_LE).
-
-Example:
-
-asrc: asrc@2034000 {
-	compatible = "fsl,imx53-asrc";
-	reg = <0x02034000 0x4000>;
-	interrupts = <0 50 IRQ_TYPE_LEVEL_HIGH>;
-	clocks = <&clks 107>, <&clks 107>, <&clks 0>,
-	       <&clks 0>, <&clks 0>, <&clks 0>, <&clks 0>,
-	       <&clks 0>, <&clks 0>, <&clks 0>, <&clks 0>,
-	       <&clks 0>, <&clks 0>, <&clks 0>, <&clks 0>,
-	       <&clks 107>, <&clks 0>, <&clks 0>;
-	clock-names = "mem", "ipg", "asrck0",
-		"asrck_1", "asrck_2", "asrck_3", "asrck_4",
-		"asrck_5", "asrck_6", "asrck_7", "asrck_8",
-		"asrck_9", "asrck_a", "asrck_b", "asrck_c",
-		"asrck_d", "asrck_e", "asrck_f";
-	dmas = <&sdma 17 23 1>, <&sdma 18 23 1>, <&sdma 19 23 1>,
-	     <&sdma 20 23 1>, <&sdma 21 23 1>, <&sdma 22 23 1>;
-	dma-names = "rxa", "rxb", "rxc",
-		"txa", "txb", "txc";
-	fsl,asrc-rate  = <48000>;
-	fsl,asrc-width = <16>;
-};
Documentation/devicetree/bindings/sound/fsl,imx-asrc.yaml new file +159 -0

159 lines not on this page · raw message

Signature · 1 line
2.43.0
maintainer
#8 lore raw

Re: [PATCH v1 03/14] dt-bindings: sound: fsl,imx-asrc: convert to YAML

Quoted 1 line · Sebastian Reichel

Convert the i.MX ASRC DT binding to YAML.

Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify relevant patches. Look at what existing commits in the area you're changing are doing and make sure your subject lines visually resemble what they're doing. There's no need to resubmit to fix this alone.

maintainer
#9 lore raw

Re: [PATCH v1 03/14] dt-bindings: sound: fsl,imx-asrc: convert to YAML

In reply to Sebastian Reichel
Quoted 90 lines · Sebastian Reichel

Convert the i.MX ASRC DT binding to YAML.

---
 .../devicetree/bindings/sound/fsl,asrc.txt    |  80 ---------
 .../bindings/sound/fsl,imx-asrc.yaml          | 159 ++++++++++++++++++
 2 files changed, 159 insertions(+), 80 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/sound/fsl,asrc.txt
 create mode 100644 Documentation/devicetree/bindings/sound/fsl,imx-asrc.yaml
Documentation/devicetree/bindings/sound/fsl,imx-asrc.yaml new file +73 -0
new file mode 100644
index 000000000000..bc1607ecf345
@@ -0,0 +1,159 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/fsl,imx-asrc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Freescale Asynchronous Sample Rate Converter (ASRC) Controller
+
+description:
+  The Asynchronous Sample Rate Converter (ASRC) converts the sampling rate of
+  a signal associated with an input clock into a signal associated with a
+  different output clock. The driver currently works as a Front End of DPCM
+  with other Back Ends Audio controller such as ESAI, SSI and SAI. It has
+  three pairs to support three substreams within totally 10 channels.
+
+maintainers:
+  - Shawn Guo <[email protected]>
+  - Sascha Hauer <[email protected]>
+
+properties:
+  compatible:
+    oneOf:
+      - enum:
+          - fsl,imx35-asrc
+          - fsl,imx53-asrc
+          - fsl,imx8qm-asrc
+          - fsl,imx8qxp-asrc
+      - items:
+          - enum:
+              - fsl,imx6sx-asrc
+              - fsl,imx6ul-asrc
+          - const: fsl,imx53-asrc
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  dmas:
+    maxItems: 6
+
+  dma-names:
+    items:
+      - const: rxa
+      - const: rxb
+      - const: rxc
+      - const: txa
+      - const: txb
+      - const: txc
+
+  clocks:
+    maxItems: 19
+
+  clock-names:
+    items:
+      - const: mem
+      - const: ipg
+      - const: asrck_0
+      - const: asrck_1
+      - const: asrck_2
+      - const: asrck_3
+      - const: asrck_4
+      - const: asrck_5
+      - const: asrck_6
+      - const: asrck_7
+      - const: asrck_8
+      - const: asrck_9
+      - const: asrck_a
+      - const: asrck_b
+      - const: asrck_c
+      - const: asrck_d
+      - const: asrck_e

Documentation/devicetree/bindings/sound/fsl,imx-asrc.yaml line 83

Quoted 10 lines
Documentation/devicetree/bindings/sound/fsl,imx-asrc.yaml new file +10 -0
+      - const: asrck_f
+      - const: spba
+
+  fsl,asrc-rate:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    description: The mutual sample rate used by DPCM Back Ends
+
+  fsl,asrc-width:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    description: The mutual sample width used by DPCM Back Ends

Constraints?

Documentation/devicetree/bindings/sound/fsl,imx-asrc.yaml line 90

Quoted 7 lines
Documentation/devicetree/bindings/sound/fsl,imx-asrc.yaml new file +7 -0
+
+  fsl,asrc-clk-map:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    description:
+      Defines clock map used in driver
+      <0> - select the map for asrc0 in imx8qm/imx8qxp
+      <1> - select the map for asrc1 in imx8qm/imx8qxp

Looks like constraints.

Documentation/devicetree/bindings/sound/fsl,imx-asrc.yaml line 103

Quoted 13 lines
Documentation/devicetree/bindings/sound/fsl,imx-asrc.yaml new file +13 -0
+
+  big-endian:
+    type: boolean
+    description:
+      If this property is absent, the little endian mode will be in use as
+      default. Otherwise, the big endian mode will be in use for all the
+      device registers.
+
+  fsl,asrc-format:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    description:
+      Defines a mutual sample format used by DPCM Back Ends, which can
+      replace the fsl,asrc-width. The value is 2 (S16_LE), or 6 (S24_LE).

Looks like constraints.

Quoted 59 lines
Documentation/devicetree/bindings/sound/fsl,imx-asrc.yaml new file +56 -0
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - dmas
+  - dma-names
+  - clocks
+  - clock-names
+  - fsl,asrc-rate
+  - fsl,asrc-width
+
+allOf:
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - fsl,imx8qm-asrc
+              - fsl,imx8qxp-asrc
+    then:
+      required:
+        - fsl,asrc-clk-map
+    else:
+      properties:
+        fsl,asrc-clk-map: false
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/irq.h>
+    #include <dt-bindings/clock/imx6qdl-clock.h>
+    asrc: asrc@2034000 {
+        compatible = "fsl,imx53-asrc";
+        reg = <0x02034000 0x4000>;
+        interrupts = <0 50 IRQ_TYPE_LEVEL_HIGH>;
+        clocks = <&clks IMX6QDL_CLK_ASRC_IPG>,
+                 <&clks IMX6QDL_CLK_ASRC_MEM>, <&clks 0>,
+                 <&clks 0>, <&clks 0>, <&clks 0>, <&clks 0>,
+                 <&clks 0>, <&clks 0>, <&clks 0>, <&clks 0>,
+                 <&clks 0>, <&clks 0>, <&clks 0>, <&clks 0>,
+                 <&clks IMX6QDL_CLK_ASRC>, <&clks 0>, <&clks 0>,
+                 <&clks IMX6QDL_CLK_SPBA>;
+        clock-names = "mem", "ipg", "asrck_0",
+                "asrck_1", "asrck_2", "asrck_3", "asrck_4",
+                "asrck_5", "asrck_6", "asrck_7", "asrck_8",
+                "asrck_9", "asrck_a", "asrck_b", "asrck_c",
+                "asrck_d", "asrck_e", "asrck_f", "spba";
+        dmas = <&sdma 17 23 1>, <&sdma 18 23 1>, <&sdma 19 23 1>,
+               <&sdma 20 23 1>, <&sdma 21 23 1>, <&sdma 22 23 1>;
+        dma-names = "rxa", "rxb", "rxc",
+                    "txa", "txb", "txc";
+        fsl,asrc-rate  = <48000>;
+        fsl,asrc-width = <16>;
+    };
Signature · 1 line
2.43.0
#10 lore raw

PATCH 4/14 dt-bindings: input: touchscreen: fsl,imx6ul-tsc convert to YAML

In reply to Sebastian Reichel

Convert the i.MX6UL touchscreen DT binding to YAML.

---
 .../input/touchscreen/fsl,imx6ul-tsc.yaml     | 92 +++++++++++++++++++
 .../bindings/input/touchscreen/imx6ul_tsc.txt | 38 --------
 2 files changed, 92 insertions(+), 38 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/input/touchscreen/fsl,imx6ul-tsc.yaml
 delete mode 100644 Documentation/devicetree/bindings/input/touchscreen/imx6ul_tsc.txt
Documentation/devicetree/bindings/input/touchscreen/fsl,imx6ul-tsc.yaml new file +92 -0
new file mode 100644
index 000000000000..db18f24978b1
@@ -0,0 +1,92 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/input/touchscreen/fsl,imx6ul-tsc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Freescale i.MX6UL Touch Controller
+
+maintainers:
+  - Haibo Chen <[email protected]>
+  - Shawn Guo <[email protected]>
+  - Sascha Hauer <[email protected]>
+
+properties:
+  compatible:
+    const: fsl,imx6ul-tsc
+
+  reg:
+    items:
+      - description: touch controller address
+      - description: ADC2 address
+
+  interrupts:
+    items:
+      - description: touch controller address
+      - description: ADC2 address
+
+  clocks:
+    maxItems: 2
+
+  clock-names:
+    items:
+      - const: tsc
+      - const: adc
+
+  xnur-gpio:
+    description:
+      The X- gpio this controller connect to. This xnur-gpio returns to
+      low once the finger leave the touch screen (The last touch event
+      the touch controller capture).
+
+  measure-delay-time:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    description:
+      The value of measure delay time. Before X-axis or Y-axis measurement,
+      the screen need some time before even potential distribution ready.
+    default: 0xffff
+    minimum: 0
+    maximum: 0xffffff
+
+  pre-charge-time:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    description:
+      The touch screen need some time to precharge.
+    default: 0xfff
+    minimum: 0
+    maximum: 0xffffffff
+
+  touchscreen-average-samples:
+    description: Number of data samples which are averaged for each read.
+    enum: [ 1, 4, 8, 16, 32 ]
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - clocks
+  - clock-names
+  - xnur-gpio
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/arm-gic.h>
+    #include <dt-bindings/clock/imx6ul-clock.h>
+    #include <dt-bindings/gpio/gpio.h>
+    tsc: tsc@2040000 {
+        compatible = "fsl,imx6ul-tsc";
+        reg = <0x02040000 0x4000>, <0x0219c000 0x4000>;
+        interrupts = <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>,
+                     <GIC_SPI 101 IRQ_TYPE_LEVEL_HIGH>;
+        clocks = <&clks IMX6UL_CLK_IPG>,
+                 <&clks IMX6UL_CLK_ADC2>;
+        clock-names = "tsc", "adc";
+        pinctrl-names = "default";
+        pinctrl-0 = <&pinctrl_tsc>;
+        xnur-gpio = <&gpio1 3 GPIO_ACTIVE_LOW>;
+        measure-delay-time = <0xfff>;
+        pre-charge-time = <0xffff>;
+        touchscreen-average-samples = <32>;
+    };
Documentation/devicetree/bindings/input/touchscreen/imx6ul_tsc.txt deleted +0 -38
deleted file mode 100644
index 164915004424..000000000000
@@ -1,38 +0,0 @@
-* Freescale i.MX6UL Touch Controller
-
-Required properties:
-- compatible: must be "fsl,imx6ul-tsc".
-- reg: this touch controller address and the ADC2 address.
-- interrupts: the interrupt of this touch controller and ADC2.
-- clocks: the root clock of touch controller and ADC2.
-- clock-names; must be "tsc" and "adc".
-- xnur-gpio: the X- gpio this controller connect to.
-  This xnur-gpio returns to low once the finger leave the touch screen (The
-  last touch event the touch controller capture).
-
-Optional properties:
-- measure-delay-time: the value of measure delay time.
-  Before X-axis or Y-axis measurement, the screen need some time before
-  even potential distribution ready.
-  This value depends on the touch screen.
-- pre-charge-time: the touch screen need some time to precharge.
-  This value depends on the touch screen.
-- touchscreen-average-samples: Number of data samples which are averaged for
-  each read. Valid values are 1, 4, 8, 16 and 32.
-
-Example:
-	tsc: tsc@2040000 {
-		compatible = "fsl,imx6ul-tsc";
-		reg = <0x02040000 0x4000>, <0x0219c000 0x4000>;
-		interrupts = <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>,
-			     <GIC_SPI 101 IRQ_TYPE_LEVEL_HIGH>;
-		clocks = <&clks IMX6UL_CLK_IPG>,
-			 <&clks IMX6UL_CLK_ADC2>;
-		clock-names = "tsc", "adc";
-		pinctrl-names = "default";
-		pinctrl-0 = <&pinctrl_tsc>;
-		xnur-gpio = <&gpio1 3 GPIO_ACTIVE_LOW>;
-		measure-delay-time = <0xfff>;
-		pre-charge-time = <0xffff>;
-		touchscreen-average-samples = <32>;
-	};
Signature · 1 line
2.43.0
#11 lore raw

Re: [PATCH v1 04/14] dt-bindings: input: touchscreen: fsl,imx6ul-tsc convert to YAML

Quoted 4 lines · Sebastian Reichel

Convert the i.MX6UL touchscreen DT binding to YAML.

---

...

Quoted 5 lines
Documentation/devicetree/bindings/input/touchscreen/fsl,imx6ul-tsc.yaml new file +5 -0
+
+  interrupts:
+    items:
+      - description: touch controller address
+      - description: ADC2 address

Documentation/devicetree/bindings/input/touchscreen/fsl,imx6ul-tsc.yaml line 36

Quoted 10 lines
Documentation/devicetree/bindings/input/touchscreen/fsl,imx6ul-tsc.yaml new file +10 -0
+
+  clocks:
+    maxItems: 2
+
+  clock-names:
+    items:
+      - const: tsc
+      - const: adc
+
+  xnur-gpio:

xnur-gpios:

Also you need:
maxItems: 1

Documentation/devicetree/bindings/input/touchscreen/fsl,imx6ul-tsc.yaml line 49

Quoted 13 lines
Documentation/devicetree/bindings/input/touchscreen/fsl,imx6ul-tsc.yaml new file +13 -0
+    description:
+      The X- gpio this controller connect to. This xnur-gpio returns to
+      low once the finger leave the touch screen (The last touch event
+      the touch controller capture).
+
+  measure-delay-time:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    description:
+      The value of measure delay time. Before X-axis or Y-axis measurement,
+      the screen need some time before even potential distribution ready.
+    default: 0xffff
+    minimum: 0
+    maximum: 0xffffff

Time seems like something humans can grasp, so why using hexadecimal numbers? Same question for pre-charge-time.

Documentation/devicetree/bindings/input/touchscreen/fsl,imx6ul-tsc.yaml line 60

Quoted 11 lines
Documentation/devicetree/bindings/input/touchscreen/fsl,imx6ul-tsc.yaml new file +11 -0
+
+  pre-charge-time:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    description:
+      The touch screen need some time to precharge.
+    default: 0xfff
+    minimum: 0
+    maximum: 0xffffffff
+
+  touchscreen-average-samples:
+    description: Number of data samples which are averaged for each read.

This should fail the testing - judging by Rob's reports, you did not test it. You don't have type for this property. Missing allOf: to touchscreen.

Documentation/devicetree/bindings/input/touchscreen/fsl,imx6ul-tsc.yaml line 70

Quoted 10 lines
Documentation/devicetree/bindings/input/touchscreen/fsl,imx6ul-tsc.yaml new file +10 -0
+    enum: [ 1, 4, 8, 16, 32 ]
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - clocks
+  - clock-names
+  - xnur-gpio
+

allOf: with $ref to touchscreen.

Documentation/devicetree/bindings/input/touchscreen/fsl,imx6ul-tsc.yaml line 78

Quoted 8 lines
Documentation/devicetree/bindings/input/touchscreen/fsl,imx6ul-tsc.yaml new file +8 -0
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/arm-gic.h>
+    #include <dt-bindings/clock/imx6ul-clock.h>
+    #include <dt-bindings/gpio/gpio.h>
+    tsc: tsc@2040000 {

Drop label and just "touchscreen@2040000"

Best regards,
Krzysztof

#12 lore raw

PATCH 5/14 dt-bindings: soc: imx: fsl,imx-anatop: add binding

In reply to Sebastian Reichel

Add missing binding for i.MX anatop syscon.

---
 .../bindings/soc/imx/fsl,imx-anatop.yaml      | 125 ++++++++++++++++++
 1 file changed, 125 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/soc/imx/fsl,imx-anatop.yaml
Documentation/devicetree/bindings/soc/imx/fsl,imx-anatop.yaml new file +125 -0
new file mode 100644
index 000000000000..436fdae1879e
@@ -0,0 +1,125 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/soc/imx/fsl,imx-anatop.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: ANATOP register
+
+maintainers:
+  - Shawn Guo <[email protected]>
+  - Sascha Hauer <[email protected]>
+
+properties:
+  compatible:
+    oneOf:
+      - items:
+          - enum:
+              - fsl,imx6sl-anatop
+              - fsl,imx6sll-anatop
+              - fsl,imx6sx-anatop
+              - fsl,imx6ul-anatop
+              - fsl,imx7d-anatop
+          - const: fsl,imx6q-anatop
+          - const: syscon
+          - const: simple-mfd
+      - items:
+          - const: fsl,imx6q-anatop
+          - const: syscon
+          - const: simple-mfd
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 3
+
+  tempmon:
+    type: object
+    unevaluatedProperties: false
+    $ref: /schemas/thermal/imx-thermal.yaml
+
+patternProperties:
+  "regulator-((3p0)|(vddcore)|(vddsoc))$":
+    type: object
+    unevaluatedProperties: false
+    $ref: /schemas/regulator/anatop-regulator.yaml
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/clock/imx6ul-clock.h>
+    #include <dt-bindings/interrupt-controller/arm-gic.h>
+
+    anatop: anatop@20c8000 {
+        compatible = "fsl,imx6ul-anatop", "fsl,imx6q-anatop",
+                     "syscon", "simple-mfd";
+        reg = <0x020c8000 0x1000>;
+        interrupts = <GIC_SPI 49 IRQ_TYPE_LEVEL_HIGH>,
+                     <GIC_SPI 54 IRQ_TYPE_LEVEL_HIGH>,
+                     <GIC_SPI 127 IRQ_TYPE_LEVEL_HIGH>;
+
+        reg_3p0: regulator-3p0 {
+            compatible = "fsl,anatop-regulator";
+                regulator-name = "vdd3p0";
+                regulator-min-microvolt = <2625000>;
+                regulator-max-microvolt = <3400000>;
+                anatop-reg-offset = <0x120>;
+                anatop-vol-bit-shift = <8>;
+                anatop-vol-bit-width = <5>;
+                anatop-min-bit-val = <0>;
+                anatop-min-voltage = <2625000>;
+                anatop-max-voltage = <3400000>;
+                anatop-enable-bit = <0>;
+        };
+
+        reg_arm: regulator-vddcore {
+            compatible = "fsl,anatop-regulator";
+                regulator-name = "cpu";
+                regulator-min-microvolt = <725000>;
+                regulator-max-microvolt = <1450000>;
+                regulator-always-on;
+                anatop-reg-offset = <0x140>;
+                anatop-vol-bit-shift = <0>;
+                anatop-vol-bit-width = <5>;
+                anatop-delay-reg-offset = <0x170>;
+                anatop-delay-bit-shift = <24>;
+                anatop-delay-bit-width = <2>;
+                anatop-min-bit-val = <1>;
+                anatop-min-voltage = <725000>;
+                anatop-max-voltage = <1450000>;
+        };
+
+        reg_soc: regulator-vddsoc {
+            compatible = "fsl,anatop-regulator";
+                regulator-name = "vddsoc";
+                regulator-min-microvolt = <725000>;
+                regulator-max-microvolt = <1450000>;
+                regulator-always-on;
+                anatop-reg-offset = <0x140>;
+                anatop-vol-bit-shift = <18>;
+                anatop-vol-bit-width = <5>;
+                anatop-delay-reg-offset = <0x170>;
+                anatop-delay-bit-shift = <28>;
+                anatop-delay-bit-width = <2>;
+                anatop-min-bit-val = <1>;
+                anatop-min-voltage = <725000>;
+                anatop-max-voltage = <1450000>;
+        };
+
+        tempmon: tempmon {
+            compatible = "fsl,imx6ul-tempmon", "fsl,imx6sx-tempmon";
+            interrupt-parent = <&gpc>;
+            interrupts = <GIC_SPI 49 IRQ_TYPE_LEVEL_HIGH>;
+            fsl,tempmon = <&anatop>;
+            nvmem-cells = <&tempmon_calib>, <&tempmon_temp_grade>;
+            nvmem-cell-names = "calib", "temp_grade";
+            clocks = <&clks IMX6UL_CLK_PLL3_USB_OTG>;
+            #thermal-sensor-cells = <0>;
+        };
+    };
Signature · 1 line
2.43.0
#13 lore raw

Re: [PATCH v1 05/14] dt-bindings: soc: imx: fsl,imx-anatop: add binding

Quoted 39 lines · Sebastian Reichel

Add missing binding for i.MX anatop syscon.

---
 .../bindings/soc/imx/fsl,imx-anatop.yaml      | 125 ++++++++++++++++++
 1 file changed, 125 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/soc/imx/fsl,imx-anatop.yaml
Documentation/devicetree/bindings/soc/imx/fsl,imx-anatop.yaml new file +25 -0
new file mode 100644
index 000000000000..436fdae1879e
@@ -0,0 +1,125 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/soc/imx/fsl,imx-anatop.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: ANATOP register
+
+maintainers:
+  - Shawn Guo <[email protected]>
+  - Sascha Hauer <[email protected]>
+
+properties:
+  compatible:
+    oneOf:
+      - items:
+          - enum:
+              - fsl,imx6sl-anatop
+              - fsl,imx6sll-anatop
+              - fsl,imx6sx-anatop
+              - fsl,imx6ul-anatop
+              - fsl,imx7d-anatop
+          - const: fsl,imx6q-anatop
+          - const: syscon
+          - const: simple-mfd

Documentation/devicetree/bindings/soc/imx/fsl,imx-anatop.yaml line 35

Quoted 10 lines
Documentation/devicetree/bindings/soc/imx/fsl,imx-anatop.yaml new file +10 -0
+      - items:
+          - const: fsl,imx6q-anatop
+          - const: syscon
+          - const: simple-mfd
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 3

You need to describe items instead (items: - description: ...)

Documentation/devicetree/bindings/soc/imx/fsl,imx-anatop.yaml line 40

Quoted 5 lines
Documentation/devicetree/bindings/soc/imx/fsl,imx-anatop.yaml new file +5 -0
+
+  tempmon:
+    type: object
+    unevaluatedProperties: false
+    $ref: /schemas/thermal/imx-thermal.yaml

That's confusing. The imx-thermal has phandle to anatop and is a child of it. Please sort it out, e.g. deprecate one way.

Quoted 19 lines
Documentation/devicetree/bindings/soc/imx/fsl,imx-anatop.yaml new file +19 -0
+
+patternProperties:
+  "regulator-((3p0)|(vddcore)|(vddsoc))$":
+    type: object
+    unevaluatedProperties: false
+    $ref: /schemas/regulator/anatop-regulator.yaml
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/clock/imx6ul-clock.h>
+    #include <dt-bindings/interrupt-controller/arm-gic.h>
+
+    anatop: anatop@20c8000 {

Documentation/devicetree/bindings/soc/imx/fsl,imx-anatop.yaml line 69

Quoted 10 lines
Documentation/devicetree/bindings/soc/imx/fsl,imx-anatop.yaml new file +10 -0
+        compatible = "fsl,imx6ul-anatop", "fsl,imx6q-anatop",
+                     "syscon", "simple-mfd";
+        reg = <0x020c8000 0x1000>;
+        interrupts = <GIC_SPI 49 IRQ_TYPE_LEVEL_HIGH>,
+                     <GIC_SPI 54 IRQ_TYPE_LEVEL_HIGH>,
+                     <GIC_SPI 127 IRQ_TYPE_LEVEL_HIGH>;
+
+        reg_3p0: regulator-3p0 {
+            compatible = "fsl,anatop-regulator";
+                regulator-name = "vdd3p0";

Messed indentation.

Best regards,
Krzysztof

#14 lore raw

PATCH 6/14 dt-bindings: soc: imx: fsl,imx-iomuxc-gpr: add imx6

In reply to Sebastian Reichel

Add compatibles used by different i.MX6 variants to the i.MX IOMUX Controller GPR binding.

---
 .../bindings/soc/imx/fsl,imx-iomuxc-gpr.yaml   | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
Documentation/devicetree/bindings/soc/imx/fsl,imx-iomuxc-gpr.yaml +18 -0
index 1da1b758b4ae..6f229ffe20a5 100644
@@ -16,6 +16,24 @@ description:
 properties:
   compatible:
     oneOf:
+      - items:
+          - const: fsl,imx6q-iomuxc-gpr
+          - const: syscon
+          - const: simple-mfd
+      - items:
+          - enum:
+              - fsl,imx6sl-iomuxc-gpr
+              - fsl,imx6sll-iomuxc-gpr
+              - fsl,imx6ul-iomuxc-gpr
+          - const: fsl,imx6q-iomuxc-gpr
+          - const: syscon
+      - items:
+          - enum:
+              - fsl,imx6sx-iomuxc-gpr
+              - fsl,imx7d-iomuxc-gpr
+          - const: fsl,imx6q-iomuxc-gpr
+          - const: syscon
+          - const: simple-mfd
       - items:
           - const: fsl,imx8mq-iomuxc-gpr
           - const: syscon
Signature · 1 line
2.43.0
#15 lore raw

Re: [PATCH v1 06/14] dt-bindings: soc: imx: fsl,imx-iomuxc-gpr: add imx6

Quoted 13 lines · Sebastian Reichel

Add compatibles used by different i.MX6 variants to the i.MX IOMUX Controller GPR binding.

---
 .../bindings/soc/imx/fsl,imx-iomuxc-gpr.yaml   | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
Documentation/devicetree/bindings/soc/imx/fsl,imx-iomuxc-gpr.yaml +0 -0
index 1da1b758b4ae..6f229ffe20a5 100644

Documentation/devicetree/bindings/soc/imx/fsl,imx-iomuxc-gpr.yaml description: · line 20

Quoted 5 lines
Documentation/devicetree/bindings/soc/imx/fsl,imx-iomuxc-gpr.yaml +2 -0
@@ -16,6 +16,24 @@ description:
 properties:
   compatible:
     oneOf:
+      - items:
+          - const: fsl,imx6q-iomuxc-gpr

Just change existing entry to enum and add it there.

Best regards,
Krzysztof

#16 lore raw

PATCH 7/14 dt-bindings: lcdif: Do not require power-domains for i.MX6ULL

In reply to Sebastian Reichel

i.MX6UL(L) uses "fsl,imx6sx-lcdif" as fallback compatible string, but has only very lightweight DISPLAY power domain. Its DISPLAY power domain is not supported by the binding / Linux kernel at the moment. Since the current setup is working, let's remove the power-domain from being required for that platform to fix the warning printed by CHECK_DTBS=y.

Fixes f62678a77d58 ("dt-bindings: mxsfb: Document i.MX8M/i.MX6SX/i.MX6SL power-domains property")
---
 Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/display/fsl,lcdif.yaml +7 -1
index 1c2be8d6f633..0681fc49aa1b 100644
@@ -120,13 +120,19 @@ allOf:
           maxItems: 1
         clock-names:
           maxItems: 1
+  - if:
+      properties:
+        compatible:
+          const: fsl,imx6sx-lcdif
+    then:
+      required:
+        - power-domains
   - if:
       properties:
         compatible:
           contains:
             enum:
               - fsl,imx6sl-lcdif
-              - fsl,imx6sx-lcdif
               - fsl,imx8mm-lcdif
               - fsl,imx8mn-lcdif
               - fsl,imx8mp-lcdif
Signature · 1 line
2.43.0
Acked-by on v1 7/14
#17 lore raw

Re: [PATCH v1 07/14] dt-bindings: lcdif: Do not require power-domains for i.MX6ULL

Quoted 4 lines · Sebastian Reichel

i.MX6UL(L) uses "fsl,imx6sx-lcdif" as fallback compatible string, but has only very lightweight DISPLAY power domain. Its DISPLAY power domain is not supported by the binding / Linux kernel at the moment. Since the current setup is working, let's remove

Best regards,
Krzysztof

#18 lore raw

Re: [PATCH v1 07/14] dt-bindings: lcdif: Do not require power-domains for i.MX6ULL

In reply to Sebastian Reichel

Hi Sebastian,

Am 10.02.24 um 02:18 schrieb Sebastian Reichel:

Quoted 6 lines

i.MX6UL(L) uses "fsl,imx6sx-lcdif" as fallback compatible string, but has only very lightweight DISPLAY power domain. Its DISPLAY power domain is not supported by the binding / Linux kernel at the moment. Since the current setup is working, let's remove the power-domain from being required for that platform to fix the warning printed by CHECK_DTBS=y.

i'm not sure this is a good idea. In case i.MX6UL(L) is different from i.MX6SX here, then it should have a different compatible.

Regards

#19 lore raw

Re: [PATCH v1 07/14] dt-bindings: lcdif: Do not require power-domains for i.MX6ULL

Hi Stefan,

Quoted 9 lines · Stefan Wahren

Am 10.02.24 um 02:18 schrieb Sebastian Reichel:

Quoted 6 lines

i.MX6UL(L) uses "fsl,imx6sx-lcdif" as fallback compatible string, but has only very lightweight DISPLAY power domain. Its DISPLAY power domain is not supported by the binding / Linux kernel at the moment. Since the current setup is working, let's remove the power-domain from being required for that platform to fix the warning printed by CHECK_DTBS=y.

i'm not sure this is a good idea. In case i.MX6UL(L) is different from i.MX6SX here, then it should have a different compatible.

It already has. The i.MX6UL(L) compatible looks like this:

compatible = "fsl,imx6ul-lcdif", "fsl,imx6sx-lcdif"

So the i.MX6SX one is just a fallback compatible. But the current requirement for power-domains affects i.MX6UL(L), since it says the compatible only needs to contain "fsl,imx6sx-lcdif" somewhere to make power-domains mandatory.

Note, that the kernel driver does not use "fsl,imx6ul-lcdif", so the hardware itself is indeed compatible.

-- Sebastian

#20 lore raw

Re: [PATCH v1 07/14] dt-bindings: lcdif: Do not require power-domains for i.MX6ULL

Hi Sebastian,

Am 13.02.24 um 00:10 schrieb Sebastian Reichel:

Quoted 12 lines

Hi Stefan,

Quoted 9 lines · Stefan Wahren

Am 10.02.24 um 02:18 schrieb Sebastian Reichel:

Quoted 6 lines

i.MX6UL(L) uses "fsl,imx6sx-lcdif" as fallback compatible string, but has only very lightweight DISPLAY power domain. Its DISPLAY power domain is not supported by the binding / Linux kernel at the moment. Since the current setup is working, let's remove the power-domain from being required for that platform to fix the warning printed by CHECK_DTBS=y.

i'm not sure this is a good idea. In case i.MX6UL(L) is different from i.MX6SX here, then it should have a different compatible.

Quoted 8 lines

It already has. The i.MX6UL(L) compatible looks like this:

compatible = "fsl,imx6ul-lcdif", "fsl,imx6sx-lcdif"

So the i.MX6SX one is just a fallback compatible. But the current requirement for power-domains affects i.MX6UL(L), since it says the compatible only needs to contain "fsl,imx6sx-lcdif" somewhere to make power-domains mandatory.

thanks, i misunderstood the commit message. I thought this was a i.MX6UL(L) specific issue and the i.MX6SX is slightly different. In the past the fallback compatible was sometimes abused.

So everything makes sense now.

Quoted 9 lines

Note, that the kernel driver does not use "fsl,imx6ul-lcdif", so the hardware itself is indeed compatible.

-- Sebastian

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#21 lore raw

PATCH 8/14 dt-bindings: fsl-imx-sdma: fix HDMI audio index

In reply to Sebastian Reichel

HDMI Audio has been added to the DT binding documentation with an incorrect index. DT and the driver use index 26. This happened, because the binding is missing MULTI_SAI type, which is using index 25.

Fixes 7bdbd87d4008 ("dt-bindings: fsl-imx-sdma: Convert imx sdma to DT schema")
---
 Documentation/devicetree/bindings/dma/fsl,imx-sdma.yaml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/dma/fsl,imx-sdma.yaml +2 -1
index b95dd8db5a30..37135fa024f9 100644
@@ -92,7 +92,8 @@ properties:
               description: needs firmware more than ver 2
           - Shared ASRC: 23
           - SAI: 24
-          - HDMI Audio: 25
+          - Multi SAI: 25
+          - HDMI Audio: 26
 
        The third cell: transfer priority ID
          enum:
Signature · 1 line
2.43.0
Acked-by on v1 8/14
#22 lore raw

Re: [PATCH v1 08/14] dt-bindings: fsl-imx-sdma: fix HDMI audio index

Quoted 9 lines · Sebastian Reichel

HDMI Audio has been added to the DT binding documentation with an incorrect index. DT and the driver use index 26. This happened, because the binding is missing MULTI_SAI type, which is using index 25.

Fixes 7bdbd87d4008 ("dt-bindings: fsl-imx-sdma: Convert imx sdma to DT schema")

---

Best regards,
Krzysztof

#23 lore raw

PATCH 9/14 ARM: dts: imx6ull: fix pinctrl node name

In reply to Sebastian Reichel

pinctrl node name must be either pinctrl or pinmux.

---
 arch/arm/boot/dts/nxp/imx/imx6ull.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/nxp/imx/imx6ull.dtsi +1 -1
index 2bccd45e9fc2..8a1776067ecc 100644
@@ -75,7 +75,7 @@ rngb: rng@2284000 {
 				clocks = <&clks IMX6UL_CLK_DUMMY>;
 			};
 
-			iomuxc_snvs: iomuxc-snvs@2290000 {
+			iomuxc_snvs: pinctrl@2290000 {
 				compatible = "fsl,imx6ull-iomuxc-snvs";
 				reg = <0x02290000 0x4000>;
 			};
Signature · 1 line
2.43.0
#25 lore raw

PATCH 10/14 ARM: dts: imx6ul: Remove fsl,anatop from usbotg1

In reply to Sebastian Reichel

fsl,anatop should only be added to the usbphy nodes.

---
 arch/arm/boot/dts/nxp/imx/imx6ul.dtsi | 1 -
 1 file changed, 1 deletion(-)
arch/arm/boot/dts/nxp/imx/imx6ul.dtsi +0 -1
index a27a7554c2e7..9eb4eee0c272 100644
@@ -855,7 +855,6 @@ usbotg1: usb@2184000 {
 				clocks = <&clks IMX6UL_CLK_USBOH3>;
 				fsl,usbphy = <&usbphy1>;
 				fsl,usbmisc = <&usbmisc 0>;
-				fsl,anatop = <&anatop>;
 				ahb-burst-config = <0x0>;
 				tx-burst-size-dword = <0x10>;
 				rx-burst-size-dword = <0x10>;
Signature · 1 line
2.43.0
#26 lore raw

PATCH 11/14 ARM: dts: imx6ul: add missing #thermal-sensor-cells

In reply to Sebastian Reichel

Fix the following warning found via CHECK_DTBS:

tempmon: '#thermal-sensor-cells' is a required property

---
 arch/arm/boot/dts/nxp/imx/imx6ul.dtsi | 1 +
 1 file changed, 1 insertion(+)
arch/arm/boot/dts/nxp/imx/imx6ul.dtsi +1 -0
index 9eb4eee0c272..45b7605ac381 100644
@@ -638,6 +638,7 @@ tempmon: tempmon {
 					nvmem-cells = <&tempmon_calib>, <&tempmon_temp_grade>;
 					nvmem-cell-names = "calib", "temp_grade";
 					clocks = <&clks IMX6UL_CLK_PLL3_USB_OTG>;
+					#thermal-sensor-cells = <0>;
 				};
 			};
 
Signature · 1 line
2.43.0
#27 lore raw

PATCH 12/14 dt-bindings: vendor-prefixes: add UNI-T

In reply to Sebastian Reichel

Uni-Trend Technology is a manufacturer of measurement and testing tools.

---
 Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/vendor-prefixes.yaml +2 -0
index 1a0dc04f1db4..e945e76696c2 100644
@@ -1484,6 +1484,8 @@ patternProperties:
     description: Ufi Space Co., Ltd.
   "^ugoos,.*":
     description: Ugoos Industrial Co., Ltd.
+  "^uni-t,.*":
+    description: Uni-Trend Technology (China) Co., Ltd.
   "^uniwest,.*":
     description: United Western Technologies Corp (UniWest)
   "^upisemi,.*":
Signature · 1 line
2.43.0
#29 lore raw

PATCH 13/14 dt-bindings: arm: add UNI-T UTi260b

In reply to Sebastian Reichel

Add compatible value for i.MX6ULL based UNI-T
UTi260b thermal camera.

---
 Documentation/devicetree/bindings/arm/fsl.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/fsl.yaml +1 -0
index 228dcc5c7d6f..fa20c2699530 100644
@@ -708,6 +708,7 @@ properties:
               - toradex,colibri-imx6ull      # Colibri iMX6ULL Modules
               - toradex,colibri-imx6ull-emmc # Colibri iMX6ULL 1GB (eMMC) Module
               - toradex,colibri-imx6ull-wifi # Colibri iMX6ULL Wi-Fi / BT Modules
+              - uni-t,imx6ull-uti260b   # UNI-T UTi260b
           - const: fsl,imx6ull
 
       - description: i.MX6ULL Armadeus Systems OPOS6ULDev Board
Signature · 1 line
2.43.0
#30 lore raw

Re: [PATCH v1 13/14] dt-bindings: arm: add UNI-T UTi260b

Quoted 13 lines · Sebastian Reichel

Add compatible value for i.MX6ULL based UNI-T
UTi260b thermal camera.

---
 Documentation/devicetree/bindings/arm/fsl.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/fsl.yaml +0 -0
index 228dcc5c7d6f..fa20c2699530 100644

Documentation/devicetree/bindings/arm/fsl.yaml properties: · line 711

Quoted 4 lines
Documentation/devicetree/bindings/arm/fsl.yaml +1 -0
@@ -708,6 +708,7 @@ properties:
               - toradex,colibri-imx6ull      # Colibri iMX6ULL Modules
               - toradex,colibri-imx6ull-emmc # Colibri iMX6ULL 1GB (eMMC) Module
               - toradex,colibri-imx6ull-wifi # Colibri iMX6ULL Wi-Fi / BT Modules
+              - uni-t,imx6ull-uti260b   # UNI-T UTi260b

If the product name is "uti260b", then it is enough "uni-t,uti260b". If you added the imx part because there is a SoM, then it is anyway not correct representation of the SoM.

Best regards,
Krzysztof

#31 lore raw

PATCH 14/14 ARM: dts: imx6ull-uti260b: Add board

In reply to Sebastian Reichel

Add UNI-T UTi260b thermal camera board.

---
 arch/arm/boot/dts/nxp/imx/Makefile            |   1 +
 arch/arm/boot/dts/nxp/imx/imx6ull-uti260b.dts | 564 ++++++++++++++++++
 2 files changed, 565 insertions(+)
 create mode 100644 arch/arm/boot/dts/nxp/imx/imx6ull-uti260b.dts
arch/arm/boot/dts/nxp/imx/Makefile +1 -0
index a724d1a7a9a0..47350cf3ddeb 100644
@@ -349,6 +349,7 @@ dtb-$(CONFIG_SOC_IMX6UL) += \
 	imx6ull-tarragon-slavext.dtb \
 	imx6ull-tqma6ull2-mba6ulx.dtb \
 	imx6ull-tqma6ull2l-mba6ulx.dtb \
+	imx6ull-uti260b.dtb \
 	imx6ulz-14x14-evk.dtb \
 	imx6ulz-bsh-smm-m2.dtb
 dtb-$(CONFIG_SOC_IMX7D) += \
arch/arm/boot/dts/nxp/imx/imx6ull-uti260b.dts new file +564 -0

564 lines not on this page · raw message

Signature · 1 line
2.43.0
#32 lore raw

Re: [PATCH v1 14/14] ARM: dts: imx6ull-uti260b: Add board

Hi Sebastian,

Am 10.02.24 um 02:18 schrieb Sebastian Reichel:

Quoted 27 lines

Add UNI-T UTi260b thermal camera board.

---
  arch/arm/boot/dts/nxp/imx/Makefile            |   1 +
  arch/arm/boot/dts/nxp/imx/imx6ull-uti260b.dts | 564 ++++++++++++++++++
  2 files changed, 565 insertions(+)

create mode 100644 arch/arm/boot/dts/nxp/imx/imx6ull-uti260b.dts

arch/arm/boot/dts/nxp/imx/Makefile +1 -0
index a724d1a7a9a0..47350cf3ddeb 100644
@@ -349,6 +349,7 @@ dtb-$(CONFIG_SOC_IMX6UL) += \
  	imx6ull-tarragon-slavext.dtb \
  	imx6ull-tqma6ull2-mba6ulx.dtb \
  	imx6ull-tqma6ull2l-mba6ulx.dtb \
+	imx6ull-uti260b.dtb \
  	imx6ulz-14x14-evk.dtb \
  	imx6ulz-bsh-smm-m2.dtb
  dtb-$(CONFIG_SOC_IMX7D) += \
arch/arm/boot/dts/nxp/imx/imx6ull-uti260b.dts new file +0 -0
new file mode 100644
index 000000000000..336727895fa4

arch/arm/boot/dts/nxp/imx/imx6ull-uti260b.dts line 2

Quoted 2 lines
arch/arm/boot/dts/nxp/imx/imx6ull-uti260b.dts new file +2 -0
@@ -0,0 +1,564 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+// Copyright (C) 2022 Sebastian Reichel <[email protected]>

2024 ?

Quoted 17 lines
arch/arm/boot/dts/nxp/imx/imx6ull-uti260b.dts new file +17 -0
+
+/dts-v1/;
+#include "imx6ull.dtsi"
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/input/input.h>
+#include <dt-bindings/clock/imx6ul-clock.h>
+
+/ {
+	model = "UNI-T UTi260B Thermal Camera";
+	compatible = "uni-t,imx6ull-uti260b", "fsl,imx6ull";
+
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
+	memory@80000000 {
+		device_type = "memory";

arch/arm/boot/dts/nxp/imx/imx6ull-uti260b.dts line 29

Quoted 10 lines
arch/arm/boot/dts/nxp/imx/imx6ull-uti260b.dts new file +10 -0
+		reg = <0x80000000 0x20000000>;
+	};
+
+	leds {
+		compatible = "gpio-leds";
+		pinctrl-names = "default";
+		pinctrl-0 = <&mux_led_ctrl>;
+
+		led {
+			label = "led";

The label property is deprecated, please use color and function instead.

Quoted 74 lines
arch/arm/boot/dts/nxp/imx/imx6ull-uti260b.dts new file +74 -0
+			gpios = <&gpio2 2 GPIO_ACTIVE_HIGH>;
+			default-state = "off";
+		};
+	};
+
+	gpio-keys {
+		compatible = "gpio-keys";
+		pinctrl-names = "default";
+		pinctrl-0 = <&mux_gpio_keys>;
+		autorepeat;
+
+		up-key {
+			label = "Up";
+			gpios = <&gpio2 11 GPIO_ACTIVE_LOW>;
+			linux,code = <KEY_UP>;
+		};
+
+		down-key {
+			label = "Down";
+			gpios = <&gpio2 12 GPIO_ACTIVE_LOW>;
+			linux,code = <KEY_DOWN>;
+		};
+
+		left-key {
+			label = "Left";
+			gpios = <&gpio2 13 GPIO_ACTIVE_LOW>;
+			linux,code = <KEY_LEFT>;
+		};
+
+		right-key {
+			label = "Right";
+			gpios = <&gpio2 10 GPIO_ACTIVE_LOW>;
+			linux,code = <KEY_RIGHT>;
+		};
+
+		ok-key {
+			label = "Ok";
+			gpios = <&gpio2 9 GPIO_ACTIVE_LOW>;
+			linux,code = <KEY_ENTER>;
+		};
+
+		return-key {
+			label = "Return";
+			gpios = <&gpio2 15 GPIO_ACTIVE_LOW>;
+			linux,code = <KEY_ESC>;
+		};
+
+		play-key {
+			label = "Media";
+			gpios = <&gpio2 8 GPIO_ACTIVE_LOW>;
+			linux,code = <KEY_MEDIA>;
+		};
+
+		trigger-key {
+			label = "Trigger";
+			gpios = <&gpio2 14 GPIO_ACTIVE_LOW>;
+			linux,code = <BTN_TRIGGER>;
+		};
+
+		power-key {
+			label = "Power";
+			gpios = <&gpio2 3 GPIO_ACTIVE_LOW>;
+			linux,code = <KEY_POWER>;
+		};
+
+		light-key {
+			label = "Light";
+			gpios = <&gpio2 1 GPIO_ACTIVE_LOW>;
+			linux,code = <KEY_LIGHTS_TOGGLE>;
+		};
+	};
+
+	panel_backlight: backlight {
+		compatible = "pwm-backlight";

arch/arm/boot/dts/nxp/imx/imx6ull-uti260b.dts line 113

Quoted 10 lines
arch/arm/boot/dts/nxp/imx/imx6ull-uti260b.dts new file +10 -0
+		brightness-levels = <0 4 8 16 32 64 128 255>;
+		default-brightness-level = <6>;
+		enable-gpios = <&gpio1 9 GPIO_ACTIVE_LOW>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&mux_backlight_enable>;
+		power-supply = <&reg_vsd>;
+		pwms = <&pwm1 0 50000 0>;
+	};
+
+	reg_vsd: regulator-vsd {

i think the node name should be just "regulator"

arch/arm/boot/dts/nxp/imx/imx6ull-uti260b.dts line 120

Quoted 7 lines
arch/arm/boot/dts/nxp/imx/imx6ull-uti260b.dts new file +7 -0
+		compatible = "regulator-fixed";
+		regulator-name = "VSD_3V3";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+	};
+
+	reg_vref: regulator-vref-4v2 {

dito

Quoted 39 lines
arch/arm/boot/dts/nxp/imx/imx6ull-uti260b.dts new file +39 -0
+		compatible = "regulator-fixed";
+		regulator-name = "VREF_4V2";
+		regulator-min-microvolt = <4200000>;
+		regulator-max-microvolt = <4200000>;
+	};
+
+	tp5000: charger {
+		compatible = "gpio-charger";
+		charger-type = "usb-sdp";
+		gpios = <&gpio1 1 GPIO_ACTIVE_LOW>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&mux_charger_stat1>;
+	};
+
+	battery: battery {
+		compatible = "simple-battery";
+		/* generic 26650 battery */
+		device-chemistry = "lithium-ion";
+		charge-full-design-microamp-hours = <5000000>;
+		voltage-max-design-microvolt = <4200000>;
+		voltage-min-design-microvolt = <3300000>;
+	};
+
+	fuel-gauge {
+		compatible = "adc-battery";
+		charged-gpios = <&gpio1 2 GPIO_ACTIVE_LOW>;
+		io-channel-names = "voltage";
+		io-channels = <&adc1 7>;
+		monitored-battery = <&battery>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&mux_charger_stat2>;
+		power-supplies = <&tp5000>;
+	};
+
+	poweroff {
+		compatible = "gpio-poweroff";
+		gpios = <&gpio2 4 GPIO_ACTIVE_LOW>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&mux_poweroff>;

arch/arm/boot/dts/nxp/imx/imx6ull-uti260b.dts line 169

Quoted 10 lines
arch/arm/boot/dts/nxp/imx/imx6ull-uti260b.dts new file +10 -0
+	};
+};
+
+&gpio1 {
+	ir-reset-hog {
+		gpio-hog;
+		gpios = <3 GPIO_ACTIVE_LOW>;
+		line-name = "ir-reset-gpio";
+		output-low;
+		pinctrl-0 = <&mux_ir_reset>;

Doesn't this miss pinctrl-names = "default" ?

Quoted 18 lines
arch/arm/boot/dts/nxp/imx/imx6ull-uti260b.dts new file +18 -0
+	};
+};
+
+&gpio2 {
+	/* configuring this to output-high results in poweroff */
+	power-en-hog {
+		gpio-hog;
+		gpios = <6 GPIO_ACTIVE_HIGH>;
+		line-name = "power-en-gpio";
+		output-low;
+		pinctrl-0 = <&mux_poweroff2>;
+	};
+};
+
+&ecspi3 {
+	cs-gpios = <&gpio1 20 GPIO_ACTIVE_LOW>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&mux_spi3>, <&mux_spi3_cs>;

arch/arm/boot/dts/nxp/imx/imx6ull-uti260b.dts line 197

Quoted 10 lines
arch/arm/boot/dts/nxp/imx/imx6ull-uti260b.dts new file +10 -0
+	status = "okay";
+
+	panel@0 {
+		compatible = "inanbo,t28cp45tn89-v17";
+		reg = <0>;
+		backlight = <&panel_backlight>;
+		power-supply = <&reg_vsd>;
+		spi-cpha;
+		spi-cpol;
+		spi-max-frequency = <100000>;

This seems slow to me. Is this a limitation of the display?

Quoted 81 lines
arch/arm/boot/dts/nxp/imx/imx6ull-uti260b.dts new file +81 -0
+		spi-rx-bus-width = <0>;
+
+		port {
+			panel_in: endpoint {
+				remote-endpoint = <&display_out>;
+			};
+		};
+	};
+};
+
+&uart1 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&mux_uart>;
+	status = "okay";
+};
+
+&pwm1 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&mux_pwm>;
+	status = "okay";
+};
+
+&i2c1 {
+	clock-frequency = <100000>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&mux_i2c1>;
+	status = "okay";
+
+	camera@21 {
+		compatible = "galaxycore,gc0308";
+		reg = <0x21>;
+		clocks = <&clks IMX6UL_CLK_CSI>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&mux_gc0308>;
+		powerdown-gpios = <&gpio1 5 GPIO_ACTIVE_HIGH>;
+		reset-gpios = <&gpio1 6 GPIO_ACTIVE_LOW>;
+		vdd28-supply = <&reg_vsd>;
+
+		port {
+			gc0308_to_parallel: endpoint {
+				remote-endpoint = <&parallel_from_gc0308>;
+				bus-width = <8>;
+				data-shift = <2>; /* lines 9:2 are used */
+				hsync-active = <1>; /* active high */
+				vsync-active = <1>; /* active high */
+				data-active = <1>; /* active high */
+				pclk-sample = <1>; /* sample on rising edge */
+			};
+		};
+	};
+};
+
+&csi {
+	status = "okay";
+	pinctrl-names = "default";
+	pinctrl-0 = <&mux_csi>;
+
+	port {
+		parallel_from_gc0308: endpoint {
+			remote-endpoint = <&gc0308_to_parallel>;
+		};
+	};
+};
+
+&i2c2 {
+	clock-frequency = <100000>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&mux_i2c2>;
+	status = "okay";
+
+	rtc@51 {
+		compatible = "nxp,pcf8563";
+		reg = <0x51>;
+	};
+};
+
+&lcdif {
+	assigned-clocks = <&clks IMX6UL_CLK_LCDIF_PRE_SEL>;
+	assigned-clock-parents = <&clks IMX6UL_CLK_PLL5_VIDEO_DIV>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&mux_lcd_data>, <&mux_lcd_ctrl>;

arch/arm/boot/dts/nxp/imx/imx6ull-uti260b.dts line 288

Quoted 10 lines
arch/arm/boot/dts/nxp/imx/imx6ull-uti260b.dts new file +10 -0
+	status = "okay";
+
+	port {
+		display_out: endpoint {
+			remote-endpoint = <&panel_in>;
+		};
+	};
+};
+
+&usdhc1 {

Would be nice to place a comment above this, which mentions the intended use case: eMMC, SD card, ...

arch/arm/boot/dts/nxp/imx/imx6ull-uti260b.dts line 301

Quoted 13 lines
arch/arm/boot/dts/nxp/imx/imx6ull-uti260b.dts new file +13 -0
+	cd-gpios = <&gpio1 19 GPIO_ACTIVE_LOW>;
+	keep-power-in-suspend;
+	no-1-8-v;
+	pinctrl-names = "default", "state_100mhz", "state_200mhz";
+	pinctrl-0 = <&mux_sdhc1>, <&mux_sdhc1_cd>;
+	pinctrl-1 = <&mux_sdhc1_100mhz>, <&mux_sdhc1_cd>;
+	pinctrl-2 = <&mux_sdhc1_200mhz>, <&mux_sdhc1_cd>;
+	wakeup-source;
+	vmmc-supply = <&reg_vsd>;
+	status = "okay";
+};
+
+&usdhc2 {

dito

Best regards

Quoted 23 lines
arch/arm/boot/dts/nxp/imx/imx6ull-uti260b.dts new file +22 -0
+	keep-power-in-suspend;
+	no-1-8-v;
+	non-removable;
+	pinctrl-names = "default";
+	pinctrl-0 = <&mux_sdhc2>;
+	wakeup-source;
+	status = "okay";
+};
+
+&wdog1 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&mux_wdog>;
+};
+
+&adc1 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&mux_adc>;
+	vref-supply = <&reg_vref>;
+	#io-channel-cells = <1>;
+	status = "okay";
+};
+
#33 lore raw

Re: [PATCH v1 14/14] ARM: dts: imx6ull-uti260b: Add board

Hi Stefan,

Quoted 10 lines · Stefan Wahren

arch/arm/boot/dts/nxp/imx/imx6ull-uti260b.dts line 113

Quoted 1 line
arch/arm/boot/dts/nxp/imx/imx6ull-uti260b.dts new file +1 -0
+	reg_vsd: regulator-vsd {

i think the node name should be just "regulator"

arch/arm/boot/dts/nxp/imx/imx6ull-uti260b.dts line 120

Quoted 7 lines
arch/arm/boot/dts/nxp/imx/imx6ull-uti260b.dts new file +7 -0
+		compatible = "regulator-fixed";
+		regulator-name = "VSD_3V3";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+	};
+
+	reg_vref: regulator-vref-4v2 {

dito

The nodename must be unique. So just "regulator" does not work. In the past this was sometimes solved by adding something like @0, which is part of the nodename. But that is not ok, since there is no reg property.

Quoted 8 lines
Quoted 8 lines

+&ecspi3 {

arch/arm/boot/dts/nxp/imx/imx6ull-uti260b.dts new file +7 -0
+	cs-gpios = <&gpio1 20 GPIO_ACTIVE_LOW>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&mux_spi3>, <&mux_spi3_cs>;
+	status = "okay";
+
+	panel@0 {
+		compatible = "inanbo,t28cp45tn89-v17";
Quoted 8 lines

arch/arm/boot/dts/nxp/imx/imx6ull-uti260b.dts line 197

Quoted 6 lines
arch/arm/boot/dts/nxp/imx/imx6ull-uti260b.dts new file +6 -0
+		reg = <0>;
+		backlight = <&panel_backlight>;
+		power-supply = <&reg_vsd>;
+		spi-cpha;
+		spi-cpol;
+		spi-max-frequency = <100000>;

This seems slow to me. Is this a limitation of the display?

I just used something slow, which should definitely work. I will try to increase to 1MHz. Note, that the display is not driven via SPI. SPI is just used for the configuration.

Thanks for the review,

-- Sebastian

#34 lore raw

Re: [PATCH v1 14/14] ARM: dts: imx6ull-uti260b: Add board

Quoted 15 lines
Quoted 7 lines
Quoted 7 lines

+&ecspi3 {

arch/arm/boot/dts/nxp/imx/imx6ull-uti260b.dts new file +6 -0
+	cs-gpios = <&gpio1 20 GPIO_ACTIVE_LOW>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&mux_spi3>, <&mux_spi3_cs>;
+	status = "okay";
+
+	panel@0 {
Quoted 8 lines

arch/arm/boot/dts/nxp/imx/imx6ull-uti260b.dts line 197

Quoted 7 lines
arch/arm/boot/dts/nxp/imx/imx6ull-uti260b.dts new file +7 -0
+		compatible = "inanbo,t28cp45tn89-v17";
+		reg = <0>;
+		backlight = <&panel_backlight>;
+		power-supply = <&reg_vsd>;
+		spi-cpha;
+		spi-cpol;
+		spi-max-frequency = <100000>;

This seems slow to me. Is this a limitation of the display?

Quoted 3 lines

I just used something slow, which should definitely work. I will try to increase to 1MHz. Note, that the display is not driven via SPI. SPI is just used for the configuration.

Thanks for clarification. Yes, 1 MHz would be better.

Quoted 4 lines

Thanks for the review,

-- Sebastian