linux-next: build failure after merge of the vfs-brauner tree
Subsystems (2)
Hi all,
After merging the vfs-brauner tree, today's linux-next build (x86_64 allmodconfig) failed like this:
In file included from include/linux/highmem.h:5,
from include/linux/bvec.h:10,
from include/linux/blk_types.h:10,
from include/linux/blkdev.h:9,
from fs/btrfs/super.c:6:include/linux/fs.h: In function 'super_set_sysfs_name_generic':include/linux/fs.h:2597:9: error: function 'super_set_sysfs_name_generic' might be a candidate for 'gnu_printf' format attribute [-Werror=suggest-attribute=format]
2597 | vsnprintf(sb->s_sysfs_name, sizeof(sb->s_sysfs_name), fmt, args);
| ^~~~~~~~~cc1: all warnings being treated as errors
and many more similar.
Caused by commit
eeea5d25d4a7 ("fs: add FS_IOC_GETFSSYSFSPATH")
This new finction is not used anywhere, so just remove it for now?
I have used the vfs-brauner tree from next-20240209 for today.
Signature · 2 lines
Cheers, Stephen Rothwell
Quoted 16 lines · Stephen Rothwell
Hi all,
After merging the vfs-brauner tree, today's linux-next build (
x86_64allmodconfig) failed like this:In file included from
include/linux/highmem.h:5,
frominclude/linux/bvec.h:10,
frominclude/linux/blk_types.h:10,
frominclude/linux/blkdev.h:9,
fromfs/btrfs/super.c:6:include/linux/fs.h: In function 'super_set_sysfs_name_generic':include/linux/fs.h:2597:9: error: function 'super_set_sysfs_name_generic' might be a candidate for 'gnu_printf' format attribute [-Werror=suggest-attribute=format]2597 | vsnprintf(sb->s_sysfs_name, sizeof(sb->s_sysfs_name), fmt, args); | ^~~~~~~~~cc1: all warnings being treated as errors
Quoted 7 lines
and many more similar.
Caused by commit
eeea5d25d4a7("fs: addFS_IOC_GETFSSYSFSPATH")This new finction is not used anywhere, so just remove it for now?
Let's not drop it; people adding support for other filesystems will probably want it. Here's a fixup patch:
-- >8 --
From baf60243a686b0dca9236110491694bd03378063 Mon Sep 17 00:00:00 2001
From: Kent Overstreet <[email protected]>
Date: Sun, 11 Feb 2024 19:34:56 -0500
Subject: [PATCH] fixup! fs: FS_IOC_GETSYSFSPATH
include/linux/fs.h +1 -0
@@ -2574,6 +2574,7 @@ static inline void super_set_sysfs_name_id(struct super_block *sb) }/* try to use something standard before you use this */ +__printf(2, 3)static inline void super_set_sysfs_name_generic (struct super_block *sb,const char *fmt, ...) {va_list args;