wifi: iwlwifi: fix #ifdef CONFIG_ACPI check
PATCH 1/1 wifi: iwlwifi: fix #ifdef CONFIG_ACPI check
From: Arnd Bergmann <[email protected]>
The #ifdef check around the function definitionm for two functions was changed without also changing the one on the declaration:
drivers/net/wireless/intel/iwlwifi/fw/uefi.c:359:6: error: redefinition of 'iwl_uefi_get_sgom_table'
359 | void iwl_uefi_get_sgom_table(struct iwl_trans *trans,
| ^~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/net/wireless/intel/iwlwifi/fw/uefi.c:11:
drivers/net/wireless/intel/iwlwifi/fw/uefi.h:294:6: note: previous definition of 'iwl_uefi_get_sgom_table' with type 'void(struct iwl_trans *, struct iwl_fw_runtime *)'
294 | void iwl_uefi_get_sgom_table(struct iwl_trans *trans, struct iwl_fw_runtime *fwrt)
| ^~~~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/intel/iwlwifi/fw/uefi.c:392:5: error: redefinition of 'iwl_uefi_get_uats_table'
392 | int iwl_uefi_get_uats_table(struct iwl_trans *trans,
| ^~~~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/intel/iwlwifi/fw/uefi.h:299:5: note: previous definition of 'iwl_uefi_get_uats_table' with type 'int(struct iwl_trans *, struct iwl_fw_runtime *)'
299 | int iwl_uefi_get_uats_table(struct iwl_trans *trans,
| ^~~~~~~~~~~~~~~~~~~~~~~Adapt it by merging the declarations into the existing #ifdef block.
Fixes 74f4cd710705 ("wifi: iwlwifi: take SGOM and UATS code out of ACPI ifdef")
Signed-off-by Arnd Bergmann <[email protected]>
--- drivers/net/wireless/intel/iwlwifi/fw/uefi.h | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-)
drivers/net/wireless/intel/iwlwifi/fw/uefi.h +4 -7
@@ -204,6 +204,9 @@ int iwl_uefi_get_mcc(struct iwl_fw_runtime *fwrt, char *mcc);int iwl_uefi_get_eckv (struct iwl_fw_runtime *fwrt,u32 *extl_clk);int iwl_uefi_get_dsm (struct iwl_fw_runtime *fwrt,enum iwl_dsm_funcs func,u32 *value); +void iwl_uefi_get_sgom_table (struct iwl_trans *trans,struct iwl_fw_runtime *fwrt); +int iwl_uefi_get_uats_table (struct iwl_trans *trans, +struct iwl_fw_runtime *fwrt);#else /* CONFIG_EFI */ static inline void *iwl_uefi_get_pnvm (struct iwl_trans *trans,size_t *len) {
@@ -283,13 +286,7 @@ static inline int iwl_uefi_get_dsm(struct iwl_fw_runtime *fwrt, {return -ENOENT ; } -#endif /* CONFIG_EFI */ -#if defined(CONFIG_EFI ) && defined(CONFIG_ACPI ) -void iwl_uefi_get_sgom_table (struct iwl_trans *trans,struct iwl_fw_runtime *fwrt); -int iwl_uefi_get_uats_table (struct iwl_trans *trans, -struct iwl_fw_runtime *fwrt); -#else static inline void iwl_uefi_get_sgom_table (struct iwl_trans *trans,struct iwl_fw_runtime *fwrt) {
@@ -301,5 +298,5 @@ int iwl_uefi_get_uats_table(struct iwl_trans *trans, {return 0 ; } -#endif +#endif /* CONFIG_EFI */ #endif /* __iwl_fw_uefi__ */
Signature · 1 line
2.39.2