selftests: add missing gitignore files and include generated objects
Subsystems (3)
v2 cover selftests: add missing gitignore files and include generated objects
This series aims to keep the git status clean after building the selftests by adding some missing .gitignore files and object inclusion in existing .gitignore files. This is one of the requirements listed in the selftests documentation for new tests, but it is not always followed as desired.
After adding these .gitignore files and including the generated objects, the working tree appears clean again.
The new version includes a missing entry fot the .gitignore in damon, which was reported by Bernd Edlinger <[email protected]>, who also proposed a patch for it as well as for other missing .gitignore files covered by v1. Bernd has been added to the corresponding patch as the reporter. If a different tag is desired, I am fine with it.
To: Shuah Khan <[email protected]>
To: SeongJae Park <[email protected]>
To: Bernd Edlinger <[email protected]>
Changes in v2:
- Remove patch for netfilter (not relevant anymore).
- Add patch for damon (missing binary in .gitignore).
- Link to v1: https://lore.kernel.org/r/[email protected]
---
Javier Carrasco (4):
selftests: uevent: add missing gitignore
selftests: thermal: intel: power_floor: add missing gitignore
selftests: thermal: intel: workload_hint: add missing gitignore
selftests: damon: add access_memory to .gitignore
tools/testing/selftests/damon/.gitignore | 1 + tools/testing/selftests/thermal/intel/power_floor/.gitignore | 1 + tools/testing/selftests/thermal/intel/workload_hint/.gitignore | 1 + tools/testing/selftests/uevent/.gitignore | 1 + 4 files changed, 4 insertions(+)
---
base-commit: 716f4aaa7b48a55c73d632d0657b35342b1fefd7
change-id: 20240101-selftest_gitignore-7da2c503766e
Best regards,
Signature · 1 line
Javier Carrasco <[email protected]>
PATCH v2 1/4 selftests: uevent: add missing gitignore
The 'uevent_filtering' test generates an object with the same name, but there is no .gitignore file in the directory to add the object as stated in the selftest documentation.
Add the missing .gitignore file and include 'uevent_filtering'.
--- tools/testing/selftests/uevent/.gitignore | 1 + 1 file changed, 1 insertion(+)
tools/testing/selftests/uevent/.gitignore new file +1 -0
@@ -0,0 +1 @@ +uevent_filtering
Signature · 1 line
2.40.1
PATCH v2 2/4 selftests: thermal: intel: power_floor: add missing gitignore
In reply to Javier CarrascoThe 'power_floor' test generates an object with the same name, but there is no .gitignore file in the directory to add the object as stated in the selftest documentation.
Add the missing .gitignore file and include 'power_floor'.
--- tools/testing/selftests/thermal/intel/power_floor/.gitignore | 1 + 1 file changed, 1 insertion(+)
tools/testing/selftests/thermal/intel/power_floor/.gitignore new file +1 -0
@@ -0,0 +1 @@ +power_floor_test
Signature · 1 line
2.40.1
PATCH v2 3/4 selftests: thermal: intel: workload_hint: add missing gitignore
In reply to Javier CarrascoThe 'workload_hint_test' test generates an object with the same name, but there is no .gitignore file in the directory to add the object as stated in the selftest documentation.
Add the missing .gitignore file and include 'workload_hint_test'.
--- tools/testing/selftests/thermal/intel/workload_hint/.gitignore | 1 + 1 file changed, 1 insertion(+)
tools/testing/selftests/thermal/intel/workload_hint/.gitignore new file +1 -0
@@ -0,0 +1 @@ +workload_hint_test
Signature · 1 line
2.40.1
PATCH v2 4/4 selftests: damon: add access_memory to .gitignore
In reply to Javier CarrascoThis binary is missing in the .gitignore and stays as an untracked file.
--- tools/testing/selftests/damon/.gitignore | 1 + 1 file changed, 1 insertion(+)
tools/testing/selftests/damon/.gitignore +1 -0
@@ -1,2 +1,3 @@ # SPDX-License-Identifier: GPL-2.0-only huge_count_read_write +access_memory
Signature · 1 line
2.40.1
Re: [PATCH v2 4/4] selftests: damon: add access_memory to .gitignore
Hello,
Quoted 4 lines · On Mon, 12 Feb 2024 20:43:39 +0100 Javier Carrasco…
This binary is missing in the .gitignore and stays as an untracked file.
Reported-by Bernd Edlinger <[email protected]>Signed-off-by Javier Carrasco <[email protected]>
'checkpatch.pl' complains as below:
WARNING: Reported-by: should be immediately followed by Closes: with a URL to the report #11:
I guess the 'Closes:' could this link?
https://lore.kernel.org/r/AS8P193MB1285C963658008F1B2702AF7E4792@AS8P193MB1285.EURP193.PROD.OUTLOOK.COM
Also, note that this conflicts on mm-unstable.
Other than those,
Thanks,
SJ
Quoted 15 lines
--- tools/testing/selftests/damon/.gitignore | 1 + 1 file changed, 1 insertion(+)tools/testing/selftests/damon/.gitignore +1
-0@@ -1,2 +1,3 @@ # SPDX-License-Identifier: GPL-2.0-only huge_count_read_write +access_memorySignature · 2 lines
-- 2.40.1
Re: [PATCH v2 4/4] selftests: damon: add access_memory to .gitignore
Quoted 11 lines · SeongJae Park
Hello,
Quoted 4 lines · On Mon, 12 Feb 2024 20:43:39 +0100 Javier Carrasco…
This binary is missing in the .gitignore and stays as an untracked file.
Reported-by Bernd Edlinger <[email protected]>Signed-off-by Javier Carrasco <[email protected]>'checkpatch.pl' complains as below:
Quoted 8 lines
WARNING: Reported-by: should be immediately followed by Closes: with a URL to the report #11:
Reported-by Bernd Edlinger <[email protected]>Signed-off-by Javier Carrasco <[email protected]>I guess the 'Closes:' could this link?
https://lore.kernel.org/r/AS8P193MB1285C963658008F1B2702AF7E4792@AS8P193MB1285.EURP193.PROD.OUTLOOK.COM
I will add the Closes tag with the right link, thank you.
Quoted 1 line
Also, note that this conflicts on mm-unstable.
Should I use mm-unstable as basis to make sure no conflicts are introduced?
Quoted 23 lines
Other than those,
Reviewed-by SeongJae Park <[email protected]>Thanks,
SJQuoted 13 lines
--- tools/testing/selftests/damon/.gitignore | 1 + 1 file changed, 1 insertion(+)tools/testing/selftests/damon/.gitignore +1
-0@@ -1,2 +1,3 @@ # SPDX-License-Identifier: GPL-2.0-only huge_count_read_write +access_memory
Quoted 2 lines
Quoted 2 lines
Signature · 1 line
2.40.1
Best regards,
Javier Carrasco
SeongJae Park
maintainerRe: [PATCH v2 4/4] selftests: damon: add access_memory to .gitignore
Quoted 19 lines · On Mon, 12 Feb 2024 21:07:34 +0100 Javier Carrasco…
Quoted 16 lines · SeongJae Park
Hello,
Quoted 4 lines · On Mon, 12 Feb 2024 20:43:39 +0100 Javier Carrasco…
This binary is missing in the .gitignore and stays as an untracked file.
Reported-by Bernd Edlinger <[email protected]>Signed-off-by Javier Carrasco <[email protected]>'checkpatch.pl' complains as below:
WARNING: Reported-by: should be immediately followed by Closes: with a URL to the report #11:
Reported-by Bernd Edlinger <[email protected]>Signed-off-by Javier Carrasco <[email protected]>
Quoted 5 lines
Quoted 3 lines
I guess the 'Closes:' could this link?
https://lore.kernel.org/r/AS8P193MB1285C963658008F1B2702AF7E4792@AS8P193MB1285.EURP193.PROD.OUTLOOK.COMI will add the Closes tag with the right link, thank you.
Thank you :)
Quoted 4 lines
Quoted 2 lines
Also, note that this conflicts on mm-unstable.
Should I use mm-unstable as basis to make sure no conflicts are introduced?
DAMON selftest patches could be merged in mm-unstable or linux-kselftest depending on cases.
If you rebase this on mm-unstable, it might conflict on linux-kselftest. Letting Shuah merge this on linux-kselftest and asking Linus Torvalds to fix the conflict in next merge window could be one possible option.
Or, making this split out of this series, rebase on mm-unstable, and asking Andrew Morton to carry may be another option.
Andrew and Shuah, may I ask your opinions?
Thanks,
SJ
[...]
Andrew Morton
maintainerRe: [PATCH v2 4/4] selftests: damon: add access_memory to .gitignore
Quoted 8 lines · On Mon, 12 Feb 2024 12:23:56 -0800 SeongJae Park <[email protected]> wrote:
Quoted 4 lines
Quoted 2 lines
Also, note that this conflicts on mm-unstable.
Should I use mm-unstable as basis to make sure no conflicts are introduced?
DAMON selftest patches could be merged in mm-unstable or linux-kselftest depending on cases.
Quoted 8 lines
If you rebase this on mm-unstable, it might conflict on linux-kselftest. Letting Shuah merge this on linux-kselftest and asking Linus Torvalds to fix the conflict in next merge window could be one possible option.
Or, making this split out of this series, rebase on mm-unstable, and asking Andrew Morton to carry may be another option.
Andrew and Shuah, may I ask your opinions?
I'd say base it on mm-unstable so we don't have conflicts for people to deal with?