Skip to contentSkip to conversation

selftests: add missing gitignore files and include generated objects

PATCH Superseded Javier Carrasco 2 participants 6 messages Feb 13, 2024

Subsystems (3)

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

v3 cover selftests: add missing gitignore files and include generated objects

This series aims to keep the git status clean after building the selftests by adding some missing .gitignore files and object inclusion in existing .gitignore files. This is one of the requirements listed in the selftests documentation for new tests, but it is not always followed as desired.

After adding these .gitignore files and including the generated objects, the working tree appears clean again.

The new version includes a missing entry fot the .gitignore in damon, which was reported by Bernd Edlinger <[email protected]>, who also proposed a patch for it as well as for other missing .gitignore files covered by v1. Bernd has been added to the corresponding patch as the reporter. If a different tag is desired, I am fine with it.

To: Shuah Khan <[email protected]>
To: SeongJae Park <[email protected]>
To: Bernd Edlinger <[email protected]>

Changes in v3:
- General: base on mm-unstable to avoid conflicts.
- damon: add missing Closes tag.
- Link to v2: https://lore.kernel.org/r/[email protected]

Changes in v2:
- Remove patch for netfilter (not relevant anymore).
- Add patch for damon (missing binary in .gitignore).
- Link to v1: https://lore.kernel.org/r/[email protected]

---
Javier Carrasco (4):
selftests: uevent: add missing gitignore
selftests: thermal: intel: power_floor: add missing gitignore
selftests: thermal: intel: workload_hint: add missing gitignore
selftests: damon: add access_memory to .gitignore

 tools/testing/selftests/damon/.gitignore                       | 1 +
 tools/testing/selftests/thermal/intel/power_floor/.gitignore   | 1 +
 tools/testing/selftests/thermal/intel/workload_hint/.gitignore | 1 +
 tools/testing/selftests/uevent/.gitignore                      | 1 +
 4 files changed, 4 insertions(+)

---
base-commit: 7e56cf9a7f108e8129d75cea0dabc9488fb4defa
change-id: 20240101-selftest_gitignore-7da2c503766e

Best regards,

Signature · 1 line
Javier Carrasco <[email protected]>
#1 lore raw

PATCH v3 1/4 selftests: uevent: add missing gitignore

The 'uevent_filtering' test generates an object with the same name, but there is no .gitignore file in the directory to add the object as stated in the selftest documentation.

Add the missing .gitignore file and include 'uevent_filtering'.

---
 tools/testing/selftests/uevent/.gitignore | 1 +
 1 file changed, 1 insertion(+)
tools/testing/selftests/uevent/.gitignore new file +1 -0
new file mode 100644
index 000000000000..382afb74cd40
@@ -0,0 +1 @@
+uevent_filtering
Signature · 1 line
2.40.1
#2 lore raw

PATCH v3 2/4 selftests: thermal: intel: power_floor: add missing gitignore

In reply to Javier Carrasco

The 'power_floor' test generates an object with the same name, but there is no .gitignore file in the directory to add the object as stated in the selftest documentation.

Add the missing .gitignore file and include 'power_floor'.

---
 tools/testing/selftests/thermal/intel/power_floor/.gitignore | 1 +
 1 file changed, 1 insertion(+)
tools/testing/selftests/thermal/intel/power_floor/.gitignore new file +1 -0
new file mode 100644
index 000000000000..1b9a76406f18
@@ -0,0 +1 @@
+power_floor_test
Signature · 1 line
2.40.1
#3 lore raw

PATCH v3 3/4 selftests: thermal: intel: workload_hint: add missing gitignore

In reply to Javier Carrasco

The 'workload_hint_test' test generates an object with the same name, but there is no .gitignore file in the directory to add the object as stated in the selftest documentation.

Add the missing .gitignore file and include 'workload_hint_test'.

---
 tools/testing/selftests/thermal/intel/workload_hint/.gitignore | 1 +
 1 file changed, 1 insertion(+)
tools/testing/selftests/thermal/intel/workload_hint/.gitignore new file +1 -0
new file mode 100644
index 000000000000..d697b034a3a8
@@ -0,0 +1 @@
+workload_hint_test
Signature · 1 line
2.40.1
#4 lore raw

PATCH v3 4/4 selftests: damon: add access_memory to .gitignore

In reply to Javier Carrasco

This binary is missing in the .gitignore and stays as an untracked file.

---
 tools/testing/selftests/damon/.gitignore | 1 +
 1 file changed, 1 insertion(+)
tools/testing/selftests/damon/.gitignore +1 -0
index d861701f0327..e65ef9d9cedc 100644
@@ -2,3 +2,4 @@
 huge_count_read_write
 debugfs_target_ids_read_before_terminate_race
 debugfs_target_ids_pid_leak
+access_memory
Signature · 1 line
2.40.1
maintainer
#5 lore raw

Re: [PATCH v3 4/4] selftests: damon: add access_memory to .gitignore

Quoted 6 lines · On Tue, 13 Feb 2024 23:46:53 +0100 Javier Carrasco…

This binary is missing in the .gitignore and stays as an untracked file.

Thank you, I confirmed this can cleanly be applied on mm-unstable. But, I think my suggestion was to split this patch out of the patchset and send separately so that Andrew can carry this on mm-unstable? Otherwise, Shuah would get the conflict on her tree, or Andrew would need to carry the patches for theremal and uevent selftests on mm-unstable.

Thanks,
SJ

Quoted 16 lines
---
 tools/testing/selftests/damon/.gitignore | 1 +
 1 file changed, 1 insertion(+)
tools/testing/selftests/damon/.gitignore +1 -0
index d861701f0327..e65ef9d9cedc 100644
@@ -2,3 +2,4 @@
 huge_count_read_write
 debugfs_target_ids_read_before_terminate_race
 debugfs_target_ids_pid_leak
+access_memory
Signature · 2 lines
-- 
2.40.1