Skip to contentSkip to conversation

Staging: rtl8192e: rtl819x_HTProc: Removed braces from single statement block

PATCH Superseded Aaron Parfitt 2 participants 2 messages Feb 13, 2024 – Feb 15, 2024 Staging

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: rtl8192e: rtl819x_HTProc: Removed braces from single statement block

Fixed code style issue

---
 drivers/staging/rtl8192e/rtl819x_HTProc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8192e/rtl819x_HTProc.c +2 -2
index 6d0912f90198..49b882c363bf 100644
@@ -480,9 +480,9 @@ void ht_on_assoc_rsp(struct rtllib_device *ieee)
 	}
 
 	ht_info->current_mpdu_density = pPeerHTCap->MPDUDensity;
-	if (ht_info->iot_action & HT_IOT_ACT_TX_USE_AMSDU_8K) {
+	if (ht_info->iot_action & HT_IOT_ACT_TX_USE_AMSDU_8K)
 		ht_info->current_ampdu_enable = false;
-	}
+
 	ht_info->cur_rx_reorder_enable = 1;
 
 	if (pPeerHTCap->MCS[0] == 0)
Signature · 1 line
2.43.0
#1 lore raw

Hi Aaron,

looks OK but can we make the subject more unique. Maybe like this:

[PATCH] Staging: rtl8192e: Removed braces from single statement block in ht_on_assoc_rsp

Or is this getting to long?

I propose the description to be like:

Remove braces from single statement blocks to clear checkpatch warning.

If you change this you need to make a v2 with changelog.

Bye Philipp

Quoted 23 lines · Aaron Parfitt

Fixed code style issue

---
  drivers/staging/rtl8192e/rtl819x_HTProc.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8192e/rtl819x_HTProc.c +2 -2
index 6d0912f90198..49b882c363bf 100644
@@ -480,9 +480,9 @@ void ht_on_assoc_rsp(struct rtllib_device *ieee)
  	}
 
  	ht_info->current_mpdu_density = pPeerHTCap->MPDUDensity;
-	if (ht_info->iot_action & HT_IOT_ACT_TX_USE_AMSDU_8K) {
+	if (ht_info->iot_action & HT_IOT_ACT_TX_USE_AMSDU_8K)
  		ht_info->current_ampdu_enable = false;
-	}
+
  	ht_info->cur_rx_reorder_enable = 1;
 
  	if (pPeerHTCap->MCS[0] == 0)