Skip to contentSkip to conversation

cpufreq/intel_pstate: remove cpudata::prev_cummulative_iowait

PATCH Applied Jiri Slaby (SUSE) 2 participants 2 messages Feb 13, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cpufreq/intel_pstate: remove cpudata::prev_cummulative_iowait

Commit 09c448d3c61f (cpufreq: intel_pstate: Use IOWAIT flag in Atom algorithm) removed the last user of cpudata::prev_cummulative_iowait. So remove the member too.

Found by https://github.com/jirislaby/clang-struct.

Cc Srinivas Pandruvada <[email protected]>
Cc Len Brown <[email protected]>
Cc "Rafael J. Wysocki" <[email protected]>
Cc Viresh Kumar <[email protected]>
---
 drivers/cpufreq/intel_pstate.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/cpufreq/intel_pstate.c +0 -3
index ca94e60e705a..5ad3542c0e1e 100644
@@ -201,8 +201,6 @@ struct global_params {
  * @prev_aperf:		Last APERF value read from APERF MSR
  * @prev_mperf:		Last MPERF value read from MPERF MSR
  * @prev_tsc:		Last timestamp counter (TSC) value
- * @prev_cummulative_iowait: IO Wait time difference from last and
- *			current sample
  * @sample:		Storage for storing last Sample data
  * @min_perf_ratio:	Minimum capacity in terms of PERF or HWP ratios
  * @max_perf_ratio:	Maximum capacity in terms of PERF or HWP ratios
@@ -241,7 +239,6 @@ struct cpudata {
 	u64	prev_aperf;
 	u64	prev_mperf;
 	u64	prev_tsc;
-	u64	prev_cummulative_iowait;
 	struct sample sample;
 	int32_t	min_perf_ratio;
 	int32_t	max_perf_ratio;
Signature · 1 line
2.43.1
maintainer Applied
#1 lore raw
Quoted 31 lines · Jiri Slaby (SUSE)

Commit 09c448d3c61f (cpufreq: intel_pstate: Use IOWAIT flag in Atom algorithm) removed the last user of cpudata::prev_cummulative_iowait. So remove the member too.

Found by https://github.com/jirislaby/clang-struct.

Cc Srinivas Pandruvada <[email protected]>
Cc Len Brown <[email protected]>
Cc "Rafael J. Wysocki" <[email protected]>
Cc Viresh Kumar <[email protected]>
---
 drivers/cpufreq/intel_pstate.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/cpufreq/intel_pstate.c +0 -2
index ca94e60e705a..5ad3542c0e1e 100644
@@ -201,8 +201,6 @@ struct global_params {
  * @prev_aperf:                Last APERF value read from APERF MSR
  * @prev_mperf:                Last MPERF value read from MPERF MSR
  * @prev_tsc:          Last timestamp counter (TSC) value
- * @prev_cummulative_iowait: IO Wait time difference from last and
- *                     current sample
  * @sample:            Storage for storing last Sample data
  * @min_perf_ratio:    Minimum capacity in terms of PERF or HWP ratios
  * @max_perf_ratio:    Maximum capacity in terms of PERF or HWP ratios

drivers/cpufreq/intel_pstate.c struct cpudata {

Quoted 8 lines
drivers/cpufreq/intel_pstate.c +0 -2
@@ -241,7 +239,6 @@ struct cpudata {
        u64     prev_aperf;
        u64     prev_mperf;
        u64     prev_tsc;
-       u64     prev_cummulative_iowait;
        struct sample sample;
        int32_t min_perf_ratio;
        int32_t max_perf_ratio;
--

Applied as 6.9 material, thanks!