spi: dw: remove redundant assignment to variable len
Subsystems (2)
PATCH 1/1 spi: dw: remove redundant assignment to variable len
The variable id len being initialized with a value that is never read, it is being re-assigned later on in a for-loop. The initialization is redundant and can be removed.
Cleans up clang scan build warning:drivers/spi/spi-dw-dma.c:580:17: warning: Although the value stored to 'len' is used in the enclosing expression, the value is never actually read from 'len' [deadcode.DeadStores]
--- drivers/spi/spi-dw-dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/spi/spi-dw-dma.c +1 -1
@@ -577,7 +577,7 @@ static int dw_spi_dma_transfer_one(struct dw_spi *dws,sg_init_table (&tx_tmp,1 );sg_init_table (&rx_tmp,1 ); -for (base =0 , len =0 ; base < xfer->len; base += len) { +for (base =0 ; base < xfer->len; base += len) {/* Fetch next Tx DMA data chunk */ if (!tx_len) { tx_sg = !tx_sg ? &xfer->tx_sg.sgl[0 ] :sg_next (tx_sg);
Signature · 1 line
2.39.2
Quoted 1 line · Colin Ian King
The variable id len being initialized with a value that is never read,
should be "len is being.."
Quoted 26 lines
it is being re-assigned later on in a for-loop. The initialization is redundant and can be removed.
Cleans up clang scan build warning:
drivers/spi/spi-dw-dma.c:580:17: warning: Although the value stored to 'len' is used in the enclosing expression, the value is never actually read from 'len' [deadcode.DeadStores]Signed-off-by Colin Ian King <[email protected]>--- drivers/spi/spi-dw-dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/spi/spi-dw-dma.c +1
-1@@ -577,7 +577,7 @@ static int dw_spi_dma_transfer_one(struct dw_spi *dws,sg_init_table (&tx_tmp,1 );sg_init_table (&rx_tmp,1 ); -for (base =0 , len =0 ; base < xfer->len; base += len) { +for (base =0 ; base < xfer->len; base += len) {/* Fetch next Tx DMA data chunk */ if (!tx_len) { tx_sg = !tx_sg ? &xfer->tx_sg.sgl[0 ] :sg_next (tx_sg);
Quoted 8 lines · Colin Ian King
The variable id len being initialized with a value that is never read, it is being re-assigned later on in a for-loop. The initialization is redundant and can be removed.
Cleans up clang scan build warning:
drivers/spi/spi-dw-dma.c:580:17: warning: Although the value stored to 'len' is used in the enclosing expression, the value is never actually read from 'len' [deadcode.DeadStores]
Don't know for sure now what was my original intention of having it pre-initialized in the for-loop init section. Possibly what you suggest to drop was a leftover from some another version of the function implementation where the re-initialization was required. On the other hand rather weak but still a justification of having that assignment can be a maintainability so all the basic loop variables would be safely pre-initialized before the code block is executed. But in that case a more correct value would have been "xfer->len" instead of zero. Anyway let's keep the code simple and drop the assignment. Thanks for the patch.
-Serge(y)
Quoted 22 lines
Signed-off-by Colin Ian King <[email protected]>--- drivers/spi/spi-dw-dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/spi/spi-dw-dma.c +1
-1@@ -577,7 +577,7 @@ static int dw_spi_dma_transfer_one(struct dw_spi *dws,sg_init_table (&tx_tmp,1 );sg_init_table (&rx_tmp,1 ); -for (base =0 , len =0 ; base < xfer->len; base += len) { +for (base =0 ; base < xfer->len; base += len) {/* Fetch next Tx DMA data chunk */ if (!tx_len) { tx_sg = !tx_sg ? &xfer->tx_sg.sgl[0 ] :sg_next (tx_sg);Signature · 1 line
2.39.2
Mark Brown
maintainerQuoted 10 lines · Colin Ian King
The variable id len being initialized with a value that is never read, it is being re-assigned later on in a for-loop. The initialization is redundant and can be removed.
Cleans up clang scan build warning:
drivers/spi/spi-dw-dma.c:580:17: warning: Although the value stored to 'len' is used in the enclosing expression, the value is never actually read from 'len' [deadcode.DeadStores][...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
Thanks!
[1/1] spi: dw: remove redundant assignment to variable len
commit: 125b28b18926e050e770160a5897b81082304f8c
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark