enic: Avoid false positive under FORTIFY_SOURCE
Subsystems (3)
PATCH 1/1 enic: Avoid false positive under FORTIFY_SOURCE
FORTIFY_SOURCE has been ignoring 0-sized destinations while the kernel code base has been converted to flexible arrays. In order to enforce the 0-sized destinations (e.g. with __counted_by), the remaining 0-sized destinations need to be handled. Unfortunately, struct vic_provinfo resists full conversion, as it contains a flexible array of flexible arrays, which is only possible with the 0-sized fake flexible array.
Use unsafe_memcpy() to avoid future false positives under CONFIG_FORTIFY_SOURCE.
---
Cc: Christian Benvenuti <[email protected]>
Cc: Satish Kharat <[email protected]>
Cc: "David S. Miller" <[email protected]>
Cc: Eric Dumazet <[email protected]>
Cc: Jakub Kicinski <[email protected]>
Cc: Paolo Abeni <[email protected]>
Cc: Gustavo A. R. Silva <[email protected]>
Cc: [email protected]
--- drivers/net/ethernet/cisco/enic/vnic_vic.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/ethernet/cisco/enic/vnic_vic.c +2 -1
@@ -49,7 +49,8 @@ int vic_provinfo_add_tlv(struct vic_provinfo *vp, u16 type, u16 length, tlv->type =htons (type); tlv->length =htons (length); -memcpy (tlv->value, value, length); +unsafe_memcpy (tlv->value, value, length, + /* Flexible array of flexible arrays */); vp->num_tlvs =htonl (ntohl (vp->num_tlvs) +1 ); vp->length = htonl(ntohl(vp->length) +
Signature · 1 line
2.34.1
This patch was applied to netdev/net.git (main) by David S. Miller <[email protected]>:
Hello:
This patch was applied to netdev/net.git (main)
by David S. Miller <[email protected]>:
Quoted 8 lines · On Fri, 16 Feb 2024 15:30:05 -0800 you wrote:
FORTIFY_SOURCEhas been ignoring 0-sized destinations while the kernel code base has been converted to flexible arrays. In order to enforce the 0-sized destinations (e.g. with__counted_by), the remaining 0-sized destinations need to be handled. Unfortunately, structvic_provinforesists full conversion, as it contains a flexible array of flexible arrays, which is only possible with the 0-sized fake flexible array.[...]
Here is the summary with links:
- enic: Avoid false positive under FORTIFY_SOURCE
https://git.kernel.org/netdev/net/c/40b9385dd8e6
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html