exec: Remove unnecessary ‘NULL’ values from vma
Subsystems (3)
PATCH 1/1 exec: Remove unnecessary ‘NULL’ values from vma
vma is assigned first, so it does not need to initialize the assignment.
Signed-off-by Li zeming <[email protected]>
--- fs/exec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/exec.c +1 -1
@@ -254,7 +254,7 @@ static void flush_arg_page(struct linux_binprm *bprm, unsigned long pos,static int __bprm_mm_init (struct linux_binprm *bprm) {int err; -struct vm_area_struct *vma =NULL ; +struct vm_area_struct *vma;struct mm_struct *mm = bprm->mm; bprm->vma = vma =vm_area_alloc (mm);
Signature · 1 line
2.18.2
Quoted 2 lines · Li zeming
vma is assigned first, so it does not need to initialize the assignment.
I don't really like removing explicit initializations. They don't cause any problems and the compiler will remove redundant stores, so there's no benefit in dropping them.
Signature · 1 line
Kees Cook