Skip to contentSkip to conversation

board: ti: Add support for BeaglePlay

PATCH In review Nishanth Menon 6 participants 47 messages Aug 25, 2023 – Feb 21, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

v6 cover board: ti: Add support for BeaglePlay

Alright, 6th time is a charm ;) Hopefully this takes care of all the un-addressed concerns we have had. Thanks all for pitching in, reviewing and improving and I will stop finding things to cleanup (promise).

Baseline: 7c6b18fb5494 (origin/next) Merge branch '2023-08-24-enable-more-features-in-qemu-arm' into next Full series available: https://github.com/nmenon/fix-k3-dt-u-boot/commits/beagleplay-v6
Boot Logs: https://gist.github.com/nmenon/8be4106e2d0b572aa5e77d93476095b4

Caveats:
* Networking: pending https://lore.kernel.org/all/[email protected]/
* 32kclk and usb: pending:
https://lore.kernel.org/u-boot/[email protected]/
OR https://github.com/nmenon/fix-k3-dt-u-boot/commit/853b29d63c1ca642be316f1afb0fb778610dec46
being properly resolved (NOTE: without this patch, wlan is broken in
Linux as the 32kclk from SoC is incorrectly supplied to wlan as 25MHz)
* There seems to be a bug in Linux kernel with sdhci that seems to
depend on u-boot initialization of sdhci for functionality (TI
internal actions already triggered).
* buildman discussion about config fragments:
https://lore.kernel.org/all/CAPnjgZ14CUVt=rM943hh9PQUhK9LJDgZYPxUsATYQe3wwOUYqQ@mail.gmail.com/
* Documentation that we can copy paste:
https://lore.kernel.org/all/[email protected]/
and followon in kernel.org:
https://lore.kernel.org/all/[email protected]/
if it all percolates back down to u-boot tree, should be trivial
cleanup.
* Build fails with binman implementation for TI SoCs - Neha will take
care of
https://lore.kernel.org/all/[email protected]/
* This series picks up Jan's patch for working around Device Manager not
compliant with EFI specification reqs and applies it to am62x_sk (TI
internal action already triggered)
https://lore.kernel.org/all/20230825011623.c74qqidp6wgvc5kl@plaza/
* I noticed that when drivers like the am654_sdhci.c uses
deffered_probe, the default probe function does'nt fail
https://source.denx.de/u-boot/u-boot/-/blob/master/boot/bootflow.c#L279
So ends up attempting for each of the boot_targets even if mmc dev
dev_id would fail. Not really sure how to solve it, so will leave it
here. (the https://gist.github.com/nmenon/8be4106e2d0b572aa5e77d93476095b4#file-beagleplay-emmc-sd-not-inserted
should show a bunch of 'MMC: no card present' each of which costs around
1 second.

Changes since V5:
* New patches to clean up mmc.env to sync with BOOTSTD operations yet enable easier non-U-Boot developer experience for uEnv.txt and optimize access to non-plugged in sd-card.
* Picked up Jan's patch[1] as part of this series.
* Introduced default_findfdt.env as review comment
* Saw Simon's feedback on uSD boot, and documented that as well, will be good for new devs to have that info in one flow.
* Quick overall diff: https://gist.github.com/nmenon/6d934f4e1092aa293a771d26b0f2bff7

V5: https://lore.kernel.org/all/[email protected]/
V4: https://lore.kernel.org/all/[email protected]/
V3: https://lore.kernel.org/all/[email protected]/
V2: https://lore.kernel.org/u-boot/[email protected]/
V1: https://lore.kernel.org/all/[email protected]/

Jan Kiszka (1):
configs: am62x_evm_a53_defconfig: Disable semi-functional PSCI reset
support

Nishanth Menon (18):
include: env: ti: mmc: envboot/mmcboot: Check result of mmc dev before
proceeding
include: env: ti: mmc: envboot: Only attempt boot.scr if BOOTSTD is
not enabled
include: configs: ti_armv7_common: Add documentation for protected
section
include: configs: am62x_evm: Drop unused SDRAM address
include: configs: am62x_evm: Wrap distroboot with
CONFIG_DISTRO_DEFAULTS
board: ti: am62x: am62x.env: Add explicit boot_targets
configs: am62x_evm_a53_defconfig: Switch to bootstd
include: configs: am62x_evm: Drop distro_bootcmd usage
include: env: ti: ti_armv7_common.env: Rename to ti_common.env
include: env: ti: Add a generic default_findfdt.env
board: ti: am62x: am62x.env: Use default findfdt
arm: mach-k3: am625_init: Use IS_ENABLED()
arm: mach-k3: am625_init: Convert rtc_erratumi2327_init to static
configs: am62x_evm*: Enable EMMC_BOOT configuration
arm: mach-k3: am625: Add support for UDA FS
arm: dts: k3-am625-sk-binman: Add labels for unsigned binary
board: ti: am62x: Add am62x_beagleplay_* defconfigs and env file
doc: board: ti: Add BeaglePlay documentation

Robert Nelson (1):
arm: dts: Add k3-am625-beagleplay

 arch/arm/dts/Makefile                         |    2 +
 .../dts/k3-am625-beagleplay-ddr4-1600MTs.dtsi | 2195 +++++++++++++++++
 arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi  |  195 ++
 arch/arm/dts/k3-am625-beagleplay.dts          |  758 ++++++
 arch/arm/dts/k3-am625-r5-beagleplay.dts       |   86 +
 arch/arm/dts/k3-am625-sk-binman.dtsi          |    4 +-
 arch/arm/mach-k3/am625_init.c                 |   49 +-
 board/siemens/iot2050/iot2050.env             |    2 +-
 board/ti/am62ax/am62ax.env                    |    2 +-
 board/ti/am62x/MAINTAINERS                    |    7 +
 board/ti/am62x/am62x.env                      |    8 +-
 board/ti/am62x/beagleplay.env                 |   19 +
 board/ti/am62x/beagleplay_a53.config          |   55 +
 board/ti/am62x/beagleplay_r5.config           |   15 +
 board/ti/am64x/am64x.env                      |    2 +-
 board/ti/am65x/am65x.env                      |    2 +-
 board/ti/j721e/j721e.env                      |    2 +-
 board/ti/j721s2/j721s2.env                    |    2 +-
 board/ti/ks2_evm/k2e_evm.env                  |    2 +-
 board/ti/ks2_evm/k2g_evm.env                  |    2 +-
 board/ti/ks2_evm/k2hk_evm.env                 |    2 +-
 board/ti/ks2_evm/k2l_evm.env                  |    2 +-
 configs/am62x_evm_a53_defconfig               |    7 +-
 configs/am62x_evm_r5_defconfig                |    1 +
 doc/board/ti/am62x_beagleplay.rst             |  322 +++
 doc/board/ti/img/beagleplay_emmc.svg          |  697 ++++++
 doc/board/ti/k3.rst                           |    1 +
 include/configs/am62x_evm.h                   |    6 -
 include/configs/ti_armv7_common.h             |    2 +-
 include/env/ti/default_findfdt.env            |   12 +
 include/env/ti/mmc.env                        |   12 +-
 .../ti/{ti_armv7_common.env => ti_common.env} |    0
 32 files changed, 4419 insertions(+), 54 deletions(-)
 create mode 100644 arch/arm/dts/k3-am625-beagleplay-ddr4-1600MTs.dtsi
 create mode 100644 arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi
 create mode 100644 arch/arm/dts/k3-am625-beagleplay.dts
 create mode 100644 arch/arm/dts/k3-am625-r5-beagleplay.dts
 create mode 100644 board/ti/am62x/beagleplay.env
 create mode 100644 board/ti/am62x/beagleplay_a53.config
 create mode 100644 board/ti/am62x/beagleplay_r5.config
 create mode 100644 doc/board/ti/am62x_beagleplay.rst
 create mode 100644 doc/board/ti/img/beagleplay_emmc.svg
 create mode 100644 include/env/ti/default_findfdt.env
 rename include/env/ti/{ti_armv7_common.env => ti_common.env} (100%)

[1] https://lore.kernel.org/all/[email protected]/

Signature · 1 line
2.40.0
#1 lore raw

PATCH v6 1/20 include: env: ti: mmc: envboot/mmcboot: Check result of mmc dev before proceeding

If mmc dev reports that the device is not present, there is no point in proceeding further to attempt to load the files.

---
new patch - noticed a series of 'MMC: no card present' in boot log and was wondering why, now I know - shaves off 2 seconds or so into boot process.

 include/env/ti/mmc.env | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
include/env/ti/mmc.env +5 -3
index 6fb47fb26673..b8eb51ca1744 100644
@@ -15,7 +15,7 @@ loadbootenv=fatload mmc ${mmcdev} ${loadaddr} ${bootenvfile}
 loadimage=load ${devtype} ${bootpart} ${loadaddr} ${bootdir}/${bootfile}
 loadfdt=load ${devtype} ${bootpart} ${fdtaddr} ${bootdir}/dtb/${fdtfile}
 get_fdt_mmc=load mmc ${bootpart} ${fdtaddr} ${bootdir}/dtb/${name_fdt}
-envboot=mmc dev ${mmcdev};
+envboot=if mmc dev ${mmcdev}; then
 	if mmc rescan; then
 		echo SD/MMC found on device ${mmcdev};
 		if run loadbootscript; then
@@ -31,6 +31,7 @@ envboot=mmc dev ${mmcdev};
 			fi;
 		fi;
 	fi;
+  fi;
 mmcloados=
 	if test ${boot_fdt} = yes || test ${boot_fdt} = try; then
 		if run get_fdt_mmc; then
@@ -45,7 +46,7 @@ mmcloados=
 	else
 		bootz;
 	fi;
-mmcboot=mmc dev ${mmcdev};
+mmcboot=if mmc dev ${mmcdev}; then
 	devnum=${mmcdev};
 	devtype=mmc;
 	if mmc rescan; then
@@ -58,7 +59,8 @@ mmcboot=mmc dev ${mmcdev};
 				run mmcloados;
 			fi;
 		fi;
-fi;
+	fi;
+  fi;
 
 init_mmc=run args_all args_mmc
 get_overlay_mmc=
Signature · 1 line
2.40.0
Reviewed-by on v6 1/20
#2 lore raw

Re: [PATCH V6 01/20] include: env: ti: mmc: envboot/mmcboot: Check result of mmc dev before proceeding

Quoted 4 lines · Nishanth Menon

If mmc dev reports that the device is not present, there is no point in proceeding further to attempt to load the files.

Signature · 1 line
Tom
Reviewed-by on v6 1/20
#3 lore raw

Re: [PATCH V6 01/20] include: env: ti: mmc: envboot/mmcboot: Check result of mmc dev before proceeding

In reply to Nishanth Menon
Quoted 4 lines · Nishanth Menon

If mmc dev reports that the device is not present, there is no point in proceeding further to attempt to load the files.

Quoted 50 lines

---
new patch - noticed a series of 'MMC: no card present' in boot log and was wondering why, now I know - shaves off 2 seconds or so into boot process.

 include/env/ti/mmc.env | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
include/env/ti/mmc.env +5 -3
index 6fb47fb26673..b8eb51ca1744 100644
@@ -15,7 +15,7 @@ loadbootenv=fatload mmc ${mmcdev} ${loadaddr} ${bootenvfile}
 loadimage=load ${devtype} ${bootpart} ${loadaddr} ${bootdir}/${bootfile}
 loadfdt=load ${devtype} ${bootpart} ${fdtaddr} ${bootdir}/dtb/${fdtfile}
 get_fdt_mmc=load mmc ${bootpart} ${fdtaddr} ${bootdir}/dtb/${name_fdt}
-envboot=mmc dev ${mmcdev};
+envboot=if mmc dev ${mmcdev}; then
 	if mmc rescan; then
 		echo SD/MMC found on device ${mmcdev};
 		if run loadbootscript; then
@@ -31,6 +31,7 @@ envboot=mmc dev ${mmcdev};
 			fi;
 		fi;
 	fi;
+  fi;
 mmcloados=
 	if test ${boot_fdt} = yes || test ${boot_fdt} = try; then
 		if run get_fdt_mmc; then
@@ -45,7 +46,7 @@ mmcloados=
 	else
 		bootz;
 	fi;
-mmcboot=mmc dev ${mmcdev};
+mmcboot=if mmc dev ${mmcdev}; then
 	devnum=${mmcdev};
 	devtype=mmc;
 	if mmc rescan; then
@@ -58,7 +59,8 @@ mmcboot=mmc dev ${mmcdev};
 				run mmcloados;
 			fi;
 		fi;
-fi;
+	fi;
+  fi;
 
 init_mmc=run args_all args_mmc
 get_overlay_mmc=
Signature · 1 line
2.40.0
#4 lore raw

Re: [PATCH V6 01/20] include: env: ti: mmc: envboot/mmcboot: Check result of mmc dev before proceeding

In reply to Nishanth Menon
Quoted 6 lines · Nishanth Menon

If mmc dev reports that the device is not present, there is no point in proceeding further to attempt to load the files.

For the series, applied to u-boot/next, thanks!

Signature · 1 line
Tom
#5 lore raw

PATCH v6 2/20 include: env: ti: mmc: envboot: Only attempt boot.scr if BOOTSTD is not enabled

In reply to Nishanth Menon

'script' bootmethod that should be used with CONFIG_BOOTSTD.

---

Since Simon educated me to realize that the published documentation can be stale and bootmeths=script does indeed work for some time despite what the docs say..

 include/env/ti/mmc.env | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
include/env/ti/mmc.env +3 -1
index b8eb51ca1744..0256a2d2aaca 100644
@@ -5,7 +5,9 @@ args_mmc=run finduuid;setenv bootargs console=${console}
 	${optargs}
 	root=PARTUUID=${uuid} rw
 	rootfstype=${mmcrootfstype}
+#ifndef CONFIG_BOOTSTD
 loadbootscript=load mmc ${mmcdev} ${loadaddr} boot.scr
+#endif
 bootscript=echo Running bootscript from mmc${mmcdev} ...;
 	source ${loadaddr}
 bootenvfile=uEnv.txt
@@ -18,7 +20,7 @@ get_fdt_mmc=load mmc ${bootpart} ${fdtaddr} ${bootdir}/dtb/${name_fdt}
 envboot=if mmc dev ${mmcdev}; then
 	if mmc rescan; then
 		echo SD/MMC found on device ${mmcdev};
-		if run loadbootscript; then
+		if test -n "${loadbootscript}" && run loadbootscript; then
 			run bootscript;
 		else
 			if run loadbootenv; then
Signature · 1 line
2.40.0
Reviewed-by on v6 2/20
#7 lore raw

Re: [PATCH V6 02/20] include: env: ti: mmc: envboot: Only attempt boot.scr if BOOTSTD is not enabled

In reply to Nishanth Menon
Quoted 3 lines · Nishanth Menon

'script' bootmethod that should be used with CONFIG_BOOTSTD.

Quoted 34 lines

---

Since Simon educated me to realize that the published documentation can be stale and bootmeths=script does indeed work for some time despite what the docs say..

 include/env/ti/mmc.env | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
include/env/ti/mmc.env +3 -1
index b8eb51ca1744..0256a2d2aaca 100644
@@ -5,7 +5,9 @@ args_mmc=run finduuid;setenv bootargs console=${console}
 	${optargs}
 	root=PARTUUID=${uuid} rw
 	rootfstype=${mmcrootfstype}
+#ifndef CONFIG_BOOTSTD
 loadbootscript=load mmc ${mmcdev} ${loadaddr} boot.scr
+#endif
 bootscript=echo Running bootscript from mmc${mmcdev} ...;
 	source ${loadaddr}
 bootenvfile=uEnv.txt
@@ -18,7 +20,7 @@ get_fdt_mmc=load mmc ${bootpart} ${fdtaddr} ${bootdir}/dtb/${name_fdt}
 envboot=if mmc dev ${mmcdev}; then
 	if mmc rescan; then
 		echo SD/MMC found on device ${mmcdev};
-		if run loadbootscript; then
+		if test -n "${loadbootscript}" && run loadbootscript; then
 			run bootscript;
 		else
 			if run loadbootenv; then
Signature · 1 line
2.40.0
#8 lore raw

PATCH v6 3/20 include: configs: ti_armv7_common: Add documentation for protected section

In reply to Nishanth Menon

Make the section protected by CONFIG_DISTRO_DEFAULTS macro clear.

---
No change other than picking up reviews, tested tags along the way.

V5: https://lore.kernel.org/r/[email protected]

 include/configs/ti_armv7_common.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/configs/ti_armv7_common.h +1 -1
index dbbeff34ba82..4e30d0d2ddf8 100644
@@ -200,7 +200,7 @@
 #define CFG_EXTRA_ENV_SETTINGS					\
 	BOOTENV
 
-#endif
+#endif /* CONFIG_DISTRO_DEFAULTS */
 
 #endif /* CONFIG_ARM64 */
 
Signature · 1 line
2.40.0
#9 lore raw

PATCH v6 4/20 include: configs: am62x_evm: Drop unused SDRAM address

In reply to Nishanth Menon

Drop unused macro. This was meant for a second region of DDR which we do not need for AM62x evm configurations.

---
No change other than picking up reviews, tested tags along the way.

V5: https://lore.kernel.org/r/[email protected]

 include/configs/am62x_evm.h | 3 ---
 1 file changed, 3 deletions(-)
include/configs/am62x_evm.h +0 -3
index 44180dc7687b..379e0c13a395 100644
@@ -12,9 +12,6 @@
 #include <config_distro_bootcmd.h>
 #include <env/ti/mmc.h>
 
-/* DDR Configuration */
-#define CFG_SYS_SDRAM_BASE1		0x880000000
-
 /* Now for the remaining common defines */
 #include <configs/ti_armv7_common.h>
 
Signature · 1 line
2.40.0
Reviewed-by on v6 4/20
#10 lore raw

Re: [PATCH V6 04/20] include: configs: am62x_evm: Drop unused SDRAM address

Quoted 5 lines · Nishanth Menon

Drop unused macro. This was meant for a second region of DDR which we do not need for AM62x evm configurations.

Quoted 23 lines

---
No change other than picking up reviews, tested tags along the way.

V5: https://lore.kernel.org/r/[email protected]

 include/configs/am62x_evm.h | 3 ---
 1 file changed, 3 deletions(-)
include/configs/am62x_evm.h +0 -3
index 44180dc7687b..379e0c13a395 100644
@@ -12,9 +12,6 @@
 #include <config_distro_bootcmd.h>
 #include <env/ti/mmc.h>
 
-/* DDR Configuration */
-#define CFG_SYS_SDRAM_BASE1		0x880000000
-
 /* Now for the remaining common defines */
 #include <configs/ti_armv7_common.h>
 
Signature · 1 line
2.40.0
#11 lore raw

PATCH v6 5/20 include: configs: am62x_evm: Wrap distroboot with CONFIG_DISTRO_DEFAULTS

In reply to Nishanth Menon

Wrap the distro_boot options with CONFIG_DISTRO_DEFAULTS.

This is an intermediate step for us to switch over to CONFIG_BOOTSTD_DEFAULTS and drop this section in follow on patches.

---
No change other than picking up reviews, tested tags along the way.

V5: https://lore.kernel.org/r/[email protected]

 include/configs/am62x_evm.h | 2 ++
 1 file changed, 2 insertions(+)
include/configs/am62x_evm.h +2 -0
index 379e0c13a395..81d7658cdb0d 100644
@@ -9,8 +9,10 @@
 #ifndef __CONFIG_AM625_EVM_H
 #define __CONFIG_AM625_EVM_H
 
+#ifdef CONFIG_DISTRO_DEFAULTS
 #include <config_distro_bootcmd.h>
 #include <env/ti/mmc.h>
+#endif
 
 /* Now for the remaining common defines */
 #include <configs/ti_armv7_common.h>
Signature · 1 line
2.40.0
Reviewed-by on v6 5/20
#12 lore raw

Re: [PATCH V6 05/20] include: configs: am62x_evm: Wrap distroboot with CONFIG_DISTRO_DEFAULTS

Quoted 8 lines · Nishanth Menon

Wrap the distro_boot options with CONFIG_DISTRO_DEFAULTS.

This is an intermediate step for us to switch over to CONFIG_BOOTSTD_DEFAULTS and drop this section in follow on patches.

Quoted 25 lines

---
No change other than picking up reviews, tested tags along the way.

V5: https://lore.kernel.org/r/[email protected]

 include/configs/am62x_evm.h | 2 ++
 1 file changed, 2 insertions(+)
include/configs/am62x_evm.h +2 -0
index 379e0c13a395..81d7658cdb0d 100644
@@ -9,8 +9,10 @@
 #ifndef __CONFIG_AM625_EVM_H
 #define __CONFIG_AM625_EVM_H
 
+#ifdef CONFIG_DISTRO_DEFAULTS
 #include <config_distro_bootcmd.h>
 #include <env/ti/mmc.h>
+#endif
 
 /* Now for the remaining common defines */
 #include <configs/ti_armv7_common.h>
Signature · 1 line
2.40.0
#13 lore raw

PATCH v6 6/20 board: ti: am62x: am62x.env: Add explicit boot_targets

In reply to Nishanth Menon

Add explicit boot_targets to indicate the specific boot sequence to follow.

NOTE: The non-standard ti_mmc emulates what is done for distro_boot. With bootstd, this will eventually need to be replaced by equivalent class.

---
No change other than picking up reviews, tested tags along the way.

V5: https://lore.kernel.org/r/[email protected]

 board/ti/am62x/am62x.env | 1 +
 1 file changed, 1 insertion(+)
board/ti/am62x/am62x.env +1 -0
index f2dc87893a92..1cf56dbd8128 100644
@@ -11,6 +11,7 @@ args_all=setenv optargs ${optargs} earlycon=ns16550a,mmio32,0x02800000
 	${mtdparts}
 run_kern=booti ${loadaddr} ${rd_spec} ${fdtaddr}
 
+boot_targets=ti_mmc mmc0 mmc1 usb pxe dhcp
 boot=mmc
 mmcdev=1
 bootpart=1:2
Signature · 1 line
2.40.0
Reviewed-by on v6 6/20
#14 lore raw

Re: [PATCH V6 06/20] board: ti: am62x: am62x.env: Add explicit boot_targets

Quoted 9 lines · Nishanth Menon

Add explicit boot_targets to indicate the specific boot sequence to follow.

NOTE: The non-standard ti_mmc emulates what is done for distro_boot. With bootstd, this will eventually need to be replaced by equivalent class.

Quoted 21 lines

---
No change other than picking up reviews, tested tags along the way.

V5: https://lore.kernel.org/r/[email protected]

 board/ti/am62x/am62x.env | 1 +
 1 file changed, 1 insertion(+)
board/ti/am62x/am62x.env +1 -0
index f2dc87893a92..1cf56dbd8128 100644
@@ -11,6 +11,7 @@ args_all=setenv optargs ${optargs} earlycon=ns16550a,mmio32,0x02800000
 	${mtdparts}
 run_kern=booti ${loadaddr} ${rd_spec} ${fdtaddr}
 
+boot_targets=ti_mmc mmc0 mmc1 usb pxe dhcp
 boot=mmc
 mmcdev=1
 bootpart=1:2
Signature · 1 line
2.40.0
#15 lore raw

PATCH v6 7/20 configs: am62x_evm_a53_defconfig: Switch to bootstd

In reply to Nishanth Menon

Switch to using bootstd. Note with this change, we will stop using distro_bootcmd and instead depend entirely on bootflow method of starting the system up.

---
No change other than picking up reviews, tested tags along the way.
V5: https://lore.kernel.org/r/[email protected]

 configs/am62x_evm_a53_defconfig | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
configs/am62x_evm_a53_defconfig +3 -2
index d55caabe22c9..1807df8bbee9 100644
@@ -28,8 +28,9 @@ CONFIG_SPL_SPI=y
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_SPL_LOAD_FIT=y
 CONFIG_SPL_LOAD_FIT_ADDRESS=0x81000000
-CONFIG_DISTRO_DEFAULTS=y
-CONFIG_BOOTCOMMAND="run envboot; run distro_bootcmd;"
+CONFIG_BOOTSTD_FULL=y
+CONFIG_BOOTSTD_DEFAULTS=y
+CONFIG_BOOTCOMMAND="run envboot; bootflow scan -lb"
 CONFIG_SPL_MAX_SIZE=0x58000
 CONFIG_SPL_HAS_BSS_LINKER_SECTION=y
 CONFIG_SPL_BSS_START_ADDR=0x80c80000
Signature · 1 line
2.40.0
Reviewed-by on v6 7/20
#16 lore raw

Re: [PATCH V6 07/20] configs: am62x_evm_a53_defconfig: Switch to bootstd

Quoted 9 lines · Nishanth Menon

Switch to using bootstd. Note with this change, we will stop using distro_bootcmd and instead depend entirely on bootflow method of starting the system up.

Signature · 1 line
Tom
Reviewed-by on v6 7/20
#17 lore raw

Re: [PATCH V6 07/20] configs: am62x_evm_a53_defconfig: Switch to bootstd

In reply to Nishanth Menon
Quoted 9 lines · Nishanth Menon

Switch to using bootstd. Note with this change, we will stop using distro_bootcmd and instead depend entirely on bootflow method of starting the system up.

Quoted 24 lines

---
No change other than picking up reviews, tested tags along the way.
V5: https://lore.kernel.org/r/[email protected]

 configs/am62x_evm_a53_defconfig | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
configs/am62x_evm_a53_defconfig +3 -2
index d55caabe22c9..1807df8bbee9 100644
@@ -28,8 +28,9 @@ CONFIG_SPL_SPI=y
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_SPL_LOAD_FIT=y
 CONFIG_SPL_LOAD_FIT_ADDRESS=0x81000000
-CONFIG_DISTRO_DEFAULTS=y
-CONFIG_BOOTCOMMAND="run envboot; run distro_bootcmd;"
+CONFIG_BOOTSTD_FULL=y
+CONFIG_BOOTSTD_DEFAULTS=y
+CONFIG_BOOTCOMMAND="run envboot; bootflow scan -lb"
 CONFIG_SPL_MAX_SIZE=0x58000
 CONFIG_SPL_HAS_BSS_LINKER_SECTION=y
 CONFIG_SPL_BSS_START_ADDR=0x80c80000
Signature · 1 line
2.40.0
#18 lore raw

Re: [PATCH V6 07/20] configs: am62x_evm_a53_defconfig: Switch to bootstd

In reply to Nishanth Menon

Hello Nishanth,

Quoted 30 lines · Nishanth Menon

Switch to using bootstd. Note with this change, we will stop using distro_bootcmd and instead depend entirely on bootflow method of starting the system up.

---
No change other than picking up reviews, tested tags along the way.
V5: https://lore.kernel.org/r/[email protected]
 configs/am62x_evm_a53_defconfig | 5 +++--

 1 file changed, 3 insertions(+), 2 deletions(-)
configs/am62x_evm_a53_defconfig +0 -0
index d55caabe22c9..1807df8bbee9 100644
@@ -28,8 +28,9 @@ CONFIG_SPL_SPI=y
  # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set

 CONFIG_SPL_LOAD_FIT=y
 CONFIG_SPL_LOAD_FIT_ADDRESS=0x81000000

configs/am62x_evm_a53_defconfig +3 -2
-CONFIG_DISTRO_DEFAULTS=y
-CONFIG_BOOTCOMMAND="run envboot; run distro_bootcmd;"
+CONFIG_BOOTSTD_FULL=y
+CONFIG_BOOTSTD_DEFAULTS=y
+CONFIG_BOOTCOMMAND="run envboot; bootflow scan -lb"
Quoted 3 lines

 CONFIG_SPL_MAX_SIZE=0x58000
 CONFIG_SPL_HAS_BSS_LINKER_SECTION=y
 CONFIG_SPL_BSS_START_ADDR=0x80c80000

could you please suggest which distro have you used for testing?

After U-Boot update to v2024.01 Buildroot is not booting any more:

---
U-Boot 2024.01 (Feb 15 2024 - 01:43:17 +0100)

SoC:   AM62X SR1.0 HS-FS
Model: Texas Instruments AM625 SK
DRAM:  2 GiB
Core:  56 devices, 23 uclasses, devicetree: separate
MMC:   mmc@fa10000: 0, mmc@fa00000: 1
Loading Environment from nowhere... OK
In:    serial@2800000
Out:   serial@2800000
Err:   serial@2800000
Net:   eth0: ethernet@8000000port@1
Hit any key to stop autoboot:  0 

switch to partitions #0, OK
mmc1 is current device
SD/MMC found on device 1
Failed to load 'uEnv.txt'
Scanning for bootflows in all bootdevs

Seq  Method       State   Uclass    Part  Name                      Filename
---  -----------  ------  --------  ----  ------------------------  ----------------

Scanning global bootmeth 'efi_mgr':
No EFI system partition
No EFI system partition
Failed to persist EFI variables
Scanning bootdev '[email protected]':
Scanning bootdev '[email protected]':
Unknown uclass 'usb' in label
link up on port 1, speed 100, full duplex
BOOTP broadcast 1
BOOTP broadcast 2
BOOTP broadcast 3
...
---

I suppose TI's BSP has older U-Boot... So it's not providing necessary script for BOOTSTD, I suppose?

Signature · 1 line
Alexander Sverdlin.
#19 lore raw

Re: [PATCH V6 07/20] configs: am62x_evm_a53_defconfig: Switch to bootstd

Quoted 76 lines · Alexander Sverdlin

Hello Nishanth,

Quoted 30 lines · Nishanth Menon

Switch to using bootstd. Note with this change, we will stop using distro_bootcmd and instead depend entirely on bootflow method of starting the system up.

---
No change other than picking up reviews, tested tags along the way.
V5: https://lore.kernel.org/r/[email protected]
 configs/am62x_evm_a53_defconfig | 5 +++--

 1 file changed, 3 insertions(+), 2 deletions(-)
configs/am62x_evm_a53_defconfig +0 -0
index d55caabe22c9..1807df8bbee9 100644
@@ -28,8 +28,9 @@ CONFIG_SPL_SPI=y
  # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set

 CONFIG_SPL_LOAD_FIT=y
 CONFIG_SPL_LOAD_FIT_ADDRESS=0x81000000

configs/am62x_evm_a53_defconfig +3 -2
-CONFIG_DISTRO_DEFAULTS=y
-CONFIG_BOOTCOMMAND="run envboot; run distro_bootcmd;"
+CONFIG_BOOTSTD_FULL=y
+CONFIG_BOOTSTD_DEFAULTS=y
+CONFIG_BOOTCOMMAND="run envboot; bootflow scan -lb"
Quoted 3 lines

 CONFIG_SPL_MAX_SIZE=0x58000
 CONFIG_SPL_HAS_BSS_LINKER_SECTION=y
 CONFIG_SPL_BSS_START_ADDR=0x80c80000

could you please suggest which distro have you used for testing?

After U-Boot update to v2024.01 Buildroot is not booting any more:

---
U-Boot 2024.01 (Feb 15 2024 - 01:43:17 +0100)

SoC:   AM62X SR1.0 HS-FS
Model: Texas Instruments AM625 SK
DRAM:  2 GiB
Core:  56 devices, 23 uclasses, devicetree: separate
MMC:   mmc@fa10000: 0, mmc@fa00000: 1
Loading Environment from nowhere... OK
In:    serial@2800000
Out:   serial@2800000
Err:   serial@2800000
Net:   eth0: ethernet@8000000port@1
Hit any key to stop autoboot:  0 

switch to partitions #0, OK
mmc1 is current device
SD/MMC found on device 1
Failed to load 'uEnv.txt'
Scanning for bootflows in all bootdevs

Seq  Method       State   Uclass    Part  Name                      Filename
---  -----------  ------  --------  ----  ------------------------  ----------------

Scanning global bootmeth 'efi_mgr':
No EFI system partition
No EFI system partition
Failed to persist EFI variables
Scanning bootdev '[email protected]':
Scanning bootdev '[email protected]':
Unknown uclass 'usb' in label
link up on port 1, speed 100, full duplex
BOOTP broadcast 1
BOOTP broadcast 2
BOOTP broadcast 3
...
---

Quoted 3 lines

I suppose TI's BSP has older U-Boot... So it's not providing necessary script for BOOTSTD, I suppose?

You can make the BeagleBone boot via EFI, but it requires a hybrid partition table (ROM loader want DOS, EFI needs GPT). A Debian integration with this can be found for Isar [1] in this series [2]. It's only using upstream sources (plus still one u-boot patch to get wifi working).

If you want legacy script booting, I suspect you need to flip some extra switches explicitly by now.

Jan

[1] https://github.com/ilbers/isar/
[2] https://patchwork.isar-build.org/project/isar/list/?series=1049

Signature · 2 lines
Siemens AG, Technology
Linux Expert Center
#20 lore raw

Re: [PATCH V6 07/20] configs: am62x_evm_a53_defconfig: Switch to bootstd

Hi Jan!

Quoted 38 lines · Jan Kiszka
Quoted 34 lines

U-Boot 2024.01 (Feb 15 2024 - 01:43:17 +0100)

SoC:   AM62X SR1.0 HS-FS
Model: Texas Instruments AM625 SK
DRAM:  2 GiB
Core:  56 devices, 23 uclasses, devicetree: separate
MMC:   mmc@fa10000: 0, mmc@fa00000: 1
Loading Environment from nowhere... OK
In:    serial@2800000
Out:   serial@2800000
Err:   serial@2800000
Net:   eth0: ethernet@8000000port@1
Hit any key to stop autoboot:  0
switch to partitions #0, OK
mmc1 is current device
SD/MMC found on device 1
Failed to load 'uEnv.txt'
Scanning for bootflows in all bootdevs
Seq  Method       State   Uclass    Part  Name                      Filename ---  -----------  ------  --------  ----  ------------------------  ---------------- Scanning global bootmeth 'efi_mgr':
No EFI system partition
No EFI system partition
Failed to persist EFI variables
Scanning bootdev '[email protected]':
Scanning bootdev '[email protected]':
Unknown uclass 'usb' in label
link up on port 1, speed 100, full duplex
BOOTP broadcast 1
BOOTP broadcast 2
BOOTP broadcast 3
...
---

Quoted 3 lines

I suppose TI's BSP has older U-Boot... So it's not providing necessary script for BOOTSTD, I suppose?

Quoted 8 lines

You can make the BeagleBone boot via EFI, but it requires a hybrid partition table (ROM loader want DOS, EFI needs GPT). A Debian integration with this can be found for Isar [1] in this series [2]. It's only using upstream sources (plus still one u-boot patch to get wifi working).

If you want legacy script booting, I suspect you need to flip some extra switches explicitly by now.

Thanks for the hints!
I'm wondering, if this was a deliberate "let's stop booting all the pre-existing embedded distros" decision? (buildroot, yocto/meta-ti...)

Signature · 1 line
Alexander Sverdlin.
#21 lore raw

Re: [PATCH V6 07/20] configs: am62x_evm_a53_defconfig: Switch to bootstd

Quoted 47 lines · Alexander Sverdlin

Hi Jan!

Quoted 44 lines · Jan Kiszka
Quoted 34 lines

U-Boot 2024.01 (Feb 15 2024 - 01:43:17 +0100)

SoC:   AM62X SR1.0 HS-FS
Model: Texas Instruments AM625 SK
DRAM:  2 GiB
Core:  56 devices, 23 uclasses, devicetree: separate
MMC:   mmc@fa10000: 0, mmc@fa00000: 1
Loading Environment from nowhere... OK
In:    serial@2800000
Out:   serial@2800000
Err:   serial@2800000
Net:   eth0: ethernet@8000000port@1
Hit any key to stop autoboot:  0
switch to partitions #0, OK
mmc1 is current device
SD/MMC found on device 1
Failed to load 'uEnv.txt'
Scanning for bootflows in all bootdevs
Seq  Method       State   Uclass    Part  Name                      Filename ---  -----------  ------  --------  ----  ------------------------  ---------------- Scanning global bootmeth 'efi_mgr':
No EFI system partition
No EFI system partition
Failed to persist EFI variables
Scanning bootdev '[email protected]':
Scanning bootdev '[email protected]':
Unknown uclass 'usb' in label
link up on port 1, speed 100, full duplex
BOOTP broadcast 1
BOOTP broadcast 2
BOOTP broadcast 3
...
---

Quoted 3 lines

I suppose TI's BSP has older U-Boot... So it's not providing necessary script for BOOTSTD, I suppose?

You can make the BeagleBone boot via EFI, but it requires a hybrid partition table (ROM loader want DOS, EFI needs GPT). A Debian integration with this can be found for Isar [1] in this series [2]. It's only using upstream sources (plus still one u-boot patch to get wifi working).

Quoted 7 lines
Quoted 2 lines

If you want legacy script booting, I suspect you need to flip some extra switches explicitly by now.

Thanks for the hints!
I'm wondering, if this was a deliberate "let's stop booting all the pre-existing embedded distros" decision? (buildroot, yocto/meta-ti...)

FWIW, I'm not seeing other boot methods being specifically disabled in beagleplay in 2024.01 or even newer. I didn't try the result, but this may actually be some other issue and real bug, nothing obviously intended.

My personal observation is that continuous integration testings with all-upstream components is not really a common thing. I saw that with multiple active SoCs from various vendors.

Jan

Signature · 2 lines
Siemens AG, Technology
Linux Expert Center
#22 lore raw

Re: [PATCH V6 07/20] configs: am62x_evm_a53_defconfig: Switch to bootstd

Quoted 51 lines · Jan Kiszka
Quoted 50 lines · Alexander Sverdlin

Hi Jan!

Quoted 46 lines · Jan Kiszka
Quoted 34 lines

U-Boot 2024.01 (Feb 15 2024 - 01:43:17 +0100)

SoC:   AM62X SR1.0 HS-FS
Model: Texas Instruments AM625 SK
DRAM:  2 GiB
Core:  56 devices, 23 uclasses, devicetree: separate
MMC:   mmc@fa10000: 0, mmc@fa00000: 1
Loading Environment from nowhere... OK
In:    serial@2800000
Out:   serial@2800000
Err:   serial@2800000
Net:   eth0: ethernet@8000000port@1
Hit any key to stop autoboot:  0
switch to partitions #0, OK
mmc1 is current device
SD/MMC found on device 1
Failed to load 'uEnv.txt'
Scanning for bootflows in all bootdevs
Seq  Method       State   Uclass    Part  Name                      Filename ---  -----------  ------  --------  ----  ------------------------  ---------------- Scanning global bootmeth 'efi_mgr':
No EFI system partition
No EFI system partition
Failed to persist EFI variables
Scanning bootdev '[email protected]':
Scanning bootdev '[email protected]':
Unknown uclass 'usb' in label
link up on port 1, speed 100, full duplex
BOOTP broadcast 1
BOOTP broadcast 2
BOOTP broadcast 3
...
---

Quoted 3 lines

I suppose TI's BSP has older U-Boot... So it's not providing necessary script for BOOTSTD, I suppose?

You can make the BeagleBone boot via EFI, but it requires a hybrid partition table (ROM loader want DOS, EFI needs GPT). A Debian integration with this can be found for Isar [1] in this series [2]. It's only using upstream sources (plus still one u-boot patch to get wifi working).

If you want legacy script booting, I suspect you need to flip some extra switches explicitly by now.

Quoted 9 lines
Quoted 4 lines

Thanks for the hints!
I'm wondering, if this was a deliberate "let's stop booting all the pre-existing embedded distros" decision? (buildroot, yocto/meta-ti...)

FWIW, I'm not seeing other boot methods being specifically disabled in beagleplay in 2024.01 or even newer. I didn't try the result, but this may actually be some other issue and real bug, nothing obviously intended.

I'm not even sure about this anymore, though there is still a bug, just a different one:

...
U-Boot 2024.04-rc2-00040-g3e6f2a94bfc (Feb 20 2024 - 08:42:59 +0100)

SoC:   AM62X SR1.0 GP
Model: BeagleBoard.org BeaglePlay
DRAM:  2 GiB
Core:  98 devices, 27 uclasses, devicetree: separate
MMC:   mmc@fa10000: 0, mmc@fa00000: 1, mmc@fa20000: 2
Loading Environment from nowhere... OK
In:    serial@2800000
Out:   serial@2800000
Err:   serial@2800000
Net:   No ethernet found.

Press SPACE to abort autoboot in 2 seconds => print bootmeths
bootmeths=script extlinux efi pxe
=> bootflow scan -l
Scanning for bootflows in all bootdevs

Seq  Method       State   Uclass    Part  Name                      Filename
---  -----------  ------  --------  ----  ------------------------  ----------------

Scanning bootdev '[email protected]':
0 efi ready mmc 2 [email protected]_ efi/boot/bootaa64.efi
Scanning bootdev '[email protected]':
1 extlinux ready mmc 1 [email protected]_ /extlinux/extlinux.conf
Unknown uclass 'usb' in label
"Synchronous Abort" handler, esr 0x86000004, far 0x3030303030303840
elr: 3030302fb0bc0840 lr : 3030302fb0bc0840 (reloc)
elr: 3030303030303840 lr : 3030303030303840
x0 : 00000000ffffffed x1 : 0000000000000000
x2 : 0000000000000002 x3 : 00000000ffb49d30
x4 : 00000000fffd4c00 x5 : 00000000ffb49d50
x6 : 0000000000000000 x7 : 00000000ffb4e890
x8 : 0000000000006924 x9 : 00000000ffb1212c
x10: 0000000000000003 x11: 0000000000006914
x12: 00000000ffb1221c x13: 00000000ffb12b40
x14: 00000000ffb12b40 x15: 00000000ffb12535
x16: 00000000fff8a9d4 x17: 0000000000000000
x18: 00000000ffb23da0 x19: 0000314074726f70
x20: 00000000fffed000 x21: 00000000fffef000
x22: 0000000000000000 x23: 00000000fffef000
x24: 00000000fffef000 x25: 0000000000000000
x26: 00000000fffc7174 x27: 0000000000000000
x28: 0000000000000000 x29: 74656e7265687465

Same with 2024.01 release.

Jan

Signature · 2 lines
Siemens AG, Technology
Linux Expert Center
#23 lore raw

Re: [PATCH V6 07/20] configs: am62x_evm_a53_defconfig: Switch to bootstd

Quoted 28 lines · Jan Kiszka
Quoted 27 lines · Jan Kiszka
Quoted 26 lines · Alexander Sverdlin

Hi Jan!

Quoted 23 lines · Jan Kiszka
Quoted 23 lines

U-Boot 2024.01 (Feb 15 2024 - 01:43:17 +0100)

SoC:   AM62X SR1.0 HS-FS
Model: Texas Instruments AM625 SK
DRAM:  2 GiB
Core:  56 devices, 23 uclasses, devicetree: separate
MMC:   mmc@fa10000: 0, mmc@fa00000: 1
Loading Environment from nowhere... OK
In:    serial@2800000
Out:   serial@2800000
Err:   serial@2800000
Net:   eth0: ethernet@8000000port@1
Hit any key to stop autoboot:  0
switch to partitions #0, OK
mmc1 is current device
SD/MMC found on device 1
Failed to load 'uEnv.txt'
Scanning for bootflows in all bootdevs
Seq  Method       State   Uclass    Part  Name                      Filename ---  -----------  ------  --------  ----  ------------------------  ---------------- Scanning global bootmeth 'efi_mgr':
No EFI system partition
No EFI system partition

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines

Failed to persist EFI variables
Scanning bootdev '[email protected]':
Scanning bootdev '[email protected]':
Unknown uclass 'usb' in label
link up on port 1, speed 100, full duplex
BOOTP broadcast 1
BOOTP broadcast 2
BOOTP broadcast 3

I am pretty sure ethernet is not enabled in upstream u-boot.

Quoted 13 lines
Quoted 13 lines
Quoted 13 lines
Quoted 13 lines
Quoted 6 lines

...
---

I suppose TI's BSP has older U-Boot... So it's not providing necessary script for BOOTSTD, I suppose?

You can make the BeagleBone boot via EFI, but it requires a hybrid partition table (ROM loader want DOS, EFI needs GPT). A Debian integration with this can be found for Isar [1] in this series [2]. It's only using upstream sources (plus still one u-boot patch to get wifi working).

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 2 lines

If you want legacy script booting, I suspect you need to flip some extra switches explicitly by now.

Thanks for the hints!
I'm wondering, if this was a deliberate "let's stop booting all the pre-existing embedded distros" decision? (buildroot, yocto/meta-ti...)

It was more of a "lets standardize one way of booting across all ARM devices as much as we can" effort - EBBR and others inclusive. To that effort, distro_boot and bootstd have made significant steps forward.
NOTE: yocto, buildroot etc will need a few tweaks to get things operational unfortunately. BUT, note: bootstd was what beagleplay was introduced upstream as default in the first place - so all we are finding is that introduced behavior.

Quoted 55 lines
Quoted 6 lines
Quoted 1 line

FWIW, I'm not seeing other boot methods being specifically disabled in beagleplay in 2024.01 or even newer. I didn't try the result, but this may actually be some other issue and real bug, nothing obviously intended.

I'm not even sure about this anymore, though there is still a bug, just a different one:

...
U-Boot 2024.04-rc2-00040-g3e6f2a94bfc (Feb 20 2024 - 08:42:59 +0100)

SoC:   AM62X SR1.0 GP
Model: BeagleBoard.org BeaglePlay
DRAM:  2 GiB
Core:  98 devices, 27 uclasses, devicetree: separate
MMC:   mmc@fa10000: 0, mmc@fa00000: 1, mmc@fa20000: 2
Loading Environment from nowhere... OK
In:    serial@2800000
Out:   serial@2800000
Err:   serial@2800000
Net:   No ethernet found.

Press SPACE to abort autoboot in 2 seconds => print bootmeths
bootmeths=script extlinux efi pxe
=> bootflow scan -l
Scanning for bootflows in all bootdevs

Seq  Method       State   Uclass    Part  Name                      Filename
---  -----------  ------  --------  ----  ------------------------  ----------------

Scanning bootdev '[email protected]':
0 efi ready mmc 2 [email protected]_ efi/boot/bootaa64.efi
Scanning bootdev '[email protected]':
1 extlinux ready mmc 1 [email protected]_ /extlinux/extlinux.conf
Unknown uclass 'usb' in label
"Synchronous Abort" handler, esr 0x86000004, far 0x3030303030303840
elr: 3030302fb0bc0840 lr : 3030302fb0bc0840 (reloc)
elr: 3030303030303840 lr : 3030303030303840
x0 : 00000000ffffffed x1 : 0000000000000000
x2 : 0000000000000002 x3 : 00000000ffb49d30
x4 : 00000000fffd4c00 x5 : 00000000ffb49d50
x6 : 0000000000000000 x7 : 00000000ffb4e890
x8 : 0000000000006924 x9 : 00000000ffb1212c
x10: 0000000000000003 x11: 0000000000006914
x12: 00000000ffb1221c x13: 00000000ffb12b40
x14: 00000000ffb12b40 x15: 00000000ffb12535
x16: 00000000fff8a9d4 x17: 0000000000000000
x18: 00000000ffb23da0 x19: 0000314074726f70
x20: 00000000fffed000 x21: 00000000fffef000
x22: 0000000000000000 x23: 00000000fffef000
x24: 00000000fffef000 x25: 0000000000000000
x26: 00000000fffc7174 x27: 0000000000000000
x28: 0000000000000000 x29: 74656e7265687465

Quoted 1 line

Same with 2024.01 release.

boot_targets=mmc1 mmc0 usb pxe

networking ran into some significant challenges. I was hoping to get networking merged but the series got offset and network never made it.. Dropping pxe from boot_targets

=> setenv boot_targets mmc1 mmc0 usb
=> print bootmeths
bootmeths=script extlinux efi pxe
=> print boot_targets
boot_targets=mmc1 mmc0 usb
=> bootflow scan -l
Scanning for bootflows in all bootdevs

Seq  Method       State   Uclass    Part  Name                      Filename
---  -----------  ------  --------  ----  ------------------------  ----------------

Scanning bootdev '[email protected]':
0 extlinux ready mmc 1 [email protected]_ /extlinux/extlinux.conf
Scanning bootdev '[email protected]':
1 extlinux ready mmc 1 [email protected]_ /extlinux/extlinux.conf
Unknown uclass 'usb' in label
No more bootdevs
--- ----------- ------ -------- ---- ------------------------ ---------------- (2 bootflows, 2 valid)
=>

Signature · 3 lines
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
#24 lore raw

Re: [PATCH V6 07/20] configs: am62x_evm_a53_defconfig: Switch to bootstd

In reply to Jan Kiszka
Quoted 3 lines · Jan Kiszka

My personal observation is that continuous integration testings with all-upstream components is not really a common thing. I saw that with multiple active SoCs from various vendors.

For what it is worth, https://software-dl.ti.com/cicd-report/upstream/
-> we are trying to do that on TI side, though it is still in infancy and test coverage is still more to be desired.

Signature · 3 lines
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
#25 lore raw

Re: [PATCH V6 07/20] configs: am62x_evm_a53_defconfig: Switch to bootstd

In reply to Jan Kiszka

Hello Jan,

Quoted 3 lines · Jan Kiszka

My personal observation is that continuous integration testings with all-upstream components is not really a common thing. I saw that with multiple active SoCs from various vendors.

With some limitation we have this running in Toradex since a couple of years, we do integrate latest mainline kernel/u-boot and OE master layers and run all that through our Lava test suite on real hardware.

It has challenges, even getting the build to succeed is not obvious and requires continuous care, but we do spot regression on RC releases and we actively report and/or contribute fixes for it.

Unfortunately the test results are still not published on some website and are only internal, but we are working on making this available.

Looking forward to have more players doing it, starting from the SoC vendors!

Francesco

#26 lore raw

Re: [PATCH V6 07/20] configs: am62x_evm_a53_defconfig: Switch to bootstd

Quoted 15 lines · Francesco Dolcini

Hello Jan,

Quoted 3 lines · Jan Kiszka

My personal observation is that continuous integration testings with all-upstream components is not really a common thing. I saw that with multiple active SoCs from various vendors.

With some limitation we have this running in Toradex since a couple of years, we do integrate latest mainline kernel/u-boot and OE master layers and run all that through our Lava test suite on real hardware.

It has challenges, even getting the build to succeed is not obvious and requires continuous care, but we do spot regression on RC releases and we actively report and/or contribute fixes for it.

Quoted 5 lines

Unfortunately the test results are still not published on some website and are only internal, but we are working on making this available.

Looking forward to have more players doing it, starting from the SoC vendors!

This is great to hear an highly welcome!

One challenge of this is definitely to get the information to the right people, ideally without requiring too much manual effort (as that is often the most limited resource) while not overloading the target audience with too many false or inaccurate reports.

Jan

Signature · 2 lines
Siemens AG, Technology
Linux Expert Center
#27 lore raw

PATCH v6 8/20 include: configs: am62x_evm: Drop distro_bootcmd usage

In reply to Nishanth Menon

Now that BOOTSTD is used by default, drop un-used header file inclusion.

---
No change other than picking up reviews, tested tags along the way.
V5: https://lore.kernel.org/r/[email protected]

 include/configs/am62x_evm.h | 5 -----
 1 file changed, 5 deletions(-)
include/configs/am62x_evm.h +0 -5
index 81d7658cdb0d..c8fe59b75313 100644
@@ -9,11 +9,6 @@
 #ifndef __CONFIG_AM625_EVM_H
 #define __CONFIG_AM625_EVM_H
 
-#ifdef CONFIG_DISTRO_DEFAULTS
-#include <config_distro_bootcmd.h>
-#include <env/ti/mmc.h>
-#endif
-
 /* Now for the remaining common defines */
 #include <configs/ti_armv7_common.h>
 
Signature · 1 line
2.40.0
Reviewed-by on v6 8/20
#28 lore raw

Re: [PATCH V6 08/20] include: configs: am62x_evm: Drop distro_bootcmd usage

Quoted 6 lines · Nishanth Menon

Now that BOOTSTD is used by default, drop un-used header file inclusion.

Quoted 24 lines

---
No change other than picking up reviews, tested tags along the way.
V5: https://lore.kernel.org/r/[email protected]

 include/configs/am62x_evm.h | 5 -----
 1 file changed, 5 deletions(-)
include/configs/am62x_evm.h +0 -5
index 81d7658cdb0d..c8fe59b75313 100644
@@ -9,11 +9,6 @@
 #ifndef __CONFIG_AM625_EVM_H
 #define __CONFIG_AM625_EVM_H
 
-#ifdef CONFIG_DISTRO_DEFAULTS
-#include <config_distro_bootcmd.h>
-#include <env/ti/mmc.h>
-#endif
-
 /* Now for the remaining common defines */
 #include <configs/ti_armv7_common.h>
 
Signature · 1 line
2.40.0
#29 lore raw

PATCH v6 9/20 include: env: ti: ti_armv7_common.env: Rename to ti_common.env

In reply to Nishanth Menon

ti_armv7_common does not make any more sense as it is used by armv7 and armv8 TI based platforms.

---
No change other than picking up reviews, tested tags along the way.
V5: https://lore.kernel.org/r/[email protected]

 board/siemens/iot2050/iot2050.env                     | 2 +-
 board/ti/am62ax/am62ax.env                            | 2 +-
 board/ti/am62x/am62x.env                              | 2 +-
 board/ti/am64x/am64x.env                              | 2 +-
 board/ti/am65x/am65x.env                              | 2 +-
 board/ti/j721e/j721e.env                              | 2 +-
 board/ti/j721s2/j721s2.env                            | 2 +-
 board/ti/ks2_evm/k2e_evm.env                          | 2 +-
 board/ti/ks2_evm/k2g_evm.env                          | 2 +-
 board/ti/ks2_evm/k2hk_evm.env                         | 2 +-
 board/ti/ks2_evm/k2l_evm.env                          | 2 +-
 include/env/ti/{ti_armv7_common.env => ti_common.env} | 0
 12 files changed, 11 insertions(+), 11 deletions(-)
 rename include/env/ti/{ti_armv7_common.env => ti_common.env} (100%)
board/siemens/iot2050/iot2050.env +1 -1
index caa9f80e3fca..8bbd7abe98f0 100644
@@ -6,7 +6,7 @@
  *   Jan Kiszka <[email protected]>
  */
 
-#include <env/ti/ti_armv7_common.env>
+#include <env/ti/ti_common.env>
 
 usb_pgood_delay=900
 
board/ti/am62ax/am62ax.env +1 -1
index 3f7c333fa404..bfed7f360844 100644
@@ -1,4 +1,4 @@
-#include <env/ti/ti_armv7_common.env>
+#include <env/ti/ti_common.env>
 #include <env/ti/mmc.env>
 
 default_device_tree=ti/k3-am62a7-sk.dtb
board/ti/am62x/am62x.env +1 -1
index 1cf56dbd8128..1ef948df83d7 100644
@@ -1,4 +1,4 @@
-#include <env/ti/ti_armv7_common.env>
+#include <env/ti/ti_common.env>
 #include <env/ti/mmc.env>
 
 default_device_tree=ti/k3-am625-sk.dtb
board/ti/am64x/am64x.env +1 -1
index 1567907fcbdc..68e42222b7f1 100644
@@ -1,4 +1,4 @@
-#include <env/ti/ti_armv7_common.env>
+#include <env/ti/ti_common.env>
 #include <env/ti/mmc.env>
 #include <env/ti/k3_dfu.env>
 
board/ti/am65x/am65x.env +1 -1
index 755bff2707c8..286b9c300c05 100644
@@ -1,4 +1,4 @@
-#include <env/ti/ti_armv7_common.env>
+#include <env/ti/ti_common.env>
 #include <env/ti/mmc.env>
 #include <env/ti/k3_dfu.env>
 #if CONFIG_CMD_REMOTEPROC
board/ti/j721e/j721e.env +1 -1
index 2f2fb0591279..8cc8232fc131 100644
@@ -1,4 +1,4 @@
-#include <env/ti/ti_armv7_common.env>
+#include <env/ti/ti_common.env>
 #include <env/ti/mmc.env>
 #include <env/ti/ufs.env>
 #include <env/ti/k3_dfu.env>
board/ti/j721s2/j721s2.env +1 -1
index 6825b1469854..64e3d9da85f0 100644
@@ -1,4 +1,4 @@
-#include <env/ti/ti_armv7_common.env>
+#include <env/ti/ti_common.env>
 #include <env/ti/mmc.env>
 #include <env/ti/ufs.env>
 #include <env/ti/k3_dfu.env>
board/ti/ks2_evm/k2e_evm.env +1 -1
index a145db53e5fa..3dbb7934c59a 100644
@@ -1,4 +1,4 @@
-#include <env/ti/ti_armv7_common.env>
+#include <env/ti/ti_common.env>
 #include <env/ti/ti_armv7_keystone2.env>
 
 findfdt=setenv fdtfile ${name_fdt}
board/ti/ks2_evm/k2g_evm.env +1 -1
index 4f4941dd0907..2b500fc6edf6 100644
@@ -1,4 +1,4 @@
-#include <env/ti/ti_armv7_common.env>
+#include <env/ti/ti_common.env>
 #include <env/ti/ti_armv7_keystone2.env>
 #include <env/ti/mmc.env>
 
board/ti/ks2_evm/k2hk_evm.env +1 -1
index 0714a51090ef..9991b76f8fcc 100644
@@ -1,4 +1,4 @@
-#include <env/ti/ti_armv7_common.env>
+#include <env/ti/ti_common.env>
 #include <env/ti/ti_armv7_keystone2.env>
 
 findfdt=setenv fdtfile ${name_fdt}
board/ti/ks2_evm/k2l_evm.env +1 -1
index e8a803a4ed76..4e2debca4bde 100644
@@ -1,4 +1,4 @@
-#include <env/ti/ti_armv7_common.env>
+#include <env/ti/ti_common.env>
 #include <env/ti/ti_armv7_keystone2.env>
 
 findfdt=setenv fdtfile ${name_fdt}
include/env/ti/ti_common.env renamed from include/env/ti/ti_armv7_common.env +0 -0
similarity index 100%
rename from include/env/ti/ti_armv7_common.env
rename to include/env/ti/ti_common.env
Signature · 1 line
2.40.0
#30 lore raw

PATCH v6 10/20 include: env: ti: Add a generic default_findfdt.env

In reply to Nishanth Menon

ti_mmc bootmethod uses a findfdt routine that is expected to be implemented by all platforms.

Define a default findfdt based on configured DEFAULT_DEVICE_TREE option for u-boot. This saves duplication across multiple boards and handles architecture folder location changes centrally.

TI ARMV7 platforms will need to override default_device_tree_subarch in the env file to point to the appropriate platform. Note: default "omap" is used to cater to "most common" default.

---
Changes:
* Made it as default_findfdt as discussed in review.

V5: https://lore.kernel.org/r/[email protected]

 include/env/ti/default_findfdt.env | 12 ++++++++++++
 1 file changed, 12 insertions(+)
 create mode 100644 include/env/ti/default_findfdt.env
include/env/ti/default_findfdt.env new file +12 -0
new file mode 100644
index 000000000000..a2b51dd923bb
@@ -0,0 +1,12 @@
+default_device_tree=CONFIG_DEFAULT_DEVICE_TREE
+default_device_tree_arch=ti
+#ifdef CONFIG_ARM64
+findfdt=
+	setenv name_fdt ${default_device_tree_arch}/${default_device_tree}.dtb;
+	setenv fdtfile ${name_fdt}
+#else
+default_device_tree_subarch=omap
+findfdt=
+	setenv name_fdt ${default_device_tree_arch}/${default_device_tree_subarch}/${default_device_tree}.dtb;
+	setenv fdtfile ${name_fdt}
+#endif
Signature · 1 line
2.40.0
Reviewed-by on v6 10/20
#31 lore raw

Re: [PATCH V6 10/20] include: env: ti: Add a generic default_findfdt.env

Quoted 7 lines · Nishanth Menon

ti_mmc bootmethod uses a findfdt routine that is expected to be implemented by all platforms.

Define a default findfdt based on configured DEFAULT_DEVICE_TREE option for u-boot. This saves duplication across multiple boards and handles architecture folder location changes centrally.

Quoted 6 lines

TI ARMV7 platforms will need to override default_device_tree_subarch in the env file to point to the appropriate platform. Note: default "omap" is used to cater to "most common" default.

Signature · 1 line
Tom
Reviewed-by on v6 10/20
#32 lore raw

Re: [PATCH V6 10/20] include: env: ti: Add a generic default_findfdt.env

In reply to Nishanth Menon
Quoted 7 lines · Nishanth Menon

ti_mmc bootmethod uses a findfdt routine that is expected to be implemented by all platforms.

Define a default findfdt based on configured DEFAULT_DEVICE_TREE option for u-boot. This saves duplication across multiple boards and handles architecture folder location changes centrally.

Quoted 6 lines

TI ARMV7 platforms will need to override default_device_tree_subarch in the env file to point to the appropriate platform. Note: default "omap" is used to cater to "most common" default.

Quoted 29 lines

---
Changes:
* Made it as default_findfdt as discussed in review.

V5: https://lore.kernel.org/r/[email protected]

 include/env/ti/default_findfdt.env | 12 ++++++++++++
 1 file changed, 12 insertions(+)
 create mode 100644 include/env/ti/default_findfdt.env
include/env/ti/default_findfdt.env new file +12 -0
new file mode 100644
index 000000000000..a2b51dd923bb
@@ -0,0 +1,12 @@
+default_device_tree=CONFIG_DEFAULT_DEVICE_TREE
+default_device_tree_arch=ti
+#ifdef CONFIG_ARM64
+findfdt=
+	setenv name_fdt ${default_device_tree_arch}/${default_device_tree}.dtb;
+	setenv fdtfile ${name_fdt}
+#else
+default_device_tree_subarch=omap
+findfdt=
+	setenv name_fdt ${default_device_tree_arch}/${default_device_tree_subarch}/${default_device_tree}.dtb;
+	setenv fdtfile ${name_fdt}
+#endif
Signature · 1 line
2.40.0
#33 lore raw

PATCH v6 11/20 board: ti: am62x: am62x.env: Use default findfdt

In reply to Nishanth Menon

Use the default findfdt using CONFIG_DEFAULT_DEVICE_TREE

---
No change that picking up Review, tested by and using new include file.

V5: https://lore.kernel.org/r/[email protected]

 board/ti/am62x/am62x.env | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
board/ti/am62x/am62x.env +1 -4
index 1ef948df83d7..3b79ae1b3f0d 100644
@@ -1,10 +1,7 @@
 #include <env/ti/ti_common.env>
+#include <env/ti/default_findfdt.env>
 #include <env/ti/mmc.env>
 
-default_device_tree=ti/k3-am625-sk.dtb
-findfdt=
-	setenv name_fdt ${default_device_tree};
-	setenv fdtfile ${name_fdt}
 name_kern=Image
 console=ttyS2,115200n8
 args_all=setenv optargs ${optargs} earlycon=ns16550a,mmio32,0x02800000
Signature · 1 line
2.40.0
Reviewed-by on v6 11/20
#34 lore raw

Re: [PATCH V6 11/20] board: ti: am62x: am62x.env: Use default findfdt

Quoted 5 lines · Nishanth Menon

Use the default findfdt using CONFIG_DEFAULT_DEVICE_TREE

Quoted 25 lines

---
No change that picking up Review, tested by and using new include file.

V5: https://lore.kernel.org/r/[email protected]

 board/ti/am62x/am62x.env | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
board/ti/am62x/am62x.env +1 -4
index 1ef948df83d7..3b79ae1b3f0d 100644
@@ -1,10 +1,7 @@
 #include <env/ti/ti_common.env>
+#include <env/ti/default_findfdt.env>
 #include <env/ti/mmc.env>
 
-default_device_tree=ti/k3-am625-sk.dtb
-findfdt=
-	setenv name_fdt ${default_device_tree};
-	setenv fdtfile ${name_fdt}
 name_kern=Image
 console=ttyS2,115200n8
 args_all=setenv optargs ${optargs} earlycon=ns16550a,mmio32,0x02800000
Signature · 1 line
2.40.0
#35 lore raw

PATCH v6 12/20 arm: mach-k3: am625_init: Use IS_ENABLED()

In reply to Nishanth Menon

Drop the #ifdeffery and use IS_ENABLED() inline check and let the compiler do it's thing.

---
No change other than picking up reviews, tested tags along the way.
V5: https://lore.kernel.org/r/[email protected]

 arch/arm/mach-k3/am625_init.c | 35 +++++++++++++++++------------------
 1 file changed, 17 insertions(+), 18 deletions(-)
arch/arm/mach-k3/am625_init.c +17 -18
index 0e5d44269ebf..165bca6885ef 100644
@@ -121,10 +121,10 @@ void board_init_f(ulong dummy)
 	struct udevice *dev;
 	int ret;
 
-#if defined(CONFIG_CPU_V7R)
-	setup_k3_mpu_regions();
-	rtc_erratumi2327_init();
-#endif
+	if (IS_ENABLED(CONFIG_CPU_V7R)) {
+		setup_k3_mpu_regions();
+		rtc_erratumi2327_init();
+	}
 
 	/*
 	 * Cannot delay this further as there is a chance that
@@ -156,29 +156,28 @@ void board_init_f(ulong dummy)
 
 	preloader_console_init();
 
-#ifdef CONFIG_K3_EARLY_CONS
 	/*
 	 * Allow establishing an early console as required for example when
 	 * doing a UART-based boot. Note that this console may not "survive"
 	 * through a SYSFW PM-init step and will need a re-init in some way
 	 * due to changing module clock frequencies.
 	 */
-	early_console_init();
-#endif
+	if (IS_ENABLED(CONFIG_K3_EARLY_CONS))
+		early_console_init();
 
-#if defined(CONFIG_K3_LOAD_SYSFW)
 	/*
 	 * Configure and start up system controller firmware. Provide
 	 * the U-Boot console init function to the SYSFW post-PM configuration
 	 * callback hook, effectively switching on (or over) the console
 	 * output.
 	 */
-	ret = is_rom_loaded_sysfw(&bootdata);
-	if (!ret)
-		panic("ROM has not loaded TIFS firmware\n");
+	if (IS_ENABLED(CONFIG_K3_LOAD_SYSFW)) {
+		ret = is_rom_loaded_sysfw(&bootdata);
+		if (!ret)
+			panic("ROM has not loaded TIFS firmware\n");
 
-	k3_sysfw_loader(true, NULL, NULL);
-#endif
+		k3_sysfw_loader(true, NULL, NULL);
+	}
 
 	/*
 	 * Force probe of clk_k3 driver here to ensure basic default clock
@@ -209,11 +208,11 @@ void board_init_f(ulong dummy)
 		enable_mcu_esm_reset();
 	}
 
-#if defined(CONFIG_K3_AM64_DDRSS)
-	ret = uclass_get_device(UCLASS_RAM, 0, &dev);
-	if (ret)
-		panic("DRAM init failed: %d\n", ret);
-#endif
+	if (IS_ENABLED(CONFIG_K3_AM64_DDRSS)) {
+		ret = uclass_get_device(UCLASS_RAM, 0, &dev);
+		if (ret)
+			panic("DRAM init failed: %d\n", ret);
+	}
 	spl_enable_dcache();
 }
 
Signature · 1 line
2.40.0
#36 lore raw

PATCH v6 13/20 arm: mach-k3: am625_init: Convert rtc_erratumi2327_init to static

In reply to Nishanth Menon

The erratum is called locally, make it static, drop the #ifdeffery since it will only be called in R5 build and mark it potentially unused to stop compiler screaming at us.

While at this, drop the redundant return for a void function.

---
No change other than picking up reviews, tested tags along the way.
V5: https://lore.kernel.org/r/[email protected]

 arch/arm/mach-k3/am625_init.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
arch/arm/mach-k3/am625_init.c +1 -5
index 165bca6885ef..499cb57267b9 100644
@@ -80,8 +80,6 @@ static __maybe_unused void enable_mcu_esm_reset(void)
 	writel(stat, CTRLMMR_MCU_RST_CTRL);
 }
 
-#if defined(CONFIG_CPU_V7R)
-
 /*
  * RTC Erratum i2327 Workaround for Silicon Revision 1
  *
@@ -94,7 +92,7 @@ static __maybe_unused void enable_mcu_esm_reset(void)
  *
  * https://www.ti.com/lit/er/sprz487c/sprz487c.pdf
  */
-void rtc_erratumi2327_init(void)
+static __maybe_unused void rtc_erratumi2327_init(void)
 {
 	u32 counter;
 
@@ -112,9 +110,7 @@ void rtc_erratumi2327_init(void)
 	 */
 	writel(K3RTC_KICK0_UNLOCK_VALUE, REG_K3RTC_KICK0);
 	writel(K3RTC_KICK1_UNLOCK_VALUE, REG_K3RTC_KICK1);
-	return;
 }
-#endif
 
 void board_init_f(ulong dummy)
 {
Signature · 1 line
2.40.0
#37 lore raw

PATCH v6 14/20 configs: am62x_evm*: Enable EMMC_BOOT configuration

In reply to Nishanth Menon

Enable EMMC boot support for AM62x evm base configuration.

---
No change other than picking up reviews, tested tags along the way.
V5: https://lore.kernel.org/r/[email protected]

 configs/am62x_evm_a53_defconfig | 1 +
 configs/am62x_evm_r5_defconfig  | 1 +
 2 files changed, 2 insertions(+)
configs/am62x_evm_a53_defconfig +1 -0
index 1807df8bbee9..112125673699 100644
@@ -70,6 +70,7 @@ CONFIG_TI_K3_NAVSS_UDMA=y
 CONFIG_TI_SCI_PROTOCOL=y
 CONFIG_DM_MAILBOX=y
 CONFIG_K3_SEC_PROXY=y
+CONFIG_SUPPORT_EMMC_BOOT=y
 CONFIG_MMC_SDHCI=y
 CONFIG_MMC_SDHCI_ADMA=y
 CONFIG_SPL_MMC_SDHCI_ADMA=y
configs/am62x_evm_r5_defconfig +1 -0
index 3c5f36729842..489ee943fe31 100644
@@ -92,6 +92,7 @@ CONFIG_DM_MAILBOX=y
 CONFIG_K3_SEC_PROXY=y
 CONFIG_SPL_MISC=y
 CONFIG_ESM_K3=y
+CONFIG_SUPPORT_EMMC_BOOT=y
 CONFIG_MMC_SDHCI=y
 CONFIG_MMC_SDHCI_ADMA=y
 CONFIG_SPL_MMC_SDHCI_ADMA=y
Signature · 1 line
2.40.0
#38 lore raw

PATCH v6 15/20 arm: mach-k3: am625: Add support for UDA FS

In reply to Nishanth Menon

While boot partition support with EMMC boot is useful, it is constrained by the size of boot hardware partition itself.

In the case of K3 devices, tispl images can contain OP-TEE images that can substantially vary in size and the u-boot image itself can vary over time as we enable various features.

So use the CSD information in the case of EMMC_BOOT configuration being enabled to pick boot partition or UDA FS mode operation to pick.

If EMMC_BOOT is disabled, then depend on filesystem configuration to pick data from UDA.

While at this, drop the extraneous whitespace.

---
No change other than picking up reviews, tested tags along the way.
V5: https://lore.kernel.org/r/[email protected]
V4: https://lore.kernel.org/r/[email protected]

 arch/arm/mach-k3/am625_init.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
arch/arm/mach-k3/am625_init.c +7 -1
index 499cb57267b9..8fa36f7b913e 100644
@@ -220,9 +220,15 @@ u32 spl_mmc_boot_mode(struct mmc *mmc, const u32 boot_device)
 	u32 bootmode_cfg = (devstat & MAIN_DEVSTAT_PRIMARY_BOOTMODE_CFG_MASK) >>
 			    MAIN_DEVSTAT_PRIMARY_BOOTMODE_CFG_SHIFT;
 
-
 	switch (bootmode) {
 	case BOOT_DEVICE_EMMC:
+		if (IS_ENABLED(CONFIG_SUPPORT_EMMC_BOOT)) {
+			if (spl_mmc_emmc_boot_partition(mmc))
+				return MMCSD_MODE_EMMCBOOT;
+			return MMCSD_MODE_FS;
+		}
+		if (IS_ENABLED(CONFIG_SPL_FS_FAT) || IS_ENABLED(CONFIG_SPL_FS_EXT4))
+			return MMCSD_MODE_FS;
 		return MMCSD_MODE_EMMCBOOT;
 	case BOOT_DEVICE_MMC:
 		if (bootmode_cfg & MAIN_DEVSTAT_PRIMARY_MMC_FS_RAW_MASK)
Signature · 1 line
2.40.0
#39 lore raw

PATCH v6 16/20 configs: am62x_evm_a53_defconfig: Disable semi-functional PSCI reset support

In reply to Nishanth Menon

From: Jan Kiszka <[email protected]>

At this point, system shutdown is not supported by the DM firmware that TF-A calls. As we can't de-select only this feature[1], declare complete PSCI reset support as non-functional so that we don't signal incomplete support to the OS via EFI runtime services. This makes power-off under Linux work again when booting via EFI.

[1] https://uefi.org/specs/UEFI/2.9_A/08_Services_Runtime_Services.html?highlight=efiresetshutdown#resetsystem

---
New patch picked from Jan
https://lore.kernel.org/all/[email protected]/
Changes:
- modify am62x_evm as common change.
- slight update to $subject and commit message

 configs/am62x_evm_a53_defconfig | 1 +
 1 file changed, 1 insertion(+)
configs/am62x_evm_a53_defconfig +1 -0
index 112125673699..a2729c1d0e36 100644
@@ -25,6 +25,7 @@ CONFIG_SPL_FS_FAT=y
 CONFIG_SPL_LIBDISK_SUPPORT=y
 CONFIG_SPL_SPI_FLASH_SUPPORT=y
 CONFIG_SPL_SPI=y
+# CONFIG_PSCI_RESET is not set
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_SPL_LOAD_FIT=y
 CONFIG_SPL_LOAD_FIT_ADDRESS=0x81000000
Signature · 1 line
2.40.0
Reviewed-by on v6 16/20
#40 lore raw

Re: [PATCH V6 16/20] configs: am62x_evm_a53_defconfig: Disable semi-functional PSCI reset support

Quoted 11 lines · Nishanth Menon

From: Jan Kiszka <[email protected]>

At this point, system shutdown is not supported by the DM firmware that TF-A calls. As we can't de-select only this feature[1], declare complete PSCI reset support as non-functional so that we don't signal incomplete support to the OS via EFI runtime services. This makes power-off under Linux work again when booting via EFI.

[1] https://uefi.org/specs/UEFI/2.9_A/08_Services_Runtime_Services.html?highlight=efiresetshutdown#resetsystem

Quoted 24 lines

---
New patch picked from Jan
https://lore.kernel.org/all/[email protected]/
Changes:
- modify am62x_evm as common change.
- slight update to $subject and commit message

 configs/am62x_evm_a53_defconfig | 1 +
 1 file changed, 1 insertion(+)
configs/am62x_evm_a53_defconfig +1 -0
index 112125673699..a2729c1d0e36 100644
@@ -25,6 +25,7 @@ CONFIG_SPL_FS_FAT=y
 CONFIG_SPL_LIBDISK_SUPPORT=y
 CONFIG_SPL_SPI_FLASH_SUPPORT=y
 CONFIG_SPL_SPI=y
+# CONFIG_PSCI_RESET is not set
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_SPL_LOAD_FIT=y
 CONFIG_SPL_LOAD_FIT_ADDRESS=0x81000000
Signature · 1 line
2.40.0
#41 lore raw

PATCH v6 17/20 arm: dts: k3-am625-sk-binman: Add labels for unsigned binary

In reply to Nishanth Menon

Add labels for unsigned binary to permit over-ride.

---
No change other than picking up reviews, tested tags along the way.
V5: https://lore.kernel.org/r/[email protected]
V4: https://lore.kernel.org/r/[email protected]
V3: https://lore.kernel.org/all/[email protected]/
V2: https://lore.kernel.org/u-boot/[email protected]/
V1: https://lore.kernel.org/all/[email protected]/

 arch/arm/dts/k3-am625-sk-binman.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/dts/k3-am625-sk-binman.dtsi +2 -2
index a35d6418c25f..41277bf4bfdb 100644
@@ -389,7 +389,7 @@
 					type = "flat_dt";
 					arch = "arm";
 					compression = "none";
-					blob {
+					spl_am625_sk_dtb_unsigned: blob {
 						filename = SPL_AM625_SK_DTB;
 					};
 				};
@@ -438,7 +438,7 @@
 					type = "flat_dt";
 					arch = "arm";
 					compression = "none";
-					blob {
+					am625_sk_dtb_unsigned: blob {
 						filename = AM625_SK_DTB;
 					};
 					hash {
Signature · 1 line
2.40.0
#42 lore raw

PATCH v6 18/20 arm: dts: Add k3-am625-beagleplay

In reply to Nishanth Menon

From: Robert Nelson <[email protected]>

BeagleBoard.org BeaglePlay is an easy to use, affordable open source hardware single board computer based on the Texas Instruments AM625 SoC that allows you to create connected devices that work even at long distances using IEEE 802.15.4g LR-WPAN and IEEE 802.3cg 10Base-T1L. Expansion is provided over open standards based mikroBUS, Grove and QWIIC headers among other interfaces.

This board family can be identified by the 24c32 eeprom:

[aa 55 33 ee 01 37 00 10  2e 00 42 45 41 47 4c 45  |.U3..7....BEAGLE|]
[50 4c 41 59 2d 41 30 2d  00 00 30 32 30 30 37 38  |PLAY-A0-..020078|]

https://beagleplay.org/
https://git.beagleboard.org/beagleplay/beagleplay

baseline of base device tree is v6.5-rc1.

---
No change other than picking up reviews, tested tags along the way.
V5: https://lore.kernel.org/r/[email protected]
V4: https://lore.kernel.org/r/[email protected]
V3: https://lore.kernel.org/all/[email protected]/
V2: https://lore.kernel.org/u-boot/[email protected]/
V1: https://lore.kernel.org/all/[email protected]/

 arch/arm/dts/Makefile                         |    2 +
 .../dts/k3-am625-beagleplay-ddr4-1600MTs.dtsi | 2195 +++++++++++++++++
 arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi  |  195 ++
 arch/arm/dts/k3-am625-beagleplay.dts          |  758 ++++++
 arch/arm/dts/k3-am625-r5-beagleplay.dts       |   86 +
 board/ti/am62x/MAINTAINERS                    |    7 +
 6 files changed, 3243 insertions(+)
 create mode 100644 arch/arm/dts/k3-am625-beagleplay-ddr4-1600MTs.dtsi
 create mode 100644 arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi
 create mode 100644 arch/arm/dts/k3-am625-beagleplay.dts
 create mode 100644 arch/arm/dts/k3-am625-r5-beagleplay.dts
arch/arm/dts/Makefile +2 -0
index 85fd5b1157b1..bd61a3527082 100644
@@ -1334,6 +1334,8 @@ dtb-$(CONFIG_SOC_K3_AM642) += k3-am642-evm.dtb \
 
 dtb-$(CONFIG_SOC_K3_AM625) += k3-am625-sk.dtb \
 			      k3-am625-r5-sk.dtb \
+			      k3-am625-beagleplay.dtb \
+			      k3-am625-r5-beagleplay.dtb \
 			      k3-am625-verdin-wifi-dev.dtb \
 			      k3-am625-verdin-r5.dtb
 
arch/arm/dts/k3-am625-beagleplay-ddr4-1600MTs.dtsi new file +2195 -0

2,195 lines not on this page · raw message

arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi new file +195 -0

195 lines not on this page · raw message

arch/arm/dts/k3-am625-beagleplay.dts new file +758 -0

602 lines not on this page · raw message

arch/arm/dts/k3-am625-r5-beagleplay.dts new file +86 -0

86 lines not on this page · raw message

board/ti/am62x/MAINTAINERS +7 -0
index 105e741995ed..6ac4e65f5afc 100644

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Signature · 1 line
2.40.0

Part of the diff is not shown here. View the raw message.

#43 lore raw

PATCH v6 19/20 board: ti: am62x: Add am62x_beagleplay_* defconfigs and env file

In reply to Nishanth Menon

Add defconfig fragments for am625 based beagleplay and corresponding customized environment file for beagleplay.

---
No major changes other than explicitly calling out script in the crafted bootmeths

V5: https://lore.kernel.org/r/[email protected]
V4: https://lore.kernel.org/r/[email protected]
V3: https://lore.kernel.org/all/[email protected]/
V2: https://lore.kernel.org/u-boot/[email protected]/
V1: https://lore.kernel.org/all/[email protected]/

 board/ti/am62x/beagleplay.env        | 19 ++++++++++
 board/ti/am62x/beagleplay_a53.config | 55 ++++++++++++++++++++++++++++
 board/ti/am62x/beagleplay_r5.config  | 15 ++++++++
 3 files changed, 89 insertions(+)
 create mode 100644 board/ti/am62x/beagleplay.env
 create mode 100644 board/ti/am62x/beagleplay_a53.config
 create mode 100644 board/ti/am62x/beagleplay_r5.config
board/ti/am62x/beagleplay.env new file +19 -0
new file mode 100644
index 000000000000..4f0a94a8113e
@@ -0,0 +1,19 @@
+#include <env/ti/ti_common.env>
+#include <env/ti/default_findfdt.env>
+#include <env/ti/mmc.env>
+
+name_kern=Image
+console=ttyS2,115200n8
+args_all=setenv optargs ${optargs} earlycon=ns16550a,mmio32,0x02800000
+run_kern=booti ${loadaddr} ${rd_spec} ${fdtaddr}
+set_led_state_fail_load= led led-0 off; led led-1 on;
+	led led-2 off; led led-3 on; led led-4 off
+set_led_state_start_load=led led-0 on; led led-1 off;
+	led led-2 on; led led-3 off; led led-4 on
+boot=mmc
+mmcdev=1
+bootpart=1:1
+bootdir=/boot
+boot_targets=mmc1 mmc0 usb pxe
+bootmeths=script extlinux efi pxe
+rd_spec=-
board/ti/am62x/beagleplay_a53.config new file +55 -0

55 lines not on this page · raw message

board/ti/am62x/beagleplay_r5.config new file +15 -0
new file mode 100644
index 000000000000..4ee0375a2a1d
@@ -0,0 +1,15 @@
+# Defconfig fragment to apply on top of:
+# am62x_evm_r5_defconfig
+#
+CONFIG_DEFAULT_DEVICE_TREE="k3-am625-r5-beagleplay"
+CONFIG_OF_LIST="k3-am625-r5-beagleplay"
+CONFIG_SPL_OF_LIST="k3-am625-r5-beagleplay"
+# Do spl board init
+CONFIG_SPL_BOARD_INIT=y
+# Do not use emmc boot - we will use FS only
+CONFIG_SUPPORT_EMMC_BOOT=n
+# No SPI flash on Beagleplay
+CONFIG_SPI=n
+CONFIG_SPI_FLASH=n
+CONFIG_SPL_DM_SPI_FLASH=n
+CONFIG_SPL_SPI_FLASH_SUPPORT=n
Signature · 1 line
2.40.0
Reviewed-by on v6 19/20
#44 lore raw

Re: [PATCH V6 19/20] board: ti: am62x: Add am62x_beagleplay_* defconfigs and env file

Quoted 6 lines · Nishanth Menon

Add defconfig fragments for am625 based beagleplay and corresponding customized environment file for beagleplay.

Signature · 1 line
Tom
#45 lore raw

PATCH v6 20/20 doc: board: ti: Add BeaglePlay documentation

In reply to Nishanth Menon

Add base documentation for BeaglePlay

---
Cc: Heinrich Schuchardt <[email protected]> Since V5:
- Updated to point at how to get serial console
- Introduce on using sd card and some tips and tricks I personally learnt from others including trying to calm fears that U-Boot development is risky.

V5: https://lore.kernel.org/r/[email protected]
V4: https://lore.kernel.org/r/[email protected]
V3: https://lore.kernel.org/all/[email protected]/
V2: https://lore.kernel.org/u-boot/[email protected]/
V1: https://lore.kernel.org/all/[email protected]/

 doc/board/ti/am62x_beagleplay.rst    | 322 +++++++++++++
 doc/board/ti/img/beagleplay_emmc.svg | 697 +++++++++++++++++++++++++++
 doc/board/ti/k3.rst                  |   1 +
 3 files changed, 1020 insertions(+)
 create mode 100644 doc/board/ti/am62x_beagleplay.rst
 create mode 100644 doc/board/ti/img/beagleplay_emmc.svg
doc/board/ti/am62x_beagleplay.rst new file +322 -0
new file mode 100644
index 000000000000..39913b29ab2c
@@ -0,0 +1,322 @@
+.. SPDX-License-Identifier: GPL-2.0+ OR BSD-3-Clause
+.. sectionauthor:: Nishanth Menon <[email protected]>
+
+AM62x Beagleboard.org Beagleplay
+================================
+
+Introduction:
+-------------
+
+BeagleBoard.org BeaglePlay is an easy to use, affordable open source
+hardware single board computer based on the Texas Instruments AM625
+SoC that allows you to create connected devices that work even at long
+distances using IEEE 802.15.4g LR-WPAN and IEEE 802.3cg 10Base-T1L.
+Expansion is provided over open standards based mikroBUS, Grove and
+QWIIC headers among other interfaces.
+
+Further information can be found at:
+
+* Product Page: https://beagleplay.org/
+* Hardware documentation: https://git.beagleboard.org/beagleplay/beagleplay
+
+Boot Flow:
+----------
+Below is the pictorial representation of boot flow:
+
+.. image:: img/boot_diagram_k3_current.svg
+  :alt: Boot flow diagram
+
+- On this platform, 'TI Foundational Security' (TIFS) functions as the
+  security enclave master while 'Device Manager' (DM), also known as the
+  'TISCI server' in "TI terminology", offers all the essential services.
+  The A53 or M4F (Aux core) sends requests to TIFS/DM to accomplish these
+  services, as illustrated in the diagram above.
+
+Sources:
+--------
+.. include::  k3.rst
+    :start-after: .. k3_rst_include_start_boot_sources
+    :end-before: .. k3_rst_include_end_boot_sources
+
+Build procedure:
+----------------
+0. Setup the environment variables:
+
+.. include::  k3.rst
+    :start-after: .. k3_rst_include_start_common_env_vars_desc
+    :end-before: .. k3_rst_include_end_common_env_vars_desc
+
+.. include::  k3.rst
+    :start-after: .. k3_rst_include_start_board_env_vars_desc
+    :end-before: .. k3_rst_include_end_board_env_vars_desc
+
+Set the variables corresponding to this platform:
+
+.. include::  k3.rst
+    :start-after: .. k3_rst_include_start_common_env_vars_defn
+    :end-before: .. k3_rst_include_end_common_env_vars_defn
+.. code-block:: bash
+
+ $ export UBOOT_CFG_CORTEXR="am62x_evm_r5_defconfig beagleplay_r5.config"
+ $ export UBOOT_CFG_CORTEXA="am62x_evm_a53_defconfig beagleplay_a53.config"
+ $ export TFA_BOARD=lite
+ $ # we dont use any extra TFA parameters
+ $ unset TFA_EXTRA_ARGS
+ $ export OPTEE_PLATFORM=k3-am62x
+ $ export OPTEE_EXTRA_ARGS="CFG_WITH_SOFTWARE_PRNG=y"
+
+.. include::  am62x_sk.rst
+    :start-after: .. am62x_evm_rst_include_start_build_steps
+    :end-before: .. am62x_evm_rst_include_end_build_steps
+
+Target Images
+--------------
+Copy the below images to an SD card and boot:
+
+* tiboot3-am62x-gp-evm.bin from R5 build as tiboot3.bin
+* tispl.bin_unsigned from Cortex-A build as tispl.bin
+* u-boot.img_unsigned from Cortex-A build as u-boot.img
+
+Image formats
+-------------
+
+- tiboot3.bin
+
+.. image:: img/multi_cert_tiboot3.bin.svg
+  :alt: tiboot3.bin image format
+
+- tispl.bin
+
+.. image:: img/dm_tispl.bin.svg
+  :alt: tispl.bin image format
+
+Additional hardware for U-Boot development
+------------------------------------------
+
+* Serial Console is critical for U-Boot development on BeaglePlay. See
+  `BeaglePlay serial console documentation
+  <https://docs.beagleboard.org/latest/boards/beagleplay/demos-and-tutorials/using-serial-console.html>`_.
+* uSD is preferred option over eMMC, and a SD/MMC reader will be needed.
+* (optionally) JTAG is useful when working with very early stages of boot.
+
+Default storage options
+-----------------------
+
+There are multiple storage media options on BeaglePlay, but primarily:
+
+* Onboard eMMC (default) - reliable, fast and meant for deployment use.
+* SD/MMC card interface (hold 'USR' switch and power on) - Entirely
+  depends on the SD card quality.
+
+Flash to uSD card or how to deal with "bricked" Board
+--------------------------------------------------------
+
+When deploying or working on Linux, it's common to use the onboard
+eMMC. However, avoiding the eMMC and using the uSD card is safer when
+working with U-Boot.
+
+If you choose to  hand format your own bootable uSD card, be
+aware that it can be difficult. The following information
+may be helpful, but remember that it is only sometimes
+reliable, and partition options can cause issues. These
+can potentially help:
+
+* https://git.ti.com/cgit/arago-project/tisdk-setup-scripts/tree/create-sdcard.sh
+* https://elinux.org/Beagleboard:Expanding_File_System_Partition_On_A_microSD
+
+The simplest option is to start with a standard distribution
+image like those in `BeagleBoard.org Distros Page
+<https://www.beagleboard.org/distros>`_ and download a disk image for
+BeaglePlay. Pick a 16GB+ uSD card to be on the safer side.
+
+With an SD/MMC Card reader and `Balena Etcher
+<https://etcher.balena.io/>`_, having a functional setup in minutes is
+a trivial matter, and it works on almost all Host Operating Systems.
+Yes Windows users, Windows Subsystem for Linux(WSL) based development
+with U-Boot and update uSD card is practical.
+
+Updating U-Boot is a matter of copying the tiboot3.bin, tispl.bin and
+u-boot.img to the "BOOT" partition of the uSD card. Remember to sync
+and unmount (or Eject - depending on the Operating System) the uSD
+card prior to physically removing from SD card reader.
+
+Also see following section on switch setting used for booting using
+uSD card.
+
+.. note::
+  Great news! If the board has not been damaged physically, there's no
+  need to worry about it being "bricked" on this platform. You only have
+  to flash an uSD card, plug it in, and reinstall the image on eMMC. This
+  means that even if you make a mistake, you can quickly fix it and rest
+  easy.
+
+  If you are frequently working with uSD cards, you might find the
+  following useful:
+
+  * `USB-SD-Mux <https://www.linux-automation.com/en/products/usb-sd-mux.html>`_
+  * `SD-Wire <https://wiki.tizen.org/SDWire>`_
+
+Flash to eMMC
+-------------
+
+The eMMC layout selected is user-friendly for developers. The
+boot hardware partition of the eMMC only contains the fixed-size
+tiboot3.bin image. This is because the contents of the boot partitions
+need to run from the SoC's internal SRAM, which remains a fixed size
+constant. The other components of the boot sequence, such as tispl.bin
+and u-boot.img, are located in the /BOOT partition in the User Defined
+Area (UDA) hardware partition of the eMMC. These components can vary
+significantly in size. The choice of keeping tiboot3.bin in boot0 or
+boot1 partition depends on A/B update requirements.
+
+.. image:: img/beagleplay_emmc.svg
+  :alt: eMMC partitions and boot file organization for BeaglePlay
+
+The following are the steps from Linux shell to program eMMC:
+
+.. code-block:: bash
+
+  # # Enable Boot0 boot
+  # mmc bootpart enable 1 2 /dev/mmcblk0
+  # mmc bootbus set single_backward x1 x8 /dev/mmcblk0
+  # mmc hwreset enable /dev/mmcblk0
+
+  # # Clear eMMC boot0
+  # echo '0' >> /sys/class/block/mmcblk0boot0/force_ro
+  # dd if=/dev/zero of=/dev/mmcblk0boot0 count=32 bs=128k
+  # # Write tiboot3.bin
+  # dd if=tiboot3.bin of=/dev/mmcblk0boot0 bs=128k
+
+  # # Copy the rest of the boot binaries
+  # mount /dev/mmcblk0p1 /boot/firmware
+  # cp tispl.bin /boot/firmware
+  # cp u-boot.img /boot/firmware
+  # sync
+
+.. warning ::
+
+  U-Boot is configured to prioritize booting from an SD card if it
+  detects a valid boot partition and boot files on it, even if the
+  system initially booted from eMMC. The boot order is set as follows:
+
+  * SD/MMC
+  * eMMC
+  * USB
+  * PXE
+
+LED patterns during boot
+------------------------
+
+.. list-table:: USR LED status indication
+   :widths: 16 16
+   :header-rows: 1
+
+   * - USR LEDs (012345)
+     - Indicates
+
+   * - 00000
+     - Boot failure or R5 image not started up
+
+   * - 11111
+     - A53 SPL/U-boot has started up
+
+   * - 10101
+     - OS boot process has been initiated
+
+   * - 01010
+     - OS boot process failed and drops to U-Boot shell
+
+.. note ::
+
+  In the table above, 0 indicates LED switched off and 1 indicates LED
+  switched ON.
+
+.. warning ::
+
+  If the "red" power LED is not glowing, the system power supply is not
+  functional. Please refer to `BeaglePlay documentation
+  <https://beagleplay.org/>`_ for further information.
+
+A53 SPL DDR Memory Layout
+-------------------------
+
+.. include::  am62x_sk.rst
+    :start-after: .. am62x_evm_rst_include_start_ddr_mem_layout
+    :end-before: .. am62x_evm_rst_include_end_ddr_mem_layout
+
+Switch Setting for Boot Mode
+----------------------------
+
+The boot time option is configured via "USR" button on the board.
+See `Beagleplay Schematics <https://git.beagleboard.org/beagleplay/beagleplay/-/blob/main/BeaglePlay_sch.pdf>`_
+for details.
+
+.. list-table:: Boot Modes
+   :widths: 16 16 16
+   :header-rows: 1
+
+   * - USR Switch Position
+     - Primary Boot
+     - Secondary Boot
+
+   * - Not Pressed
+     - eMMC
+     - UART
+
+   * - Pressed
+     - SD/MMC File System (FS) mode
+     - USB Device Firmware Upgrade (DFU) mode
+
+To switch to SD card boot mode, hold the USR button while powering on
+with Type-C power supply, then release when power LED lights up.
+
+Debugging U-Boot
+----------------
+
+See :ref:`Common Debugging environment - OpenOCD<k3_rst_refer_openocd>`: for
+detailed setup and debugging information.
+
+.. warning::
+
+  **OpenOCD support since**: v0.12.0
+
+  If the default package version of OpenOCD in your development
+  environment's distribution needs to be updated, it might be necessary to
+  build OpenOCD from the source.
+
+.. include::  k3.rst
+    :start-after: .. k3_rst_include_start_openocd_connect_tag_connect
+    :end-before: .. k3_rst_include_end_openocd_connect_tag_connect
+
+.. include::  k3.rst
+    :start-after: .. k3_rst_include_start_openocd_cfg_external_intro
+    :end-before: .. k3_rst_include_end_openocd_cfg_external_intro
+
+For example, with BeaglePlay (AM62X platform), the openocd_connect.cfg:
+
+.. code-block:: tcl
+
+  # TUMPA example:
+  # http://www.tiaowiki.com/w/TIAO_USB_Multi_Protocol_Adapter_User's_Manual
+  source [find interface/ftdi/tumpa.cfg]
+
+  transport select jtag
+
+  # default JTAG configuration has only SRST and no TRST
+  reset_config srst_only srst_push_pull
+
+  # delay after SRST goes inactive
+  adapter srst delay 20
+
+  if { ![info exists SOC] } {
+    # Set the SoC of interest
+    set SOC am625
+  }
+
+  source [find target/ti_k3.cfg]
+
+  ftdi tdo_sample_edge falling
+
+  # Speeds for FT2232H are in multiples of 2, and 32MHz is tops
+  # max speed we seem to achieve is ~20MHz.. so we pick 16MHz
+  adapter speed 16000
doc/board/ti/img/beagleplay_emmc.svg new file +697 -0

697 lines not on this page · raw message

doc/board/ti/k3.rst +1 -0
index 5f9bd4dfcbe9..ef31ccd12a42 100644
@@ -30,6 +30,7 @@ K3 Based SoCs
 .. toctree::
    :maxdepth: 1
 
+   am62x_beagleplay
    am62x_sk
    ../toradex/verdin-am62
    am64x_evm
Signature · 1 line
2.40.0
Tested-by on the v6 series
#46 lore raw
In reply to Nishanth Menon
Quoted 87 lines · Nishanth Menon

Alright, 6th time is a charm ;) Hopefully this takes care of all the un-addressed concerns we have had. Thanks all for pitching in, reviewing and improving and I will stop finding things to cleanup (promise).

Baseline: 7c6b18fb5494 (origin/next) Merge branch '2023-08-24-enable-more-features-in-qemu-arm' into next Full series available: https://github.com/nmenon/fix-k3-dt-u-boot/commits/beagleplay-v6
Boot Logs: https://gist.github.com/nmenon/8be4106e2d0b572aa5e77d93476095b4

Caveats:
* Networking: pending https://lore.kernel.org/all/[email protected]/
* 32kclk and usb: pending:
https://lore.kernel.org/u-boot/[email protected]/
OR https://github.com/nmenon/fix-k3-dt-u-boot/commit/853b29d63c1ca642be316f1afb0fb778610dec46
being properly resolved (NOTE: without this patch, wlan is broken in
Linux as the 32kclk from SoC is incorrectly supplied to wlan as 25MHz)
* There seems to be a bug in Linux kernel with sdhci that seems to
depend on u-boot initialization of sdhci for functionality (TI
internal actions already triggered).
* buildman discussion about config fragments:
https://lore.kernel.org/all/CAPnjgZ14CUVt=rM943hh9PQUhK9LJDgZYPxUsATYQe3wwOUYqQ@mail.gmail.com/
* Documentation that we can copy paste:
https://lore.kernel.org/all/[email protected]/
and followon in kernel.org:
https://lore.kernel.org/all/[email protected]/
if it all percolates back down to u-boot tree, should be trivial
cleanup.
* Build fails with binman implementation for TI SoCs - Neha will take
care of
https://lore.kernel.org/all/[email protected]/
* This series picks up Jan's patch for working around Device Manager not
compliant with EFI specification reqs and applies it to am62x_sk (TI
internal action already triggered)
https://lore.kernel.org/all/20230825011623.c74qqidp6wgvc5kl@plaza/
* I noticed that when drivers like the am654_sdhci.c uses
deffered_probe, the default probe function does'nt fail
https://source.denx.de/u-boot/u-boot/-/blob/master/boot/bootflow.c#L279
So ends up attempting for each of the boot_targets even if mmc dev
dev_id would fail. Not really sure how to solve it, so will leave it
here. (the https://gist.github.com/nmenon/8be4106e2d0b572aa5e77d93476095b4#file-beagleplay-emmc-sd-not-inserted
should show a bunch of 'MMC: no card present' each of which costs around
1 second.

Changes since V5:
* New patches to clean up mmc.env to sync with BOOTSTD operations yet enable easier non-U-Boot developer experience for uEnv.txt and optimize access to non-plugged in sd-card.
* Picked up Jan's patch[1] as part of this series.
* Introduced default_findfdt.env as review comment
* Saw Simon's feedback on uSD boot, and documented that as well, will be good for new devs to have that info in one flow.
* Quick overall diff: https://gist.github.com/nmenon/6d934f4e1092aa293a771d26b0f2bff7

V5: https://lore.kernel.org/all/[email protected]/
V4: https://lore.kernel.org/all/[email protected]/
V3: https://lore.kernel.org/all/[email protected]/
V2: https://lore.kernel.org/u-boot/[email protected]/
V1: https://lore.kernel.org/all/[email protected]/

Jan Kiszka (1):
configs: am62x_evm_a53_defconfig: Disable semi-functional PSCI reset
support

Nishanth Menon (18):
include: env: ti: mmc: envboot/mmcboot: Check result of mmc dev before
proceeding
include: env: ti: mmc: envboot: Only attempt boot.scr if BOOTSTD is
not enabled
include: configs: ti_armv7_common: Add documentation for protected
section
include: configs: am62x_evm: Drop unused SDRAM address
include: configs: am62x_evm: Wrap distroboot with
CONFIG_DISTRO_DEFAULTS
board: ti: am62x: am62x.env: Add explicit boot_targets
configs: am62x_evm_a53_defconfig: Switch to bootstd
include: configs: am62x_evm: Drop distro_bootcmd usage
include: env: ti: ti_armv7_common.env: Rename to ti_common.env
include: env: ti: Add a generic default_findfdt.env
board: ti: am62x: am62x.env: Use default findfdt
arm: mach-k3: am625_init: Use IS_ENABLED()
arm: mach-k3: am625_init: Convert rtc_erratumi2327_init to static
configs: am62x_evm*: Enable EMMC_BOOT configuration
arm: mach-k3: am625: Add support for UDA FS
arm: dts: k3-am625-sk-binman: Add labels for unsigned binary
board: ti: am62x: Add am62x_beagleplay_* defconfigs and env file
doc: board: ti: Add BeaglePlay documentation

Quoted 2 lines

Robert Nelson (1):
arm: dts: Add k3-am625-beagleplay

I re-tested v6.

Using baseline 11cf91f755c7 ("Merge branch '2023-08-26-bootstd-chromeos-impreovements-and-move-to-gcc-13.2' into next") I could boot all the way to U-boot proper shell.

And the LEDs work for me as well with:

=> led led-0 toggle

So for the whole series:

Note that I did not tried any boot related commands since I mostly work on Android booting and I have not rebased my wip-branch yet.

Quoted 49 lines
 arch/arm/dts/Makefile                         |    2 +
 .../dts/k3-am625-beagleplay-ddr4-1600MTs.dtsi | 2195 +++++++++++++++++
 arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi  |  195 ++
 arch/arm/dts/k3-am625-beagleplay.dts          |  758 ++++++
 arch/arm/dts/k3-am625-r5-beagleplay.dts       |   86 +
 arch/arm/dts/k3-am625-sk-binman.dtsi          |    4 +-
 arch/arm/mach-k3/am625_init.c                 |   49 +-
 board/siemens/iot2050/iot2050.env             |    2 +-
 board/ti/am62ax/am62ax.env                    |    2 +-
 board/ti/am62x/MAINTAINERS                    |    7 +
 board/ti/am62x/am62x.env                      |    8 +-
 board/ti/am62x/beagleplay.env                 |   19 +
 board/ti/am62x/beagleplay_a53.config          |   55 +
 board/ti/am62x/beagleplay_r5.config           |   15 +
 board/ti/am64x/am64x.env                      |    2 +-
 board/ti/am65x/am65x.env                      |    2 +-
 board/ti/j721e/j721e.env                      |    2 +-
 board/ti/j721s2/j721s2.env                    |    2 +-
 board/ti/ks2_evm/k2e_evm.env                  |    2 +-
 board/ti/ks2_evm/k2g_evm.env                  |    2 +-
 board/ti/ks2_evm/k2hk_evm.env                 |    2 +-
 board/ti/ks2_evm/k2l_evm.env                  |    2 +-
 configs/am62x_evm_a53_defconfig               |    7 +-
 configs/am62x_evm_r5_defconfig                |    1 +
 doc/board/ti/am62x_beagleplay.rst             |  322 +++
 doc/board/ti/img/beagleplay_emmc.svg          |  697 ++++++
 doc/board/ti/k3.rst                           |    1 +
 include/configs/am62x_evm.h                   |    6 -
 include/configs/ti_armv7_common.h             |    2 +-
 include/env/ti/default_findfdt.env            |   12 +
 include/env/ti/mmc.env                        |   12 +-
 .../ti/{ti_armv7_common.env => ti_common.env} |    0
 32 files changed, 4419 insertions(+), 54 deletions(-)
 create mode 100644 arch/arm/dts/k3-am625-beagleplay-ddr4-1600MTs.dtsi
 create mode 100644 arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi
 create mode 100644 arch/arm/dts/k3-am625-beagleplay.dts
 create mode 100644 arch/arm/dts/k3-am625-r5-beagleplay.dts
 create mode 100644 board/ti/am62x/beagleplay.env
 create mode 100644 board/ti/am62x/beagleplay_a53.config
 create mode 100644 board/ti/am62x/beagleplay_r5.config
 create mode 100644 doc/board/ti/am62x_beagleplay.rst
 create mode 100644 doc/board/ti/img/beagleplay_emmc.svg
 create mode 100644 include/env/ti/default_findfdt.env
 rename include/env/ti/{ti_armv7_common.env => ti_common.env} (100%)

[1] https://lore.kernel.org/all/[email protected]/

Signature · 1 line
2.40.0