Skip to contentSkip to conversation

gpio: provide for_each_hwgpio()

PATCH In review Bartosz Golaszewski 2 participants 6 messages Feb 22, 2024 – Feb 23, 2024 GPIO

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/2 gpio: provide for_each_hwgpio()

From: Bartosz Golaszewski <[email protected]>

We only provide iterators for requested GPIOs to provider drivers. In order to allow them to display debug information about all GPIOs, let's provide a variant for iterating over all GPIOs.

---
v1 -> v2:
- rename the iterator to for_each_hwgpio()

 include/linux/gpio/driver.h | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
include/linux/gpio/driver.h +15 -0
index 9c1fbfaebaa8..175129a92656 100644
@@ -551,6 +551,21 @@ DEFINE_CLASS(_gpiochip_for_each_data,
 	     }),
 	     const char **label, int *i)
 
+/**
+ * for_each_hwgpio - Iterates over all GPIOs for given chip.
+ * @_chip: Chip to iterate over.
+ * @_i: Loop counter.
+ * @_label: Place to store the address of the label if the GPIO is requested.
+ *          Set to NULL for unused GPIOs.
+ */
+#define for_each_hwgpio(_chip, _i, _label) \
+	for (CLASS(_gpiochip_for_each_data, _data)(&_label, &_i); \
+	     *_data.i < _chip->ngpio; \
+	     (*_data.i)++, kfree(*(_data.label)), *_data.label = NULL) \
+		if (IS_ERR(*_data.label = \
+			gpiochip_dup_line_label(_chip, *_data.i))) {} \
+		else
+
 /**
  * for_each_requested_gpio_in_range - iterates over requested GPIOs in a given range
  * @_chip:	the chip to query
Signature · 1 line
2.40.1
#1 lore raw

PATCH v2 2/2 gpio: sim: use for_each_hwgpio()

From: Bartosz Golaszewski <[email protected]>

Display debugfs information about all simulated GPIOs, not only the requested ones.

---
 drivers/gpio/gpio-sim.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpio/gpio-sim.c +2 -2
index c4106e37e6db..88fc3712811c 100644
@@ -234,10 +234,10 @@ static void gpio_sim_dbg_show(struct seq_file *seq, struct gpio_chip *gc)
 
 	guard(mutex)(&chip->lock);
 
-	for_each_requested_gpio(gc, i, label)
+	for_each_hwgpio(gc, i, label)
 		seq_printf(seq, " gpio-%-3d (%s) %s,%s\n",
 			   gc->base + i,
-			   label,
+			   label ?: "<unused>",
 			   test_bit(i, chip->direction_map) ? "input" :
 				test_bit(i, chip->value_map) ? "output-high" :
 							       "output-low",
Signature · 1 line
2.40.1
#3 lore raw

Re: [PATCH v2 2/2] gpio: sim: use for_each_hwgpio()

In reply to Bartosz Golaszewski
Quoted 29 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Display debugfs information about all simulated GPIOs, not only the requested ones.

---
 drivers/gpio/gpio-sim.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpio/gpio-sim.c +2 -3
index c4106e37e6db..88fc3712811c 100644
@@ -234,10 +234,10 @@ static void gpio_sim_dbg_show(struct seq_file *seq, struct gpio_chip *gc)
 
        guard(mutex)(&chip->lock);
 
-       for_each_requested_gpio(gc, i, label)
+       for_each_hwgpio(gc, i, label)
                seq_printf(seq, " gpio-%-3d (%s) %s,%s\n",
                           gc->base + i,
-                          label,
+                          label ?: "<unused>",
                           test_bit(i, chip->direction_map) ? "input" :
                                test_bit(i, chip->value_map) ? "output-high" :
                                                               "output-low",
--
Quoted 2 lines

2.40.1

Patch applied.

Bart

Reviewed-by on v2 1/2
#4 lore raw
In reply to Bartosz Golaszewski
Quoted 10 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

We only provide iterators for requested GPIOs to provider drivers. In order to allow them to display debug information about all GPIOs, let's provide a variant for iterating over all GPIOs.

---
v1 -> v2:
- rename the iterator to for_each_hwgpio()

Yours,
Linus Walleij

#5 lore raw
In reply to Bartosz Golaszewski
Quoted 42 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

We only provide iterators for requested GPIOs to provider drivers. In order to allow them to display debug information about all GPIOs, let's provide a variant for iterating over all GPIOs.

---
v1 -> v2:
- rename the iterator to for_each_hwgpio()

 include/linux/gpio/driver.h | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
include/linux/gpio/driver.h +15 -1
index 9c1fbfaebaa8..175129a92656 100644
@@ -551,6 +551,21 @@ DEFINE_CLASS(_gpiochip_for_each_data,
             }),
             const char **label, int *i)
 
+/**
+ * for_each_hwgpio - Iterates over all GPIOs for given chip.
+ * @_chip: Chip to iterate over.
+ * @_i: Loop counter.
+ * @_label: Place to store the address of the label if the GPIO is requested.
+ *          Set to NULL for unused GPIOs.
+ */
+#define for_each_hwgpio(_chip, _i, _label) \
+       for (CLASS(_gpiochip_for_each_data, _data)(&_label, &_i); \
+            *_data.i < _chip->ngpio; \
+            (*_data.i)++, kfree(*(_data.label)), *_data.label = NULL) \
+               if (IS_ERR(*_data.label = \
+                       gpiochip_dup_line_label(_chip, *_data.i))) {} \
+               else
+
 /**
  * for_each_requested_gpio_in_range - iterates over requested GPIOs in a given range
  * @_chip:     the chip to query
--
Quoted 2 lines

2.40.1

Patch applied.

Bart