Skip to contentSkip to conversation

panic-suppress-gnu_printf-warning.patch removed from -mm tree

merged mm-hotfixes-stable Andrew Morton 1 participant 1 message Feb 22, 2024

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The quilt patch titled
Subject: panic: suppress gnu_printf warning
has been removed from the -mm tree. Its filename was
panic-suppress-gnu_printf-warning.patch

This patch was dropped because it was merged into the mm-hotfixes-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: Baoquan He <[email protected]>
Subject: panic: suppress gnu_printf warning
Date: Sun, 7 Jan 2024 17:16:41 +0800

with GCC 13.2.1 and W=1, there's compiling warning like this:

kernel/panic.c: In function `__warn':
kernel/panic.c:676:17: warning: function __warn' might be a candidate for gnu_printf' format attribute [-Wsuggest-attribute=format]

  676 |                 vprintk(args->fmt, args->args);
      |                 ^~~~~~~

The normal __printf(x,y) adding can't fix it. So add workaround which disables -Wsuggest-attribute=format to mute it.

---

 kernel/panic.c |    5 +++++
 1 file changed, 5 insertions(+)
kernel/panic.c renamed from kernel/panic.c~panic-suppress-gnu_printf-warning +5 -0
@@ -666,8 +666,13 @@ void __warn(const char *file, int line,
 		pr_warn("WARNING: CPU: %d PID: %d at %pS\n",
 			raw_smp_processor_id(), current->pid, caller);
 
+#pragma GCC diagnostic push
+#ifndef __clang__
+#pragma GCC diagnostic ignored "-Wsuggest-attribute=format"
+#endif
 	if (args)
 		vprintk(args->fmt, args->args);
+#pragma GCC diagnostic pop
 
 	print_modules();
 

_

Patches currently in -mm which might be from [email protected] are

mm-vmalloc-remove-vmap_area_list.patch kexec-split-crashkernel-reservation-code-out-from-crash_corec.patch crash-split-vmcoreinfo-exporting-code-out-from-crash_corec.patch crash-remove-dependency-of-fa_dump-on-crash_dump.patch crash-remove-dependency-of-fa_dump-on-crash_dump-fix.patch crash-split-crash-dumping-code-out-from-kexec_corec.patch crash-clean-up-kdump-related-config-items.patch x86-crash-wrap-crash-dumping-code-into-crash-related-ifdefs.patch x86-crash-wrap-crash-dumping-code-into-crash-related-ifdefs-fix.patch arm64-crash-wrap-crash-dumping-code-into-crash-related-ifdefs.patch arm64-crash-wrap-crash-dumping-code-into-crash-related-ifdefs-fix.patch ppc-crash-enforce-kexec-and-kexec_file-to-select-crash_dump.patch ppc-crash-enforce-kexec-and-kexec_file-to-select-crash_dump-fix.patch s390-crash-wrap-crash-dumping-code-into-crash-related-ifdefs.patch sh-crash-wrap-crash-dumping-code-into-crash-related-ifdefs.patch mips-crash-wrap-crash-dumping-code-into-crash-related-ifdefs.patch riscv-crash-wrap-crash-dumping-code-into-crash-related-ifdefs.patch arm-crash-wrap-crash-dumping-code-into-crash-related-ifdefs.patch loongarch-crash-wrap-crash-dumping-code-into-crash-related-ifdefs.patch arch-crash-move-arch_crash_save_vmcoreinfo-out-to-file-vmcore_infoc.patch