Skip to contentSkip to conversation

usb: typec: altmodes/displayport: send configure message on sop'

PATCH In review RD Babiera 2 participants 2 messages Feb 23, 2024 – Feb 26, 2024

Subsystems (3)
lore
Share & tools
lore

RD Babiera

author
#0 lore raw

PATCH 1/1 usb: typec: altmodes/displayport: send configure message on sop'

When the port is setting the pin configuration when no configuration is chosen, the DisplayPort driver will not send Configure to the cable plug if it's available. Add transition to DP_STATE_CONFIGURE_PRIME.

Fixes 71ba4fe56656 ("usb: typec: altmodes/displayport: add SOP' support")
---
 drivers/usb/typec/altmodes/displayport.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/usb/typec/altmodes/displayport.c +2 -1
index 5a80776c7255..867f9796f8a8 100644
@@ -164,7 +164,8 @@ static int dp_altmode_status_update(struct dp_altmode *dp)
 	} else if (!(con & DP_CONF_CURRENTLY(dp->data.conf))) {
 		ret = dp_altmode_configure(dp, con);
 		if (!ret) {
-			dp->state = DP_STATE_CONFIGURE;
+			dp->state = dp->plug_prime ? DP_STATE_CONFIGURE_PRIME :
+						     DP_STATE_CONFIGURE;
 			if (dp->hpd != hpd) {
 				dp->hpd = hpd;
 				dp->pending_hpd = true;

base-commit: 3bf0514dc6f36f81ee11b1becd977cb87b4c90c6

Signature · 1 line
2.44.0.rc0.258.g7320e95886-goog
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 6 lines · RD Babiera

When the port is setting the pin configuration when no configuration is chosen, the DisplayPort driver will not send Configure to the cable plug if it's available. Add transition to DP_STATE_CONFIGURE_PRIME.

Fixes 71ba4fe56656 ("usb: typec: altmodes/displayport: add SOP' support")
Quoted 22 lines
---
 drivers/usb/typec/altmodes/displayport.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/usb/typec/altmodes/displayport.c +2 -1
index 5a80776c7255..867f9796f8a8 100644
@@ -164,7 +164,8 @@ static int dp_altmode_status_update(struct dp_altmode *dp)
 	} else if (!(con & DP_CONF_CURRENTLY(dp->data.conf))) {
 		ret = dp_altmode_configure(dp, con);
 		if (!ret) {
-			dp->state = DP_STATE_CONFIGURE;
+			dp->state = dp->plug_prime ? DP_STATE_CONFIGURE_PRIME :
+						     DP_STATE_CONFIGURE;
 			if (dp->hpd != hpd) {
 				dp->hpd = hpd;
 				dp->pending_hpd = true;

base-commit: 3bf0514dc6f36f81ee11b1becd977cb87b4c90c6

Signature · 1 line
2.44.0.rc0.258.g7320e95886-goog
Signature · 1 line
heikki