Skip to contentSkip to conversation

linux-next: build failure after merge of the gpio-brgl tree

DISCUSSION Stephen Rothwell 3 participants 5 messages Feb 23, 2024 – Feb 26, 2024 Linux-next tree

lore
Share & tools
lore
#0 lore raw

Hi all,

After merging the gpio-brgl tree, today's linux-next build (x86_64 allmodconfig) failed like this:

x86_64-linux-gnu-ld: vmlinux.o: in function `bgpio_write64':
gpio-mmio.c:(.text+0x1489427): undefined reference to `iowrite64'
x86_64-linux-gnu-ld: vmlinux.o: in function `bgpio_read64':
gpio-mmio.c:(.text+0x14894a0): undefined reference to `ioread64'
x86_64-linux-gnu-ld: vmlinux.o: in function `bgpio_write64be':
gpio-mmio.c:(.text+0x1489527): undefined reference to `iowrite64be'
x86_64-linux-gnu-ld: vmlinux.o: in function `bgpio_read64be':
gpio-mmio.c:(.text+0x14895a0): undefined reference to `ioread64be'

Caused by commit

36e44186e0ba ("gpio: mmio: Support 64-bit BE access")

I have used the gpio-brgl from next-20240222 for today.

Signature · 2 lines
Cheers,
Stephen Rothwell
#1 lore raw
Quoted 17 lines · Stephen Rothwell

Hi all,

After merging the gpio-brgl tree, today's linux-next build (x86_64 allmodconfig) failed like this:

x86_64-linux-gnu-ld: vmlinux.o: in function `bgpio_write64':
gpio-mmio.c:(.text+0x1489427): undefined reference to `iowrite64'
x86_64-linux-gnu-ld: vmlinux.o: in function `bgpio_read64':
gpio-mmio.c:(.text+0x14894a0): undefined reference to `ioread64'
x86_64-linux-gnu-ld: vmlinux.o: in function `bgpio_write64be':
gpio-mmio.c:(.text+0x1489527): undefined reference to `iowrite64be'
x86_64-linux-gnu-ld: vmlinux.o: in function `bgpio_read64be':
gpio-mmio.c:(.text+0x14895a0): undefined reference to `ioread64be'

Caused by commit

Quoted 7 lines

36e44186e0ba ("gpio: mmio: Support 64-bit BE access")

I have used the gpio-brgl from next-20240222 for today.

--
Cheers,
Stephen Rothwell

Hi Stephen,

I'm not seeing this issue with allmodconfig on x86_64, could you give me some more information on the build environment?

Andy: Could it be that the ifdefs you added should depend on CONFIG_64BIT and not only on the BITS_PER_LONG value?

Bartosz

#2 lore raw
Quoted 18 lines · Bartosz Golaszewski
Quoted 16 lines · Stephen Rothwell

After merging the gpio-brgl tree, today's linux-next build (x86_64 allmodconfig) failed like this:

x86_64-linux-gnu-ld: vmlinux.o: in function `bgpio_write64':
gpio-mmio.c:(.text+0x1489427): undefined reference to `iowrite64'
x86_64-linux-gnu-ld: vmlinux.o: in function `bgpio_read64':
gpio-mmio.c:(.text+0x14894a0): undefined reference to `ioread64'
x86_64-linux-gnu-ld: vmlinux.o: in function `bgpio_write64be':
gpio-mmio.c:(.text+0x1489527): undefined reference to `iowrite64be'
x86_64-linux-gnu-ld: vmlinux.o: in function `bgpio_read64be':
gpio-mmio.c:(.text+0x14895a0): undefined reference to `ioread64be'

Caused by commit

36e44186e0ba ("gpio: mmio: Support 64-bit BE access")

Quoted 7 lines
Quoted 1 line

I have used the gpio-brgl from next-20240222 for today.

I'm not seeing this issue with allmodconfig on x86_64, could you give me some more information on the build environment?

Andy: Could it be that the ifdefs you added should depend on CONFIG_64BIT and not only on the BITS_PER_LONG value?

If so, it will be the old issue as I just used what is currently done for LE 64-bit accessors in the same file.
I think the problem here is different, i.e. io*64*() are not available on all (64-bit) architectures in comparison to readq()/writeq(). I'll look at this later today.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#3 lore raw
In reply to Bartosz Golaszewski

Hi Bartosz,

Quoted 15 lines · On Fri, 23 Feb 2024 08:51:10 +0100 Bartosz Golaszewski…
Quoted 13 lines · Stephen Rothwell

After merging the gpio-brgl tree, today's linux-next build (x86_64 allmodconfig) failed like this:

x86_64-linux-gnu-ld: vmlinux.o: in function `bgpio_write64':
gpio-mmio.c:(.text+0x1489427): undefined reference to `iowrite64'
x86_64-linux-gnu-ld: vmlinux.o: in function `bgpio_read64':
gpio-mmio.c:(.text+0x14894a0): undefined reference to `ioread64'
x86_64-linux-gnu-ld: vmlinux.o: in function `bgpio_write64be':
gpio-mmio.c:(.text+0x1489527): undefined reference to `iowrite64be'
x86_64-linux-gnu-ld: vmlinux.o: in function `bgpio_read64be':
gpio-mmio.c:(.text+0x14895a0): undefined reference to `ioread64be'

Quoted 6 lines
Quoted 3 lines

Caused by commit

36e44186e0ba ("gpio: mmio: Support 64-bit BE access")

I'm not seeing this issue with allmodconfig on x86_64, could you give me some more information on the build environment?

These builds are cross builds using Debian's cross compilers on a ppc64le host.

$ x86_64-linux-gnu-gcc --version
x86_64-linux-gnu-gcc (Debian 13.2.0-7) 13.2.0
$ x86_64-linux-gnu-ld --version
GNU ld (GNU Binutils for Debian) 2.41
Signature · 2 lines
Cheers,
Stephen Rothwell
#4 lore raw
Quoted 28 lines · Stephen Rothwell

Hi Bartosz,

Quoted 15 lines · On Fri, 23 Feb 2024 08:51:10 +0100 Bartosz Golaszewski…
Quoted 13 lines · Stephen Rothwell

After merging the gpio-brgl tree, today's linux-next build (x86_64 allmodconfig) failed like this:

x86_64-linux-gnu-ld: vmlinux.o: in function `bgpio_write64':
gpio-mmio.c:(.text+0x1489427): undefined reference to `iowrite64'
x86_64-linux-gnu-ld: vmlinux.o: in function `bgpio_read64':
gpio-mmio.c:(.text+0x14894a0): undefined reference to `ioread64'
x86_64-linux-gnu-ld: vmlinux.o: in function `bgpio_write64be':
gpio-mmio.c:(.text+0x1489527): undefined reference to `iowrite64be'
x86_64-linux-gnu-ld: vmlinux.o: in function `bgpio_read64be':
gpio-mmio.c:(.text+0x14895a0): undefined reference to `ioread64be'

Quoted 6 lines
Quoted 3 lines

Caused by commit

36e44186e0ba ("gpio: mmio: Support 64-bit BE access")

I'm not seeing this issue with allmodconfig on x86_64, could you give me some more information on the build environment?

These builds are cross builds using Debian's cross compilers on a ppc64le host.

Quoted 8 lines
$ x86_64-linux-gnu-gcc --version
x86_64-linux-gnu-gcc (Debian 13.2.0-7) 13.2.0
$ x86_64-linux-gnu-ld --version
GNU ld (GNU Binutils for Debian) 2.41

--
Cheers,
Stephen Rothwell

I dropped the offending commit from my for-next branch. Let's revisit it after the upcoming merge window.

Bart