sunrpc: remove SLAB_MEM_SPREAD flag usage
Subsystems (5)
PATCH 1/1 sunrpc: remove SLAB_MEM_SPREAD flag usage
From: Chengming Zhou <[email protected]>
The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove its usage so we can delete it from slab. No functional change.
--- net/sunrpc/rpc_pipe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/sunrpc/rpc_pipe.c +1 -1
@@ -1490,7 +1490,7 @@ int register_rpc_pipefs(void) rpc_inode_cachep =kmem_cache_create ("rpc_inode_cache" ,sizeof (struct rpc_inode ),0 , (SLAB_HWCACHE_ALIGN |SLAB_RECLAIM_ACCOUNT | -SLAB_MEM_SPREAD |SLAB_ACCOUNT ), +SLAB_ACCOUNT ), init_once);if (!rpc_inode_cachep)return -ENOMEM ;
Signature · 1 line
2.40.1
Quoted 4 lines · On 2024/2/24 21:51, [email protected] wrote:
From: Chengming Zhou <[email protected]>
The
SLAB_MEM_SPREADflag is already a no-op as of 6.8-rc1, remove its usage so we can delete it from slab. No functional change.
Update changelog to make it clearer:
The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was removed as of v6.8-rc1, so it became a dead flag since the commit 16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h"). And the series[1] went on to mark it obsolete to avoid confusion for users. Here we can just remove all its users, which has no functional change.
[1] https://lore.kernel.org/all/[email protected]/
Thanks!
Quoted 19 lines
Signed-off-by Chengming Zhou <[email protected]>--- net/sunrpc/rpc_pipe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)net/sunrpc/rpc_pipe.c +1
-1@@ -1490,7 +1490,7 @@ int register_rpc_pipefs(void) rpc_inode_cachep =kmem_cache_create ("rpc_inode_cache" ,sizeof (struct rpc_inode ),0 , (SLAB_HWCACHE_ALIGN |SLAB_RECLAIM_ACCOUNT | -SLAB_MEM_SPREAD |SLAB_ACCOUNT ), +SLAB_ACCOUNT ), init_once);if (!rpc_inode_cachep)return -ENOMEM ;
Simon Horman
reviewerQuoted 14 lines · Chengming Zhou
Quoted 4 lines · On 2024/2/24 21:51, [email protected] wrote:
From: Chengming Zhou <[email protected]>
The
SLAB_MEM_SPREADflag is already a no-op as of 6.8-rc1, remove its usage so we can delete it from slab. No functional change.Update changelog to make it clearer:
The
SLAB_MEM_SPREADflag used to be implemented in SLAB, which was removed as of v6.8-rc1, so it became a dead flag since the commit16a1d968358a("mm/slab: removemm/slab.candslab_def.h"). And the series[1] went on to mark it obsolete to avoid confusion for users. Here we can just remove all its users, which has no functional change.
Quoted 3 lines
[1] https://lore.kernel.org/all/[email protected]/
Thanks!
Thanks Chengming Zhou,
As per my comment on a similar patch [*], this seems reasonable to me. But I think it would be best to post a v2 of this patch with the updated patch description (which is very helpful, BTW).
[*] https://lore.kernel.org/all/[email protected]/
Quoted 7 lines
Quoted 7 lines
Signed-off-by Chengming Zhou <[email protected]>--- net/sunrpc/rpc_pipe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 11 lines
net/sunrpc/rpc_pipe.c int register_rpc_pipefs(void) · line 1494
Quoted 11 lines
net/sunrpc/rpc_pipe.c +1
-1@@ -1490,7 +1490,7 @@ int register_rpc_pipefs(void) rpc_inode_cachep =kmem_cache_create ("rpc_inode_cache" ,sizeof (struct rpc_inode ),0 , (SLAB_HWCACHE_ALIGN |SLAB_RECLAIM_ACCOUNT | -SLAB_MEM_SPREAD |SLAB_ACCOUNT ), +SLAB_ACCOUNT ), init_once);
Also, while we are here, perhaps the indentation can be improved. Something like:
rpc_inode_cachep = kmem_cache_create("rpc_inode_cache",
sizeof(struct rpc_inode),
0, (SLAB_HWCACHE_ALIGN|SLAB_RECLAIM_ACCOUNT|
SLAB_ACCOUNT),
init_once);Quoted 3 lines
Quoted 2 lines
net/sunrpc/rpc_pipe.c +0
-0if (!rpc_inode_cachep)return -ENOMEM ;
PATCH v2 1/1 sunrpc: remove SLAB_MEM_SPREAD flag usage
From: Chengming Zhou <[email protected]>
The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was removed as of v6.8-rc1, so it became a dead flag since the commit 16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h"). And the series[1] went on to mark it obsolete to avoid confusion for users. Here we can just remove all its users, which has no functional change.
[1] https://lore.kernel.org/all/[email protected]/
---
v2:
- Update the patch description and include the related link to make it clearer that SLAB_MEM_SPREAD flag is now a no-op.
--- net/sunrpc/rpc_pipe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/sunrpc/rpc_pipe.c +1 -1
@@ -1490,7 +1490,7 @@ int register_rpc_pipefs(void) rpc_inode_cachep =kmem_cache_create ("rpc_inode_cache" ,sizeof (struct rpc_inode ),0 , (SLAB_HWCACHE_ALIGN |SLAB_RECLAIM_ACCOUNT | -SLAB_MEM_SPREAD |SLAB_ACCOUNT ), +SLAB_ACCOUNT ), init_once);if (!rpc_inode_cachep)return -ENOMEM ;
Signature · 1 line
2.40.1
PATCH v3 1/1 sunrpc: remove SLAB_MEM_SPREAD flag usage
In reply to Simon HormanFrom: Chengming Zhou <[email protected]>
The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was removed as of v6.8-rc1, so it became a dead flag since the commit 16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h"). And the series[1] went on to mark it obsolete to avoid confusion for users. Here we can just remove all its users, which has no functional change.
[1] https://lore.kernel.org/all/[email protected]/
---
v3:
- Improve the indentation, per Simon Horman.
v2:
- Update the patch description and include the related link to make it clearer that SLAB_MEM_SPREAD flag is now a no-op.
--- net/sunrpc/rpc_pipe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/sunrpc/rpc_pipe.c +1 -1
@@ -1490,7 +1490,7 @@ int register_rpc_pipefs(void) rpc_inode_cachep =kmem_cache_create ("rpc_inode_cache" ,sizeof (struct rpc_inode ),0 , (SLAB_HWCACHE_ALIGN |SLAB_RECLAIM_ACCOUNT | -SLAB_MEM_SPREAD |SLAB_ACCOUNT ), +SLAB_ACCOUNT ), init_once);if (!rpc_inode_cachep)return -ENOMEM ;
Signature · 1 line
2.40.1
Quoted 10 lines · Chengming Zhou
From: Chengming Zhou <[email protected]>
The
SLAB_MEM_SPREADflag used to be implemented in SLAB, which was removed as of v6.8-rc1, so it became a dead flag since the commit16a1d968358a("mm/slab: removemm/slab.candslab_def.h"). And the series[1] went on to mark it obsolete to avoid confusion for users. Here we can just remove all its users, which has no functional change.
Quoted 8 lines
Signed-off-by Chengming Zhou <[email protected]>---
v3:
- Improve the indentation, per Simon Horman.v2:
- Update the patch description and include the related link to make it clearer thatSLAB_MEM_SPREADflag is now a no-op.
Thanks for the updates.
In future please consider the following:
1. Don't post new revisions of a series more than once every 24h
2. Do post new revisions as new email threads